mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
e216d0851d
d05be124dbc0b24fb69d0c28ba2d6b297d243751 test: added coverage to estimatefee (kevkevin) Pull request description: Added a assert for an rpc error when we try to estimate fee for the max conf_target Line I am adding coverage to https://github.com/bitcoin/bitcoin/blob/master/src/rpc/fees.cpp#LL71C52-L71C52 ACKs for top commit: MarcoFalke: lgtm ACK d05be124dbc0b24fb69d0c28ba2d6b297d243751 Tree-SHA512: dfab075989446e33d1a5ff1a308f1ba1b9f80cce3848fbe4231f69212ceef456a3f2b19365a42123e0397c31893fd9f1fd9973cc00cfbb324386e12ed0e6bccc
56 lines
2.3 KiB
Python
Executable File
56 lines
2.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2018-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the estimatefee RPCs.
|
|
|
|
Test the following RPCs:
|
|
- estimatesmartfee
|
|
- estimaterawfee
|
|
"""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_raises_rpc_error
|
|
|
|
class EstimateFeeTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
def run_test(self):
|
|
# missing required params
|
|
assert_raises_rpc_error(-1, "estimatesmartfee", self.nodes[0].estimatesmartfee)
|
|
assert_raises_rpc_error(-1, "estimaterawfee", self.nodes[0].estimaterawfee)
|
|
|
|
# wrong type for conf_target
|
|
assert_raises_rpc_error(-3, "Expected type number, got string", self.nodes[0].estimatesmartfee, 'foo')
|
|
assert_raises_rpc_error(-3, "Expected type number, got string", self.nodes[0].estimaterawfee, 'foo')
|
|
|
|
# wrong type for estimatesmartfee(estimate_mode)
|
|
assert_raises_rpc_error(-3, "Expected type string, got number", self.nodes[0].estimatesmartfee, 1, 1)
|
|
assert_raises_rpc_error(-8, 'Invalid estimate_mode parameter, must be one of: "unset", "economical", "conservative"', self.nodes[0].estimatesmartfee, 1, 'foo')
|
|
|
|
# wrong type for estimaterawfee(threshold)
|
|
assert_raises_rpc_error(-3, "Expected type number, got string", self.nodes[0].estimaterawfee, 1, 'foo')
|
|
|
|
# extra params
|
|
assert_raises_rpc_error(-1, "estimatesmartfee", self.nodes[0].estimatesmartfee, 1, 'ECONOMICAL', 1)
|
|
assert_raises_rpc_error(-1, "estimaterawfee", self.nodes[0].estimaterawfee, 1, 1, 1)
|
|
|
|
# max value of 1008 per src/policy/fees.h
|
|
assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008", self.nodes[0].estimaterawfee, 1009)
|
|
|
|
# valid calls
|
|
self.nodes[0].estimatesmartfee(1)
|
|
# self.nodes[0].estimatesmartfee(1, None)
|
|
self.nodes[0].estimatesmartfee(1, 'ECONOMICAL')
|
|
self.nodes[0].estimatesmartfee(1, 'unset')
|
|
self.nodes[0].estimatesmartfee(1, 'conservative')
|
|
|
|
self.nodes[0].estimaterawfee(1)
|
|
self.nodes[0].estimaterawfee(1, None)
|
|
self.nodes[0].estimaterawfee(1, 1)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
EstimateFeeTest().main()
|