dash/test/functional
PastaPastaPasta b483948627
Merge pull request #4255 from kittywhiskers/darwinqol
build: gitian, linting and macOS-specific QoL improvements (part 1)
2021-09-01 19:51:48 -04:00
..
data merge bitcoin#13960: Fix PSBT deserialization of 0-input transactions (#4310) 2021-08-03 12:15:44 +03:00
test_framework merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
.gitignore
combine_logs.py Merge #14051: [Tests] Make combine_logs.py handle multi-line logs 2021-07-01 16:33:23 -05:00
combined_log_template.html
create_cache.py
example_test.py Merge #13954: Warn (don't fail!) on spelling errors. Fix typos reported by codespell. 2021-07-19 12:51:24 -05:00
feature_abortnode.py dashification 2021-07-12 20:16:37 -05:00
feature_addressindex.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_asmap.py Merge #17812: asmap feature refinements and functional tests 2021-05-20 00:05:12 +05:30
feature_assumevalid.py Merge #21084: test: fix timeout decrease in feature_assumevalid 2021-07-16 10:04:09 -05:00
feature_bip68_sequence.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_block_reward_reallocation.py Merge #14365: tests: Add Python dead code linter (vulture) to Travis 2021-08-12 14:42:32 -03:00
feature_block.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_blocksdir.py Merge #13985: [trivial] Fix slightly confusing mispelling in feature_blocksdir.py log message 2021-07-02 10:38:08 -04:00
feature_cltv.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_config_args.py Merge #14494: Error if # is used in rpcpassword in conf 2021-08-22 21:34:42 -05:00
feature_csv_activation.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_dbcrash.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_dersig.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_dip3_deterministicmns.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_dip4_coinbasemerkleroots.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_dip0020_activation.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_fee_estimation.py partial Merge #14180: qa: Premine to deterministic address with -disablewallet 2021-07-21 15:53:38 -05:00
feature_governance_objects.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
feature_help.py Merge #13867: qa: Make extended tests pass on native Windows 2021-07-06 20:29:31 +03:00
feature_includeconf.py Merge #13799: Ignore unknown config file options; warn instead of error 2021-07-02 12:59:28 +03:00
feature_llmq_chainlocks.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_llmq_connections.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_llmq_data_recovery.py tests: Use wait_for_chainlocked_block_all_nodes in more places (#4139) 2021-05-11 18:55:40 +02:00
feature_llmq_dkgerrors.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_llmq_is_cl_conflicts.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_llmq_is_retroactive.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_llmq_signing.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_llmq_simplepose.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_logging.py Merge #12853: qa: Match full plain text by default 2021-05-23 01:19:32 +03:00
feature_maxuploadtarget.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
feature_minchainwork.py Backport 11796 + 11774 (#3612) 2020-07-17 02:44:20 +03:00
feature_multikeysporks.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_new_quorum_type_activation.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_notifications.py Merge #14465: tests: Stop node before removing the notification file 2021-08-13 22:06:22 -06:00
feature_nulldummy.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_proxy.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_pruning.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_reindex.py Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args 2021-06-28 21:31:44 -05:00
feature_shutdown.py
feature_spentindex.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_sporks.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_timestampindex.py Merge #14365: tests: Add Python dead code linter (vulture) to Travis 2021-08-12 14:42:32 -03:00
feature_txindex.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
feature_uacomment.py Merge #12853: qa: Match full plain text by default 2021-05-23 01:19:32 +03:00
feature_versionbits_warning.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
interface_bitcoin_cli.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
interface_http.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
interface_rest.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
interface_rpc.py Merge #14777: tests: Add regtest for JSON-RPC batch calls 2021-08-10 20:24:28 -04:00
interface_zmq_dash.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
interface_zmq.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
mempool_accept.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
mempool_expiry.py Merge #14365: tests: Add Python dead code linter (vulture) to Travis 2021-08-12 14:42:32 -03:00
mempool_limit.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
mempool_packages.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
mempool_persist.py Merge pull request #4234 from UdjinM6/backports-0.17-pr35 2021-07-10 12:11:49 +03:00
mempool_reorg.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
mempool_resurrect.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
mempool_spend_coinbase.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
mining_basic.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
mining_getblocktemplate_longpoll.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
mining_prioritisetransaction.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
p2p_addrv2_relay.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
p2p_blocksonly.py Merge #15990: Add tests and documentation for blocksonly 2021-07-21 15:53:38 -05:00
p2p_compactblocks.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
p2p_connect_to_devnet.py Fix devnet name, tweak tests (#4284) 2021-07-22 11:24:46 +03:00
p2p_disconnect_ban.py Merge #14720: rpc: Correctly name arguments 2021-08-10 20:24:28 -04:00
p2p_fingerprint.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
p2p_instantsend.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
p2p_invalid_block.py Partial merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request 2021-08-22 21:35:12 -05:00
p2p_invalid_locator.py Merge #13915: [qa] Add test for max number of entries in locator 2021-07-06 20:29:31 +03:00
p2p_invalid_messages.py Merge #14812: qa: fix p2p_invalid_messages on macOS 2021-08-22 21:34:42 -05:00
p2p_invalid_tx.py Fix more spelling errors 2021-07-19 12:52:03 -05:00
p2p_leak_tx.py Merge #14365: tests: Add Python dead code linter (vulture) to Travis 2021-08-12 14:42:32 -03:00
p2p_leak.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
p2p_mempool.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
p2p_node_network_limited.py Merge #13954: Warn (don't fail!) on spelling errors. Fix typos reported by codespell. 2021-07-19 12:51:24 -05:00
p2p_permissions.py Merge #16631: net: The default whitelistrelay should be true 2021-07-19 19:00:04 -05:00
p2p_quorum_data.py Merge #13916: qa: wait_for_verack by default 2021-07-06 20:29:31 +03:00
p2p_sendheaders.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
p2p_timeouts.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
p2p_unrequested_blocks.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
README.md Merge #14519: tests: add utility to easily profile node performance with perf 2021-08-18 22:24:36 -03:00
rpc_bind.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
rpc_blockchain.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_coinjoin.py Update copyright (#4115) 2021-04-20 22:33:02 +03:00
rpc_decodescript.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_deprecated.py Merge #12490: [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server (#4380) 2021-08-31 23:31:31 -04:00
rpc_fundrawtransaction_hd.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_fundrawtransaction.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_getblockfilter.py bitcoin#14121: Index for BIP 157 block filters 2021-08-12 12:44:03 +05:30
rpc_getblockstats.py Merge #14518: rpc: Always throw in getblockstats if -txindex is required 2021-07-23 10:12:54 -04:00
rpc_getchaintips.py Backport 11796 + 11774 (#3612) 2020-07-17 02:44:20 +03:00
rpc_help.py Merge #14122: Test rpc_help.py failed: Check whether ZMQ is enabled or not. 2021-07-19 17:11:17 -05:00
rpc_invalidateblock.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_masternode.py Update copyright (#4115) 2021-04-20 22:33:02 +03:00
rpc_mnauth.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_named_arguments.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_net.py Merge #14720: rpc: Correctly name arguments 2021-08-10 20:24:28 -04:00
rpc_platform_filter.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_preciousblock.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_psbt.py Merge pull request #4229 from kittywhiskers/auxports 2021-08-10 22:34:17 +03:00
rpc_rawtransaction.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_scantxoutset.py tests: re-adapt scantxoutset RPC tests for Dash 2021-07-21 12:00:37 +05:30
rpc_setban.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_signmessage.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_signrawtransaction.py Merge #12490: [Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server (#4380) 2021-08-31 23:31:31 -04:00
rpc_txoutproof.py Merge #13054: tests: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. 2021-07-06 20:29:33 +03:00
rpc_uptime.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
rpc_users.py Merge #13867: qa: Make extended tests pass on native Windows 2021-07-06 20:29:31 +03:00
rpc_verifychainlock.py tests: Use wait_for_chainlocked_block_all_nodes in more places (#4139) 2021-05-11 18:55:40 +02:00
rpc_verifyislock.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
test_runner.py Merge #14522: tests: add invalid P2P message tests 2021-08-22 21:34:32 -05:00
wallet_abandonconflict.py Merge #15247: qa: Use wallet to retrieve raw transactions 2021-08-16 23:56:24 -03:00
wallet_backup.py Merge #15026: [test] Rename rpc_timewait to rpc_timeout 2021-08-15 11:08:08 -04:00
wallet_basic.py Merge #15247: qa: Use wallet to retrieve raw transactions 2021-08-16 23:56:24 -03:00
wallet_disable.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
wallet_disableprivatekeys.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
wallet_dump.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
wallet_encryption.py Merge #12493: [wallet] Reopen CDBEnv after encryption instead of shutting down 2021-04-05 03:31:50 +02:00
wallet_groups.py Merge #15026: [test] Rename rpc_timewait to rpc_timeout 2021-08-15 11:08:08 -04:00
wallet_hd.py Merge #12755: [tests] Better stderr testing 2021-06-28 02:00:44 +03:00
wallet_import_rescan.py Merge #15866: test: Add missing syncwithvalidationinterfacequeue to wallet_import_rescan 2021-08-11 13:58:48 -04:00
wallet_importmulti.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
wallet_importprunedfunds.py Merge #14720: rpc: Correctly name arguments 2021-08-10 20:24:28 -04:00
wallet_keypool_hd.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
wallet_keypool_topup.py Merge #13441: Prevent shared conf files from failing with different available options in different binaries 2021-06-28 02:00:50 +03:00
wallet_keypool.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
wallet_labels.py Merge #13498: [wallet] Fixups from account API deprecation 2020-12-22 17:58:12 +01:00
wallet_listreceivedby.py partial Merge #14180: qa: Premine to deterministic address with -disablewallet 2021-07-21 15:53:38 -05:00
wallet_listsinceblock.py Merge #13136: [tests] Fix flake8 warnings in several wallet functional tests 2021-05-25 14:09:35 +03:00
wallet_listtransactions.py Merge #14365: tests: Add Python dead code linter (vulture) to Travis 2021-08-12 14:42:32 -03:00
wallet_multiwallet.py Merge #14561: Remove fs::relative call and fix listwalletdir tests 2021-08-14 11:56:56 -06:00
wallet_resendwallettransactions.py Backport 11796 + 11774 (#3612) 2020-07-17 02:44:20 +03:00
wallet_txn_clone.py Merge #13944: test: Port usage of deprecated optparse module to argparse module 2021-07-06 20:29:32 +03:00
wallet_txn_doublespend.py Merge #13944: test: Port usage of deprecated optparse module to argparse module 2021-07-06 20:29:32 +03:00
wallet_upgradetohd.py merge #14954: Require python 3.5 2021-08-31 11:16:12 +05:30
wallet_zapwallettxes.py Backport 11796 + 11774 (#3612) 2020-07-17 02:44:20 +03:00

Functional tests

Writing Functional Tests

Example test

The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.

Coverage

Running test_runner.py with the --coverage argument tracks which RPCs are called by the tests and prints a report of uncovered RPCs in the summary. This can be used (along with the --extended argument) to find out which RPCs we don't have test cases for.

Style guidelines

  • Where possible, try to adhere to PEP-8 guidelines
  • Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
  • The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
  • See the python lint script that checks for violations that could lead to bugs and issues in the test code.
  • Avoid wildcard imports
  • Use a module-level docstring to describe what the test is testing, and how it is testing it.
  • When subclassing the BitcoinTestFramwork, place overrides for the set_test_params(), add_options() and setup_xxxx() methods at the top of the subclass, then locally-defined helper methods, then the run_test() method.
  • Use '{}'.format(x) for string formatting, not '%s' % x.

Naming guidelines

  • Name the test <area>_test.py, where area can be one of the following:
    • feature for tests for full features that aren't wallet/mining/mempool, eg feature_rbf.py
    • interface for tests for other interfaces (REST, ZMQ, etc), eg interface_rest.py
    • mempool for tests for mempool behaviour, eg mempool_reorg.py
    • mining for tests for mining features, eg mining_prioritisetransaction.py
    • p2p for tests that explicitly test the p2p interface, eg p2p_disconnect_ban.py
    • rpc for tests for individual RPC methods or features, eg rpc_listtransactions.py
    • wallet for tests for wallet features, eg wallet_keypool.py
  • use an underscore to separate words
    • exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg rpc_decodescript.py, not rpc_decode_script.py
  • Don't use the redundant word test in the name, eg interface_zmq.py, not interface_zmq_test.py

General test-writing advice

  • Set self.num_nodes to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis).
  • Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
  • Set the self.setup_clean_chain variable in set_test_params() to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x500=12500 DASH) in its wallet.
  • When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
  • Many of the core test framework classes such as CBlock and CTransaction don't allow new attributes to be added to their objects at runtime like typical Python objects allow. This helps prevent unpredictable side effects from typographical errors or usage of the objects outside of their intended purpose.

RPC and P2P definitions

Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:

  • /src/rpc/* for RPCs
  • /src/wallet/rpc* for wallet RPCs
  • ProcessMessage() in /src/net_processing.cpp for parsing P2P messages

Using the P2P interface

  • messages.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the dashd(s) being tested in a callback-based event loop; the other implements the test logic.

  • P2PConnection is the class used to connect to a dashd. P2PInterface contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods.

  • Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are p2p_unrequested_blocks.py, p2p_compactblocks.py.

test-framework modules

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for functional tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support P2P connectivity to a dashd.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

Benchmarking with perf

An easy way to profile node performance during functional tests is provided for Linux platforms using perf.

Perf will sample the running node and will generate profile data in the node's datadir. The profile data can then be presented using perf report or a graphical tool like hotspot.

There are two ways of invoking perf: one is to use the --perf flag when running tests, which will profile each node during the entire test run: perf begins to profile when the node starts and ends when it shuts down. The other way is the use the profile_with_perf context manager, e.g.

with node.profile_with_perf("send-big-msgs"):
    # Perform activity on the node you're interested in profiling, e.g.:
    for _ in range(10000):
        node.p2p.send_message(some_large_message)

To see useful textual output, run

perf report -i /path/to/datadir/send-big-msgs.perf.data.xxxx --stdio | c++filt | less

See also: