mirror of
https://github.com/dashpay/dash.git
synced 2024-12-29 05:49:11 +01:00
401b55e5c4
a5cfb40e27bd281354bd0d14d91f83efb6bfce9f doc: release note for changed {sign,verify}message error codes (Sebastian Falbesoner)
9e399b9b2d386b28c0c0ff59fc75d31dbec31d9c test: check parameter validity in rpc_signmessage.py (Sebastian Falbesoner)
e62f0c71f10def124b1c1219d790cef246a32c3e rpc: fix {sign,message}verify RPC errors for invalid address/signature (Sebastian Falbesoner)
Pull request description:
RPCs that accept address parameters usually return the intended error code `RPC_INVALID_ADDRESS_OR_KEY` (-5) if a passed address is invalid. The two exceptions to the rule are `signmessage` and `verifymessage`, which return `RPC_TYPE_ERROR` (-3) in this case instead. Oddly enough `verifymessage` returns `RPC_INVALID_ADDRESS_OR_KEY` when the _signature_ was malformed, where `RPC_TYPE_ERROR` would be more approriate.
This PR fixes these inaccuracies and as well adds tests to `rpc_signmessage.py` that check the parameter validity and error codes for the related RPCs `signmessagewithprivkey`, `signmessage` and `verifymessage`.
master branch:
```
$ ./bitcoin-cli signmessage invalid_addr message
error code: -3
error message:
Invalid address
$ ./bitcoin-cli verifymessage invalid_addr dummy_sig message
error code: -3
error message:
Invalid address
$ ./bitcoin-cli verifymessage 12c6DSiU4Rq3P4ZxziKxzrL5LmMBrzjrJX invalid_sig message
error code: -5
error message:
Malformed base64 encoding
```
PR branch:
```
$ ./bitcoin-cli signmessage invalid_addr message
error code: -5
error message:
Invalid address
$ ./bitcoin-cli verifymessage invalid_addr dummy_sig message
error code: -5
error message:
Invalid address
$ ./bitcoin-cli verifymessage 12c6DSiU4Rq3P4ZxziKxzrL5LmMBrzjrJX invalid_sig message
error code: -3
error message:
Malformed base64 encoding
```
ACKs for top commit:
laanwj:
Code review ACK a5cfb40e27bd281354bd0d14d91f83efb6bfce9f
meshcollider:
utACK a5cfb40e27bd281354bd0d14d91f83efb6bfce9f
Tree-SHA512: bae0c4595a2603cea66090f6033785601837b45fd853052312b3a39d8520566c581994b68f693dd247c22586c638c3b7689c849085cce548cc36b9bf0e119d2d
62 lines
3.1 KiB
Python
Executable File
62 lines
3.1 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test RPC commands for signing and verifying messages."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
)
|
|
|
|
class SignMessagesTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def run_test(self):
|
|
message = 'This is just a test message'
|
|
|
|
self.log.info('test signing with priv_key')
|
|
priv_key = 'cU4zhap7nPJAWeMFu4j6jLrfPmqakDAzy8zn8Fhb3oEevdm4e5Lc'
|
|
address = 'yeMpGzMj3rhtnz48XsfpB8itPHhHtgxLc3'
|
|
expected_signature = 'ICzMhjIUmmXcPWy2+9nw01zQMawo+s5FIy6F7VMkL+TmIeNq1j3AMEuw075os29kh5KYLbysKkDlDD+EAqERBd4='
|
|
signature = self.nodes[0].signmessagewithprivkey(priv_key, message)
|
|
assert_equal(expected_signature, signature)
|
|
assert self.nodes[0].verifymessage(address, signature, message)
|
|
|
|
self.log.info('test signing with an address with wallet')
|
|
address = self.nodes[0].getnewaddress()
|
|
signature = self.nodes[0].signmessage(address, message)
|
|
assert self.nodes[0].verifymessage(address, signature, message)
|
|
|
|
self.log.info('test verifying with another address should not work')
|
|
other_address = self.nodes[0].getnewaddress()
|
|
other_signature = self.nodes[0].signmessage(other_address, message)
|
|
assert not self.nodes[0].verifymessage(other_address, signature, message)
|
|
assert not self.nodes[0].verifymessage(address, other_signature, message)
|
|
|
|
self.log.info('test parameter validity and error codes')
|
|
# signmessage(withprivkey) have two required parameters
|
|
for num_params in [0, 1, 3, 4, 5]:
|
|
param_list = ["dummy"]*num_params
|
|
assert_raises_rpc_error(-1, "signmessagewithprivkey", self.nodes[0].signmessagewithprivkey, *param_list)
|
|
assert_raises_rpc_error(-1, "signmessage", self.nodes[0].signmessage, *param_list)
|
|
# verifymessage has three required parameters
|
|
for num_params in [0, 1, 2, 4, 5]:
|
|
param_list = ["dummy"]*num_params
|
|
assert_raises_rpc_error(-1, "verifymessage", self.nodes[0].verifymessage, *param_list)
|
|
# invalid key or address provided
|
|
assert_raises_rpc_error(-5, "Invalid private key", self.nodes[0].signmessagewithprivkey, "invalid_key", message)
|
|
assert_raises_rpc_error(-5, "Invalid address", self.nodes[0].signmessage, "invalid_addr", message)
|
|
assert_raises_rpc_error(-5, "Invalid address", self.nodes[0].verifymessage, "invalid_addr", signature, message)
|
|
# malformed signature provided
|
|
assert_raises_rpc_error(-3, "Malformed base64 encoding", self.nodes[0].verifymessage, self.nodes[0].getnewaddress(), "invalid_sig", message)
|
|
|
|
if __name__ == '__main__':
|
|
SignMessagesTest().main()
|