d63080100a
* Overhaul of coin selection for mixing DoAutomaticDenominating logic should be: - check pre-conditions, - check denominations and collaterals, - try using existing queue, - try creating new queue. Currently coins are selected too early and conditions are not quite right. This is partially due to the fact that we no longer merge old inputs and thus we are no longer able to calculate thresholds correctly using SelectCoinsDark. To do this in a proper way we should use balances i.e. GetAnonymizableBalance etc. Another issue is that we should take fee into account when we calculate such balancies and when we select coins we should ask for a correct denom, not just the smallest one as a minimum value. And finally there are two bugs. SelectCoinsGrouppedByAddresses: shouldn't push items smaller than the smallest denom into resulting vector. SelectCoinsDark: should allow small inputs in where "small" is defined by nValueMin, not by some arbitrary amount. * apply fee assumption for non-denoms only * fix * remove const |
||
---|---|---|
.tx | ||
build-aux/m4 | ||
contrib | ||
dash-docs | ||
depends | ||
doc | ||
qa | ||
share | ||
src | ||
.gitattributes | ||
.gitignore | ||
.travis.yml | ||
autogen.sh | ||
configure.ac | ||
CONTRIBUTING.md | ||
COPYING | ||
INSTALL | ||
libbitcoinconsensus.pc.in | ||
Makefile.am | ||
README.md |
Dash Core staging tree 0.12.1
What is Dash?
Dash is an experimental new digital currency that enables anonymous, instant payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.
For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.
License
Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.
Development Process
The master
branch is meant to be stable. Development is normally done in separate branches.
Tags are created to indicate new official,
stable release versions of Dash Core.
The contribution workflow is described in CONTRIBUTING.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled in configure) with: make check
There are also regression and integration tests of the RPC interface, written
in Python, that are run automatically on the build server.
These tests can be run (if the test dependencies are installed) with: qa/pull-tester/rpc-tests.py
The Travis CI system makes sure that every pull request is built for Windows and Linux, OS X, and that unit and sanity tests are automatically run.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.
Translators should also follow the forum.