mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
d70ba2c0f7
e48826ad87b4f92261f7433e84f48dac9bd9e5c3 tests: remove ComputeBlockVersion shortcut from versionbits tests (Anthony Towns)
c5f36725e877d8eb492383844f8ef7535466b366 [refactor] Move ComputeBlockVersion into VersionBitsCache (Anthony Towns)
4a69b4dbe0d7f504811b67c399da7e6d11e4f805 [move-only] Move ComputeBlockVersion from validation to versionbits (Anthony Towns)
0cfd6c6a8f929d5567ac41f95c21548f115efee5 [refactor] versionbits: make VersionBitsCache a full class (Anthony Towns)
8ee3e0bed5bf2cd3c7a68ca6ba6c65f7b9a72cca [refactor] rpc/blockchain.cpp: SoftForkPushBack (Anthony Towns)
92f48f360da5f425428b761219301f509826bec4 deploymentinfo: Add DeploymentName() (Anthony Towns)
ea68b3a5729f5d240e968388c4f88acffeb27228 [move-only] Rename versionbitsinfo to deploymentinfo (Anthony Towns)
c64b2c6a0f79369624ae96b2e3d579d50aae4de6 scripted-diff: rename versionbitscache (Anthony Towns)
de55304f6e7a8b607e6b3fc7436de50910747b0c [refactor] Add versionbits deployments to deploymentstatus.h (Anthony Towns)
2b0d291da8f479739ff394dd92801da8c40b9f8e [refactor] Add deploymentstatus.h (Anthony Towns)
eccd736f3dc231ac0306ca763c3b72cf8247230a versionbits: Use dedicated lock instead of cs_main (Anthony Towns)
36a4ba0aaaa9b35185d7178994e36bc02cca9887 versionbits: correct doxygen comments (Anthony Towns)
Pull request description:
Introduces helper functions to make it easy to bury future deployments, along the lines of the suggestion from [11398](https://github.com/bitcoin/bitcoin/pull/11398#issuecomment-335599326) "I would prefer it if a buried deployment wouldn't require all code paths that check the BIP9 status to require changing".
This provides three functions: `DeploymentEnabled()` which tests if a deployment can ever be active, `DeploymentActiveAt()` which checks if a deployment should be enforced in the given block, and `DeploymentActiveAfter()` which checks if a deployment should be enforced in the block following the given block, and overloads all three to work both with buried deployments and versionbits deployments.
This adds a dedicated lock for the versionbits cache, which is acquired internally by the versionbits functions, rather than relying on `cs_main`. It also moves moves versionbitscache into deploymentstatus to avoid a circular dependency with validation.
ACKs for top commit:
jnewbery:
ACK e48826ad87b4f92261f7433e84f48dac9bd9e5c3
gruve-p:
ACK e48826ad87
MarcoFalke:
re-ACK e48826ad87b4f92261f7433e84f48dac9bd9e5c3 🥈
Tree-SHA512: c846ba64436d36f8180046ad551d8b0d9e20509b9bc185aa2639055fc28803dd8ec2d6771ab337e80da0b40009ad959590d5772f84a0bf6199b65190d4155bed
135 lines
6.2 KiB
C++
135 lines
6.2 KiB
C++
// Copyright (c) 2016 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_VERSIONBITS_H
|
|
#define BITCOIN_VERSIONBITS_H
|
|
|
|
#include <chain.h>
|
|
#include <gsl/pointers.h>
|
|
#include <sync.h>
|
|
|
|
#include <map>
|
|
|
|
/** What block version to use for new blocks (pre versionbits) */
|
|
static const int32_t VERSIONBITS_LAST_OLD_BLOCK_VERSION = 4;
|
|
/** What bits to set in version for versionbits blocks */
|
|
static const int32_t VERSIONBITS_TOP_BITS = 0x20000000UL;
|
|
/** What bitmask determines whether versionbits is in use */
|
|
static const int32_t VERSIONBITS_TOP_MASK = 0xE0000000UL;
|
|
/** Total bits available for versionbits */
|
|
static const int32_t VERSIONBITS_NUM_BITS = 29;
|
|
|
|
/** BIP 9 defines a finite-state-machine to deploy a softfork in multiple stages.
|
|
* State transitions happen during retarget period if conditions are met
|
|
* In case of reorg, transitions can go backward. Without transition, state is
|
|
* inherited between periods. All blocks of a period share the same state.
|
|
*/
|
|
enum class ThresholdState {
|
|
DEFINED, // First state that each softfork starts out as. The genesis block is by definition in this state for each deployment.
|
|
STARTED, // For blocks past the starttime.
|
|
LOCKED_IN, // For one retarget period after the first retarget period with STARTED blocks of which at least threshold have the associated bit set in nVersion.
|
|
ACTIVE, // For all blocks after the LOCKED_IN retarget period (final state)
|
|
FAILED, // For all blocks once the first retarget period after the timeout time is hit, if LOCKED_IN wasn't already reached (final state)
|
|
};
|
|
|
|
// A map that gives the state for blocks whose height is a multiple of Period().
|
|
// The map is indexed by the block's parent, however, so all keys in the map
|
|
// will either be nullptr or a block with (height + 1) % Period() == 0.
|
|
typedef std::map<const CBlockIndex*, ThresholdState> ThresholdConditionCache;
|
|
|
|
/** Display status of an in-progress BIP9 softfork */
|
|
struct BIP9Stats {
|
|
/** Length of blocks of the BIP9 signalling period */
|
|
int period;
|
|
/** Number of blocks with the version bit set required to activate the softfork */
|
|
int threshold;
|
|
/** Number of blocks elapsed since the beginning of the current period */
|
|
int elapsed;
|
|
/** Number of blocks with the version bit set since the beginning of the current period */
|
|
int count;
|
|
/** False if there are not enough blocks left in this period to pass activation threshold */
|
|
bool possible;
|
|
};
|
|
|
|
/**
|
|
* Abstract class that implements BIP9-style threshold logic, and caches results.
|
|
*/
|
|
class AbstractThresholdConditionChecker {
|
|
protected:
|
|
virtual bool Condition(const CBlockIndex* pindex, const Consensus::Params& params) const =0;
|
|
virtual int64_t BeginTime(const Consensus::Params& params) const =0;
|
|
virtual int SignalHeight(const CBlockIndex* pindexPrev, const Consensus::Params& params) const = 0;
|
|
virtual int64_t EndTime(const Consensus::Params& params) const =0;
|
|
virtual int Period(const Consensus::Params& params) const =0;
|
|
virtual int Threshold(const Consensus::Params& params, int nAttempt) const =0;
|
|
|
|
public:
|
|
/** Returns the numerical statistics of an in-progress BIP9 softfork in the current period */
|
|
BIP9Stats GetStateStatisticsFor(const CBlockIndex* pindex, const Consensus::Params& params, ThresholdConditionCache& cache) const;
|
|
/** Returns the state for pindex A based on parent pindexPrev B. Applies any state transition if conditions are present.
|
|
* Caches state from first block of period. */
|
|
ThresholdState GetStateFor(const CBlockIndex* pindexPrev, const Consensus::Params& params, ThresholdConditionCache& cache) const;
|
|
/** Returns the height since when the ThresholdState has started for pindex A based on parent pindexPrev B, all blocks of a period share the same */
|
|
int GetStateSinceHeightFor(const CBlockIndex* pindexPrev, const Consensus::Params& params, ThresholdConditionCache& cache) const;
|
|
};
|
|
|
|
/** BIP 9 allows multiple softforks to be deployed in parallel. We cache
|
|
* per-period state for every one of them. */
|
|
class VersionBitsCache
|
|
{
|
|
private:
|
|
Mutex m_mutex;
|
|
ThresholdConditionCache m_caches[Consensus::MAX_VERSION_BITS_DEPLOYMENTS] GUARDED_BY(m_mutex);
|
|
|
|
public:
|
|
/** Get the numerical statistics for a given deployment for the signalling period that includes the block after pindexPrev. */
|
|
BIP9Stats Statistics(const CBlockIndex* pindexPrev, const Consensus::Params& params, Consensus::DeploymentPos pos);
|
|
|
|
static uint32_t Mask(const Consensus::Params& params, Consensus::DeploymentPos pos);
|
|
|
|
/** Get the BIP9 state for a given deployment for the block after pindexPrev. */
|
|
ThresholdState State(const CBlockIndex* pindexPrev, const Consensus::Params& params, Consensus::DeploymentPos pos);
|
|
|
|
/** Get the block height at which the BIP9 deployment switched into the state for the block after pindexPrev. */
|
|
int StateSinceHeight(const CBlockIndex* pindexPrev, const Consensus::Params& params, Consensus::DeploymentPos pos);
|
|
|
|
/** Determine what nVersion a new block should use
|
|
*/
|
|
int32_t ComputeBlockVersion(const CBlockIndex* pindexPrev, const Consensus::Params& params);
|
|
|
|
void Clear();
|
|
};
|
|
|
|
class AbstractEHFManager
|
|
{
|
|
public:
|
|
using Signals = std::unordered_map<uint8_t, int>;
|
|
|
|
/**
|
|
* getInstance() is used in versionbit because it is non-trivial
|
|
* to get access to NodeContext from all usages of VersionBits* methods
|
|
* For simplification of interface this methods static/global variable is used
|
|
* to get access to EHF data
|
|
*/
|
|
public:
|
|
[[nodiscard]] static gsl::not_null<AbstractEHFManager*> getInstance() {
|
|
return globalInstance;
|
|
};
|
|
|
|
/**
|
|
* `GetSignalsStage' prepares signals for new block.
|
|
* The results are diffent with GetFromCache results due to one more
|
|
* stage of processing: signals that would be expired in next block
|
|
* are excluded from results.
|
|
* This member function is not const because it calls non-const GetFromCache()
|
|
*/
|
|
virtual Signals GetSignalsStage(const CBlockIndex* const pindexPrev) = 0;
|
|
|
|
|
|
protected:
|
|
static AbstractEHFManager* globalInstance;
|
|
};
|
|
|
|
#endif // BITCOIN_VERSIONBITS_H
|