dash/qa/rpc-tests
Alexander Block d94092b60b
Fix spork propagation while in IBD and fix spork integration tests (#2533)
* Fix spork syncing issue in sporks tests

https://github.com/dashpay/dash/pull/2522 caused an issue with sporks syncing
in tests. The introduced time check in CMasternodeSync::ProcessTick causes
masternode sync to never start when mocktime is enabled, so this commit
disables mocktime for sporks.py.

Disabling mocktime however leads to fInitialDownload never becoming false
in CMasternodeSync::UpdatedBlockTip, so mnsync is never started. To fix
this, the tests now create a block before connecting the last node.

This however doesn't work because node1 will ignore the "getheaders" request
from node2 as it has not finished mnsync yet...so we also have to force
finish mnsync for node1.

* Also respond with getdata for announced sporks while in IBD

There was never a good reason to ignore spork announcements while in IBD.
At the same time, this poses the risk of missing out on sporks while in IBD.
This also fixes an issue in sporks testing, as nodes did not request for
announced sporks.

* Use wait_to_sync instead of custom loop
2018-12-06 14:43:36 +01:00
..
test_framework Sleep longer between attempts in sync_blocks 2018-11-15 15:25:04 +01:00
.gitignore
abandonconflict.py Merge #8531: [qa] abandonconflict: Use assert_equal 2018-01-08 18:04:55 +01:00
addressindex.py Fix rpc tests broken by 2110 (#2118) 2018-06-12 21:37:31 +03:00
assumevalid.py Add assumevalid testcase 2018-01-21 12:48:33 +01:00
autoix-mempool.py Fix auto-IS tests (#2414) 2018-11-05 12:28:04 +03:00
bip9-softforks.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
bip65-cltv-p2p.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
bip65-cltv.py Merge #8391: Consensus: Remove ISM 2018-01-20 09:22:40 +01:00
bip68-112-113-p2p.py Drop delayed headers logic and fix duplicate initial headers sync by handling block inv correctly (#2032) 2018-04-20 13:53:05 +03:00
bip68-sequence.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
bipdersig-p2p.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
bipdersig.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
blockchain.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
create_cache.py Merge #8713: [qa] create_cache: Delete temp dir when done 2018-01-11 13:19:32 +01:00
decodescript.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
dip3-deterministicmns.py Implement CDummyDKG and CDummyCommitment until we have the real DKG merged (#2492) 2018-11-26 16:53:20 +01:00
disablewallet.py Python 3 fixes/porting in rpc tests 2017-12-21 20:34:07 +01:00
forknotify.py Merge #9532: Remove unused variables 2018-01-23 09:24:27 +01:00
fundrawtransaction-hd.py Some cleanup (mostly trivial) (#2038) 2018-04-20 13:53:23 +03:00
fundrawtransaction.py Some cleanup (mostly trivial) (#2038) 2018-04-20 13:53:23 +03:00
getblocktemplate_longpoll.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
getblocktemplate_proposals.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
getchaintips.py Add forkpoint to getchaintips (#2039) 2018-04-18 14:50:52 +03:00
httpbasics.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
import-rescan.py Fix import-rescan.py and add workaround for pruning mode 2018-02-01 11:13:01 +01:00
importmulti.py Merge #9108: Use importmulti timestamp when importing watch only keys (on top of #9682) 2018-02-01 11:13:01 +01:00
importprunedfunds.py Merge #8581: [wallet] rpc: Drop misleading option 2018-01-09 14:04:20 +01:00
invalidateblock.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
invalidblockrequest.py Support "fast" mode when calling sync_masternodes (#2383) 2018-10-26 19:41:40 +03:00
invalidtxrequest.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
keypool-hd.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
keypool.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
listsinceblock.py Fix listsinceblock.py 2018-01-21 14:14:34 +01:00
listtransactions.py Remove leftover RBF code from BTC (#2297) 2018-09-20 15:39:34 +03:00
maxblocksinflight.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
maxuploadtarget.py Drop delayed headers logic and fix duplicate initial headers sync by handling block inv correctly (#2032) 2018-04-20 13:53:05 +03:00
mempool_limit.py Merge #9274: [qa] Use cached utxo set to fix performance regression 2018-01-17 17:31:12 +01:00
mempool_packages.py Merge #10157: [0.14] Fix the mempool_packages.py test 2018-01-26 12:59:29 +01:00
mempool_reorg.py Merge #7562: Bump transaction version default to 2 2018-01-20 09:22:38 +01:00
mempool_resurrect_test.py Fix rpc tests broken by 2110 (#2118) 2018-06-12 21:37:31 +03:00
mempool_spendcoinbase.py Fix rpc tests broken by 2110 (#2118) 2018-06-12 21:37:31 +03:00
merkle_blocks.py Fix rpc tests broken by 2110 (#2118) 2018-06-12 21:37:31 +03:00
multi_rpc.py Merge #9233: Fix some typos 2018-01-17 17:27:24 +01:00
multikeysporks.py M-of-N-like sporks (#2288) 2018-09-30 20:01:33 +03:00
nodehandling.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
nulldummy.py Fix nulldummy tests by creating correct DIP4 coinbase transactions 2018-09-03 10:46:52 +02:00
p2p-acceptblock.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
p2p-autoinstantsend.py Fix auto-IS tests (#2414) 2018-11-05 12:28:04 +03:00
p2p-compactblocks.py Backport compact blocks functionality from bitcoin (#1966) 2018-04-11 14:06:01 +03:00
p2p-fullblocktest.py Support "fast" mode when calling sync_masternodes (#2383) 2018-10-26 19:41:40 +03:00
p2p-instantsend.py Sync blocks before creating TXs (#2496) 2018-11-26 13:40:36 +01:00
p2p-leaktests.py Revert "Merge #7542: Implement "feefilter" P2P message" (#2025) 2018-04-11 18:16:43 +03:00
p2p-mempool.py Merge #9508: Remove unused Python imports 2018-01-21 12:48:33 +01:00
p2p-timeouts.py Merge #9715: Disconnect peers which we do not receive VERACKs from within 60 sec 2018-01-23 09:24:28 +01:00
p2p-versionbits-warning.py Merge #8860: [qa] util: Move wait_bitcoinds() into stop_nodes() 2018-01-12 09:57:56 +01:00
preciousblock.py [qa] Avoid race in preciousblock test. 2018-02-08 11:06:22 +01:00
prioritise_transaction.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
proxy_test.py Merge #9151: [qa] proxy_test: Calculate hardcoded port numbers 2018-01-15 06:14:16 +01:00
pruning.py Merge #9820: Fix pruning test broken by 2 hour manual prune window 2018-01-26 12:59:29 +01:00
rawtransactions.py Fix rpc tests 2018-01-15 08:26:15 +01:00
README.md test: remove necessity to call create_callback_map 2015-12-07 12:45:14 +01:00
receivedby.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
reindex.py Merge #8860: [qa] util: Move wait_bitcoinds() into stop_nodes() 2018-01-12 09:57:56 +01:00
rest.py Merge #8638: rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST 2018-01-09 14:16:38 +01:00
rpcbind_test.py Merge #9824: qa: Check return code when stopping nodes 2018-01-26 12:59:29 +01:00
rpcnamedargs.py Merge #9707: Fix RPC failure testing 2018-01-23 09:24:28 +01:00
sendheaders.py [qa] Fix race condition in sendheaders.py 2018-02-08 10:40:51 +01:00
signmessages.py Dashify addresses/keys in signmessages.py RPC test 2017-12-21 20:37:17 +01:00
signrawtransactions.py Merge #9650: Better handle invalid parameters to signrawtransaction 2018-02-07 13:11:08 +01:00
smartfees.py Merge #9276: Some minor testing cleanups 2018-01-17 17:31:12 +01:00
spentindex.py Fix rpc tests broken by 2110 (#2118) 2018-06-12 21:37:31 +03:00
sporks.py Fix spork propagation while in IBD and fix spork integration tests (#2533) 2018-12-06 14:43:36 +01:00
timestampindex.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
txindex.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
txn_clone.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
txn_doublespend.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
wallet-accounts.py Fix wallet-accounts.py tests 2018-01-09 17:45:28 +01:00
wallet-dump.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
wallet-hd.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
wallet.py Fix rpc tests broken by 2110 (#2118) 2018-06-12 21:37:31 +03:00
walletbackup.py Merge #8724: [qa] walletbackup: Sync blocks inside the loop 2018-01-11 13:19:32 +01:00
zapwallettxes.py Merge #8056: [qa] Remove hardcoded "4 nodes" from test_framework 2017-12-21 18:50:13 +01:00
zmq_test.py Merge #9508: Remove unused Python imports 2018-01-21 12:48:33 +01:00

Regression tests

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for new regression tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support p2p connectivity to a bitcoind.

test_framework/comptool.py

Framework for comparison-tool style, p2p tests.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/blockstore.py

Implements disk-backed block and tx storage.

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

P2P test design notes

Mininode

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • NodeConn is the class used to connect to a bitcoind. If you implement a callback class that derives from NodeConnCB and pass that to the NodeConn object, your code will receive the appropriate callbacks when events of interest arrive.

  • You can pass the same handler to multiple NodeConn's if you like, or pass different ones to each -- whatever makes the most sense for your test.

  • Call NetworkThread.start() after all NodeConn objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • RPC calls are available in p2p tests.

  • Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples: p2p-accept-block.py, maxblocksinflight.py.

Comptool

  • Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.

  • Set the num_nodes variable (defined in ComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then --testbinary can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then --refbinary can be optionally used to change the bitcoind that will be used on nodes 2 and up.

  • Implement a (generator) function called get_tests() which yields TestInstances. Each TestInstance consists of:

    • a list of [object, outcome, hash] entries
      • object is a CBlock, CTransaction, or CBlockHeader. CBlock's and CTransaction's are tested for acceptance. CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.
      • outcome is True, False, or None. If True or False, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. If None is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.
      • hash is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
    • sync_every_block: True/False. If False, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. If True, then each block is tested in sequence and synced (this is slower when processing many blocks).
    • sync_every_transaction: True/False. Analogous to sync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. If True or False, then only the last tx's acceptance is tested against the given outcome.
  • For examples of tests written in this framework, see invalidblockrequest.py and p2p-fullblocktest.py.