sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 03:52:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
dbfa92990a
dash/.travis
History
MarcoFalke dbfa92990a
Merge #21096: Re-add dead code detection 
3f8776a1391c3978ed66144df15fd9bcb9edd35d Re-add dead code detection (flack)

Pull request description:

  This re-adds unreachable code detection for Python based on `vulture`.

  Effectively, this reverts f4beb4996d27f2cdaf4f0a63e7dc044bf17decce. The difference to the previous version is that this runs with the `--min-confidence 100` setting. From https://pypi.org/project/vulture/:

  > Use `--min-confidence 100` to only report code that is guaranteed to be unused within the analyzed files.

  So this should avoid the previous issues where static analysis had wrong positives due to the dynamic nature of Python code by only reporting things that are unambiguous (such as code after a `return` statement). As such, there is not suppressions list.

  My motivation was mainly #21081 which would have been caught by this (as can be seen by the CI run failing). This is still marked as draft because #21081 is needed to get the linter to pass. Also, there is a second problem that this found (see https://github.com/bitcoin/bitcoin/pull/19509/files#r571454691). From what I can tell, this is a spurious type comment that could just be removed (or if that line has no side effects it could also be deleted altogether?). I could add a commit here to fix it, but I wanted to see if there is interest in having this linter again in the first place

ACKs for top commit:
  practicalswift:
    ACK 3f8776a1391c3978ed66144df15fd9bcb9edd35d

Tree-SHA512: 52314ad4f627d969de1eb15375ca677ed86a2e816fe773756a1ce22421214ba407b5a09a4bf701a3aab1a10c7b336f548e4cef3327edf154acba55e987db21f6
2021-10-05 20:34:00 +03:00
..
lint_04_install.sh Merge #21096: Re-add dead code detection 2021-10-05 20:34:00 +03:00
lint_05_before_script.sh Partial merge #13863: travis: move script sections to files in .travis/ subject to shellcheck 2021-07-08 13:09:43 -04:00
lint_06_script.sh Merge #15255: [tests] Remove travis_wait from lint script 2021-09-10 20:55:59 -04:00
README.md Partial merge #13863: travis: move script sections to files in .travis/ subject to shellcheck 2021-07-08 13:09:43 -04:00
test_03_before_install.sh Merge #14673: travis: Fail the UBSan Travis build in case of newly introduced UBSan errors 2021-08-18 13:56:42 -05:00
test_04_install.sh Merge #16438: travis: Print memory and number of cpus 2021-09-12 14:15:12 -04:00
test_05_before_script.sh merge #19240: macOS toolchain simplification and bump 2021-09-03 17:49:55 +05:30

README.md

travis build scripts

The .travis directory contains scripts for each build step in each build stage. Currently the travis build defines two stages lint and test. Each stage has it's own lifecycle. Every script in here is named and numbered according to which stage and lifecycle step it belongs to.