mirror of
https://github.com/dashpay/dash.git
synced 2024-12-29 13:59:06 +01:00
d1d54ae6a3
cead28b[docs] Add release notes for deprecated 'account' API (John Newbery)72c9575[wallet] [tests] Add tests for accounts/labels APIs (John Newbery)109e05d[wallet] [rpc] Deprecate wallet 'account' API (John Newbery)3576ab1[wallet] [rpc] Deprecate account RPC methods (John Newbery)3db1ba0[tests] Set -deprecatedrpc=accounts in tests (John Newbery)4e671f0[tests] Rename rpc_listtransactions.py to wallet_listtransactions.py (John Newbery)a28b907[wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table (John Newbery) Pull request description: Deprecate all accounts functionality and make it only accessible by using `-deprecatedrpc=accounts`. Accounts specific RPCs, account arguments, and account related results all require the `-deprecatedrpc=accunts` startup option now in order to see account things. Several wallet functional tests use the accounts system. Those tests are unchanged, except to start the nodes with `-deprecatedrpc=accounts`. We can slowly migrate those tests to use the 'label' API instead of the 'account' API before accounts are fully removed. Tree-SHA512: 89f4ae2fe6de4a1422f1817b0997ae22d63ab5a1a558362ce923a3871f3e42963405d6573c69c27f1764679cdee5b51bf52202cc407f1361bfd8066d652f3f37
146 lines
6.6 KiB
Python
Executable File
146 lines
6.6 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the wallet accounts properly when there is a double-spend conflict."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import *
|
|
|
|
class TxnMallTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 4
|
|
self.extra_args = [['-deprecatedrpc=accounts']] * 4
|
|
|
|
def add_options(self, parser):
|
|
parser.add_option("--mineblock", dest="mine_block", default=False, action="store_true",
|
|
help="Test double-spend of 1-confirmed transaction")
|
|
|
|
def setup_network(self):
|
|
# Start with split network:
|
|
super().setup_network()
|
|
disconnect_nodes(self.nodes[1], 2)
|
|
disconnect_nodes(self.nodes[2], 1)
|
|
|
|
def run_test(self):
|
|
# All nodes should start with 1,250 BTC:
|
|
starting_balance = 1250
|
|
for i in range(4):
|
|
assert_equal(self.nodes[i].getbalance(), starting_balance)
|
|
self.nodes[i].getnewaddress("") # bug workaround, coins generated assigned to first getnewaddress!
|
|
|
|
# Assign coins to foo and bar accounts:
|
|
node0_address_foo = self.nodes[0].getnewaddress("foo")
|
|
fund_foo_txid = self.nodes[0].sendfrom("", node0_address_foo, 1219)
|
|
fund_foo_tx = self.nodes[0].gettransaction(fund_foo_txid)
|
|
|
|
node0_address_bar = self.nodes[0].getnewaddress("bar")
|
|
fund_bar_txid = self.nodes[0].sendfrom("", node0_address_bar, 29)
|
|
fund_bar_tx = self.nodes[0].gettransaction(fund_bar_txid)
|
|
|
|
assert_equal(self.nodes[0].getbalance(""),
|
|
starting_balance - 1219 - 29 + fund_foo_tx["fee"] + fund_bar_tx["fee"])
|
|
|
|
# Coins are sent to node1_address
|
|
node1_address = self.nodes[1].getnewaddress("from0")
|
|
|
|
# First: use raw transaction API to send 1240 BTC to node1_address,
|
|
# but don't broadcast:
|
|
doublespend_fee = Decimal('-.02')
|
|
rawtx_input_0 = {}
|
|
rawtx_input_0["txid"] = fund_foo_txid
|
|
rawtx_input_0["vout"] = find_output(self.nodes[0], fund_foo_txid, 1219)
|
|
rawtx_input_1 = {}
|
|
rawtx_input_1["txid"] = fund_bar_txid
|
|
rawtx_input_1["vout"] = find_output(self.nodes[0], fund_bar_txid, 29)
|
|
inputs = [rawtx_input_0, rawtx_input_1]
|
|
change_address = self.nodes[0].getnewaddress()
|
|
outputs = {}
|
|
outputs[node1_address] = 1240
|
|
outputs[change_address] = 1248 - 1240 + doublespend_fee
|
|
rawtx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
doublespend = self.nodes[0].signrawtransactionwithwallet(rawtx)
|
|
assert_equal(doublespend["complete"], True)
|
|
|
|
# Create two spends using 1 50 BTC coin each
|
|
txid1 = self.nodes[0].sendfrom("foo", node1_address, 40, 0)
|
|
txid2 = self.nodes[0].sendfrom("bar", node1_address, 20, 0)
|
|
|
|
# Have node0 mine a block:
|
|
if (self.options.mine_block):
|
|
self.nodes[0].generate(1)
|
|
sync_blocks(self.nodes[0:2])
|
|
|
|
tx1 = self.nodes[0].gettransaction(txid1)
|
|
tx2 = self.nodes[0].gettransaction(txid2)
|
|
|
|
# Node0's balance should be starting balance, plus 50BTC for another
|
|
# matured block, minus 40, minus 20, and minus transaction fees:
|
|
expected = starting_balance + fund_foo_tx["fee"] + fund_bar_tx["fee"]
|
|
if self.options.mine_block:
|
|
expected += 50
|
|
expected += tx1["amount"] + tx1["fee"]
|
|
expected += tx2["amount"] + tx2["fee"]
|
|
assert_equal(self.nodes[0].getbalance(), expected)
|
|
|
|
# foo and bar accounts should be debited:
|
|
assert_equal(self.nodes[0].getbalance("foo", 0), 1219+tx1["amount"]+tx1["fee"])
|
|
assert_equal(self.nodes[0].getbalance("bar", 0), 29+tx2["amount"]+tx2["fee"])
|
|
|
|
if self.options.mine_block:
|
|
assert_equal(tx1["confirmations"], 1)
|
|
assert_equal(tx2["confirmations"], 1)
|
|
# Node1's "from0" balance should be both transaction amounts:
|
|
assert_equal(self.nodes[1].getbalance("from0"), -(tx1["amount"]+tx2["amount"]))
|
|
else:
|
|
assert_equal(tx1["confirmations"], 0)
|
|
assert_equal(tx2["confirmations"], 0)
|
|
|
|
# Now give doublespend and its parents to miner:
|
|
self.nodes[2].sendrawtransaction(fund_foo_tx["hex"])
|
|
self.nodes[2].sendrawtransaction(fund_bar_tx["hex"])
|
|
doublespend_txid = self.nodes[2].sendrawtransaction(doublespend["hex"])
|
|
# ... mine a block...
|
|
self.nodes[2].generate(1)
|
|
|
|
# Reconnect the split network, and sync chain:
|
|
connect_nodes(self.nodes[1], 2)
|
|
self.nodes[2].generate(1) # Mine another block to make sure we sync
|
|
sync_blocks(self.nodes)
|
|
assert_equal(self.nodes[0].gettransaction(doublespend_txid)["confirmations"], 2)
|
|
|
|
# Re-fetch transaction info:
|
|
tx1 = self.nodes[0].gettransaction(txid1)
|
|
tx2 = self.nodes[0].gettransaction(txid2)
|
|
|
|
# Both transactions should be conflicted
|
|
assert_equal(tx1["confirmations"], -2)
|
|
assert_equal(tx2["confirmations"], -2)
|
|
|
|
# Node0's total balance should be starting balance, plus 100BTC for
|
|
# two more matured blocks, minus 1240 for the double-spend, plus fees (which are
|
|
# negative):
|
|
expected = starting_balance + 100 - 1240 + fund_foo_tx["fee"] + fund_bar_tx["fee"] + doublespend_fee
|
|
assert_equal(self.nodes[0].getbalance(), expected)
|
|
assert_equal(self.nodes[0].getbalance("*"), expected)
|
|
|
|
# Final "" balance is starting_balance - amount moved to accounts - doublespend + subsidies +
|
|
# fees (which are negative)
|
|
assert_equal(self.nodes[0].getbalance("foo"), 1219)
|
|
assert_equal(self.nodes[0].getbalance("bar"), 29)
|
|
assert_equal(self.nodes[0].getbalance(""), starting_balance
|
|
-1219
|
|
- 29
|
|
-1240
|
|
+ 100
|
|
+ fund_foo_tx["fee"]
|
|
+ fund_bar_tx["fee"]
|
|
+ doublespend_fee)
|
|
|
|
# Node1's "from0" account balance should be just the doublespend:
|
|
assert_equal(self.nodes[1].getbalance("from0"), 1240)
|
|
|
|
if __name__ == '__main__':
|
|
TxnMallTest().main()
|
|
|