026d3f5fd5
## Issue being fixed or feature implemented Slightly changes the detached signature creation code ## What was done? Investigated what exactly needed to be done for notarization (docs to come), tried it again, then when it failed as expected trying to figure it out, then figuring it out :) simple change in the end. ## How Has This Been Tested? created macOS detached sigs and notarized 19.0.0-rc.10 binaries and ensured that all worked as expected. See binary attached here (sha256 3829e863831b05c3d76785540183bee556c4bab03dac98f5872df06668b9cb20) [dashcore-19.0.0-rc.10-osx.dmg.zip](https://github.com/dashpay/dash/files/11246273/dashcore-19.0.0-rc.10-osx.dmg.zip). You can also do a signed gitian-build for rc.10 and should replicate these hashes. ## Breaking Changes Should be none; I would like to backport this to 19 as a 19.0.1 ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ |
||
|---|---|---|
| .. | ||
| auto_gdb | ||
| builder-keys | ||
| containers | ||
| debian | ||
| devtools | ||
| gitian-descriptors | ||
| guix | ||
| init | ||
| linearize | ||
| macdeploy | ||
| qos | ||
| seeds | ||
| shell | ||
| testgen | ||
| verify-commits | ||
| verifybinaries | ||
| windeploy | ||
| zmq | ||
| dash-cli.bash-completion | ||
| dash-qt.pro | ||
| dash-tx.bash-completion | ||
| dashd.bash-completion | ||
| filter-lcov.py | ||
| gitian-build.py | ||
| README.md | ||
| valgrind.supp | ||
Repository Tools
Developer tools
Specific tools for developers working on this repository.
Contains the script github-merge.py for merging GitHub pull requests securely and signing them using GPG.
Verify-Commits
Tool to verify that every merge commit was signed by a developer using the above github-merge.py script.
Linearize
Construct a linear, no-fork, best version of the blockchain.
Qos
A Linux bash script that will set up traffic control (tc) to limit the outgoing bandwidth for connections to the Dash network. This means one can have an always-on dashd instance running, and another local dashd/dash-qt instance which connects to this node and receives blocks from it.
Seeds
Utility to generate the pnSeed[] array that is compiled into the client.
Build Tools and Keys
Debian
Contains files used to package dashd/dash-qt for Debian-based Linux systems. If you compile dashd/dash-qt yourself, there are some useful files here.
Gitian-descriptors
Notes on getting Gitian builds up and running using KVM.
Builder keys
PGP keys used for signing Dash Core release results.
MacDeploy
Scripts and notes for Mac builds.
Gitian-build
Script for running full Gitian builds.
Test and Verify Tools
TestGen
Utilities to generate test vectors for the data-driven Dash tests.
Verify Binaries
This script attempts to download and verify the signature file SHA256SUMS.asc from bitcoin.org.