sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-26 04:22:55 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
Dash - Reinventing Cryptocurrency
17,264 Commits 24 Branches 554 Tags 573 MiB
C++ 52.7%
C 24.2%
Python 10.5%
Assembly 3.3%
JavaScript 2.6%
Other 6.5%
e288330e03
Go to file
Wladimir J. van der Laan e288330e03
Merge #11748: [Tests] Adding unit tests for GetDifficulty in blockchain.cpp. 
3e1ee31 [Tests] Adding unit tests for GetDifficulty in blockchain.cpp. (sean)

Pull request description:

  blockchain.cpp has low unit test coverage. This commit is intended
  to start improving its code coverage to reasonable levels. One or more
  follow up commits will complete the task that this commit is starting
  (though the usefulness of this commit is not dependent upon later
  commits).

  Note that these tests were not written based upon a specification of how
  GetDifficulty *should* work, but rather how it actually *does* work. As
  a result, if there are any bugs in the current GetDifficulty
  implementation, these unit tests serve to lock them in rather than
  expose them.

  -- Why has blockchain.cpp been modified if this is a unit testing change?

  Since the existing GetDifficulty function relies on a global variable,
  chainActive, it was not suitable for unit testing purposes. Both the
  existing GetDifficulty function and the unit tests now call through to
  a new, more modular version of GetDifficulty that can work on any chain,
  not just chainActive.

  -- Why does blockchain_tests.cpp directly include blockchain.cpp instead
  of blockchain.h?

  While the new GetDifficulty function's signature is arguably better than
  the old one's, it still isn't great, and doesn't seem to warrant inclusion
  as part of the blockchain.h API, especially since only test code is
  directly using it. If a better way of exposing the new GetDifficulty
  function to unit tests exists, please mention it and the commit will be
  updated accordingly.

  -- Why is the test fixture named blockchain_difficulty_tests rather than
  blockchain_tests?

  The Bitcoin Core policy for naming unit test files is to match the the
  file under test ("blockchain" becomes "blockchain_tests"). While this
  commit complies with that, blockchain.cpp is a massive file, such that
  having all of the unit tests in one file will tend towards disorder.
  Since there will be a lot more tests added to this file, the intention
  is to divide up different types of tests into different test fixtures
  within the same file.

Tree-SHA512: a7dda9c2a9414d4819b4d2911f5637891dc19cecbecfc1463846161d2a78793151927a5ab911c69a5d3013f7668e75a1d78a65667cb9d83910cda439cbe84d62
2020-01-31 07:43:43 -06:00
.github Add link to bugcrowd in issue template (#2716) 2019-02-19 13:05:59 +03:00
.tx
build-aux/m4 Merge #10803: Explicitly search for bdb5.3. 2019-07-24 11:59:09 -05:00
ci More of 11300 2020-01-10 10:34:04 -06:00
contrib Merge pull request #3312 from PastaPastaPasta/backports-0.16-pr6 2020-01-31 14:05:32 +03:00
depends Merge #11286: [depends] Don't build libevent sample code 2020-01-10 10:33:55 -06:00
doc bitcoin -> Dash 2020-01-30 07:37:50 -06:00
docker
share trivial: adding SVG and high contrast icons (#3209) 2020-01-17 15:45:25 +01:00
src Merge #11748: [Tests] Adding unit tests for GetDifficulty in blockchain.cpp. 2020-01-31 07:43:43 -06:00
test Merge #11475: [rpc] mempoolinfo should take ::minRelayTxFee into account 2020-01-31 07:43:43 -06:00
.gitattributes
.gitignore bitcoin -> dash 2019-08-24 11:11:25 -05:00
.gitlab-ci.yml Fix pull request detection in .gitlab-ci.yml (#3256) 2019-12-31 13:02:03 +03:00
.travis.yml Fix empty TRAVIS_COMMIT_RANGE for one-commit-branch builds in Travis (#3299) 2020-01-24 19:59:06 +03:00
autogen.sh
CMakeLists.txt Enable stacktrace support in gitian builds (#3006) 2019-07-02 07:16:11 +03:00
configure.ac Merge #11936: [build] Warn that only libconsensus can be built without Boost 2020-01-31 07:43:43 -06:00
CONTRIBUTING.md Merge #11624: Docs: Change formatting for sequence of steps 2020-01-16 09:22:46 -06:00
COPYING Bump copyright year to 2020 (#3290) 2020-01-17 15:42:55 +01:00
INSTALL.md
Jenkinsfile Perform Jenkins builds in /dash-src all the time to fix caching issues (#2242) 2018-08-29 13:03:18 +03:00
Jenkinsfile.gitian Let ccache compress the cache by itself instead of compressing ccache.tar (#2456) 2018-11-19 07:31:13 +01:00
libdashconsensus.pc.in
Makefile.am Merge #11541: Build: Fix Automake warnings when running autogen.sh 2020-01-16 09:22:46 -06:00
README.md Bump version to 0.16 on develop (#3239) 2019-12-13 18:52:52 +01:00

README.md

Dash Core staging tree 0.16

master: Build Status develop: Build Status

https://www.dash.org

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The contribution workflow is described in CONTRIBUTING.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also follow the forum.