dash/src/cachemap.h
PastaPastaPasta f503a7edc1
refactor: Fix warnings from cppcheck (#4625)
* src/evo/evodb.cpp:57:29: warning: Assert statement calls a function which may have desired side effects: 'IsClean'. [assertWithSideEffect]

* src/llmq/quorums.cpp:635:37: note: Null pointer dereference

src/llmq/quorums.cpp:635:37: warning: Either the condition 'pFrom==nullptr' is redundant or there is possible null pointer dereference: pFrom. [nullPointerRedundantCheck]
src/llmq/quorums.cpp:636:81: note: Assuming that condition 'pFrom==nullptr' is not redundant

* fix a bunch of cppcheck warnings

* cppcheck: run on many more files. Enable all checks except a few ignored ones.

ignored
```
    "Consider using std::transform algorithm instead of a raw loop."
    "Consider using std::accumulate algorithm instead of a raw loop."
```

* ci: build specific version of cppcheck instead of install from apt

* ci: use cppcheck 2.4, remove commented out line, fix symlink

cppcheck 2.6 is latest, however causes issues
```
src/spork.cpp:135:51: warning: Analysis failed. If the code is valid then please report this failure. [cppcheckError]
```
cppcheck 2.5 appears to get into an infinite loop

* no need to check presence before insertion

* use if-init, remove redundant check

* remove redundant check

* don't remove cmake? fix macOs depends build?

* cppcheck: one per line, alphabetize

* remove duplicate cmake install
2021-12-29 00:54:50 +03:00

180 lines
3.6 KiB
C++

// Copyright (c) 2014-2020 The Dash Core developers
// Distributed under the MIT/X11 software license, see the accompanying
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
#ifndef BITCOIN_CACHEMAP_H
#define BITCOIN_CACHEMAP_H
#include <map>
#include <list>
#include <cstddef>
#include <serialize.h>
/**
* Serializable structure for key/value items
*/
template<typename K, typename V>
struct CacheItem
{
CacheItem()
{}
CacheItem(const K& keyIn, const V& valueIn)
: key(keyIn),
value(valueIn)
{}
K key;
V value;
SERIALIZE_METHODS(CacheItem, obj)
{
READWRITE(obj.key, obj.value);
}
};
/**
* Map like container that keeps the N most recently added items
*/
template<typename K, typename V, typename Size = uint32_t>
class CacheMap
{
public:
using size_type = Size;
using item_t = CacheItem<K,V>;
using list_t = std::list<item_t>;
using list_it = typename list_t::iterator;
using list_cit = typename list_t::const_iterator;
using map_t = std::map<K, list_it>;
using map_it = typename map_t::iterator;
using map_cit = typename map_t::const_iterator;
private:
size_type nMaxSize;
list_t listItems;
map_t mapIndex;
public:
explicit CacheMap(size_type nMaxSizeIn = 0)
: nMaxSize(nMaxSizeIn),
listItems(),
mapIndex()
{}
explicit CacheMap(const CacheMap<K,V>& other)
: nMaxSize(other.nMaxSize),
listItems(other.listItems),
mapIndex()
{
RebuildIndex();
}
void Clear()
{
mapIndex.clear();
listItems.clear();
}
void SetMaxSize(size_type nMaxSizeIn)
{
nMaxSize = nMaxSizeIn;
}
size_type GetMaxSize() const {
return nMaxSize;
}
size_type GetSize() const {
return listItems.size();
}
bool Insert(const K& key, const V& value)
{
if(mapIndex.find(key) != mapIndex.end()) {
return false;
}
if(listItems.size() == nMaxSize) {
PruneLast();
}
listItems.push_front(item_t(key, value));
mapIndex.emplace(key, listItems.begin());
return true;
}
bool HasKey(const K& key) const
{
return (mapIndex.find(key) != mapIndex.end());
}
bool Get(const K& key, V& value) const
{
map_cit it = mapIndex.find(key);
if(it == mapIndex.end()) {
return false;
}
const item_t& item = *(it->second);
value = item.value;
return true;
}
void Erase(const K& key)
{
map_it it = mapIndex.find(key);
if(it == mapIndex.end()) {
return;
}
listItems.erase(it->second);
mapIndex.erase(it);
}
const list_t& GetItemList() const {
return listItems;
}
CacheMap<K,V>& operator=(const CacheMap<K,V>& other)
{
nMaxSize = other.nMaxSize;
listItems = other.listItems;
RebuildIndex();
return *this;
}
SERIALIZE_METHODS(CacheMap, obj)
{
READWRITE(obj.nMaxSize, obj.listItems);
SER_READ(obj, obj.RebuildIndex());
}
private:
void PruneLast()
{
if(listItems.empty()) {
return;
}
item_t& item = listItems.back();
mapIndex.erase(item.key);
listItems.pop_back();
}
void RebuildIndex()
{
mapIndex.clear();
for(list_it it = listItems.begin(); it != listItems.end(); ++it) {
mapIndex.emplace(it->key, it);
}
}
};
#endif // BITCOIN_CACHEMAP_H