dash/src/qt
Wladimir J. van der Laan e7c27f3b77
Merge #10898: Fix invalid checks (NULL checks after dereference, redundant checks, etc.)
76fed83 Avoid NULL pointer dereference when _walletModel is NULL (which is valid) (practicalswift)
4971a9a Use two boolean literals instead of re-using variable (practicalswift)
b5fb339 Remove duplicate uriParts.size() > 0 check (practicalswift)
7466991 Remove redundant check (!ecc is always true) (practicalswift)
55224af Remove redundant NULL checks after new (practicalswift)

Pull request description:

  Contains:
  * Remove redundant `NULL` checks after throwing `new`
  * Remove redundant check (`!ecc` is always true)
  * Remove duplicate `uriParts.size() > 0` check
  * Use two boolean literals instead of re-using variable

Tree-SHA512: 30e9af8a9d5c8184836f8267b492aeb4e26eca171a3be08f634b3f39b3055b9fa9f06623f6c69b294ca13bf99743f7645cfac2b25e014ff74687bd085a997895
2020-01-16 09:21:05 -06:00
..
forms Tweak few more strings re mixing and balances (#3265) 2020-01-04 14:20:43 +03:00
locale Translations201909 (#3107) 2019-11-11 11:24:45 +03:00
res Fix menu bar text color in Dark theme (#3236) 2019-12-12 11:46:54 +01:00
test Merge #10793: Changing &var[0] to var.data() 2020-01-10 10:33:54 -06:00
addressbookpage.cpp Qt: Remove old themes (#3141) 2019-10-10 14:53:00 +03:00
addressbookpage.h Merge #10568: Remove unnecessary forward class declarations in header files 2019-07-09 13:08:20 -05:00
addresstablemodel.cpp Fix largest part of GUI lockups with large wallets (#3155) 2019-10-19 13:39:02 +03:00
addresstablemodel.h Fix largest part of GUI lockups with large wallets (#3155) 2019-10-19 13:39:02 +03:00
askpassphrasedialog.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
askpassphrasedialog.h
bantablemodel.cpp Merge #10175: Remove excess logic. 2019-06-19 08:20:15 -05:00
bantablemodel.h
bitcoinaddressvalidator.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
bitcoinaddressvalidator.h
bitcoinamountfield.cpp Add Dark theme (#3216) 2019-11-22 21:13:47 +03:00
bitcoinamountfield.h
bitcoingui.cpp Merge #11169: [GUI] Make tabs toolbar no longer have a context menu 2020-01-01 22:31:14 -06:00
bitcoingui.h Don't show individual messages for each TX when too many come in at once (#3170) 2019-10-23 09:56:15 +02:00
bitcoinunits.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
bitcoinunits.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
callback.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
clientmodel.cpp Merge #10864: Avoid redundant redeclaration of GetWarnings(const string&) 2019-07-24 11:59:09 -05:00
clientmodel.h Merge #10568: Remove unnecessary forward class declarations in header files 2019-07-09 13:08:20 -05:00
coincontroldialog.cpp Merge #11133: Document assumptions that are being made to avoid division by zero 2020-01-12 17:01:40 -06:00
coincontroldialog.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
coincontroltreewidget.cpp Merge #10521: Limit variable scope 2019-07-08 13:50:05 -05:00
coincontroltreewidget.h
csvmodelwriter.cpp
csvmodelwriter.h
dash_locale.qrc Translations201909 (#3107) 2019-11-11 11:24:45 +03:00
dash.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
dash.qrc Only load valid themes, fallback to "Light" theme otherwise (#3285) 2020-01-14 23:17:53 +03:00
dashstrings.cpp Compliance changes to terminology (#3211) 2019-11-21 23:49:35 +03:00
editaddressdialog.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
editaddressdialog.h
guiconstants.h Let regtest have its own qt settings (#3286) 2020-01-14 23:18:15 +03:00
guiutil.cpp Define defaultTheme and darkThemePrefix as constants and use them instead of plain strings (#3288) 2020-01-16 14:24:45 +03:00
guiutil.h Add Dark theme (#3216) 2019-11-22 21:13:47 +03:00
intro.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
intro.h
macdockiconhandler.h
macdockiconhandler.mm Merge #11066: Document the preference of nullptr over NULL or (void*)0 2020-01-01 21:33:31 -06:00
macnotificationhandler.h Merge #11268: [macOS] remove Growl support, remove unused code 2020-01-10 10:33:55 -06:00
macnotificationhandler.mm Merge #11268: [macOS] remove Growl support, remove unused code 2020-01-10 10:33:55 -06:00
macos_appnap.h Backport #12783: macOS: disable AppNap during sync (and mixing) (#3024) 2019-07-15 14:38:55 +03:00
macos_appnap.mm Backport #12783: macOS: disable AppNap during sync (and mixing) (#3024) 2019-07-15 14:38:55 +03:00
masternodelist.cpp Add collateral, owner and voting addresses to masternode list table (#3207) 2019-11-22 21:12:57 +03:00
masternodelist.h Multiple speed optimizations for deterministic MN list handling (#2972) 2019-06-13 12:01:26 +03:00
modaloverlay.cpp Merge #10633: doc: Fix various typos 2019-07-11 10:34:46 -05:00
modaloverlay.h Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
networkstyle.cpp Let regtest have its own qt settings (#3286) 2020-01-14 23:18:15 +03:00
networkstyle.h Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
notificator.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
notificator.h Merge #11268: [macOS] remove Growl support, remove unused code 2020-01-10 10:33:55 -06:00
openuridialog.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
openuridialog.h
optionsdialog.cpp Only load valid themes, fallback to "Light" theme otherwise (#3285) 2020-01-14 23:17:53 +03:00
optionsdialog.h
optionsmodel.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
optionsmodel.h Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
overviewpage.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
overviewpage.h Add Qt GUI refresh w/branding updates (#3000) 2019-10-31 20:30:21 +03:00
paymentrequest.proto
paymentrequestplus.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
paymentrequestplus.h
paymentserver.cpp Merge #10964: Pass SendCoinsRecipient (208 bytes) by reference 2020-01-02 16:16:55 -06:00
paymentserver.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
peertablemodel.cpp scripted-diff: Remove Q_FOREACH #10502 2019-07-09 13:08:21 -05:00
peertablemodel.h
platformstyle.cpp scripted-diff: Remove Q_FOREACH #10502 2019-07-09 13:08:21 -05:00
platformstyle.h
qrdialog.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
qrdialog.h
qvalidatedlineedit.cpp Add Dark theme (#3216) 2019-11-22 21:13:47 +03:00
qvalidatedlineedit.h
qvaluecombobox.cpp
qvaluecombobox.h
receivecoinsdialog.cpp Qt: Remove old themes (#3141) 2019-10-10 14:53:00 +03:00
receivecoinsdialog.h Merge #10568: Remove unnecessary forward class declarations in header files 2019-07-09 13:08:20 -05:00
receiverequestdialog.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
receiverequestdialog.h
recentrequeststablemodel.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
recentrequeststablemodel.h
rpcconsole.cpp Add Dark theme (#3216) 2019-11-22 21:13:47 +03:00
rpcconsole.h #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
sendcoinsdialog.cpp Merge #10976: [MOVEONLY] Move some static functions out of wallet.h/cpp #10976 2020-01-10 10:33:57 -06:00
sendcoinsdialog.h Tweak "Send" popup and refactor related code a bit (#3218) 2019-11-27 13:53:42 +03:00
sendcoinsentry.cpp Qt: Remove old themes (#3141) 2019-10-10 14:53:00 +03:00
sendcoinsentry.h
signverifymessagedialog.cpp Merge #10793: Changing &var[0] to var.data() 2020-01-10 10:33:54 -06:00
signverifymessagedialog.h
splashscreen.cpp Merge #10770: Drop upgrade-cancel callback registration for a generic "cancelable" 2020-01-03 08:35:55 -06:00
splashscreen.h Merge #10770: Drop upgrade-cancel callback registration for a generic "cancelable" 2020-01-03 08:35:55 -06:00
trafficgraphdata.cpp
trafficgraphdata.h
trafficgraphwidget.cpp scripted-diff: Remove Q_FOREACH #10502 2019-07-09 13:08:21 -05:00
trafficgraphwidget.h
transactiondesc.cpp Fix largest part of GUI lockups with large wallets (#3155) 2019-10-19 13:39:02 +03:00
transactiondesc.h
transactiondescdialog.cpp
transactiondescdialog.h
transactionfilterproxy.cpp Fix largest part of GUI lockups with large wallets (#3155) 2019-10-19 13:39:02 +03:00
transactionfilterproxy.h Fix largest part of GUI lockups with large wallets (#3155) 2019-10-19 13:39:02 +03:00
transactionrecord.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
transactionrecord.h Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
transactiontablemodel.cpp Add Dark theme (#3216) 2019-11-22 21:13:47 +03:00
transactiontablemodel.h Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
transactionview.cpp Add Dark theme (#3216) 2019-11-22 21:13:47 +03:00
transactionview.h Merge #11015: [Qt] Add delay before filtering transactions 2019-09-25 10:33:21 +02:00
utilitydialog.cpp Compliance changes to terminology (#3211) 2019-11-21 23:49:35 +03:00
utilitydialog.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
walletframe.cpp Merge #11132: Document assumptions that are being made to avoid NULL pointer dereferences 2020-01-10 10:34:00 -06:00
walletframe.h
walletmodel.cpp More of 10793 2020-01-10 10:34:03 -06:00
walletmodel.h Handle coin type via CCoinControl (#3172) 2019-10-23 09:56:44 +02:00
walletmodeltransaction.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
walletmodeltransaction.h Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
walletview.cpp Merge #10898: Fix invalid checks (NULL checks after dereference, redundant checks, etc.) 2020-01-16 09:21:05 -06:00
walletview.h
winshutdownmonitor.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
winshutdownmonitor.h