Dash - Reinventing Cryptocurrency
Go to file
Wladimir J. van der Laan e8b95239ee
Merge #10712: Add change output if necessary to reduce excess fee
0f402b9 Fix rare edge case of paying too many fees when transaction has no change. (Alex Morcos)
253cd7e Only reserve key for scriptChange once in CreateTransaction (Alex Morcos)

Pull request description:

  This is an alternative to #10333

  See commit messages.

  The first commit is mostly code move, it just moves the change creation code out of the loop.

  @instagibbs

Tree-SHA512: f16287ae0f0c6f09cf8b1f0db5880bb567ffa74a50898e3d1ef549ba592c6309ae1a9b251739f63a8bb622d48f03ce2dff9e7a57a6bac4afb4b95b0a86613ea8
2017-07-11 19:03:41 +02:00
.github Mention reporting security issues responsibly 2016-11-10 14:41:40 +01:00
.tx qt: Set transifex slug to 0.14 2017-01-02 09:36:03 +01:00
build-aux/m4 Avoid printing generic and duplicated "checking for QT" during ./configure 2017-06-08 10:41:34 +02:00
contrib Merge #10786: Add PR description to merge commit in github-merge.py 2017-07-11 15:40:08 +02:00
depends [depends] expat 2.2.1 2017-06-19 12:49:32 +08:00
doc REST/RPC example update 2017-06-30 13:21:08 +02:00
share Slightly overhaul NSI pixmaps 2017-06-22 21:40:48 +02:00
src Fix rare edge case of paying too many fees when transaction has no change. 2017-07-11 12:20:41 -04:00
test Merge #10190: [tests] mining functional tests (including regression test for submitblock) 2017-07-11 15:21:26 +02:00
.gitattributes
.gitignore Use shared config file for functional and util tests 2017-05-03 14:18:30 -04:00
.travis.yml [test] don't run dbcrash.py on Travis 2017-07-04 17:27:46 +01:00
autogen.sh
configure.ac Merge #10565: [coverage] Remove subtrees and benchmarks from coverage report 2017-06-22 20:57:11 +02:00
CONTRIBUTING.md [doc] Add blob about finding reviewers. 2017-04-17 22:48:28 +09:00
COPYING [Trivial] Update license year range to 2017 2017-01-23 23:46:06 +01:00
INSTALL.md
libbitcoinconsensus.pc.in
Makefile.am Filter subtrees and and benchmarks from coverage report 2017-06-12 15:53:30 -07:00
README.md Rename test/pull-tester/rpc-tests.py to test/functional/test_runner.py 2017-03-20 10:40:31 -04:00

Bitcoin Core integration/staging tree

Build Status

https://bitcoincore.org

What is Bitcoin?

Bitcoin is an experimental digital currency that enables instant payments to anyone, anywhere in the world. Bitcoin uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Bitcoin Core is the name of open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Bitcoin Core software, see https://bitcoin.org/en/download, or read the original whitepaper.

License

Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is regularly built and tested, but is not guaranteed to be completely stable. Tags are created regularly to indicate new official, stable release versions of Bitcoin Core.

The contribution workflow is described in CONTRIBUTING.md.

The developer mailing list should be used to discuss complicated or controversial changes before working on a patch set.

Developer IRC can be found on Freenode at #bitcoin-core-dev.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also subscribe to the mailing list.