mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 13:32:47 +01:00
d413109da5
893628be0166b4096b6e52f516e0f65bb63a75a2 Drop minor GetSerializeSize template (Ben Woosley) da74db0940720407fafaf3582bbaf9c81a4d3b4d Drop unused GetType() from CSizeComputer (Ben Woosley) Pull request description: Based on conversation in #13462, it seems the serialization `GetType` has very narrow use/effect. In every case except for `CAddress`, which specifically relates to a network peer's address, not a wallet address etc., the serialized representation of an object is irrespective of its destination / type. This removes the unused `GetType` method from `CSizeComputer` as a step to further narrowing that use. Tree-SHA512: e72b8e9e5160396691e05aeaee3aba5a57935a75bd5005cfcc7fb51c936f3d1728a397f999da5c36696506dd815fafa5c738f3894df8864f25f91f639eba9c3d
66 lines
2.2 KiB
C++
66 lines
2.2 KiB
C++
// Copyright (c) 2011-2018 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <bench/bench.h>
|
|
#include <chainparams.h>
|
|
#include <consensus/merkle.h>
|
|
#include <consensus/validation.h>
|
|
#include <policy/policy.h>
|
|
#include <pow.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <txmempool.h>
|
|
#include <validation.h>
|
|
|
|
|
|
|
|
static void DuplicateInputs(benchmark::Bench& bench)
|
|
{
|
|
RegTestingSetup test_setup;
|
|
|
|
const CScript SCRIPT_PUB{CScript(OP_TRUE)};
|
|
|
|
const CChainParams& chainparams = Params();
|
|
|
|
CBlock block{};
|
|
CMutableTransaction coinbaseTx{};
|
|
CMutableTransaction naughtyTx{};
|
|
|
|
CBlockIndex* pindexPrev = ::ChainActive().Tip();
|
|
assert(pindexPrev != nullptr);
|
|
block.nBits = GetNextWorkRequired(pindexPrev, &block, chainparams.GetConsensus());
|
|
block.nNonce = 0;
|
|
auto nHeight = pindexPrev->nHeight + 1;
|
|
|
|
// Make a coinbase TX
|
|
coinbaseTx.vin.resize(1);
|
|
coinbaseTx.vin[0].prevout.SetNull();
|
|
coinbaseTx.vout.resize(1);
|
|
coinbaseTx.vout[0].scriptPubKey = SCRIPT_PUB;
|
|
coinbaseTx.vout[0].nValue = GetBlockSubsidy(block.nBits, nHeight, chainparams.GetConsensus());
|
|
coinbaseTx.vin[0].scriptSig = CScript() << nHeight << OP_0;
|
|
|
|
naughtyTx.vout.resize(1);
|
|
naughtyTx.vout[0].nValue = 0;
|
|
naughtyTx.vout[0].scriptPubKey = SCRIPT_PUB;
|
|
|
|
uint64_t n_inputs = (((MaxBlockSize() / ::GetSerializeSize(CTransaction(), PROTOCOL_VERSION)) - (CTransaction(coinbaseTx).GetTotalSize() + CTransaction(naughtyTx).GetTotalSize())) / 41) - 100;
|
|
for (uint64_t x = 0; x < (n_inputs - 1); ++x) {
|
|
naughtyTx.vin.emplace_back(GetRandHash(), 0, CScript(), 0);
|
|
}
|
|
naughtyTx.vin.emplace_back(naughtyTx.vin.back());
|
|
|
|
block.vtx.push_back(MakeTransactionRef(std::move(coinbaseTx)));
|
|
block.vtx.push_back(MakeTransactionRef(std::move(naughtyTx)));
|
|
|
|
block.hashMerkleRoot = BlockMerkleRoot(block);
|
|
|
|
bench.minEpochIterations(10).run([&] {
|
|
CValidationState cvstate{};
|
|
assert(!CheckBlock(block, cvstate, chainparams.GetConsensus(), false, false));
|
|
assert(cvstate.GetRejectReason() == "bad-txns-inputs-duplicate");
|
|
});
|
|
}
|
|
|
|
BENCHMARK(DuplicateInputs);
|