mirror of
https://github.com/dashpay/dash.git
synced 2024-12-29 05:49:11 +01:00
ed88ba72af
3f373659d732a5b1e5fdc692a45b2b8179f66bec Refactor: Replace SigningProvider pointers with unique_ptrs (Andrew Chow)
3afe53c4039103670cec5f9cace897ead76e20a8 Cleanup: Drop unused GUI learnRelatedScripts method (Andrew Chow)
e2f02aa59e3402048269362ff692d49a6df35cfd Refactor: Copy CWallet signals and print function to LegacyScriptPubKeyMan (Andrew Chow)
c729afd0a3b74a3943e4c359270beaf3e6ff8a7b Box the wallet: Add multiple keyman maps and loops (Andrew Chow)
4977c30d59e88a3e5ee248144bcc023debcd895b refactor: define a UINT256_ONE global constant (Andrew Chow)
415afcccd3e5583defdb76e3a280f48e98983301 HD Split: Avoid redundant upgrades (Andrew Chow)
01b4511206e399981a77976deb15785d18db46ae Make UpgradeKeyMetadata work only on LegacyScriptPubKeyMan (Andrew Chow)
4a7e43e8460127a40a7895519587399feff3b682 Store p2sh scripts in AddAndGetDestinationForScript (Andrew Chow)
501acb5538008d98abe79288b92040bc186b93f3 Always try to sign for all pubkeys in multisig (Andrew Chow)
81610eddbc57c46ae243f45d73e715d509f53a6c List output types in an array in order to be iterated over (Andrew Chow)
eb81fc3ee58d3e88af36d8091b9e4017a8603b3c Refactor: Allow LegacyScriptPubKeyMan to be null (Andrew Chow)
fadc08ad944cad42e805228cdd58e0332f4d7184 Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman (Andrew Chow)
f5be479694d4dbaf59eef562d80fbeacb3bb7dc1 wallet: Improve CWallet:MarkDestinationsDirty (João Barbosa)
Pull request description:
Continuation of wallet boxes project.
Actually makes ScriptPubKeyMan an interface which LegacyScriptPubkeyMan. Moves around functions and things from CWallet into LegacyScriptPubKeyMan so that they are actually separate things without circular dependencies.
***
Introducing the `ScriptPubKeyMan` (short for ScriptPubKeyManager) for managing scriptPubKeys and their associated scripts and keys. This functionality is moved over from `CWallet`. Instead, `CWallet` will have a pointer to a `ScriptPubKeyMan` for every possible address type, internal and external. It will fetch the correct `ScriptPubKeyMan` as necessary. When fetching new addresses, it chooses the `ScriptPubKeyMan` based on address type and whether it is change. For signing, it takes the script and asks each `ScriptPubKeyMan` for whether that `ScriptPubKeyMan` considers that script `IsMine`, whether it has that script, or whether it is able to produce a signature for it. If so, the `ScriptPubKeyMan` will provide a `SigningProvider` to the caller which will use that in order to sign.
There is currently one `ScriptPubKeyMan` - the `LegacyScriptPubKeyMan`. Each `CWallet` will have only one `LegacyScriptPubKeyMan` with the pointers for all of the address types and change pointing to this `LegacyScriptPubKeyMan`. It is created when the wallet is loaded and all keys and metadata are loaded into it instead of `CWallet`. The `LegacyScriptPubKeyMan` is primarily made up of all of the key and script management that used to be in `CWallet`. For convenience, `CWallet` has a `GetLegacyScriptPubKeyMan` which will return the `LegacyScriptPubKeyMan` or a `nullptr` if it does not have one (not yet implemented, but callers will check for the `nullptr`). For purposes of signing, `LegacyScriptPubKeyMan`'s `GetSigningProvider` will return itself rather than a separate `SigningProvider`. This will be different for future `ScriptPubKeyMan`s.
The `LegacyScriptPubKeyMan` will also handle the importing and exporting of keys and scripts instead of `CWallet`. As such, a number of RPCs have been limited to work only if a `LegacyScriptPubKeyMan` can be retrieved from the wallet. These RPCs are `sethdseed`, `addmultisigaddress`, `importaddress`, `importprivkey`, `importpubkey`, `importmulti`, `dumpprivkey`, and `dumpwallet`. Other RPCs which relied on the wallet for scripts and keys have been modified in order to take the `SigningProvider` retrieved from the `ScriptPubKeyMan` for a given script.
Overall, these changes should not effect how everything actually works and the user should experience no difference between having this change and not having it. As such, no functional tests were changed, and the only unit tests changed were those that were directly accessing `CWallet` functions that have been removed.
This PR is the last step in the [Wallet Structure Changes](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/Wallet-Class-Structure-Changes).
ACKs for top commit:
instagibbs:
re-utACK
|
||
|---|---|---|
| .. | ||
| android | ||
| forms | ||
| locale | ||
| res | ||
| test | ||
| addressbookpage.cpp | ||
| addressbookpage.h | ||
| addresstablemodel.cpp | ||
| addresstablemodel.h | ||
| appearancewidget.cpp | ||
| appearancewidget.h | ||
| askpassphrasedialog.cpp | ||
| askpassphrasedialog.h | ||
| bantablemodel.cpp | ||
| bantablemodel.h | ||
| bitcoin.cpp | ||
| bitcoin.h | ||
| bitcoinaddressvalidator.cpp | ||
| bitcoinaddressvalidator.h | ||
| bitcoinamountfield.cpp | ||
| bitcoinamountfield.h | ||
| bitcoingui.cpp | ||
| bitcoingui.h | ||
| bitcoinunits.cpp | ||
| bitcoinunits.h | ||
| clientmodel.cpp | ||
| clientmodel.h | ||
| coincontroldialog.cpp | ||
| coincontroldialog.h | ||
| coincontroltreewidget.cpp | ||
| coincontroltreewidget.h | ||
| createwalletdialog.cpp | ||
| createwalletdialog.h | ||
| csvmodelwriter.cpp | ||
| csvmodelwriter.h | ||
| dash_locale.qrc | ||
| dash.qrc | ||
| dashstrings.cpp | ||
| editaddressdialog.cpp | ||
| editaddressdialog.h | ||
| governancelist.cpp | ||
| governancelist.h | ||
| guiconstants.h | ||
| guiutil.cpp | ||
| guiutil.h | ||
| intro.cpp | ||
| intro.h | ||
| macdockiconhandler.h | ||
| macdockiconhandler.mm | ||
| macnotificationhandler.h | ||
| macnotificationhandler.mm | ||
| macos_appnap.h | ||
| macos_appnap.mm | ||
| main.cpp | ||
| masternodelist.cpp | ||
| masternodelist.h | ||
| modaloverlay.cpp | ||
| modaloverlay.h | ||
| networkstyle.cpp | ||
| networkstyle.h | ||
| notificator.cpp | ||
| notificator.h | ||
| openuridialog.cpp | ||
| openuridialog.h | ||
| optionsdialog.cpp | ||
| optionsdialog.h | ||
| optionsmodel.cpp | ||
| optionsmodel.h | ||
| overviewpage.cpp | ||
| overviewpage.h | ||
| paymentserver.cpp | ||
| paymentserver.h | ||
| peertablemodel.cpp | ||
| peertablemodel.h | ||
| qrdialog.cpp | ||
| qrdialog.h | ||
| qrimagewidget.cpp | ||
| qrimagewidget.h | ||
| qvalidatedlineedit.cpp | ||
| qvalidatedlineedit.h | ||
| qvaluecombobox.cpp | ||
| qvaluecombobox.h | ||
| README.md | ||
| receivecoinsdialog.cpp | ||
| receivecoinsdialog.h | ||
| receiverequestdialog.cpp | ||
| receiverequestdialog.h | ||
| recentrequeststablemodel.cpp | ||
| recentrequeststablemodel.h | ||
| rpcconsole.cpp | ||
| rpcconsole.h | ||
| sendcoinsdialog.cpp | ||
| sendcoinsdialog.h | ||
| sendcoinsentry.cpp | ||
| sendcoinsentry.h | ||
| signverifymessagedialog.cpp | ||
| signverifymessagedialog.h | ||
| splashscreen.cpp | ||
| splashscreen.h | ||
| trafficgraphdata.cpp | ||
| trafficgraphdata.h | ||
| trafficgraphwidget.cpp | ||
| trafficgraphwidget.h | ||
| transactiondesc.cpp | ||
| transactiondesc.h | ||
| transactiondescdialog.cpp | ||
| transactiondescdialog.h | ||
| transactionfilterproxy.cpp | ||
| transactionfilterproxy.h | ||
| transactionrecord.cpp | ||
| transactionrecord.h | ||
| transactiontablemodel.cpp | ||
| transactiontablemodel.h | ||
| transactionview.cpp | ||
| transactionview.h | ||
| utilitydialog.cpp | ||
| utilitydialog.h | ||
| walletcontroller.cpp | ||
| walletcontroller.h | ||
| walletframe.cpp | ||
| walletframe.h | ||
| walletmodel.cpp | ||
| walletmodel.h | ||
| walletmodeltransaction.cpp | ||
| walletmodeltransaction.h | ||
| walletview.cpp | ||
| walletview.h | ||
| winshutdownmonitor.cpp | ||
| winshutdownmonitor.h | ||
This directory contains the DashQT graphical user interface (GUI). It uses the cross-platform framework Qt.
The current precise version for Qt 5 is specified in qt.mk. Qt 4 is not supported.
Compile and run
See build instructions (macOS, Windows, Unix, etc).
To run:
./src/qt/dash-qt
Files and directories
forms
Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.
locale
Contains translations. They are periodically updated. The process is described here.
res
Resources such as the icon.
test
Tests.
bitcoingui.(h/cpp)
Represents the main window of the Dash UI.
*model.(h/cpp)
The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.
ClientModel is used by the main application bitcoingui and several models like peertablemodel.
*page.(h/cpp)
A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.
*dialog.(h/cpp)
Various dialogs, e.g. to open a URL. Inherit from QDialog.
paymentserver.(h/cpp)
Used to process BIP21 payment URI requests. Also handles URI based application switching (e.g. when following a dash:... link from a browser).
walletview.(h/cpp)
Represents the view to a single wallet.
Other .h/cpp files
- UI elements like BitcoinAmountField, which inherit from QWidget.
bitcoinstrings.cpp: automatically generatedbitcoinunits.(h/cpp): BTC / mBTC / etc handlingcallback.hguiconstants.h: UI colors, app name, etcguiutil.h: several helper functionsmacdockiconhandler.(h/mm): macOS dock icon handlermacnotificationhandler.(h/mm): display notifications in macOS
Contribute
See CONTRIBUTING.md for general guidelines. Specifically for Qt:
- don't change
local/dash_en.ts; this happens automatically
Using Qt Creator as IDE
You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.
Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.
Instructions for macOS:
- Make sure you installed everything through Homebrew mentioned in the macOS build instructions
- Use
./configurewith the--enable-debugflag - In Qt Creator do "New Project" -> Import Project -> Import Existing Project
- Enter "dash-qt" as project name, enter src/qt as location
- Leave the file selection as it is
- Confirm the "summary page"
- In the "Projects" tab select "Manage Kits..."
- Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
- Select LLDB as debugger (you might need to set the path to your installation)
- Start debugging with Qt Creator (you might need to the executable to "dash-qt" under "Run", which is where you can also add command line arguments)