mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
6dbc9aba0d
5ac804a9eb0cdbdcff8b50ecfb736f8793cab805 tests: Use a default of supports_cli=True (instead of supports_cli=False) (practicalswift)
993e38a4e2fa66093314b988dfbe459f46aa5864 tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such (practicalswift)
Pull request description:
Annotate functional tests supporting `bitcoin-cli` (`--usecli`) as such.
Prior to this commit 74 tests were unnecessarily skipped when running `test_runner.py --usecli`.
Before [bitcoin original commit stats]:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
9 ✓ Passed
126 ○ Skipped
```
After [dash numbers]:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
110 ✓ Passed
51 ○ Skipped
```
Context: `--usecli` was introduced in f6ade9ce1a
ACKs for top commit:
laanwj:
Code review ACK 5ac804a9eb0cdbdcff8b50ecfb736f8793cab805
Tree-SHA512: 249c0b691a74cf201c729df86c3db2b3faefa53b94703941e566943d252c6d14924e935a8da4f592951574235923fbb7cd22612a5e7e02ff6c762c55a2320ca3
110 lines
4.8 KiB
Python
Executable File
110 lines
4.8 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the RPC HTTP basics."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, str_to_b64str
|
|
|
|
import http.client
|
|
import urllib.parse
|
|
|
|
class HTTPBasicsTest (BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 3
|
|
self.supports_cli = False
|
|
|
|
def setup_network(self):
|
|
self.setup_nodes()
|
|
|
|
def run_test(self):
|
|
|
|
#################################################
|
|
# lowlevel check for http persistent connection #
|
|
#################################################
|
|
url = urllib.parse.urlparse(self.nodes[0].url)
|
|
authpair = url.username + ':' + url.password
|
|
headers = {"Authorization": "Basic " + str_to_b64str(authpair)}
|
|
|
|
conn = http.client.HTTPConnection(url.hostname, url.port)
|
|
conn.connect()
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
|
out1 = conn.getresponse().read()
|
|
assert b'"error":null' in out1
|
|
assert conn.sock is not None #according to http/1.1 connection must still be open!
|
|
|
|
#send 2nd request without closing connection
|
|
conn.request('POST', '/', '{"method": "getchaintips"}', headers)
|
|
out1 = conn.getresponse().read()
|
|
assert b'"error":null' in out1 #must also response with a correct json-rpc message
|
|
assert conn.sock is not None #according to http/1.1 connection must still be open!
|
|
conn.close()
|
|
|
|
#same should be if we add keep-alive because this should be the std. behaviour
|
|
headers = {"Authorization": "Basic " + str_to_b64str(authpair), "Connection": "keep-alive"}
|
|
|
|
conn = http.client.HTTPConnection(url.hostname, url.port)
|
|
conn.connect()
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
|
out1 = conn.getresponse().read()
|
|
assert b'"error":null' in out1
|
|
assert conn.sock is not None #according to http/1.1 connection must still be open!
|
|
|
|
#send 2nd request without closing connection
|
|
conn.request('POST', '/', '{"method": "getchaintips"}', headers)
|
|
out1 = conn.getresponse().read()
|
|
assert b'"error":null' in out1 #must also response with a correct json-rpc message
|
|
assert conn.sock is not None #according to http/1.1 connection must still be open!
|
|
conn.close()
|
|
|
|
#now do the same with "Connection: close"
|
|
headers = {"Authorization": "Basic " + str_to_b64str(authpair), "Connection":"close"}
|
|
|
|
conn = http.client.HTTPConnection(url.hostname, url.port)
|
|
conn.connect()
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
|
out1 = conn.getresponse().read()
|
|
assert b'"error":null' in out1
|
|
assert conn.sock is None #now the connection must be closed after the response
|
|
|
|
#node1 (2nd node) is running with disabled keep-alive option
|
|
urlNode1 = urllib.parse.urlparse(self.nodes[1].url)
|
|
authpair = urlNode1.username + ':' + urlNode1.password
|
|
headers = {"Authorization": "Basic " + str_to_b64str(authpair)}
|
|
|
|
conn = http.client.HTTPConnection(urlNode1.hostname, urlNode1.port)
|
|
conn.connect()
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
|
out1 = conn.getresponse().read()
|
|
assert b'"error":null' in out1
|
|
|
|
#node2 (third node) is running with standard keep-alive parameters which means keep-alive is on
|
|
urlNode2 = urllib.parse.urlparse(self.nodes[2].url)
|
|
authpair = urlNode2.username + ':' + urlNode2.password
|
|
headers = {"Authorization": "Basic " + str_to_b64str(authpair)}
|
|
|
|
conn = http.client.HTTPConnection(urlNode2.hostname, urlNode2.port)
|
|
conn.connect()
|
|
conn.request('POST', '/', '{"method": "getbestblockhash"}', headers)
|
|
out1 = conn.getresponse().read()
|
|
assert b'"error":null' in out1
|
|
assert conn.sock is not None #connection must be closed because dashd should use keep-alive by default
|
|
|
|
# Check excessive request size
|
|
conn = http.client.HTTPConnection(urlNode2.hostname, urlNode2.port)
|
|
conn.connect()
|
|
conn.request('GET', '/' + ('x'*1000), '', headers)
|
|
out1 = conn.getresponse()
|
|
assert_equal(out1.status, http.client.NOT_FOUND)
|
|
|
|
conn = http.client.HTTPConnection(urlNode2.hostname, urlNode2.port)
|
|
conn.connect()
|
|
conn.request('GET', '/' + ('x'*10000), '', headers)
|
|
out1 = conn.getresponse()
|
|
assert_equal(out1.status, http.client.BAD_REQUEST)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
HTTPBasicsTest ().main ()
|