dash/src/test
MarcoFalke efea72890c
Merge #11623: tests: Add missing locks to tests
109a85899 tests: Add missing locks to tests (practicalswift)

Pull request description:

  Add missing locks to tests to satisfy lock requirements (such as `EXCLUSIVE_LOCKS_REQUIRED(...)` (Clang Thread Safety Analysis, see #11226), `AssertLockHeld(...)` and implicit lock assumptions).

Tree-SHA512: 1aaeb1da89df1779f02fcceff9d2f8ea24a3926d421f9ea305a19be04dd0b3e63d91f6c1ed22fb7e6988343f6a5288829a387ef872cfa7b6add57bd01046b5d9
Signed-off-by: Pasta <pasta@dashboost.org>

# Conflicts:
#	src/test/test_bitcoin.cpp
2020-01-22 09:24:25 -06:00
..
data Merge #10679: Document the non-DER-conformance of one test in tx_valid.json. 2020-01-01 22:31:14 -06:00
addrman_tests.cpp Merge #11112: [developer-notes] By default, declare single-argument constructors "explicit" 2020-01-01 22:31:14 -06:00
allocator_tests.cpp Merge #10631: Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class 2019-07-17 10:05:12 -05:00
amount_tests.cpp Merge #9279: Consensus: Move CFeeRate out of libconsensus 2019-06-26 15:26:07 -05:00
arith_uint256_tests.cpp Merge #10633: doc: Fix various typos 2019-07-11 10:34:46 -05:00
base32_tests.cpp
base58_tests.cpp Merge #11117: Prepare for non-Base58 addresses (#3294) 2020-01-22 13:35:04 +03:00
base64_tests.cpp
bip32_tests.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
bip39_tests.cpp Bump copyright year to 2020 (#3290) 2020-01-17 15:42:55 +01:00
blockencodings_tests.cpp Merge #11623: tests: Add missing locks to tests 2020-01-22 09:24:25 -06:00
bloom_tests.cpp Merge #10793: Changing &var[0] to var.data() 2020-01-10 10:33:54 -06:00
bls_tests.cpp CBLSWrapper::SetHexStr() should not accept non-hex strings (#2843) 2019-04-08 08:07:26 +03:00
bswap_tests.cpp
cachemap_tests.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
cachemultimap_tests.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
checkqueue_tests.cpp Merge #10099: Slightly Improve Unit Tests for Checkqueue 2020-01-16 09:21:05 -06:00
coins_tests.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
compress_tests.cpp
crypto_tests.cpp Merge #10793: Changing &var[0] to var.data() 2020-01-10 10:33:54 -06:00
cuckoocache_tests.cpp Merge #10546: Remove 33 unused Boost includes 2019-07-08 13:50:05 -05:00
dbwrapper_tests.cpp Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
DoS_tests.cpp Merge #11623: tests: Add missing locks to tests 2020-01-22 09:24:25 -06:00
evo_deterministicmns_tests.cpp Merge #11117: Prepare for non-Base58 addresses (#3294) 2020-01-22 13:35:04 +03:00
evo_simplifiedmns_tests.cpp Bump copyright year to 2020 (#3290) 2020-01-17 15:42:55 +01:00
getarg_tests.cpp Merge #10793: Changing &var[0] to var.data() 2020-01-10 10:33:54 -06:00
governance_validators_tests.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
hash_tests.cpp Merge #10321: Use FastRandomContext for all tests 2019-07-08 10:24:27 -05:00
key_tests.cpp Merge #11117: Prepare for non-Base58 addresses (#3294) 2020-01-22 13:35:04 +03:00
limitedmap_tests.cpp Collection of minor performance optimizations (#2855) 2019-04-11 15:42:14 +03:00
main_tests.cpp
Makefile
mempool_tests.cpp Merge #11623: tests: Add missing locks to tests 2020-01-22 09:24:25 -06:00
merkle_tests.cpp Merge #13191: Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 2019-10-01 23:20:06 +02:00
miner_tests.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
multisig_tests.cpp Merge #11116: [script] Unit tests for script/standard and IsMine functions. 2019-09-24 17:47:35 +02:00
net_tests.cpp Merge #10478: rpc: Add listen address to incoming connections in getpeerinfo 2019-06-26 12:44:45 -05:00
netbase_tests.cpp Merge #10812: [utils] Allow bitcoin-cli's -rpcconnect option to be used with square brackets 2019-07-17 19:01:41 -05:00
pmt_tests.cpp Merge #10545: Use list initialization (C++11) for maps/vectors instead of boost::assign::map_list_of/list_of 2019-07-08 10:24:30 -05:00
policyestimator_tests.cpp Merge #10706: Improve wallet fee logic and fix GUI bugs 2019-09-03 22:40:26 -05:00
pow_tests.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
prevector_tests.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
raii_event_tests.cpp #10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL 2019-08-12 09:07:03 -05:00
random_tests.cpp Merge #10321: Use FastRandomContext for all tests 2019-07-08 10:24:27 -05:00
ratecheck_tests.cpp Update copyright date (2019) (#2970) 2019-06-11 14:46:07 +03:00
README.md Merge #11219: [docs] explain how to recompile a modified unit test 2020-01-01 22:31:14 -06:00
reverselock_tests.cpp
rpc_tests.cpp Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
sanity_tests.cpp
scheduler_tests.cpp Merge #10547: [tests] Use FastRandomContext instead of boost::random::{mt19937,uniform_int_distribution} 2019-07-08 10:24:29 -05:00
script_P2PK_tests.cpp
script_P2PKH_tests.cpp
script_P2SH_tests.cpp BIP143: Signing logic 2019-09-20 11:09:59 +02:00
script_standard_tests.cpp Remove more SegWit related tests from script_standard_tests.cpp 2019-09-27 09:59:55 +02:00
script_tests.cpp Merge #9964: Add const to methods that do not modify the object for which it is called 2020-01-02 16:16:55 -06:00
scriptnum10.h
scriptnum_tests.cpp Merge #10777: [tests] Avoid redundant assignments. Remove unused variables 2020-01-02 22:01:29 -06:00
serialize_tests.cpp
sighash_tests.cpp Merge #10777: [tests] Avoid redundant assignments. Remove unused variables 2020-01-02 22:01:29 -06:00
sigopcount_tests.cpp Merge bitcoin#8329: Consensus: MOVEONLY: Move functions for tx verification (#3030) 2019-07-23 12:20:23 +03:00
skiplist_tests.cpp Merge #10793: Changing &var[0] to var.data() 2020-01-10 10:33:54 -06:00
streams_tests.cpp Merge #10546: Remove 33 unused Boost includes 2019-07-08 13:50:05 -05:00
subsidy_tests.cpp Merge #8855: Use a proper factory for creating chainparams 2019-06-26 12:45:10 -05:00
test_bitcoin.cpp Merge #11623: tests: Add missing locks to tests 2020-01-22 09:24:25 -06:00
test_dash_fuzzy.cpp Merge #10409: [tests] Add fuzz testing for BlockTransactions and BlockTransactionsRequest 2020-01-22 09:11:34 -06:00
test_dash_main.cpp Merge #10843: Add attribute [[noreturn]] (C++11) to functions that will not return 2020-01-03 08:35:55 -06:00
test_dash.cpp Merge #11560: Connect to a new outbound peer if our tip is stale 2019-09-29 12:42:14 +02:00
test_dash.h Merge #10969: Declare single-argument (non-converting) constructors "explicit" 2020-01-10 10:33:57 -06:00
timedata_tests.cpp
torcontrol_tests.cpp change include 2019-06-24 11:39:34 -05:00
transaction_tests.cpp Refactor script validation to observe amounts 2019-09-19 21:04:36 +02:00
txvalidationcache_tests.cpp Merge #11623: tests: Add missing locks to tests 2020-01-22 09:24:25 -06:00
uint256_tests.cpp
univalue_tests.cpp Add univalue test for real numbers (#2460) 2018-11-22 06:09:58 +01:00
util_tests.cpp Merge #10357: Allow setting nMinimumChainWork on command line 2019-09-29 12:42:14 +02:00
versionbits_tests.cpp Merge #11160: Improve versionbits_computeblockversion test code consistency 2020-01-01 22:31:14 -06:00

Compiling/running unit tests

Unit tests will be automatically compiled if dependencies were met in ./configure and tests weren't explicitly disabled.

After configuring, they can be run with make check.

To run the dashd tests manually, launch src/test/test_dash. To recompile after a test file was modified, run make and then run the test again. If you modify a non-test file, use make -C src/test to recompile only what's needed to run the dashd tests.

To add more dashd tests, add BOOST_AUTO_TEST_CASE functions to the existing .cpp files in the test/ directory or add new .cpp files that implement new BOOST_AUTO_TEST_SUITE sections.

To run the dash-qt tests manually, launch src/qt/test/test_dash-qt

To add more dash-qt tests, add them to the src/qt/test/ directory and the src/qt/test/test_main.cpp file.

Running individual tests

test_dash has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:

test_dash --log_level=all --run_test=getarg_tests

... or to run just the doubledash test:

test_dash --run_test=getarg_tests/doubledash

Run test_dash --help for the full list.

Note on adding test cases

The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Dash Core already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).

The build system is setup to compile an executable called test_dash that runs all of the unit tests. The main source file is called test_dash.cpp. To add a new unit test file to our test suite you need to add the file to src/Makefile.test.include. The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is <source_filename>_tests.cpp and such files should wrap their tests in a test suite called <source_filename>_tests. For an example of this pattern, examine uint256_tests.cpp.

For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/.