sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-29 13:59:06 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
f0b42caef9
dash/src/evo
History
Hennadii Stepanov 91e6817a18
Merge #17785: p2p: Unify Send and Receive protocol versions 
ddefb5c0b759950942ac03f28c43b548af7b4033 p2p: Use the greatest common version in peer logic (Hennadii Stepanov)
e084d45562b94827b3a7873895882fcaae9f4d48 p2p: Remove SetCommonVersion() from VERACK handler (Hennadii Stepanov)
8d2026796a6f7add0c2cda9806e759817d1eae6f refactor: Rename local variable nSendVersion (Hennadii Stepanov)
e9a6d8b13b0558b17cdafbd32fd2663b4138ff11 p2p: Unify Send and Receive protocol versions (Hennadii Stepanov)

Pull request description:

  On master (6fef85bfa3cd7f76e83b8b57f9e4acd63eb664ec) `CNode` has two members to keep protocol version:
  - `nRecvVersion` for received messages
  - `nSendVersion` for messages to send

  After exchanging with `VERSION` and `VERACK` messages via protocol version `INIT_PROTO_VERSION`, both nodes set `nRecvVersion` _and_ `nSendVersion` to _the same_ value which is the greatest common protocol version.

  This PR:
  - replaces two `CNode` members, `nRecvVersion` `nSendVersion`, with `m_greatest_common_version`
  - removes duplicated getter and setter

  There is no change in behavior on the P2P network.

ACKs for top commit:
  jnewbery:
    ACK ddefb5c0b759950942ac03f28c43b548af7b4033
  naumenkogs:
    ACK ddefb5c0b759950942ac03f28c43b548af7b4033
  fjahr:
    Code review ACK ddefb5c0b759950942ac03f28c43b548af7b4033
  amitiuttarwar:
    code review but untested ACK ddefb5c0b7
  benthecarman:
    utACK `ddefb5c`

Tree-SHA512: 5305538dbaa5426b923b0afd20bdef4f248d310855d1d78427210c00716c67b7cb691515c421716b6157913e453076e293b10ff5fd2cd26a8e5375d42da7809d
2024-01-27 22:55:28 -06:00
..
assetlocktx.cpp refactor: split llmq/utils to Quorum Calculation and llmq/options (#5790) 2024-01-17 19:56:41 -06:00
assetlocktx.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
cbtx.cpp refactor: split llmq/utils to Quorum Calculation and llmq/options (#5790) 2024-01-17 19:56:41 -06:00
cbtx.h refactor: trivial fixes for dead, useless code and minor fixes for dash specific code (#5793) 2024-01-01 21:21:51 -06:00
creditpool.cpp refactor: make GetTxPayload return an Optional T instead of taking in a T& return (#5733) 2024-01-11 21:43:01 -06:00
creditpool.h refactor: drop dependency creditpool on llmq/utils 2023-12-21 23:02:31 -06:00
deterministicmns.cpp refactor: split llmq/utils to Quorum Calculation and llmq/options (#5790) 2024-01-17 19:56:41 -06:00
deterministicmns.h refactor: move out helper IsDIP3Enforced from deterministicmns 2023-12-21 23:02:31 -06:00
dmn_types.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
dmnstate.cpp refactor: make all ToJson functions return a UniValue instead of return by reference; add nodiscard (#5592) 2023-09-29 12:56:52 -05:00
dmnstate.h refactor: make all ToJson functions return a UniValue instead of return by reference; add nodiscard (#5592) 2023-09-29 12:56:52 -05:00
evodb.cpp refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
evodb.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
mnauth.cpp Merge #17785: p2p: Unify Send and Receive protocol versions 2024-01-27 22:55:28 -06:00
mnauth.h refactor: evo/mnauth no more depends on net_processing 2024-01-10 15:12:07 -06:00
mnhftx.cpp refactor: split llmq/utils to Quorum Calculation and llmq/options (#5790) 2024-01-17 19:56:41 -06:00
mnhftx.h fix: assertion in CMNHFManager due to missing data in evoDB (#5736) 2023-12-01 12:59:27 -06:00
providertx.cpp refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
providertx.h refactor: re-order headers and forward declarations to improve compile time (#5693) 2023-11-17 10:04:18 -06:00
simplifiedmns.cpp refactor: make GetTxPayload return an Optional T instead of taking in a T& return (#5733) 2024-01-11 21:43:01 -06:00
simplifiedmns.h refactor: use emplace_back in simplifiedmns constructors 2023-11-18 02:43:47 +07:00
specialtx.cpp fix: pass correct params into CHashWriter 2023-06-12 10:56:10 +03:00
specialtx.h refactor: make GetTxPayload return an Optional T instead of taking in a T& return (#5733) 2024-01-11 21:43:01 -06:00
specialtxman.cpp refactor: make GetTxPayload return an Optional T instead of taking in a T& return (#5733) 2024-01-11 21:43:01 -06:00
specialtxman.h fix: should not notify about mnlist changes while ConnectBlock isn't done yet (#5711) 2023-11-16 12:36:46 -06:00