sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 20:12:57 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
Dash - Reinventing Cryptocurrency
16,515 Commits 24 Branches 554 Tags 573 MiB
C++ 52.7%
C 24.2%
Python 10.5%
Assembly 3.3%
JavaScript 2.6%
Other 6.5%
f393729498
Go to file
Wladimir J. van der Laan f393729498
Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block 
876e92b Testing: listsinceblock should display all transactions that were affected since the given block, including transactions that were removed due to a reorg. (Karl-Johan Alm)
f999c46 listsinceblock: optionally find and list any transactions that were undone due to reorg when requesting a non-main chain block in a new 'removed' array. (Karl-Johan Alm)

Pull request description:

  The following scenario will not notify the caller of the fact `tx0` has been dropped:

  1. User 1 receives BTC in tx0 from utxo1 in block aa1.
  2. User 2 receives BTC in tx1 from utxo1 (same) in block bb1
  3. User 1 sees 2 confirmations at block aa3.
  4. Reorg into bb chain.
  5. User 1 asks `listsinceblock aa3` and does not see that tx0 is now invalidated.

  See `listsinceblock.py` commit for related test.

  The proposed fix is to iterate from the given block down to the fork point, and to check each transaction in the blocks against the wallet, in addition to including all transactions from the fork point to the active chain tip (the current behavior). Any transactions that were present will now also be listed in the `listsinceblock` output in a new `replaced` array. This operation may be a bit heavy but the circumstances (and perceived frequency of occurrence) warrant it, I believe.

  Example output:
  ```Python
  {
    'transactions': [],
    'replaced': [
      {
        'walletconflicts': [],
        'vout': 1,
        'account': '',
        'timereceived': 1485234857,
        'time': 1485234857,
        'amount': '1.00000000',
        'bip125-replaceable': 'unknown',
        'trusted': False,
        'category': 'receive',
        'txid': 'ce673859a30dee1d2ebdb3c05f2eea7b1da54baf68f93bb8bfe37c5f09ed22ff',
        'address': 'miqEt4kWp9zSizwGGuUWLAmxEcTW9bFUnQ',
        'label': '',
        'confirmations': -7
      }
    ],
    'lastblock': '7a388f27d09e3699102a4ebf81597d974fc4c72093eeaa02adffbbf7527f6715'
  }
  ```

  I believe this addresses the comment by @luke-jr in https://github.com/bitcoin/bitcoin/pull/9516#issuecomment-274190081 but I could be wrong..

Tree-SHA512: 607b5dcaeccb9dc0d963d3de138c40490f3e923050b29821e6bd513d26beb587bddc748fbb194503fe618cfe34a6ed65d95e8d9c5764a882b6c5f976520cff35
2019-08-12 09:07:03 -05:00
.github
.tx
build-aux/m4 Merge #10803: Explicitly search for bdb5.3. 2019-07-24 11:59:09 -05:00
ci adjust build_src.sh 10189 2019-06-19 12:44:42 -05:00
contrib Merge #10148: Use non-atomic flushing with block replay 2019-08-01 14:57:28 -05:00
depends Merge #10628: [depends] expat 2.2.1 2019-07-11 10:34:46 -05:00
doc /s/BTC/DASH 2019-07-17 19:01:41 -05:00
docker
share Backport #12783: macOS: disable AppNap during sync (and mixing) (#3024) 2019-07-15 14:38:55 +03:00
src Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block 2019-08-12 09:07:03 -05:00
test Merge #9622: [rpc] listsinceblock should include lost transactions when parameter is a reorg'd block 2019-08-12 09:07:03 -05:00
.gitattributes
.gitignore Merge #10331: Share config between util and functional tests 2019-07-08 10:24:26 -05:00
.travis.yml Fix 2 common Travis failures which happen when Travis has network issues (#3003) 2019-07-02 06:41:10 +02:00
autogen.sh
CMakeLists.txt Enable stacktrace support in gitian builds (#3006) 2019-07-02 07:16:11 +03:00
configure.ac disable jni in builds 2019-08-01 14:48:40 -05:00
CONTRIBUTING.md
COPYING
INSTALL.md
Jenkinsfile
Jenkinsfile.gitian
libdashconsensus.pc.in
Makefile.am Merge #10565: [coverage] Remove subtrees and benchmarks from coverage report 2019-07-11 10:34:46 -05:00
README.md

README.md

Dash Core staging tree 0.14.1

master: Build Status develop: Build Status

https://www.dash.org

What is Dash?

Dash is an experimental digital currency that enables anonymous, instant payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The contribution workflow is described in CONTRIBUTING.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also follow the forum.