mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
f4cd20b115
4bea30169218e2f21e0c93a059966b41c8edd205 test: use P2PK-MiniWallet for feature_csv_activation.py (Sebastian Falbesoner) dc7eb64e83f5b8e63f12729d5f77b1c920b136e4 test: MiniWallet: add P2PK support (Sebastian Falbesoner) Pull request description: This PR adds support for creating and spending transactions with raw pubkey (P2PK) outputs to MiniWallet, [as suggested by MarcoFalke](https://github.com/bitcoin/bitcoin/pull/21900#discussion_r629524841). Using that mode in the test `feature_csv_activation.py`, all txs submitted to the mempool follow the standard policy, i.e. `-acceptnonstdtxn=1` can be removed. Possible follow-ups: * Improve MiniWallet constructor Interface; an enum-like parameter instead of two booleans would probably be better * Look at other tests that could benefit from P2PK (e.g. feature_cltv.py?) * Check vsize also for P2PK txs (vsize varies due to signature, i.e. a range has to be asserted) ACKs for top commit: laanwj: Code review ACK 4bea30169218e2f21e0c93a059966b41c8edd205 Tree-SHA512: 9b428e6b7cfde59a8c7955d5096cea88af1384a5f49723f00052e9884d819d952d20a5ab39bb02f9d8b6073769c44462aa265d84a33e33da33c2d21670c488a6
144 lines
6.0 KiB
Python
144 lines
6.0 KiB
Python
#!/usr/bin/env python3
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""A limited-functionality wallet, which may replace a real wallet in tests"""
|
|
|
|
from decimal import Decimal
|
|
from test_framework.address import ADDRESS_BCRT1_P2SH_OP_TRUE
|
|
from test_framework.key import ECKey
|
|
from typing import Optional
|
|
from test_framework.messages import (
|
|
COIN,
|
|
COutPoint,
|
|
CTransaction,
|
|
CTxIn,
|
|
CTxOut,
|
|
)
|
|
from test_framework.script import (
|
|
CScript,
|
|
SignatureHash,
|
|
OP_CHECKSIG,
|
|
OP_TRUE,
|
|
OP_NOP,
|
|
SIGHASH_ALL,
|
|
)
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
hex_str_to_bytes,
|
|
satoshi_round,
|
|
)
|
|
|
|
|
|
class MiniWallet:
|
|
def __init__(self, test_node, *, raw_script=False, use_p2pk=False):
|
|
self._test_node = test_node
|
|
self._utxos = []
|
|
self._priv_key = None
|
|
self._address = None
|
|
|
|
if raw_script:
|
|
self._scriptPubKey = bytes(CScript([OP_TRUE]))
|
|
elif use_p2pk:
|
|
# use simple deterministic private key (k=1)
|
|
self._priv_key = ECKey()
|
|
self._priv_key.set((1).to_bytes(32, 'big'), True)
|
|
pub_key = self._priv_key.get_pubkey()
|
|
self._scriptPubKey = bytes(CScript([pub_key.get_bytes(), OP_CHECKSIG]))
|
|
else:
|
|
self._address = ADDRESS_BCRT1_P2SH_OP_TRUE
|
|
self._scriptPubKey = hex_str_to_bytes(self._test_node.validateaddress(self._address)['scriptPubKey'])
|
|
|
|
def scan_blocks(self, *, start=1, num):
|
|
"""Scan the blocks for self._address outputs and add them to self._utxos"""
|
|
for i in range(start, start + num):
|
|
block = self._test_node.getblock(blockhash=self._test_node.getblockhash(i), verbosity=2)
|
|
for tx in block['tx']:
|
|
self.scan_tx(tx)
|
|
|
|
def scan_tx(self, tx):
|
|
"""Scan the tx for self._scriptPubKey outputs and add them to self._utxos"""
|
|
for out in tx['vout']:
|
|
if out['scriptPubKey']['hex'] == self._scriptPubKey.hex():
|
|
self._utxos.append({'txid': tx['txid'], 'vout': out['n'], 'value': out['value']})
|
|
|
|
def sign_tx(self, tx):
|
|
"""Sign tx that has been created by MiniWallet in P2PK mode"""
|
|
assert self._priv_key is not None
|
|
(sighash, err) = SignatureHash(CScript(self._scriptPubKey), tx, 0, SIGHASH_ALL)
|
|
assert err is None
|
|
tx.vin[0].scriptSig = CScript([self._priv_key.sign_ecdsa(sighash) + bytes(bytearray([SIGHASH_ALL]))])
|
|
|
|
def generate(self, num_blocks):
|
|
"""Generate blocks with coinbase outputs to the internal address, and append the outputs to the internal list"""
|
|
blocks = self._test_node.generatetodescriptor(num_blocks, f'raw({self._scriptPubKey.hex()})')
|
|
for b in blocks:
|
|
cb_tx = self._test_node.getblock(blockhash=b, verbosity=2)['tx'][0]
|
|
self._utxos.append({'txid': cb_tx['txid'], 'vout': 0, 'value': cb_tx['vout'][0]['value']})
|
|
return blocks
|
|
|
|
def get_address(self):
|
|
return self._address
|
|
|
|
def get_utxo(self, *, txid: Optional[str]='', mark_as_spent=True):
|
|
"""
|
|
Returns a utxo and marks it as spent (pops it from the internal list)
|
|
|
|
Args:
|
|
txid: get the first utxo we find from a specific transaction
|
|
|
|
Note: Can be used to get the change output immediately after a send_self_transfer
|
|
"""
|
|
index = -1 # by default the last utxo
|
|
if txid:
|
|
utxo = next(filter(lambda utxo: txid == utxo['txid'], self._utxos))
|
|
index = self._utxos.index(utxo)
|
|
if mark_as_spent:
|
|
return self._utxos.pop(index)
|
|
else:
|
|
return self._utxos[index]
|
|
|
|
def send_self_transfer(self, *, fee_rate=Decimal("0.003"), from_node, utxo_to_spend=None):
|
|
"""Create and send a tx with the specified fee_rate. Fee may be exact or at most one satoshi higher than needed."""
|
|
tx = self.create_self_transfer(fee_rate=fee_rate, from_node=from_node, utxo_to_spend=utxo_to_spend)
|
|
self.sendrawtransaction(from_node=from_node, tx_hex=tx['hex'])
|
|
return tx
|
|
|
|
def create_self_transfer(self, *, fee_rate=Decimal("0.003"), from_node, utxo_to_spend=None, mempool_valid=True):
|
|
"""Create and return a tx with the specified fee_rate. Fee may be exact or at most one satoshi higher than needed."""
|
|
self._utxos = sorted(self._utxos, key=lambda k: k['value'])
|
|
utxo_to_spend = utxo_to_spend or self._utxos.pop() # Pick the largest utxo (if none provided) and hope it covers the fee
|
|
vsize = Decimal(85)
|
|
send_value = satoshi_round(utxo_to_spend['value'] - fee_rate * (vsize / 1000))
|
|
fee = utxo_to_spend['value'] - send_value
|
|
assert send_value > 0
|
|
|
|
tx = CTransaction()
|
|
tx.vin = [CTxIn(COutPoint(int(utxo_to_spend['txid'], 16), utxo_to_spend['vout']))]
|
|
tx.vout = [CTxOut(int(send_value * COIN), self._scriptPubKey)]
|
|
if not self._address:
|
|
# raw script
|
|
if self._priv_key is not None:
|
|
# P2PK, need to sign
|
|
self.sign_tx(tx)
|
|
else:
|
|
# anyone-can-spend
|
|
tx.vin[0].scriptSig = CScript([OP_NOP] * 24) # pad to identical size
|
|
else:
|
|
tx.vin[0].scriptSig = CScript([CScript([OP_TRUE])])
|
|
tx_hex = tx.serialize().hex()
|
|
|
|
tx_info = from_node.testmempoolaccept([tx_hex])[0]
|
|
assert_equal(mempool_valid, tx_info['allowed'])
|
|
if mempool_valid:
|
|
# TODO: for P2PK, vsize is not constant due to varying scriptSig length,
|
|
# so only check this for anyone-can-spend outputs right now
|
|
if self._priv_key is None:
|
|
assert_equal(len(tx_hex) // 2, vsize) # 1 byte = 2 character
|
|
assert_equal(tx_info['fees']['base'], fee)
|
|
return {'txid': tx_info['txid'], 'hex': tx_hex, 'tx': tx}
|
|
|
|
def sendrawtransaction(self, *, from_node, tx_hex):
|
|
from_node.sendrawtransaction(tx_hex)
|
|
self.scan_tx(from_node.decoderawtransaction(tx_hex))
|