mirror of
https://github.com/dashpay/dash.git
synced 2024-12-29 05:49:11 +01:00
f5857e5cb5
Instead of building a full copy of a CTransaction being signed, and then modifying bits and pieces until its fits the form necessary for computing the signature hash, use a wrapper serializer that only serializes the necessary bits on-the-fly. This makes it easier to see which data is actually being hash, reduces load on the heap, and also marginally improves performances (around 3-4us/sigcheck here). The performance improvements are much larger for large transactions, though. The old implementation of SignatureHash is moved to a unit tests, to test whether the old and new algorithm result in the same value for randomly-constructed transactions. |
||
|---|---|---|
| .. | ||
| data | ||
| accounting_tests.cpp | ||
| alert_tests.cpp | ||
| allocator_tests.cpp | ||
| base32_tests.cpp | ||
| base58_tests.cpp | ||
| base64_tests.cpp | ||
| bignum_tests.cpp | ||
| bip32_tests.cpp | ||
| bloom_tests.cpp | ||
| canonical_tests.cpp | ||
| checkblock_tests.cpp | ||
| Checkpoints_tests.cpp | ||
| compress_tests.cpp | ||
| DoS_tests.cpp | ||
| getarg_tests.cpp | ||
| hash_tests.cpp | ||
| hmac_tests.cpp | ||
| key_tests.cpp | ||
| Makefile.am | ||
| miner_tests.cpp | ||
| mruset_tests.cpp | ||
| multisig_tests.cpp | ||
| netbase_tests.cpp | ||
| pmt_tests.cpp | ||
| README | ||
| rpc_tests.cpp | ||
| script_P2SH_tests.cpp | ||
| script_tests.cpp | ||
| serialize_tests.cpp | ||
| sighash_tests.cpp | ||
| sigopcount_tests.cpp | ||
| test_bitcoin.cpp | ||
| transaction_tests.cpp | ||
| uint160_tests.cpp | ||
| uint256_tests.cpp | ||
| util_tests.cpp | ||
| wallet_tests.cpp | ||
The sources in this directory are unit test cases. Boost includes a unit testing framework, and since bitcoin already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible). The build system is setup to compile an executable called "test_bitcoin" that runs all of the unit tests. The main source file is called test_bitcoin.cpp, which simply includes other files that contain the actual unit tests (outside of a couple required preprocessor directives). The pattern is to create one test file for each class or source file for which you want to create unit tests. The file naming convention is "<source_filename>_tests.cpp" and such files should wrap their tests in a test suite called "<source_filename>_tests". For an examples of this pattern, examine uint160_tests.cpp and uint256_tests.cpp. For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/