mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 05:23:01 +01:00
f798da8e92
1a3a256d5e0443d19757c1f1fceb9c9ede17758a wallet: replace raw pointer with const reference in AddrToPubKey (Harris) Pull request description: This PR replaces a redundant reference-to-pointer conversion in **addmultisigaddress** from *wallet/rpcwallet.cpp*. It also makes the API from *rpc/util.h* look more straightforward as **AddrToPubKey** now uses const references like other functions from there. I am not sure why there is a ref-to-ptr conversion in addmultisignatures, so I can only speculate that this is because of "historical reasons". The ref-to-ptr conversion happens here: https://github.com/bitcoin/bitcoin/blob/master/src/wallet/rpcwallet.cpp#L1001 There, the address of LegacyScriptPubKeyMan& is given to AddrToPubKey. Later, in AddrToPubKey, it gets converted back to a reference, because GetKeyForDestination in rpc/util.cpp expects a const ref: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/util.cpp#L140 Regards, ACKs for top commit: achow101: ACK 1a3a256d5e0443d19757c1f1fceb9c9ede17758a meshcollider: utACK 1a3a256d5e0443d19757c1f1fceb9c9ede17758a promag: Code review ACK 1a3a256d5e0443d19757c1f1fceb9c9ede17758a. hebasto: ACK 1a3a256d5e0443d19757c1f1fceb9c9ede17758a, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged. Tree-SHA512: 1a2b8ddab5694ef4c65fac69f011e38dd03a634e84a35857e13bd05ad99fe42af22ee0af6230865e3d2c725693512f3336acb055ede19c958424283e7a3856c4 |
||
|---|---|---|
| .. | ||
| blockchain.cpp | ||
| blockchain.h | ||
| client.cpp | ||
| client.h | ||
| coinjoin.cpp | ||
| evo.cpp | ||
| governance.cpp | ||
| masternode.cpp | ||
| mining.cpp | ||
| mining.h | ||
| misc.cpp | ||
| net.cpp | ||
| protocol.h | ||
| quorums.cpp | ||
| rawtransaction_util.cpp | ||
| rawtransaction_util.h | ||
| rawtransaction.cpp | ||
| register.h | ||
| request.cpp | ||
| request.h | ||
| server.cpp | ||
| server.h | ||
| util.cpp | ||
| util.h | ||