mirror of
https://github.com/dashpay/dash.git
synced 2024-12-29 05:49:11 +01:00
f812de4e66
d2774c09cfcc6c5c967d40bb094eabc8c0bdb6bf Clear any input_errors for an input after it is signed (Andrew Chow)
dc174881ad8498a6905ba282a48077bc5c8037a7 Replace GetSigningProvider with GetSolvingProvider (Andrew Chow)
6a9c429084b40356aa36aa67992da35f61c2f6a2 Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan (Andrew Chow)
82a30fade70a2a95c2bbeac4aa06dafda600479d Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT (Andrew Chow)
3d70dd99f9f74eef70b19ff6f6f850adc0d5ef8f Move FillPSBT to be a member of CWallet (Andrew Chow)
a4af324d15c1ee43c2abd11a304ae18c7ee82eb0 Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwallet (Andrew Chow)
f37de927442d3f024926a66c436d59e391c8696a Implement CWallet::SignTransaction using ScriptPubKeyMan::SignTransaction (Andrew Chow)
d999dd588cab0ff479bc7bee8c9fc33880265ec6 Add SignTransaction function to ScriptPubKeyMan and LegacyScriptPubKeyMan (Andrew Chow)
2c52b59d0a44a86d94fee4e437978d822862c542 Refactor rawtransaction's SignTransaction into generic SignTransaction function (Andrew Chow)
Pull request description:
Following #17261, the way to sign transactions, PSBTs, and messages was to use `GetSigningProvider()` and get a `SigningProvider` containing the private keys. However this may not be feasible for future `ScriptPubKeyMan`s, such as for hardware wallets. Instead of exporting a `SigningProvider` containing private keys, we need to pass these things into the `ScriptPubKeyMan` (via `CWallet`) so that they can do whatever is needed internally to sign them. This is largely a refactor as the logic of processing transactions, PSBTs, and messages for is moved into `LegacyScriptPubKeyMan` and `CWallet` instead of being handled by the caller (e.g. `signrawtransaction`).
To help with this, I've refactored the 3(!) implementations of a `SignTransaction()` function into one generic one. This function will be called by `signrawtransactionwithkey` and `LegacyScriptPubKeyMan::SignTransaction()`. `CWallet::CreateTransaction()` is changed to call `CWallet::SignTransaction()` which in turn, calls `LegacyScriptPubKeyMan::SignTransaction()`. Other `ScriptPubKeyMan`s may implement `SignTransaction()` differently.
`FillPSBT()` is moved to be a member function of `CWallet` and the `psbtwallet.cpp/h` files removed. It is further split so that `CWallet` handles filling the UTXOs while the `ScriptPubKeyMan` handles adding keys, derivation paths, scripts, and signatures. In the end `LegacyScriptPubKeyMan::FillPSBT` still calls `SignPSBTInput`, but the `SigningProvider` is internal to `LegacyScriptPubKeyMan`. Other `ScriptPubKeyMan`s may do something different.
A new `SignMessage()` function is added to both `CWallet` and `ScriptPubKeyMan`. Instead of having the caller (i.e. `signmessage` or the sign message dialog) get the private key, hash the message, and sign, `ScriptPubKeyMan` will now handle that (`CWallet` passes through to the `ScriptPubKeyMan`s as it does for many functions). This signing code is thus consolidated into `LegacyScriptPubKeyMan::SignMessage()`, though other `ScriptPubKeyMan`s may implement it differently. Additionally, a `SigningError` enum is introduced for the different errors that we expect to see from `SignMessage()`.
Lastly, `GetSigningProvider()` is renamed to `GetPublicSigningProvider()`. It will now only provide pubkeys, key origins, and scripts. `LegacySigningProvider` has it's `GetKey` and `HaveKey` functions changed to only return false. Future implementations should return `HidingSigningProvider`s where private keys are hidden.
Other things like `dumpprivkey` and `dumpwallet` are not changed because they directly need and access the `LegacyScriptPubKeyMan` so are not relevant to future changes.
ACKs for top commit:
instagibbs:
reACK
|
||
|---|---|---|
| .. | ||
| android | ||
| forms | ||
| locale | ||
| res | ||
| test | ||
| addressbookpage.cpp | ||
| addressbookpage.h | ||
| addresstablemodel.cpp | ||
| addresstablemodel.h | ||
| appearancewidget.cpp | ||
| appearancewidget.h | ||
| askpassphrasedialog.cpp | ||
| askpassphrasedialog.h | ||
| bantablemodel.cpp | ||
| bantablemodel.h | ||
| bitcoin.cpp | ||
| bitcoin.h | ||
| bitcoinaddressvalidator.cpp | ||
| bitcoinaddressvalidator.h | ||
| bitcoinamountfield.cpp | ||
| bitcoinamountfield.h | ||
| bitcoingui.cpp | ||
| bitcoingui.h | ||
| bitcoinunits.cpp | ||
| bitcoinunits.h | ||
| clientmodel.cpp | ||
| clientmodel.h | ||
| coincontroldialog.cpp | ||
| coincontroldialog.h | ||
| coincontroltreewidget.cpp | ||
| coincontroltreewidget.h | ||
| createwalletdialog.cpp | ||
| createwalletdialog.h | ||
| csvmodelwriter.cpp | ||
| csvmodelwriter.h | ||
| dash_locale.qrc | ||
| dash.qrc | ||
| dashstrings.cpp | ||
| editaddressdialog.cpp | ||
| editaddressdialog.h | ||
| governancelist.cpp | ||
| governancelist.h | ||
| guiconstants.h | ||
| guiutil.cpp | ||
| guiutil.h | ||
| intro.cpp | ||
| intro.h | ||
| macdockiconhandler.h | ||
| macdockiconhandler.mm | ||
| macnotificationhandler.h | ||
| macnotificationhandler.mm | ||
| macos_appnap.h | ||
| macos_appnap.mm | ||
| main.cpp | ||
| masternodelist.cpp | ||
| masternodelist.h | ||
| modaloverlay.cpp | ||
| modaloverlay.h | ||
| networkstyle.cpp | ||
| networkstyle.h | ||
| notificator.cpp | ||
| notificator.h | ||
| openuridialog.cpp | ||
| openuridialog.h | ||
| optionsdialog.cpp | ||
| optionsdialog.h | ||
| optionsmodel.cpp | ||
| optionsmodel.h | ||
| overviewpage.cpp | ||
| overviewpage.h | ||
| paymentserver.cpp | ||
| paymentserver.h | ||
| peertablemodel.cpp | ||
| peertablemodel.h | ||
| qrdialog.cpp | ||
| qrdialog.h | ||
| qrimagewidget.cpp | ||
| qrimagewidget.h | ||
| qvalidatedlineedit.cpp | ||
| qvalidatedlineedit.h | ||
| qvaluecombobox.cpp | ||
| qvaluecombobox.h | ||
| README.md | ||
| receivecoinsdialog.cpp | ||
| receivecoinsdialog.h | ||
| receiverequestdialog.cpp | ||
| receiverequestdialog.h | ||
| recentrequeststablemodel.cpp | ||
| recentrequeststablemodel.h | ||
| rpcconsole.cpp | ||
| rpcconsole.h | ||
| sendcoinsdialog.cpp | ||
| sendcoinsdialog.h | ||
| sendcoinsentry.cpp | ||
| sendcoinsentry.h | ||
| signverifymessagedialog.cpp | ||
| signverifymessagedialog.h | ||
| splashscreen.cpp | ||
| splashscreen.h | ||
| trafficgraphdata.cpp | ||
| trafficgraphdata.h | ||
| trafficgraphwidget.cpp | ||
| trafficgraphwidget.h | ||
| transactiondesc.cpp | ||
| transactiondesc.h | ||
| transactiondescdialog.cpp | ||
| transactiondescdialog.h | ||
| transactionfilterproxy.cpp | ||
| transactionfilterproxy.h | ||
| transactionrecord.cpp | ||
| transactionrecord.h | ||
| transactiontablemodel.cpp | ||
| transactiontablemodel.h | ||
| transactionview.cpp | ||
| transactionview.h | ||
| utilitydialog.cpp | ||
| utilitydialog.h | ||
| walletcontroller.cpp | ||
| walletcontroller.h | ||
| walletframe.cpp | ||
| walletframe.h | ||
| walletmodel.cpp | ||
| walletmodel.h | ||
| walletmodeltransaction.cpp | ||
| walletmodeltransaction.h | ||
| walletview.cpp | ||
| walletview.h | ||
| winshutdownmonitor.cpp | ||
| winshutdownmonitor.h | ||
This directory contains the DashQT graphical user interface (GUI). It uses the cross-platform framework Qt.
The current precise version for Qt 5 is specified in qt.mk. Qt 4 is not supported.
Compile and run
See build instructions (macOS, Windows, Unix, etc).
To run:
./src/qt/dash-qt
Files and directories
forms
Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.
locale
Contains translations. They are periodically updated. The process is described here.
res
Resources such as the icon.
test
Tests.
bitcoingui.(h/cpp)
Represents the main window of the Dash UI.
*model.(h/cpp)
The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.
ClientModel is used by the main application bitcoingui and several models like peertablemodel.
*page.(h/cpp)
A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.
*dialog.(h/cpp)
Various dialogs, e.g. to open a URL. Inherit from QDialog.
paymentserver.(h/cpp)
Used to process BIP21 payment URI requests. Also handles URI based application switching (e.g. when following a dash:... link from a browser).
walletview.(h/cpp)
Represents the view to a single wallet.
Other .h/cpp files
- UI elements like BitcoinAmountField, which inherit from QWidget.
bitcoinstrings.cpp: automatically generatedbitcoinunits.(h/cpp): BTC / mBTC / etc handlingcallback.hguiconstants.h: UI colors, app name, etcguiutil.h: several helper functionsmacdockiconhandler.(h/mm): macOS dock icon handlermacnotificationhandler.(h/mm): display notifications in macOS
Contribute
See CONTRIBUTING.md for general guidelines. Specifically for Qt:
- don't change
local/dash_en.ts; this happens automatically
Using Qt Creator as IDE
You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.
Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.
Instructions for macOS:
- Make sure you installed everything through Homebrew mentioned in the macOS build instructions
- Use
./configurewith the--enable-debugflag - In Qt Creator do "New Project" -> Import Project -> Import Existing Project
- Enter "dash-qt" as project name, enter src/qt as location
- Leave the file selection as it is
- Confirm the "summary page"
- In the "Projects" tab select "Manage Kits..."
- Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
- Select LLDB as debugger (you might need to set the path to your installation)
- Start debugging with Qt Creator (you might need to the executable to "dash-qt" under "Run", which is where you can also add command line arguments)