mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
b07a7b810c
* Merge #11796: [tests] Functional test naming convention5fecd84
[tests] Remove redundant import in blocktools.py test (Anthony Towns)9b20bb4
[tests] Check tests conform to naming convention (Anthony Towns)7250b4e
[tests] README.md nit fixes (Anthony Towns)82b2712
[tests] move witness util functions to blocktools.py (John Newbery)1e10854
[tests] [docs] update README for new test naming scheme (John Newbery) Pull request description: Splitting #11774 into two parts -- this part updates the README with the proposed naming convention, and adds some checks to test_runner.py that the number of tests violating the naming convention doesn't increase too much. Idea is this part of the change should not introduce merge conflicts or require much rebasing, so reviews of the complicated bits won't become invalidated too often; while the second part will just be file renames, which will require regular rebasing and will introduce merge conflicts with pending PRs, but can be merged later, and should also be much easier to review, since it will only include relatively trivial changes. Tree-SHA512: b96557d41714addbbfe2aed62fb5a48639eaeb1eb3aba30ac1b3a86bb3cb8d796c6247f9c414c4695c4bf54c0ec9968ac88e2f88fb62483bc1a2f89368f7fc80 * update violation count Signed-off-by: pasta <pasta@dashboost.org> * Merge #11774: [tests] Rename functional tests6f881cc880
[tests] Remove EXPECTED_VIOLATION_COUNT (Anthony Towns)3150b3fea7
[tests] Rename misc functional tests. (Anthony Towns)81b79f2c39
[tests] Rename rpc_* functional tests. (Anthony Towns)61b8f7f273
[tests] Rename p2p_* functional tests. (Anthony Towns)90600bc7db
[tests] Rename wallet_* functional tests. (Anthony Towns)ca6523d0c8
[tests] Rename feature_* functional tests. (Anthony Towns) Pull request description: This PR changes the functional tests to have a consistent naming scheme: tests for individual RPC methods are named rpc_... tests for interfaces (REST, ZMQ, RPC features) are named interface_... tests that explicitly test the p2p interface are named p2p_... tests for wallet features are named wallet_... tests for mining features are named mining_... tests for mempool behaviour are named mempool_... tests for full features that aren't wallet/mining/mempool are named feature_... Rationale: it's sometimes difficult for new contributors to know what's already covered by existing tests and where new tests should be added. Naming in a consistent fashion makes it easier to see what's already covered at a glance. Tree-SHA512: 4246790552d42bbd95f6d5bdf67702b81b3b2c583ce7eaf1fe6d8e254721279b47315973c6e9ae82dad6e4c747f12188160764bf2624c0f8f3b4d39330ec8b16 * rename tests and edit associated strings to align test-suite with test name standards Signed-off-by: pasta <pasta@dashboost.org> * fix grammar in test/functional/test_runner.py Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * ci: Fix excluded test names * rename feature_privatesend.py to rpc_privatesend.py Signed-off-by: pasta <pasta@dashboost.org> Co-authored-by: Wladimir J. van der Laan <laanwj@gmail.com> Co-authored-by: MarcoFalke <falke.marco@gmail.com> Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: xdustinface <xdustinfacex@gmail.com>
209 lines
8.4 KiB
Python
Executable File
209 lines
8.4 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test account RPCs.
|
|
|
|
RPCs tested are:
|
|
- getaccountaddress
|
|
- getaddressesbyaccount
|
|
- listaddressgroupings
|
|
- setaccount
|
|
- sendfrom (with account arguments)
|
|
- move (with account arguments)
|
|
"""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
class WalletAccountsTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [["-paytxfee=0.0001"]]
|
|
|
|
def run_test(self):
|
|
node = self.nodes[0]
|
|
# Check that there's no UTXO on any of the nodes
|
|
assert_equal(len(node.listunspent()), 0)
|
|
|
|
# Note each time we call generate, all generated coins go into
|
|
# the same address, so we call twice to get two addresses w/500 each
|
|
node.generate(1)
|
|
node.generate(101)
|
|
assert_equal(node.getbalance(), 1000)
|
|
|
|
# there should be 2 address groups
|
|
# each with 1 address with a balance of 500 Dash
|
|
address_groups = node.listaddressgroupings()
|
|
assert_equal(len(address_groups), 2)
|
|
# the addresses aren't linked now, but will be after we send to the
|
|
# common address
|
|
linked_addresses = set()
|
|
for address_group in address_groups:
|
|
assert_equal(len(address_group), 1)
|
|
assert_equal(len(address_group[0]), 2)
|
|
assert_equal(address_group[0][1], 500)
|
|
linked_addresses.add(address_group[0][0])
|
|
|
|
# send 500 from each address to a third address not in this wallet
|
|
# There's some fee that will come back to us when the miner reward
|
|
# matures.
|
|
common_address = "yd5KMREs3GLMe6mTJYr3YrH1juwNwrFCfB"
|
|
txid = node.sendmany(
|
|
fromaccount="",
|
|
amounts={common_address: 1000},
|
|
minconf=1,
|
|
addlocked=False,
|
|
comment="",
|
|
subtractfeefrom=[common_address],
|
|
)
|
|
tx_details = node.gettransaction(txid)
|
|
fee = -tx_details['details'][0]['fee']
|
|
# there should be 1 address group, with the previously
|
|
# unlinked addresses now linked (they both have 0 balance)
|
|
address_groups = node.listaddressgroupings()
|
|
assert_equal(len(address_groups), 1)
|
|
assert_equal(len(address_groups[0]), 2)
|
|
assert_equal(set([a[0] for a in address_groups[0]]), linked_addresses)
|
|
assert_equal([a[1] for a in address_groups[0]], [0, 0])
|
|
|
|
node.generate(1)
|
|
|
|
# we want to reset so that the "" account has what's expected.
|
|
# otherwise we're off by exactly the fee amount as that's mined
|
|
# and matures in the next 100 blocks
|
|
node.sendfrom("", common_address, fee)
|
|
amount_to_send = 1.0
|
|
|
|
# Create accounts and make sure subsequent account API calls
|
|
# recognize the account/address associations.
|
|
accounts = [Account(name) for name in ("a", "b", "c", "d", "e")]
|
|
for account in accounts:
|
|
account.add_receive_address(node.getaccountaddress(account.name))
|
|
account.verify(node)
|
|
|
|
# Send a transaction to each account, and make sure this forces
|
|
# getaccountaddress to generate a new receiving address.
|
|
for account in accounts:
|
|
node.sendtoaddress(account.receive_address, amount_to_send)
|
|
account.add_receive_address(node.getaccountaddress(account.name))
|
|
account.verify(node)
|
|
|
|
# Check the amounts received.
|
|
node.generate(1)
|
|
for account in accounts:
|
|
assert_equal(
|
|
node.getreceivedbyaddress(account.addresses[0]), amount_to_send)
|
|
assert_equal(node.getreceivedbyaccount(account.name), amount_to_send)
|
|
|
|
# Check that sendfrom account reduces listaccounts balances.
|
|
for i, account in enumerate(accounts):
|
|
to_account = accounts[(i+1) % len(accounts)]
|
|
node.sendfrom(account.name, to_account.receive_address, amount_to_send)
|
|
node.generate(1)
|
|
for account in accounts:
|
|
account.add_receive_address(node.getaccountaddress(account.name))
|
|
account.verify(node)
|
|
assert_equal(node.getreceivedbyaccount(account.name), 2)
|
|
node.move(account.name, "", node.getbalance(account.name))
|
|
account.verify(node)
|
|
node.generate(101)
|
|
expected_account_balances = {"": 52000}
|
|
for account in accounts:
|
|
expected_account_balances[account.name] = 0
|
|
assert_equal(node.listaccounts(), expected_account_balances)
|
|
assert_equal(node.getbalance(""), 52000)
|
|
|
|
# Check that setaccount can assign an account to a new unused address.
|
|
for account in accounts:
|
|
address = node.getaccountaddress("")
|
|
node.setaccount(address, account.name)
|
|
account.add_address(address)
|
|
account.verify(node)
|
|
assert(address not in node.getaddressesbyaccount(""))
|
|
|
|
# Check that addmultisigaddress can assign accounts.
|
|
for account in accounts:
|
|
addresses = []
|
|
for x in range(10):
|
|
addresses.append(node.getnewaddress())
|
|
multisig_address = node.addmultisigaddress(5, addresses, account.name)['address']
|
|
account.add_address(multisig_address)
|
|
account.verify(node)
|
|
node.sendfrom("", multisig_address, 50)
|
|
node.generate(101)
|
|
for account in accounts:
|
|
assert_equal(node.getbalance(account.name), 50)
|
|
|
|
# Check that setaccount can change the account of an address from a
|
|
# different account.
|
|
change_account(node, accounts[0].addresses[0], accounts[0], accounts[1])
|
|
|
|
# Check that setaccount can change the account of an address which
|
|
# is the receiving address of a different account.
|
|
change_account(node, accounts[0].receive_address, accounts[0], accounts[1])
|
|
|
|
# Check that setaccount can set the account of an address already
|
|
# in the account. This is a no-op.
|
|
change_account(node, accounts[2].addresses[0], accounts[2], accounts[2])
|
|
|
|
# Check that setaccount can set the account of an address which is
|
|
# already the receiving address of the account. It would probably make
|
|
# sense for this to be a no-op, but right now it resets the receiving
|
|
# address, causing getaccountaddress to return a brand new address.
|
|
change_account(node, accounts[2].receive_address, accounts[2], accounts[2])
|
|
|
|
class Account:
|
|
def __init__(self, name):
|
|
# Account name
|
|
self.name = name
|
|
# Current receiving address associated with this account.
|
|
self.receive_address = None
|
|
# List of all addresses assigned with this account
|
|
self.addresses = []
|
|
|
|
def add_address(self, address):
|
|
assert_equal(address not in self.addresses, True)
|
|
self.addresses.append(address)
|
|
|
|
def add_receive_address(self, address):
|
|
self.add_address(address)
|
|
self.receive_address = address
|
|
|
|
def verify(self, node):
|
|
if self.receive_address is not None:
|
|
assert self.receive_address in self.addresses
|
|
assert_equal(node.getaccountaddress(self.name), self.receive_address)
|
|
|
|
for address in self.addresses:
|
|
assert_equal(node.getaccount(address), self.name)
|
|
|
|
assert_equal(
|
|
set(node.getaddressesbyaccount(self.name)), set(self.addresses))
|
|
|
|
|
|
def change_account(node, address, old_account, new_account):
|
|
assert_equal(address in old_account.addresses, True)
|
|
node.setaccount(address, new_account.name)
|
|
|
|
old_account.addresses.remove(address)
|
|
new_account.add_address(address)
|
|
|
|
# Calling setaccount on an address which was previously the receiving
|
|
# address of a different account should reset the receiving address of
|
|
# the old account, causing getaccountaddress to return a brand new
|
|
# address.
|
|
if address == old_account.receive_address:
|
|
new_address = node.getaccountaddress(old_account.name)
|
|
assert_equal(new_address not in old_account.addresses, True)
|
|
assert_equal(new_address not in new_account.addresses, True)
|
|
old_account.add_receive_address(new_address)
|
|
|
|
old_account.verify(node)
|
|
new_account.verify(node)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
WalletAccountsTest().main()
|