mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
11dd890928
6aaa0abc12 Remove manual byte editing in wallet_tx_clone func test (Gregory Sanders) Pull request description: Adapted from @stevenroose Tree-SHA512: 87f251579e347f870bd30fc57b0c130f00914a3dc78799826384eb049b91d49f2525d55899bf525997e23cc976ca7d10e6b56b23f7358acec307368d48a6f6f1
132 lines
5.7 KiB
Python
Executable File
132 lines
5.7 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the wallet accounts properly when there are cloned transactions with malleated scriptsigs."""
|
|
|
|
import io
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
connect_nodes,
|
|
disconnect_nodes,
|
|
)
|
|
from test_framework.messages import CTransaction, COIN
|
|
|
|
class TxnMallTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 4
|
|
|
|
def add_options(self, parser):
|
|
parser.add_argument("--mineblock", dest="mine_block", default=False, action="store_true",
|
|
help="Test double-spend of 1-confirmed transaction")
|
|
|
|
def setup_network(self):
|
|
# Start with split network:
|
|
super(TxnMallTest, self).setup_network()
|
|
disconnect_nodes(self.nodes[1], 2)
|
|
disconnect_nodes(self.nodes[2], 1)
|
|
|
|
def run_test(self):
|
|
# All nodes should start with 12,500 DASH:
|
|
starting_balance = 12500
|
|
for i in range(4):
|
|
assert_equal(self.nodes[i].getbalance(), starting_balance)
|
|
self.nodes[i].getnewaddress() # bug workaround, coins generated assigned to first getnewaddress!
|
|
|
|
self.nodes[0].settxfee(.001)
|
|
|
|
node0_address1 = self.nodes[0].getnewaddress()
|
|
node0_txid1 = self.nodes[0].sendtoaddress(node0_address1, 12190)
|
|
node0_tx1 = self.nodes[0].gettransaction(node0_txid1)
|
|
|
|
node0_address2 = self.nodes[0].getnewaddress()
|
|
node0_txid2 = self.nodes[0].sendtoaddress(node0_address2, 290)
|
|
node0_tx2 = self.nodes[0].gettransaction(node0_txid2)
|
|
|
|
assert_equal(self.nodes[0].getbalance(),
|
|
starting_balance + node0_tx1["fee"] + node0_tx2["fee"])
|
|
|
|
# Coins are sent to node1_address
|
|
node1_address = self.nodes[1].getnewaddress()
|
|
|
|
# Send tx1, and another transaction tx2 that won't be cloned
|
|
txid1 = self.nodes[0].sendtoaddress(node1_address, 400)
|
|
txid2 = self.nodes[0].sendtoaddress(node1_address, 200)
|
|
|
|
# Construct a clone of tx1, to be malleated
|
|
rawtx1 = self.nodes[0].getrawtransaction(txid1, 1)
|
|
clone_inputs = [{"txid": rawtx1["vin"][0]["txid"], "vout": rawtx1["vin"][0]["vout"]}]
|
|
clone_outputs = {rawtx1["vout"][0]["scriptPubKey"]["addresses"][0]: rawtx1["vout"][0]["value"],
|
|
rawtx1["vout"][1]["scriptPubKey"]["addresses"][0]: rawtx1["vout"][1]["value"]}
|
|
clone_locktime = rawtx1["locktime"]
|
|
clone_raw = self.nodes[0].createrawtransaction(clone_inputs, clone_outputs, clone_locktime)
|
|
|
|
# createrawtransaction randomizes the order of its outputs, so swap them if necessary.
|
|
clone_tx = CTransaction()
|
|
clone_tx.deserialize(io.BytesIO(bytes.fromhex(clone_raw)))
|
|
if (rawtx1["vout"][0]["value"] == 400 and clone_tx.vout[0].nValue != 400*COIN or rawtx1["vout"][0]["value"] != 400 and clone_tx.vout[0].nValue == 400*COIN):
|
|
(clone_tx.vout[0], clone_tx.vout[1]) = (clone_tx.vout[1], clone_tx.vout[0])
|
|
|
|
# Use a different signature hash type to sign. This creates an equivalent but malleated clone.
|
|
# Don't send the clone anywhere yet
|
|
tx1_clone = self.nodes[0].signrawtransactionwithwallet(clone_tx.serialize().hex(), None, "ALL|ANYONECANPAY")
|
|
assert_equal(tx1_clone["complete"], True)
|
|
|
|
# Have node0 mine a block, if requested:
|
|
if (self.options.mine_block):
|
|
self.nodes[0].generate(1)
|
|
self.sync_blocks(self.nodes[0:2])
|
|
|
|
tx1 = self.nodes[0].gettransaction(txid1)
|
|
tx2 = self.nodes[0].gettransaction(txid2)
|
|
|
|
# Node0's balance should be starting balance, plus 500DASH for another
|
|
# matured block, minus tx1 and tx2 amounts, and minus transaction fees:
|
|
expected = starting_balance + node0_tx1["fee"] + node0_tx2["fee"]
|
|
if self.options.mine_block:
|
|
expected += 500
|
|
expected += tx1["amount"] + tx1["fee"]
|
|
expected += tx2["amount"] + tx2["fee"]
|
|
assert_equal(self.nodes[0].getbalance(), expected)
|
|
|
|
if self.options.mine_block:
|
|
assert_equal(tx1["confirmations"], 1)
|
|
assert_equal(tx2["confirmations"], 1)
|
|
else:
|
|
assert_equal(tx1["confirmations"], 0)
|
|
assert_equal(tx2["confirmations"], 0)
|
|
|
|
# Send clone and its parent to miner
|
|
self.nodes[2].sendrawtransaction(node0_tx1["hex"])
|
|
txid1_clone = self.nodes[2].sendrawtransaction(tx1_clone["hex"])
|
|
# ... mine a block...
|
|
self.nodes[2].generate(1)
|
|
|
|
# Reconnect the split network, and sync chain:
|
|
connect_nodes(self.nodes[1], 2)
|
|
self.nodes[2].sendrawtransaction(node0_tx2["hex"])
|
|
self.nodes[2].sendrawtransaction(tx2["hex"])
|
|
self.nodes[2].generate(1) # Mine another block to make sure we sync
|
|
self.sync_blocks()
|
|
|
|
# Re-fetch transaction info:
|
|
tx1 = self.nodes[0].gettransaction(txid1)
|
|
tx1_clone = self.nodes[0].gettransaction(txid1_clone)
|
|
tx2 = self.nodes[0].gettransaction(txid2)
|
|
|
|
# Verify expected confirmations
|
|
assert_equal(tx1["confirmations"], -2)
|
|
assert_equal(tx1_clone["confirmations"], 2)
|
|
assert_equal(tx2["confirmations"], 1)
|
|
|
|
# Check node0's total balance; should be same as before the clone, + 1000 DASH for 2 matured,
|
|
# less possible orphaned matured subsidy
|
|
expected += 1000
|
|
if (self.options.mine_block):
|
|
expected -= 500
|
|
assert_equal(self.nodes[0].getbalance(), expected)
|
|
|
|
if __name__ == '__main__':
|
|
TxnMallTest().main()
|