mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00

Dash - Reinventing Cryptocurrency

bitcoin blockchain cryptocurrency dash governance instant masternode p2p privacy

Go to file

pasta f9e123efd6 Merge #5987 : refactor: reduce fMasternodeMode usage, remove fDisableGovernance global `b4477e409c` trivial: don't print `fDisableGovernance` value anymore (Kittywhiskers Van Gogh) `a42370df93` refactor: remove fDisableGovernance global, define default in variable (Kittywhiskers Van Gogh) `b1527599e4` refactor: remove fMasternodeMode and fDisableGovernance from Qt code (Kittywhiskers Van Gogh) `9402ce7171` refactor: limit usage of fDisableGovernance, use `IsValid()` instead (Kittywhiskers Van Gogh) `106f6bdd4e` refactor: reduce fMasternodeMode usage in governance and mnauth (Kittywhiskers Van Gogh) `3ba293fbcc` refactor: remove fMasternodeMode checks in CActiveMasternodeManager (Kittywhiskers Van Gogh) `b0216ac8a6` refactor: remove fMasternodeMode usage in rpc logic (Kittywhiskers Van Gogh) `4d629a04fb` refactor: limit fMasternodeMode usage in blockstorage, init, net_processing (Kittywhiskers Van Gogh) `a9cbdfcebc` refactor: remove fMasternodeMode usage from llmq logic (Kittywhiskers Van Gogh) `c62a3d5778` refactor: remove fMasternodeMode usage from coinjoin logic (Kittywhiskers Van Gogh) Pull request description: ## Motivation Since https://github.com/dashpay/dash/pull/5940, `CActiveMasternodeManager` ceased to be a global variable and became a conditional smart pointer initialized based on the value of `fMasternodeMode`. Likewise, since https://github.com/dashpay/dash/pull/5555, we can tell if any `CFlatDB`-based manager has successfully loaded its database. `CGovernanceManager` is one of them and conditionally loads its database based on the value of `fGovernanceDisabled`. `fMasternodeMode` and `fGovernanceDisabled` were (and the former to a certain degree still is) unavoidable globals due to the way the functionality they influenced was structured (i.e. decided in initialization code with no way to query from the manager itself). As we can directly ask the managers now, we can start reducing the usage of these globals and at least in this PR, get rid of one of them. This PR was the idea of PastaPastaPasta, special thanks for the suggestion! ## Additional Information * There are two conventions being used for checking `nullptr`-ity of a pointer, `if (mn_activeman)` and `if (mn_activeman != nullptr)`. The former is used in initialization and RPC code due to existing conventions there ([source](`2dacfb08bd/src/init.cpp (L1659-L1677)`), [source](`2dacfb08bd/src/rpc/net.cpp (L942-L945)`), [source](`2dacfb08bd/src/rpc/misc.cpp (L215-L218)`)). The latter is used whenever the value has to be passed as a `bool` (you cannot pass the implicit conversion to a `bool` argument without explicitly casting it) and in Dash-specific code where it is the prevalent convention ([source](`2dacfb08bd/src/governance/governance.cpp (L125)`), [source](`2dacfb08bd/src/coinjoin/client.cpp (L1064)`)). Unfortunately, that means this PR expresses the same thing sometimes in two different ways but this approach was taken so that reading is consistent within the same file. Codebase-wide harmonization is outside the scope of this PR. * Where `mn_activeman` isn't directly available, the result of the check is passed as an argument named `is_masternode` and/or set for the manager during its construction as `m_is_masternode` (`const bool`) as it is expected for the `CActiveMasternodeManager`'s presence or absence to remain as-is for the duration of the manager's lifetime. This does mean that some parts of the codebase check for `mn_activeman` while others check for {`m_`}`is_masternode`, which does reduce clarity while reading. Suggestions on improving this are welcomed. * One of the reasons this PR was made was to avoid having to deal the _possibility_ of `fMasternodeMode` or `fDisableGovernance` from desynchronizing from the behaviour of the managers it's suppose to influence. It's why additional assertions were placed in to make sure that `fMasternodeMode` and the existence of `mn_activeman` were always in sync ([source](`2dacfb08bd/src/evo/mnauth.cpp (L137-L139)`), [source](`2dacfb08bd/src/rpc/governance.cpp (L319-L320)`)). But removing the tracking global and relying on a manager's state itself prevents a potential desync, which is what this PR is aiming to do. ## Breaking Changes None expected. ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added or updated relevant unit/integration/functional/e2e tests - [x] I have made corresponding changes to the documentation (note: N/A) - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: 7861afd17c83b92af4c95b2841e9b0f676116eb3f234c4d0b1dcd3c20395452893e8ca3a17c7225389c8411dac80aeb5050f06a2ae35df5ec48998a571ef120c		2024-04-26 11:02:46 -05:00
.github	chore: narrow score of clang-diff-format for dash specific files only	2024-03-24 00:41:24 +07:00
.tx	fix: follow-up #5393 - should be used `[dash.dash_ents]` (#5472 )	2023-07-01 14:16:50 +03:00
build-aux/m4	Merge #19522 : build: fix building libconsensus with reduced exports for Darwin targets	2024-04-11 02:25:06 +07:00
ci	Merge bitcoin/bitcoin#21749 : test: Bump shellcheck version	2024-04-23 22:41:10 +07:00
contrib	Merge #21418 : contrib: Make systemd invoke dependencies only when ready	2024-04-22 09:42:16 -05:00
depends	Merge #21354 : build, doc: Drop no longer required packages from macOS cross-compiling dependencies	2024-04-11 02:25:07 +07:00
doc	merge bitcoin#25550: remove note on arm cross-compilation from build-unix.md	2024-04-23 15:34:49 +00:00
share	Merge #20813 : scripted-diff: Bump copyright headers	2024-04-10 03:19:34 +07:00
src	Merge #5987 : refactor: reduce fMasternodeMode usage, remove fDisableGovernance global	2024-04-26 11:02:46 -05:00
test	refactor: remove fMasternodeMode usage in rpc logic	2024-04-24 18:46:34 +00:00
.cirrus.yml	Merge #5976 : backport: bitcoin#17934, #21338 , #21390 , #21445 , #21602 , #21606 , #21609 , #21676 , bitcoin-core/gui#260 ,	2024-04-12 10:30:27 -05:00
.dockerignore
.editorconfig
.gitattributes
.gitignore	merge bitcoin#21336: Make .gitignore ignore src/test/fuzz/fuzz.exe	2024-02-06 08:39:51 -06:00
.gitlab-ci.yml	chore: increase amount of build jobs from 4 to 8 for depends	2024-03-17 01:09:41 +07:00
.python-version	partial bitcoin#27483: Bump python minimum version to 3.8	2023-05-11 09:18:48 -05:00
.style.yapf
autogen.sh	Merge #17829 : scripted-diff: Bump copyright of files changed in 2019	2023-12-06 11:40:14 -06:00
CMakeLists.txt	chore: Added missing sources files in CMake (#5503 )	2023-07-25 12:23:56 -05:00
configure.ac	Merge bitcoin/bitcoin#21884 : fuzz: Remove unused --enable-danger-fuzz-link-all option	2024-04-23 22:41:09 +07:00
CONTRIBUTING.md	doc: replace gfd() function to recommendation to use `git diff-range`	2024-04-23 11:26:00 -05:00
COPYING	docs: update license year range to 2024 (#5890 )	2024-02-22 20:56:43 -06:00
INSTALL.md
libdashconsensus.pc.in
Makefile.am	Merge #20549 : Support make src/bitcoin-node and src/bitcoin-gui	2024-01-16 09:34:27 -06:00
README.md	Merge #20691 : ci, doc: Travis CI features and mentions cleanup	2024-03-27 00:48:26 +07:00
SECURITY.md

README.md

Dash Core staging tree

CI	master	develop
Gitlab

https://www.dash.org

For an immediately usable, binary version of the Dash Core software, see https://www.dash.org/downloads/.

Further information about Dash Core is available in the doc folder.

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information read the original Dash whitepaper.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The develop branch is regularly built (see doc/build-*.md for instructions) and tested, but is not guaranteed to be completely stable.

The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The CI (Continuous Integration) systems make sure that every pull request is built for Windows, Linux, and macOS, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.