241f76f9bf
* Merge #13176: Improve CRollingBloomFilter performance: replace modulus with FastMod 9aac9f90d5e56752cc6cbfac48063ad29a01143c replace modulus with FastMod (Martin Ankerl) Pull request description: Not sure if this is optimization is necessary, but anyway I have some spare time so here it is. This replaces the slow modulo operation with a much faster 64bit multiplication & shift. This works when the hash is uniformly distributed between 0 and 2^32-1. This speeds up the benchmark by a factor of about 1.3: ``` RollingBloom, 5, 1500000, 3.73733, 4.97569e-07, 4.99002e-07, 4.98372e-07 # before RollingBloom, 5, 1500000, 2.86842, 3.81630e-07, 3.83730e-07, 3.82473e-07 # FastMod ``` Be aware that this changes the internal data of the filter, so this should probably not be used for CBloomFilter because of interoperability problems. Tree-SHA512: 04104f3fb09f56c9d14458a6aad919aeb0a5af944e8ee6a31f00e93c753e22004648c1cd65bf36752b6addec528d19fb665c27b955ce1666a85a928e17afa47a * Use unordered_map in CSporkManager In one of my profiling sessions with many InstantSend transactions happening, calls into CSporkManager added up to about 1% of total CPU time. This is easily avoidable by using unordered maps. * Use std::unordered_map instead of std::map in limitedmap * Use unordered_set for CNode::setAskFor * Add serialization support for unordered maps and sets * Use unordered_map for mapArgs and mapMultiArgs * Let limitedmap prune in batches and use unordered_multimap Due to the batched pruning, there is no need to maintain an ordered map of values anymore. Only when nPruneAfterSize, there is a need to create a temporary ordered vector of values to figure out what can be removed. * Instead of using a multimap for mapAskFor, use a vector which we sort on demand CNode::AskFor will now push entries into an initially unordered vector instead of an ordered multimap. Only when we later want to use vecAskFor in SendMessages, we sort the vector. The vector will actually be mostly sorted in most cases as insertion order usually mimics the desired ordering. Only the last few entries might need some shuffling around. Doing the sort on-demand should be less wasteful then trying to maintain correct order all the time. * Fix compilation of tests * Fix limitedmap tests * Rename limitedmap to unordered_limitedmap to ensure backports conflict This ensures that future backports that depends on limitedmap's ordering conflict so that we are made aware of needed action. * Fix compilation error on Travis |
||
|---|---|---|
| .. | ||
| data | ||
| addrman_tests.cpp | ||
| alert_tests.cpp | ||
| allocator_tests.cpp | ||
| amount_tests.cpp | ||
| arith_uint256_tests.cpp | ||
| base32_tests.cpp | ||
| base58_tests.cpp | ||
| base64_tests.cpp | ||
| bctest.py | ||
| bip32_tests.cpp | ||
| bip39_tests.cpp | ||
| bitcoin-util-test.py | ||
| blockencodings_tests.cpp | ||
| bloom_tests.cpp | ||
| bls_tests.cpp | ||
| bswap_tests.cpp | ||
| buildenv.py.in | ||
| cachemap_tests.cpp | ||
| cachemultimap_tests.cpp | ||
| checkqueue_tests.cpp | ||
| coins_tests.cpp | ||
| compress_tests.cpp | ||
| crypto_tests.cpp | ||
| cuckoocache_tests.cpp | ||
| dbwrapper_tests.cpp | ||
| DoS_tests.cpp | ||
| evo_deterministicmns_tests.cpp | ||
| evo_simplifiedmns_tests.cpp | ||
| getarg_tests.cpp | ||
| governance_validators_tests.cpp | ||
| hash_tests.cpp | ||
| key_tests.cpp | ||
| limitedmap_tests.cpp | ||
| main_tests.cpp | ||
| Makefile | ||
| mempool_tests.cpp | ||
| merkle_tests.cpp | ||
| miner_tests.cpp | ||
| multisig_tests.cpp | ||
| net_tests.cpp | ||
| netbase_tests.cpp | ||
| pmt_tests.cpp | ||
| policyestimator_tests.cpp | ||
| pow_tests.cpp | ||
| prevector_tests.cpp | ||
| raii_event_tests.cpp | ||
| random_tests.cpp | ||
| ratecheck_tests.cpp | ||
| README.md | ||
| reverselock_tests.cpp | ||
| rpc_tests.cpp | ||
| sanity_tests.cpp | ||
| scheduler_tests.cpp | ||
| script_P2PK_tests.cpp | ||
| script_P2PKH_tests.cpp | ||
| script_P2SH_tests.cpp | ||
| script_tests.cpp | ||
| scriptnum10.h | ||
| scriptnum_tests.cpp | ||
| serialize_tests.cpp | ||
| sighash_tests.cpp | ||
| sigopcount_tests.cpp | ||
| skiplist_tests.cpp | ||
| streams_tests.cpp | ||
| subsidy_tests.cpp | ||
| test_dash.cpp | ||
| test_dash.h | ||
| test_random.h | ||
| testutil.cpp | ||
| testutil.h | ||
| timedata_tests.cpp | ||
| transaction_tests.cpp | ||
| txvalidationcache_tests.cpp | ||
| uint256_tests.cpp | ||
| univalue_tests.cpp | ||
| util_tests.cpp | ||
| versionbits_tests.cpp | ||
Compiling/running unit tests
Unit tests will be automatically compiled if dependencies were met in ./configure
and tests weren't explicitly disabled.
After configuring, they can be run with make check.
To run the dashd tests manually, launch src/test/test_dash.
To add more dashd tests, add BOOST_AUTO_TEST_CASE functions to the existing
.cpp files in the test/ directory or add new .cpp files that
implement new BOOST_AUTO_TEST_SUITE sections.
To run the dash-qt tests manually, launch src/qt/test/test_dash-qt
To add more dash-qt tests, add them to the src/qt/test/ directory and
the src/qt/test/test_main.cpp file.
Running individual tests
test_dash has some built-in command-line arguments; for example, to run just the getarg_tests verbosely:
test_dash --log_level=all --run_test=getarg_tests
... or to run just the doubledash test:
test_dash --run_test=getarg_tests/doubledash
Run test_dash --help for the full list.
Note on adding test cases
The sources in this directory are unit test cases. Boost includes a unit testing framework, and since Dash Core already uses boost, it makes sense to simply use this framework rather than require developers to configure some other framework (we want as few impediments to creating unit tests as possible).
The build system is setup to compile an executable called test_dash
that runs all of the unit tests. The main source file is called
test_dash.cpp. To add a new unit test file to our test suite you need
to add the file to src/Makefile.test.include. The pattern is to create
one test file for each class or source file for which you want to create
unit tests. The file naming convention is <source_filename>_tests.cpp
and such files should wrap their tests in a test suite
called <source_filename>_tests. For an example of this pattern,
examine uint256_tests.cpp.
For further reading, I found the following website to be helpful in explaining how the boost unit test framework works: http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/.
bitcoin-util-test.py
The test directory also contains the bitcoin-util-test.py tool, which tests bitcoin utils (currently just dash-tx). This test gets run automatically during the make check build process. It is also possible to run the test manually from the src directory:
test/bitcoin-util-test.py --srcdir=[current directory]