mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
4c8e77a48d
d841301010914203fb5ef02627c76fad99cb11f1 test: Add docstring to wait_until() in util.py to warn about its usage (Seleme Topuz) 1343c86c7cc1fc896696b3ed87c12039e4ef3a0c test: Update wait_until usage in tests not to use the one from utils (Seleme Topuz) Pull request description: Replace global (from [test_framework/util.py](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/util.py#L228)) `wait_until()` usages with the ones provided by `BitcoinTestFramework` and `P2PInterface` classes. The motivation behind this change is that the `util.wait_until()` expects a timeout, timeout_factor and lock and it is not aware of the context of the test framework. `BitcoinTestFramework` offers a `wait_until()` which has an understandable amount of default `timeout` and a shared `timeout_factor`. Moreover, on top of these, `mininode.wait_until()` also has a shared lock. closes #19080 ACKs for top commit: MarcoFalke: ACK d841301010914203fb5ef02627c76fad99cb11f1 🦆 kallewoof: utACK d841301010914203fb5ef02627c76fad99cb11f1 Tree-SHA512: 81604f4cfa87fed98071a80e4afe940b3897fe65cf680a69619a93e97d45f25b313c12227de7040e19517fa9c003291b232f1b40b2567aba0148f22c23c47a88
107 lines
5.2 KiB
Python
Executable File
107 lines
5.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2019 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test node disconnect and ban behavior"""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
)
|
|
|
|
class DisconnectBanTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
self.supports_cli = False
|
|
|
|
def run_test(self):
|
|
self.log.info("Connect nodes both way")
|
|
self.connect_nodes(0, 1)
|
|
self.connect_nodes(1, 0)
|
|
|
|
self.log.info("Test setban and listbanned RPCs")
|
|
|
|
self.log.info("setban: successfully ban single IP address")
|
|
assert_equal(len(self.nodes[1].getpeerinfo()), 2) # node1 should have 2 connections to node0 at this point
|
|
self.nodes[1].setban(subnet="127.0.0.1", command="add")
|
|
self.wait_until(lambda: len(self.nodes[1].getpeerinfo()) == 0, timeout=10)
|
|
assert_equal(len(self.nodes[1].getpeerinfo()), 0) # all nodes must be disconnected at this point
|
|
assert_equal(len(self.nodes[1].listbanned()), 1)
|
|
|
|
self.log.info("clearbanned: successfully clear ban list")
|
|
self.nodes[1].clearbanned()
|
|
assert_equal(len(self.nodes[1].listbanned()), 0)
|
|
self.nodes[1].setban("127.0.0.0/24", "add")
|
|
|
|
self.log.info("setban: fail to ban an already banned subnet")
|
|
assert_equal(len(self.nodes[1].listbanned()), 1)
|
|
assert_raises_rpc_error(-23, "IP/Subnet already banned", self.nodes[1].setban, "127.0.0.1", "add")
|
|
|
|
self.log.info("setban: fail to ban an invalid subnet")
|
|
assert_raises_rpc_error(-30, "Error: Invalid IP/Subnet", self.nodes[1].setban, "127.0.0.1/42", "add")
|
|
assert_equal(len(self.nodes[1].listbanned()), 1) # still only one banned ip because 127.0.0.1 is within the range of 127.0.0.0/24
|
|
|
|
self.log.info("setban remove: fail to unban a non-banned subnet")
|
|
assert_raises_rpc_error(-30, "Error: Unban failed", self.nodes[1].setban, "127.0.0.1", "remove")
|
|
assert_equal(len(self.nodes[1].listbanned()), 1)
|
|
|
|
self.log.info("setban remove: successfully unban subnet")
|
|
self.nodes[1].setban("127.0.0.0/24", "remove")
|
|
assert_equal(len(self.nodes[1].listbanned()), 0)
|
|
self.nodes[1].clearbanned()
|
|
assert_equal(len(self.nodes[1].listbanned()), 0)
|
|
|
|
self.log.info("setban: test persistence across node restart")
|
|
self.nodes[1].setban("127.0.0.0/32", "add")
|
|
self.nodes[1].setban("127.0.0.0/24", "add")
|
|
self.nodes[1].setban("192.168.0.1", "add", 1) # ban for 1 seconds
|
|
self.nodes[1].setban("2001:4d48:ac57:400:cacf:e9ff:fe1d:9c63/19", "add", 1000) # ban for 1000 seconds
|
|
listBeforeShutdown = self.nodes[1].listbanned()
|
|
assert_equal("192.168.0.1/32", listBeforeShutdown[2]['address'])
|
|
self.bump_mocktime(2)
|
|
self.wait_until(lambda: len(self.nodes[1].listbanned()) == 3, timeout=10)
|
|
|
|
self.restart_node(1)
|
|
|
|
listAfterShutdown = self.nodes[1].listbanned()
|
|
assert_equal("127.0.0.0/24", listAfterShutdown[0]['address'])
|
|
assert_equal("127.0.0.0/32", listAfterShutdown[1]['address'])
|
|
assert_equal("/19" in listAfterShutdown[2]['address'], True)
|
|
|
|
# Clear ban lists
|
|
self.nodes[1].clearbanned()
|
|
self.log.info("Connect nodes both way")
|
|
self.connect_nodes(0, 1)
|
|
self.connect_nodes(1, 0)
|
|
|
|
self.log.info("Test disconnectnode RPCs")
|
|
|
|
self.log.info("disconnectnode: fail to disconnect when calling with address and nodeid")
|
|
address1 = self.nodes[0].getpeerinfo()[0]['addr']
|
|
node1 = self.nodes[0].getpeerinfo()[0]['addr']
|
|
assert_raises_rpc_error(-32602, "Only one of address and nodeid should be provided.", self.nodes[0].disconnectnode, address=address1, nodeid=node1)
|
|
|
|
self.log.info("disconnectnode: fail to disconnect when calling with junk address")
|
|
assert_raises_rpc_error(-29, "Node not found in connected nodes", self.nodes[0].disconnectnode, address="221B Baker Street")
|
|
|
|
self.log.info("disconnectnode: successfully disconnect node by address")
|
|
address1 = self.nodes[0].getpeerinfo()[0]['addr']
|
|
self.nodes[0].disconnectnode(address=address1)
|
|
self.wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 1, timeout=10)
|
|
assert not [node for node in self.nodes[0].getpeerinfo() if node['addr'] == address1]
|
|
|
|
self.log.info("disconnectnode: successfully reconnect node")
|
|
self.connect_nodes(0, 1) # reconnect the node
|
|
assert_equal(len(self.nodes[0].getpeerinfo()), 2)
|
|
assert [node for node in self.nodes[0].getpeerinfo() if node['addr'] == address1]
|
|
|
|
self.log.info("disconnectnode: successfully disconnect node by node id")
|
|
id1 = self.nodes[0].getpeerinfo()[0]['id']
|
|
self.nodes[0].disconnectnode(nodeid=id1)
|
|
self.wait_until(lambda: len(self.nodes[0].getpeerinfo()) == 1, timeout=10)
|
|
assert not [node for node in self.nodes[0].getpeerinfo() if node['id'] == id1]
|
|
|
|
if __name__ == '__main__':
|
|
DisconnectBanTest().main()
|