mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
da0042972b
db1cbcc[RPC] Remove deprecated addmultisigaddress return format (John Newbery)cb28a0b[RPC] Remove deprecated createmultisig object (John Newbery)ed45c82[tests] Remove test for deprecated createmultsig option (John Newbery)d066a1c[rpc] Remove deprecated getmininginfo RPC option (John Newbery)c6f09c2[rpc] remove deprecated estimatefee RPC (John Newbery)a8e437a[tests] Remove estimatefee from rpc_deprecated.py test (John Newbery)a5623b1[tests] Remove tests for deprecated estimatefee RPC (John Newbery)d119f2e[tests] Fix style warnings in feature_fee_estimation.py (John Newbery) Pull request description: There were some RPC/RPC options deprecated in v0.16. Those can now be removed from master since v0.16 has been branched. - `estimatefee` RPC has been removed. The `feature_fee_estimation.py` test has been updated to remove the RPC, but doesn't yet have good coverage of the replacement RPC `estimatesmartfee`. Improving the test coverage should be done in a new PR. (#11031) - the `errors` field returned by `getmininginfo` has been deprecated and replaced by a `warning` field. (#10858) - providing addresses as inputs to `createmultisig` has been deprecated. Users should use `addmultisigaddress` instead (#11415) - The return format from `addmultisigaddress` has changed (#11415) `getwitnessaddress` was also deprecated in v0.16 and can be removed, but many tests are using that RPC, so it's a larger job to remove. It should be removed in a separate PR (possibly after #11739 and #11398 have been merged and the segwit test code tidied up) Tree-SHA512: 8ffaa5f6094131339b9e9e468e8b141de4b144697d2271efa2992b80b12eb97849ade3da8df5c1c9400ed4c04e6a029926550a3e5846d2029b644f9e84ac7124
28 lines
1.1 KiB
Python
Executable File
28 lines
1.1 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test deprecation of RPC calls."""
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
|
|
class DeprecatedRpcTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
self.setup_clean_chain = True
|
|
self.extra_args = [[], []]
|
|
|
|
def run_test(self):
|
|
# This test should be used to verify correct behaviour of deprecated
|
|
# RPC methods with and without the -deprecatedrpc flags. For example:
|
|
#
|
|
# self.log.info("Make sure that -deprecatedrpc=createmultisig allows it to take addresses")
|
|
# assert_raises_rpc_error(-5, "Invalid public key", self.nodes[0].createmultisig, 1, [self.nodes[0].getnewaddress()])
|
|
# self.nodes[1].createmultisig(1, [self.nodes[1].getnewaddress()])
|
|
#
|
|
# There are currently no deprecated RPC methods in master, so this
|
|
# test is currently empty.
|
|
pass
|
|
|
|
if __name__ == '__main__':
|
|
DeprecatedRpcTest().main()
|