Commit Graph

13658 Commits

Author SHA1 Message Date
UdjinM6
57e7cc4c63
Merge pull request #1828 from UdjinM6/bp_1810_1819
Backport critical fixes from develop
2018-01-10 12:21:06 +03:00
UdjinM6
476888683c Avoid reference leakage in CKeyHolderStorage::AddKey (#1840) 2018-01-09 14:12:31 +03:00
UdjinM6
21a10057df Protect CKeyHolderStorage via mutex (#1834) 2018-01-09 12:21:28 +03:00
UdjinM6
d261575b4f Skip existing masternode conections on mixing (#1833) 2018-01-09 12:21:03 +03:00
UdjinM6
f71ab1daf6 Merge pull request #1836 from lodgepole/feature/backport-11847
[backport] Fixes compatibility with boost 1.66
2018-01-07 02:39:50 +03:00
UdjinM6
fa5fc418a0 Fix -liquidityprovider option (#1829)
revert to pre-1248 logic for liquidity providers
2018-01-06 13:10:34 +03:00
UdjinM6
c9bafe1542 Vote on IS only if it was accepted to mempool (#1826) 2018-01-06 13:10:12 +03:00
UdjinM6
63e0e30e38
bump version to 0.12.2.3 (#1827)
* bump version to 0.12.2.3

* bump version in Doxyfile
2018-01-06 13:08:18 +03:00
Wladimir J. van der Laan
068b20bc70 Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)
2018-01-05 16:38:29 +03:00
Alexander Block
d6e2aa843c Swap iterations and fUseInstantSend parameters in ApproximateBestSubset (#1819)
#1695 introduced a fix for a instant send related edge case. Somehow the
parameters got mixed up and fUseInstantSend was passed as "iterations".
2018-01-05 16:38:09 +03:00
Alexander Block
ada41c3af1 Fix crash on exit when -createwalletbackups=0 (#1810) 2018-01-05 16:38:09 +03:00
UdjinM6
8506678d4b
Prepare v0.12.2.2 release notes (#1769)
* move 0.12.2 release notes

* prepare 0.12.2.2 release notes
2017-12-16 19:29:41 +03:00
Oleg Girko
837c4fc5de Force rcc to use resource format version 1. (#1784)
Qt 5.8.0 introduced format version 2 for resources embedded into executable,
and now rcc uses this format by default to generate them.

Unfortunately, v2 format includes timestamps for embedded resource files.
Some of resource files (translations) are generated automatically
and have different timestamps for every build.

This means that dash-qt executable is slightly different for every build
because resource data contain different timestamps.

As a result, it makes reproducible build extremely difficult.

Fortunately, Qt 5.9.0 introduced --format-version option for rcc.
This change adds configure check for whether rcc accepts this option
and uses it to force rcc to generate version 1 format data.

Signed-off-by: Oleg Girko <ol@infoserver.lv>
2017-12-15 18:21:44 +03:00
UdjinM6
86e6f0dd23
Fix CMasternodeMan::ProcessVerify* logs (#1782)
Fixes these issues:
- wrong function name
- wrong addr
- too spammy
- typo
2017-12-14 19:50:06 +03:00
UdjinM6
63e3061487
Improve sync (#1779)
* Do not relay `mnp`, `mnb`, `mnw`, `govobj` and `govobjvote` until fully synced

This should massively lower outgoing traffic and load during sync process (especially on mainnet)

* Apply "no sync from me until I'm synced" rule to all nodes
2017-12-14 03:33:58 +03:00
UdjinM6
a79c972486
Fix ProcessVerifyBroadcast (#1780) 2017-12-14 03:33:27 +03:00
UdjinM6
0291604ad0
Clarify usage of pointers and references in code (#1778) 2017-12-14 03:33:08 +03:00
UdjinM6
f37a64208c
InstantSend txes should never qualify to be a 0-fee txes (#1777) 2017-12-13 15:43:05 +03:00
UdjinM6
930afd7df4
Fix mnp and mnv invs (#1775)
* Fix mnp inv

Add an entry to mapSeenMasternodePing when sending invs in DSEG response,
otherwise we won't be able to send data in ProcessGetData later and thus
peer that asked us won't be able to clear setAskFor.

* Fix mnv inv

The issue is similar to the one for mnp
2017-12-13 15:42:37 +03:00
Alexander Block
6915ee45e6 Bump version in README.md to 0.12.2 (#1774) 2017-12-12 12:53:44 +03:00
UdjinM6
54186a159f
Make sure additional indexes are recalculated correctly in VerifyDB (#1773) 2017-12-12 04:24:24 +03:00
UdjinM6
362becbcce
Bump MIN_PEER_PROTO_VERSION to 70208 (#1772)
Drop old (pre-v0.12.2.x) peers
2017-12-12 04:24:10 +03:00
UdjinM6
f9f28e7c73
De-bump to 0.12.2.2 (#1768)
* Revert "bump to 0.12.3.0 (#1726)"

This reverts commit ccbd5273ec.

* bump to 0.12.2.2
2017-12-08 16:55:05 +03:00
UdjinM6
51b2c7501c
Fix WarningBitsConditionChecker (#1765)
Assume that all masternodes are upgraded to avoid false warnings
2017-12-07 19:07:21 +03:00
UdjinM6
3028af19f1
post-DIP0001 cleanup (#1763)
* post-DIP0001 cleanup

also fixes tests

* bump nMinimumChainWork and defaultAssumeValid
2017-12-07 12:43:23 +03:00
UdjinM6
4802a1fb71
Allow IS for all txes, not only for txes with p2pkh and data outputs (#1760) 2017-12-07 12:43:08 +03:00
UdjinM6
f4502099a4
make CheckDSTXes() private, execute it on both client and server (#1736) 2017-12-07 12:42:47 +03:00
UdjinM6
c5ec2f82a8
Drop IsNormalPaymentScript, use IsPayToPublicKeyHash (#1761) 2017-12-07 04:33:51 +03:00
Ilya Savinov
442325b072 add maxgovobjdatasize field to the output of getgovernanceinfo (#1757) 2017-12-06 01:18:08 +03:00
thephez
3f3705c476 [Trivial] Typo/doc updates and RPC help formatting (#1758)
* Protocol Doc - correct type of DSQ nTime and fReady fields

* Basic typo correction

* RPC help typos
 - Change port in DisconnectNode example from Bitcoin port -> Dash port
 - Correct order of chainwork in getblockheader/getblockheaders help to
match actual output
 - Add missing fields to getmininginfo/getblocktemplate help output

* Remove duplicate generate field in getmininginfo output

* Fix generate field type info / description in getmininginfo output
2017-12-06 01:17:45 +03:00
Турбанов Андрей
9e7cc56cb6 Fix typo in release-notes.md (#1759) 2017-12-06 01:17:21 +03:00
joe
d1aeac1b2e Spelling mistake in validation.cpp (#1752)
Fixed!
2017-12-04 09:06:19 +03:00
UdjinM6
7e96af4e65
Refactor PrivateSend (#1735)
* make infoMixingMasternode private

* move PS queue entries expiration checks (and cs_darksend) to CPrivateSendBase

* drop CTxDSOut

* move prevPubKey out of CTxIn into CTxDSIn and use CTxDSIn explicitly

* drop CPrivateSendClient::NewBlock

* move IsDenominatedAmount to CPrivateSend

* move IsCollateralAmount to CPrivateSend

* drop darksend-relay.cpp/h

* drop GetMasternodeByRank
2017-12-04 09:06:07 +03:00
UdjinM6
c166ed39b0
Allow compilation with --disable-wallet (#1733)
* Allow compilation with `--disable-wallet`

* fix remaining references

* Drop wallet references/include in CActiveMasternode and fix other files affected by this change

* Wrap privatesend-client.h include with ifdef/endif and fix other files affected by this change

* Re-enable Travis build with no wallet

reverts 267e57877b
2017-12-01 21:53:34 +03:00
UdjinM6
865b61b503
Unify GetNextWorkRequired (#1737)
* unify GetNextWorkRequired

* drop enum
2017-12-01 08:15:11 +03:00
UdjinM6
3280097495
fine-tune sync conditions in getblocktemplate (#1739) 2017-12-01 08:14:57 +03:00
UdjinM6
70cb2a4af5
Fix traditional UI theme (#1741)
* fix traditional UI theme

* Fix Send dialog (PS/IS/Balance)
2017-12-01 08:14:39 +03:00
UdjinM6
32f21698e8
Adjust tests to avoid Travis timeouts (#1745)
- add some stdout spam to heavy tests (versionbits_tests, coins_tests and PrevectorTests)
- replace `--show_progress` with `--log_level=test_suite` to print these messages and avoid timeout
2017-12-01 08:14:17 +03:00
UdjinM6
bc83425589
Two small fixes in docs (#1746) 2017-12-01 08:13:49 +03:00
UdjinM6
7dfe8aade1
Merge pull request #1748 from willwray/build_quiet_warnings
Build: quiet annoying warnings
2017-12-01 08:13:21 +03:00
UdjinM6
e975f891c8
Fix ru typo (#1742) 2017-11-30 00:45:12 +03:00
Cory Fields
fee05dab93 build: silence gcc7's implicit fallthrough warning
This is a well-intentioned but realistically annoying warning. Unfortunately,
it's too easy for a warning in one header to cause dozens of repeated warnings.

(cherry picked from commit cf390dff897a679d904242286cef3b7d29847c50)
2017-11-29 12:56:04 -05:00
Cory Fields
cdb2b1944c build: quiet annoying warnings without adding new ones
Disabling warnings can be tricky, because doing so can cause a different
compiler to create new warnings about unsupported disable flags. Also, some
warnings don't surface until they're paired with another warning (gcc). For
example, adding "-Wno-foo" won't cause any trouble, but if there's a legitimate
warning emitted, the "unknown option -Wno-foo" will show up as well.

Work around this in 2 ways:

1. When checking to see if -Wno-foo is supported, check for "-Wfoo" instead.
2. Enable -Werror while checking 1.

If "-Werror -Wfoo" compiles, "-Wno-foo" is almost guaranteed to be supported.

-Werror itself is also checked. If that fails to compile by itself, it likely
means that the user added a flag that adds a warning. In that case, -Werror
won't be used while checking, and the build may be extra noisy. The user would
need to fix the bad input flag.

Also, silence 2 more additional warnings that can show up post-c++11.

(cherry picked from commit 63b3111f84daa421abc2889a550e86c17bf9609d)
2017-11-29 12:40:04 -05:00
UdjinM6
31bc9d4ee8
Show test progress for tests running in wine to avoid Travis timeout (#1740) 2017-11-27 21:07:54 +03:00
UdjinM6
5d58dd90c2
Make sure to clear setAskFor in Dash submodules (#1730)
* Make sure to clear setAskFor in Dash submodules

Thanks @sidhujag for finding the bug

* partially revert previous commit

* skip mnv until mn list is synced
2017-11-22 17:27:06 +03:00
UdjinM6
3e86c41be5
Merge pull request #1729 from codablock/backport_bitcoin_11529
Backport bitcoin #11529: Avoid slow transaction search with txindex enabled (João Barbosa)
2017-11-22 17:26:44 +03:00
Holger Schinzel
ccbd5273ec bump to 0.12.3.0 (#1726) 2017-11-22 17:19:55 +03:00
Wladimir J. van der Laan
371feda4ce Merge #11529: Avoid slow transaction search with txindex enabled
7a5f930 Avoid slow transaction search with txindex enabled (João Barbosa)

Pull request description:

  This is an alternative to #11507 where a slow search is not attempted (in any case) if `txindex` is enabled.

Tree-SHA512: e680621781a9241c0513ddd79d23b0b42f3ccec8a63ed1c926b35c43321c81c39a1028770397dd5070501dcf644d897026a2bd68a161a4b435f19227c1bbca48
2017-11-19 20:26:34 +01:00
UdjinM6
3bffd1bc62
Merge pull request #1717 from UdjinM6/develop
Merge 'master' into `develop`
2017-11-12 21:04:05 +03:00
UdjinM6
89f326c6da Merge branch 'master' into develop 2017-11-12 19:18:08 +03:00