Jorge Timón
60c8bac77c
Includes: Cleanup around net main and wallet
...
-Move from .h to .cpp: in main, net and wallet
-Remove unnecessary #include "main.h"
-Cleanup some wallet files includes
2015-07-23 21:10:26 +02:00
Jorge Timón
9dd793f499
TRIVIAL: Missing includes
2015-07-23 21:10:22 +02:00
Wladimir J. van der Laan
086cb336cd
Merge pull request #6365
...
5a7304b
Move recently introduced CTransAction::IsEquivalentTo to CWalletTx (Wladimir J. van der Laan)
2015-07-06 19:11:14 +02:00
Wladimir J. van der Laan
9546a977d3
Merge pull request #6335
...
9238ecb
Policy: MOVEONLY: 3 functions to policy.o: (Luke Dashjr)
627b9de
Policy: MOVEONLY: Create policy/policy.h with some constants (Jorge Timón)
2015-07-06 18:54:20 +02:00
Wladimir J. van der Laan
5a7304b69d
Move recently introduced CTransAction::IsEquivalentTo to CWalletTx
...
CTransAction::IsEquivalentTo was introduced in #5881 .
This functionality is only useful to the wallet, and should never have
been added to the primitive transaction type.
2015-07-02 20:57:39 +02:00
Wladimir J. van der Laan
3203a0832a
Merge pull request #5881
...
5d34e16
Add txn_clone.py test (Tom Harding)
defd2d5
Better txn_doublespend.py test (Tom Harding)
b2b3619
Implement CTransaction::IsEquivalentTo(...) (Tom Harding)
2015-07-02 19:59:50 +02:00
Jonas Schnelli
a7b9623d18
miner: rename UpdateRequestCount signal to ResetRequestCount
2015-07-01 16:09:58 +02:00
Jonas Schnelli
5496253966
add CReserveScript to allow modular script keeping/returning
...
- use one CReserveScript per mining thread
2015-07-01 16:06:14 +02:00
Jonas Schnelli
087e65def9
fix GetScriptForMining() CReserveKey::keepKey() issue
2015-06-30 21:45:46 +02:00
Jonas Schnelli
d0fc10a844
detach wallet from miner
2015-06-30 21:45:46 +02:00
Jorge Timón
627b9deff4
Policy: MOVEONLY: Create policy/policy.h with some constants
2015-06-26 17:59:07 +02:00
Wladimir J. van der Laan
91389e51c7
Merge pull request #6088
...
2085895
fundrawtransaction tests (Jonas Schnelli)
21bbd92
Add fundrawtransaction RPC method (Matt Corallo)
1e0d1a2
Add FundTransaction method to wallet (Matt Corallo)
2d84e22
Small tweaks to CCoinControl for fundrawtransaction (Matt Corallo)
9b4e7d9
Add DummySignatureCreator which just creates zeroed sigs (Pieter Wuille)
2015-06-23 12:40:00 +02:00
Philip Kaufmann
0ce30eaa36
fix crash on shutdown when e.g. changing -txindex and abort action
...
- fixes #3136
- the problem is related to Boost path and a static initialized internal
pointer
- using a std::string in CDBEnv::EnvShutdown() prevents the problem
- this removes the boost::filesystem::path path field from CDBEnv
2015-06-16 15:03:50 +02:00
Wladimir J. van der Laan
5ebe7db6d0
Merge pull request #6257
...
ef2a3de
Add paytxfee to getwalletinfo, warnings to getnetworkinfo (Stephen)
2015-06-15 09:39:30 +02:00
Tom Harding
7d6a85ab5b
Fix getbalance *
...
Chance "getbalance *" not to use IsTrusted. The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.
Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.
2015-06-12 15:31:01 -07:00
Stephen
ef2a3de25c
Add paytxfee to getwalletinfo, warnings to getnetworkinfo
2015-06-11 16:12:34 -04:00
Matt Corallo
21bbd920e5
Add fundrawtransaction RPC method
2015-06-11 01:03:23 -07:00
Matt Corallo
1e0d1a2ff0
Add FundTransaction method to wallet
...
Some code stolen from Jonas Schnelli <jonas.schnelli@include7.ch>
2015-06-11 01:03:23 -07:00
Wladimir J. van der Laan
ac5476e2c1
Merge pull request #6057
...
7e6569e
[squashme] improve/corrects prune mode detection test for required wallet rescans (Jonas Schnelli)
7a12119
[RPC] disable import functions in pruned mode (Jonas Schnelli)
3201035
[autoprune] allow wallet in pruned mode (Jonas Schnelli)
2015-06-10 12:32:31 +02:00
Wladimir J. van der Laan
7d8ffac186
Changes necessary now that zero values accepted in AmountFromValue
...
- Add an accept test for zero amounts, and a reject test for negative
amounts
- Remove ugly hack in `settxfee` that is no longer necessary
- Do explicit zero checks in wallet RPC functions
- Don't add a check for zero amounts in `createrawtransaction` - this
could be seen as a feature
2015-06-06 09:41:12 +02:00
Wladimir J. van der Laan
12cdbabc26
Merge pull request #6152
...
08d9373
Remove unused code from wallet and validation interface (Michael Ford)
2015-06-05 21:24:15 +02:00
Philip Kaufmann
a9ac95c1bc
use const references where appropriate
2015-06-04 19:34:18 +02:00
Jonas Schnelli
9a8897f4ac
Remove JSON Spirit wrapper, remove JSON Spirit leftovers
...
- implement find_value() function for UniValue
- replace all Array/Value/Object types with UniValues, remove JSON Spirit to UniValue wrapper
- remove JSON Spirit sources
2015-06-04 09:16:21 +02:00
Jonas Schnelli
3df0411ad9
remove JSON Spirit UniValue wrapper
2015-06-04 09:16:06 +02:00
Jonas Schnelli
6c7bee0624
expicit set UniValue type to avoid empty values
2015-06-04 09:16:05 +02:00
Jonas Schnelli
53b4671a9d
extend conversion to UniValue
2015-06-04 09:16:05 +02:00
Jeff Garzik
15982a8b69
Convert tree to using univalue. Eliminate all json_spirit uses.
2015-06-04 09:16:05 +02:00
Wladimir J. van der Laan
87550eefc1
Merge pull request #6183
...
28bf062
Fix off-by-one error w/ nLockTime in the wallet (Peter Todd)
2015-06-01 11:33:33 +02:00
Jonas Schnelli
7a12119d7a
[RPC] disable import functions in pruned mode
...
import functions could lead to a rescan beyond prune level
2015-05-28 09:00:45 +02:00
Wladimir J. van der Laan
c7c9af381c
Merge pull request #5669
...
da29ecb
Consensus: MOVEONLY: Move CValidationState from main consensus/validation (jtimon)
27afcd8
Consensus: Refactor: Decouple CValidationState from main::AbortNode() (Cory Fields)
2015-05-27 15:00:02 +02:00
Peter Todd
28bf06236d
Fix off-by-one error w/ nLockTime in the wallet
...
Previously due to an off-by-one error the wallet ignored
nLockTime-by-height transactions that would be valid in the next block
even though they are accepted into the mempool. The transactions
wouldn't show up until confirmed, nor would they be included in the
unconfirmed balance. Similar to the mempool behavior fix in 665bdd3b
,
the wallet code was calling IsFinalTx() directly without taking into
account the fact that doing so tells you if the transaction could have
been mined in the *current* block, rather than the next block.
To fix this we strip IsFinalTx() of non-consensus-critical
functionality, removing the default arguments, and add CheckFinalTx() to
check if a transaction will be final in the next block.
2015-05-27 05:51:33 -04:00
Michael Ford
08d9373e2f
Remove unused code from wallet and validation interface
...
Fixes #6109
2015-05-18 17:11:06 +08:00
Alex Morcos
2457dc43ac
Change default nTxConfirmTarget to 2
2015-05-18 09:01:30 +02:00
Wladimir J. van der Laan
77ed59df4d
wallet: Introduce constant for -txconfirmtarget
default
2015-05-18 09:00:24 +02:00
Wladimir J. van der Laan
97ccfdca8a
Merge pull request #6137
...
a5baba5
minor: remove unneeded bool in CWalletDB::Recover (Philip Kaufmann)
2015-05-16 09:37:01 +02:00
jtimon
da29ecbcc6
Consensus: MOVEONLY: Move CValidationState from main consensus/validation
2015-05-15 16:05:28 +02:00
Philip Kaufmann
a5baba52c5
minor: remove unneeded bool in CWalletDB::Recover
2015-05-14 15:55:17 +02:00
Philip Kaufmann
3703385547
remove unused classes from db.h
2015-05-14 01:02:00 -04:00
Wladimir J. van der Laan
00820f921d
Merge pull request #6055
...
a8cdaf5
checkpoints: move the checkpoints enable boolean into main (Cory Fields)
11982d3
checkpoints: Decouple checkpoints from Params (Cory Fields)
6996823
checkpoints: make checkpoints a member of CChainParams (Cory Fields)
9f13a10
checkpoints: store mapCheckpoints in CCheckpointData rather than a pointer (Cory Fields)
2015-05-06 11:38:39 +02:00
Wladimir J. van der Laan
00e76db8c2
Merge pull request #6085
...
b05a89b
Non-grammatical language improvements (Luke Dashjr)
7e6d23b
Bugfix: Grammar fixes (Corinne Dashjr)
2015-05-04 08:01:58 +02:00
Corinne Dashjr
7e6d23b171
Bugfix: Grammar fixes
2015-05-01 11:21:27 +00:00
Cory Fields
11982d366d
checkpoints: Decouple checkpoints from Params
...
Pass checkpoint data in as necessary
2015-04-30 23:14:48 -04:00
Wladimir J. van der Laan
23c998d811
Merge pull request #5511
...
e9c3215
[Wallet] sort pending wallet transactions before reaccepting (dexX7)
2015-04-29 09:52:39 +02:00
Cory Fields
8b08d9530b
wallet: fix boost::get usage with boost 1.58
2015-04-28 11:45:10 -04:00
Wladimir J. van der Laan
1d9d314573
Merge pull request #5696
...
691161d
Consensus: Create consensus/consensus.h with some constants (jtimon)
2015-04-26 14:42:09 +02:00
jtimon
691161d419
Consensus: Create consensus/consensus.h with some constants
2015-04-20 21:27:51 +02:00
Gregory Maxwell
219953ce50
Show zero value txouts in listunspent.
...
It's reasonable that automatic coin selection will not pick a zero
value txout, but they're actually spendable; and you should know
if you have them. Listing also makes them available to tools like
dust-b-gone.
2015-04-20 10:13:18 -07:00
Philip Kaufmann
c6de7c35bc
trivial string change in wallet.cpp (the -> that)
2015-04-20 13:29:23 +02:00
Philip Kaufmann
a21df62069
ensure consistent header comment naming conventions
...
- BITCOIN_FOLDER_SUBFOLDER_FILENAME_H
2015-04-20 13:29:22 +02:00
Wladimir J. van der Laan
4c4f1b4721
Merge pull request #5992
...
ea9e82d
[squashme] fix listunspent code indentation (Jonas Schnelli)
b9fb692
Push down RPC reqWallet flag (Jonas Schnelli)
0b9dc9c
[move] move listunspent to wallet/rpcwallet.cpp (Jonas Schnelli)
2015-04-15 11:10:23 +02:00