Wladimir J. van der Laan
6662e23a0a
Merge #7982 : build: No need to check for leveldb atomics
...
de98290 build: No need to check for leveldb atomics (Cory Fields)
2017-12-20 17:25:03 +01:00
Alexander Block
7c6dab037b
Return from main instead of calling exit()
...
Align with upstream
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
a468803bd9
Merge #7964 : Minor changes for c++11 consistency
...
07e4edb auto_ptr → unique_ptr (Wladimir J. van der Laan)
073225c chain: define enum used as bit field as uint32_t (Wladimir J. van der Laan)
2017-12-20 17:25:03 +01:00
MarcoFalke
d975013160
Merge #7807 : Fixed miner test values, gave constants for less error-prone values.
...
f8536a6 Corrected values (instagibbs)
617deeb Gave miner test values constants for less error-prone values. (instagibbs)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
61227bb21c
Merge #7962 : CalculateNextWorkRequired Cleanup
...
c7aac2d Deprecating the remaining LogPrintf dependencies that were made obsolete in PR #7459 . (21E14)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
03507a720c
Merge #7952 : Log invalid block hash to make debugging easier.
...
61c0170 Log invalid block hash to make debugging easier. (Pavel Janík)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
c8bb792f41
Merge #7939 : qt: Make it possible to show details for multiple transactions
...
f135e3c qt: Add transaction hash to details window title (Wladimir J. van der Laan)
17a6a21 qt: Make it possible to show details for multiple transactions (Wladimir J. van der Laan)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
d69bcb1a0c
Merge #7941 : Fixing comment in script_test.json test case
...
62a9abd Fixing comment in script_test.json test case (Chris Stewart)
2017-12-20 17:25:03 +01:00
Alexander Block
7973142f16
Reformat listunstpent help to align with upstream
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
5cf744532b
Merge #7916 : Explicitly pass CChainParams& to DisconnectTip()
...
176869f Explicitly pass CChainParams to ConnectBlock (face)
d0a6353 Pass CChainParams to DisconnectTip() (face)
764d237 Globals: Explicitly pass const CChainParams& to UpdateTip() (Jorge Timón)
2017-12-20 17:25:03 +01:00
Alexander Block
a60c351826
Error/Warning fixes for HD wallet part in wallet.cpp
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
bacc864640
Merge #7787 : [Moveonly] Create ui_interface.cpp
...
fa10ce6 Move ui_interface.cpp to libbitcoin_server_a_SOURCES (MarcoFalke)
fabbf80 [ui] Move InitError, InitWarning, AmountErrMsg (MarcoFalke)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
8678f2b391
Merge #7905 : test: move accounting_tests and rpc_wallet_tests to wallet/test
...
b30fb42 test: Rename wallet.dat to wallet_test.dat (Wladimir J. van der Laan)
a25a4f5 wallet_ismine.h → script/ismine.h (Wladimir J. van der Laan)
f4eae2d test: Create test fixture for wallet (Wladimir J. van der Laan)
de39c95 test: move accounting_tests and rpc_wallet_tests to wallet/test (Wladimir J. van der Laan)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
4f5bb798e7
Merge #7827 : Speed up getchaintips.
...
87049e8 Speed up getchaintips. (mrbandrews)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
1b17e94ee6
Merge #7900 : fix spelling mistake
...
3107c47 fix spelling mistake (Chris Moore)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
96f9a7c3eb
Merge #7897 : add missing newline
...
dc0693f add missing newline (Chris Moore)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
cfb8b82dc3
Merge #7848 : Divergence between 32- and 64-bit when hashing >4GB affects gettxoutsetinfo
...
28b400f doc: update release-notes for `gettxoutsetinfo` change (Wladimir J. van der Laan)
76212bb rpc: make sure `gettxoutsetinfo` hash has txids (Wladimir J. van der Laan)
9ad1a51 crypto: bytes counts are 64 bit (Wladimir J. van der Laan)
2017-12-20 17:25:03 +01:00
Wladimir J. van der Laan
6c7d133801
Merge #7518 : Add multiple options to fundrawtransaction
...
f2d0944 Add lockUnspents option to fundrawtransaction (João Barbosa)
af4fe7f Add change options to fundrawtransaction (João Barbosa)
41e835d Add strict flag to RPCTypeCheckObj (João Barbosa)
2017-12-20 17:25:02 +01:00
Wladimir J. van der Laan
24f8c248f5
Merge #7856 : Only send one GetAddr response per connection.
...
66b0724 Only send one GetAddr response per connection. (Gregory Maxwell)
2017-12-20 17:25:02 +01:00
Alexander Block
d532f22d3b
Use BIP32_EXTKEY_SIZE instead of fixed constant
...
This was missed in previous backports.
2017-12-20 17:25:02 +01:00
Wladimir J. van der Laan
7080c27dd6
Merge #7878 : [test] bctest.py: Revert faa41ee
...
fa7abe0 [test] bctest.py: Revert faa41ee (MarcoFalke)
2017-12-20 17:25:02 +01:00
Wladimir J. van der Laan
ac53190bfe
Add missing changes from Bitcoin #7853
...
Missed due to conflict resolution in out-of-order backports
2017-12-20 17:24:57 +01:00
Wladimir J. van der Laan
c176f6c5b5
Merge #7812 : Tiny refactor of IsRBFOptIn
, avoid exception
...
4f7c959 Refactor IsRBFOptIn, avoid exception (Jonas Schnelli)
2017-12-20 14:58:27 +01:00
Wladimir J. van der Laan
f1f3fa327a
Merge #7846 : Clean up lockorder data of destroyed mutexes
...
5eeb913 Clean up lockorder data of destroyed mutexes (Pieter Wuille)
2017-12-20 14:58:27 +01:00
Wladimir J. van der Laan
116b14b5f0
Merge #7849 : tests: add varints_bitpatterns test
...
4521f00 tests: add varints_bitpatterns test (Wladimir J. van der Laan)
2017-12-20 14:58:27 +01:00
Wladimir J. van der Laan
cc3a06bf53
Merge #7863 : getblockchaininfo: make bip9_softforks an object, not an array.
...
d12760b rpc-tests: handle KeyError nicely in test_framework.py (Rusty Russell)
85c807c getblockchaininfo: make bip9_softforks an object, not an array. (Rusty Russell)
2017-12-20 14:58:27 +01:00
Wladimir J. van der Laan
20cb9aa21d
Merge #7796 : [amount] Add support for negative fee rates
...
facf5a4 [amount] tests: Fix off-by-one mistake (MarcoFalke)
fa2da2c [amount] Add support for negative fee rates (MarcoFalke)
11114a6 [amount] test negative fee rates and full constructor (MarcoFalke)
2017-12-20 14:58:27 +01:00
Pieter Wuille
d983f1d785
Merge #7828 : Trivial: Globals: Explicitly pass const CChainParams& to ProcessMessage()
...
bf477bc Trivial: Globals: Explicitly pass const CChainParams& to ProcessMessage() (Jorge Timón)
2017-12-20 14:58:27 +01:00
Wladimir J. van der Laan
2a7971010d
Merge #7786 : Doc: Update isStandardTx comment
...
03c77fd Doc: Update isStandardTx comment (Matthew English)
2017-12-20 14:45:12 +01:00
Wladimir J. van der Laan
b2d659f199
Merge #7570 : Net: Add IPv6 Link-Local Address Support
...
eda3d92 Net: Add IPv6 Link-Local Address Support (mruddy)
2017-12-20 14:45:12 +01:00
Wladimir J. van der Laan
738e1c51c0
Merge #7793 : [doxygen] Fix member comments
...
fada0c4 [doc] Fix doxygen comments for members (MarcoFalke)
2017-12-20 14:45:12 +01:00
Alexander Block
cd9c6994c2
Implement named devnets ( #1791 )
...
* Initial devnet
* Move genesis block adding into its own method
* Introduce -allowprivatenet to lift limitation on RFC1918 addresses
Normally, RFC1918 (192.168.x.x/10.x.x.x/...) addresses are not allowed
to be relayed. Also, masternodes won't start when the address is considered
invalid.
This is needed to test local devnet or regtest based networks.
* Lift the requirement of minimum MN age for regtest/devnet
* Implement named devnets
This allows the creation of multiple independent devnets. Each one is
identified by a name which is hardened into a "devnet genesis" block,
which is automatically positioned at height 1. Validation rules will
ensure that a node from devnet=test1 never be able to accept blocks
from devnet=test2. This is done by checking the expected devnet genesis
block.
The genesis block of the devnet is the same as the one from regtest. This
starts the devnet with a very low difficulty, allowing us to fill up
needed balances for masternodes very fast.
Also, the devnet name is put into the sub-version of the VERSION message.
If a node connects to the wrong network, it will immediately be disconnected.
* Allow to select multiple addresses from the same group in devnet/regtest
The selection code normally only allows to select addresses from the same
group (e.g. 192.168.x.x) once. This results in connecting to only a single
node in devnet/regtest.
* Show the devnet name in the title bar and on the loading screen
* Add AllowMultipleAddressesFromGroup to chainparams and use it in net.cpp
* Remove unused/unneeded scripts from devnet geneses creation
1. OP_RETURN not needed in input script of devnet genesis
2. genesisOutputScript was unused
* Fix copy/paste error in -allowprivatenet description
* Improve -devnet parameter error handling
- Only allow one of -devnet, -regtest or -testnet
- Only allow -devnet=name to be specified once
* Use different datadir for each devnet
* Fix `devnet-devnet` issue
* Fix devnet splashscreen (should use testnet img)
* Avoid passing devNetName around (most of the time)
* Remove nMaxTipAge from CDevNetParams
Not present anymore after rebase on develop
2017-12-20 14:45:01 +03:00
Alexander Block
e5b82075ac
Fix no-wallet build after backports refactored RPCs
2017-12-20 08:39:44 +01:00
Alexander Block
f235b6a6ac
Apply review suggestions/fixes
2017-12-20 07:51:20 +01:00
Wladimir J. van der Laan
6a515e5e20
Merge #7788 : Use relative paths instead of absolute paths in protoc calls
...
0087f26 Use relative paths instead of absolute paths (Pavel Janík)
2017-12-19 13:42:36 +01:00
Wladimir J. van der Laan
e7d9ffa5d7
Merge #7774 : RPC: add versionHex in getblock and getblockheader JSON results
...
92107d5 RPC: add versionHex in getblock and getblockheader JSON results; expand data in getblockchaininfo bip9_softforks field. (mruddy)
2017-12-19 13:42:36 +01:00
Wladimir J. van der Laan
7ba8612b58
Merge #7797 : RPC: fix generatetoaddress failing to parse address
...
60361ca RPC: fix generatetoaddress failing to parse address and add unit test (mruddy)
2017-12-19 13:42:36 +01:00
Alexander Block
9dbda86cb1
HDWallet error/warning message fixes
2017-12-19 13:42:36 +01:00
Wladimir J. van der Laan
298224b3b7
Merge #7691 : [Wallet] refactor wallet/init interaction
...
25340b7 [Wallet] refactor wallet/init interaction (Jonas Schnelli)
2017-12-19 13:42:36 +01:00
Wladimir J. van der Laan
21b23d1ec1
Merge #7785 : Trivial: Fix typo: Optimizaton -> Optimization [skip ci]
...
a22bde9 Fix typo: Optimizaton -> Optimization (paveljanik)
2017-12-19 13:42:36 +01:00
Wladimir J. van der Laan
0956f3d67c
Merge #7763 : Put hex-encoded version in UpdateTip
...
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)
2017-12-19 13:42:36 +01:00
Wladimir J. van der Laan
644240157a
Merge #7766 : rpc: Register calls where they are defined
...
fb8a8cf rpc: Register calls where they are defined (Wladimir J. van der Laan)
2017-12-19 13:42:35 +01:00
Wladimir J. van der Laan
18da34e295
Merge #7761 : [Qt] remove trailing output-index from transaction-id
...
7d5e31a [Qt] remove trailing output-index from transaction-id (Jonas Schnelli)
2017-12-19 13:18:30 +01:00
Wladimir J. van der Laan
1c84417780
Merge #7573 : P2P: add maxtimeadjustment command line option
...
e1523ce P2P: add maxtimeadjustment command line option (mruddy)
2017-12-19 13:18:30 +01:00
Wladimir J. van der Laan
a9a209f586
Merge #7723 : build: python 3 compatibility
...
18f05c7 build: python 3 compatibility (Wladimir J. van der Laan)
2017-12-19 13:18:30 +01:00
Alexander Block
a309bf372e
Clear setInternalKeyPool and setExternalKeyPool instead of setKeyPool
...
Due to out of order backporting this was missed in the past
2017-12-19 13:18:30 +01:00
Wladimir J. van der Laan
e2fefa539d
Merge #7558 : [RPC] Add import/removeprunedfunds rpc call
...
f1bb13c Added companion removeprunedfunds call. (instagibbs)
7eb7029 Add importprunedfunds rpc call (instagibbs)
2017-12-19 13:18:30 +01:00
Wladimir J. van der Laan
ca33635ef7
Merge #7742 : [Wallet][RPC] add missing abandon status documentation
...
cef8bdf [Wallet][RPC] add missing abandon status documentation (Jonas Schnelli)
2017-12-19 13:18:30 +01:00
Wladimir J. van der Laan
a4911c383b
Merge #7646 : Fix lockunspent help message
...
df9e923 Fix lockunspents help message (João Barbosa)
2017-12-19 13:18:30 +01:00
Wladimir J. van der Laan
f933c67266
Merge #7715 : Fix calculation of balances and available coins.
...
68d4282 Fix calculation of balances and available coins. (Alex Morcos)
2017-12-19 13:18:30 +01:00