Commit Graph

6954 Commits

Author SHA1 Message Date
Evan Duffield
37f55a3181 Refactored masternode payments system
- Replaced coinbase cache in favor of using the masternode payments voting system only
- Syncing masternode payments now supports up to the syncing the entire payment list
2015-07-20 15:09:42 -07:00
UdjinM6
8198291c7b Force sync progress:
If it's already more then MASTERNODE_SYNC_TIMEOUT seconds passed since we asked
and we still have nothing, assume there is nothing to sync but give it another
MASTERNODE_SYNC_TIMEOUT seconds until we move further
2015-07-20 22:33:18 +03:00
Evan Duffield
d193cc2d91 Clean up broadcast list when nodes are removed 2015-07-20 12:20:15 -07:00
Evan Duffield
2d745eb539 Don't sync sporks in regtest, fix segfault
- segfault caused by:
-    fRequireEnabled = (fRequireEnabled && pmn->IsEnabled()) || !fRequireEnabled;
-    if(pmn != NULL && fRequireEnabled && pmn->protocolVersion >= masternodePayments.GetMinMasternodePaymentsProto())
2015-07-20 11:56:02 -07:00
crowning-
52b930329d UI: fixed width of wallet-repair-buttons for longer locales 2015-07-20 20:52:49 +02:00
Evan Duffield
f36e4251ab mnb/mnp debugging 2015-07-20 11:43:10 -07:00
evan82
aa996b2615 Merge pull request #446 from UdjinM6/v0.12.0.x_fix_mnb_ping_acceptance
V0.12.0.x fix mnb ping acceptance
2015-07-20 11:21:15 -07:00
UdjinM6
cc26cff893 do not require active MN on ping check from UpdateFromNewBroadcast 2015-07-20 20:46:22 +03:00
evan82
a683078867 Merge pull request #445 from crowning-/UI_Enhancements
UI: allow "," in "Min amount" field of Transaction-View
2015-07-20 10:45:37 -07:00
Evan Duffield
77af4fb6ad MNP ping changes
- Ping every 5 minutes
- Nodes will propagate pings every 10 minutes
2015-07-20 10:44:27 -07:00
crowning-
fb5f80a06a UI: allow "," in "Min amount" field of Transaction-View 2015-07-20 18:28:49 +02:00
Wladimir J. van der Laan
ae52a7ffd1
Fix warning introduced by #6412
SOCKET are defined as unsigned integers, thus always >=0.

Rebased-From: 89289d875d
2015-07-20 17:30:17 +02:00
Pieter Wuille
0739e6e57a
Test whether created sockets are select()able
Conflicts:
	src/net.cpp

Github-Pull: #6412
Rebased-From: d422f9b1fd
2015-07-20 17:29:44 +02:00
UdjinM6
753297ea99 drop -masternodeminprotocol/nMasternodeMinProtocol, use masternodePayments.GetMinMasternodePaymentsProto() 2015-07-20 08:03:36 +03:00
UdjinM6
5f9c676e05 fix condition for a recent block in mn sync 2015-07-20 04:54:03 +03:00
UdjinM6
b1f19c7e82 process checks we can without waiting for full sync 2015-07-20 04:54:02 +03:00
UdjinM6
4bcd548b62 slightly refactor 2015-07-20 04:54:02 +03:00
UdjinM6
86c869137f fixes for sync 2015-07-20 04:54:02 +03:00
UdjinM6
dba572ac96 use specific protocols 2015-07-20 04:54:02 +03:00
Evan Duffield
e6327e5546 Disable coinbase payee cache 2015-07-19 17:06:52 -07:00
Evan Duffield
57df98b38a Force chain reprocess on load for coinbase-payee index 2015-07-19 15:40:40 -07:00
Evan Duffield
e1279ebf1d Reprocess best chain for coinbase payee on each block 2015-07-19 11:19:11 -07:00
Evan Duffield
60f7428585 Disabled coinpayee cleanup 2015-07-19 10:56:45 -07:00
Evan Duffield
9668befdf4 Dont ask for mnb of known masternodes 2015-07-19 09:38:23 -07:00
Evan Duffield
c95111476c vesion bump 2015-07-19 08:51:02 -07:00
Evan Duffield
898fbcae02 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-19 08:50:01 -07:00
Evan Duffield
9c34930680 Disable nDos on early ping / sync regtest changes 2015-07-19 08:49:46 -07:00
Evan Duffield
143c80789c rebuild index when switching chains 2015-07-19 06:45:35 -07:00
Evan Duffield
2e6eb9f2b6 incremental update of coinbase cache 2015-07-19 06:28:23 -07:00
crowning-
19d698529e UI: Persist Darksend+InstantX settings (Cut'n'paste error fixed) 2015-07-19 14:42:38 +02:00
crowning-
c8c83af2f5 UI: Persist Darksend+InstantX settings and default to Darksend=false on first start (revert screen-size change) 2015-07-19 14:29:18 +02:00
crowning-
63c8ae1516 UI: Persist Darksend+InstantX settings and default to Darksend=false on first start 2015-07-19 14:25:55 +02:00
Evan Duffield
9a4914e6c1 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-18 12:52:23 -07:00
Evan Duffield
e82e5339f9 Better NewBlock sync check 2015-07-18 12:52:12 -07:00
evan82
e2257c844b Merge pull request #440 from UdjinM6/v0.12.0.x_rpc_masternode
V0.12.0.x few small masternode rpc fixes
2015-07-18 12:34:53 -07:00
Evan Duffield
841c7c270b version/proto bump 2015-07-18 12:29:19 -07:00
Evan Duffield
7aa9676118 Only check vote sigs once / payee cache update on newblock 2015-07-18 12:24:06 -07:00
UdjinM6
27dd4ccf06 move only 2015-07-18 22:17:17 +03:00
UdjinM6
a3dfd86058 Code cleanups for masternode rpc
- drop boost/lexical_cast
- drop c_str() where applicable
- slightly prettify descriptions and some output
2015-07-18 21:20:22 +03:00
UdjinM6
aa96d701af tabs to spaces 2015-07-18 20:40:19 +03:00
Evan Duffield
90f508c67e Pay masternodes when no valid budget 2015-07-18 08:53:40 -07:00
Evan Duffield
956d85c59b Change variable naming for rpc commands
- Added MonthlyPayment and TotalPayment
2015-07-18 08:48:44 -07:00
Evan Duffield
637805b2de Require 7 confirmations for finalized budget 2015-07-18 07:49:39 -07:00
Evan Duffield
853863ae86 Only check budget block payees after sync is complete 2015-07-18 06:46:54 -07:00
Evan Duffield
f9e2b18e57 version bump 2015-07-17 21:38:56 -07:00
Evan Duffield
916deaa398 Small syncing improvement 2015-07-17 21:38:15 -07:00
evan82
494afeef50 Merge pull request #439 from UdjinM6/v0.12.0.x_revert_lower_fee
V0.12.0.x revert attempts to lower fee
2015-07-17 20:15:04 -07:00
evan82
45cd565f6c Merge pull request #438 from UdjinM6/v0.12.0.x_register_MN
V0.12.0.x more checks on MN register (start-many/alias)
2015-07-17 20:14:49 -07:00
UdjinM6
990e32f3c0 revert all changes regarding attempts to lower fee 2015-07-18 03:35:59 +03:00
UdjinM6
bf1ec73357 more checks on MN register 2015-07-18 03:10:47 +03:00
Evan Duffield
59024b1b46 Resync on sleep/wake or failure 2015-07-17 16:49:41 -07:00
evan82
d9f3102313 Merge pull request #435 from UdjinM6/v0.12.0.x_ref_rpc_budget
V0.12.0.x few rpc budget fixes
2015-07-17 11:10:39 -07:00
evan82
a8e79ecd16 Merge pull request #434 from UdjinM6/v0.12.0.x_fix_fees
V0.12.0.x Fix fees
2015-07-17 11:09:24 -07:00
evan82
8ec3b473c1 Merge pull request #432 from UdjinM6/v0.12.0.x_ref_mn_statuses
V0.12.0.x Slightly refactor masternode statuses
2015-07-17 11:09:00 -07:00
Evan Duffield
d5c4f3bea4 Only ask for missing masternodes/budget items after sync is complete 2015-07-17 11:03:49 -07:00
evan82
f9ada02a7d Merge pull request #433 from UdjinM6/v0.12.0.x_ref_budget
V0.12.0.x Budget module refactor
2015-07-17 10:29:59 -07:00
UdjinM6
33ee068d6a Slightly refactor masternode statuses:
- better names (MASTERNODE_INITIAL was defined twice before that)
- move to proper header
2015-07-17 20:01:54 +03:00
UdjinM6
1282f676e5 Fixes for budget rpc
- readability
- drop c_str()
- drop boost/lexical_cast
- ValueFromAmount for money
- fValid as bool
- fix/simplify descriptions
- more info on vote-many
- feedback on mnbudget vote
2015-07-17 19:28:25 +03:00
UdjinM6
31e703dfcd Fix fees
ref https://dashtalk.org/threads/v12-testing-thread.5484/page-62#post-59368
2015-07-17 18:33:15 +03:00
UdjinM6
b84bf76324 Budget module refactor
- readability (names / spaces / simplify constructions / etc)
- proper types (int for block height, CAmount for money)
- prettify log output / drop c_str() there
- read budgets on dump before writing (safety)
- microoptimization (++it)
- sort proposals by Yeas
- sort finalized budgets by votes
- fix few small bugs
2015-07-17 18:07:07 +03:00
Evan Duffield
b6001065ae Set fValid=true when receiving new votes 2015-07-17 07:40:26 -07:00
Evan Duffield
d60f3f6984 Added more information to getvotes 2015-07-17 07:38:35 -07:00
UdjinM6
91eda7e21c Few sync improvements:
- do not call Added....() inside CMasternodeSync::Process() - that was "faking" sync process
- unify "RequestedMasternodeAttempt <= ..." logic and define MASTERNODE_SYNC_TIMEOUT
- add missing masternodeSync.AddedMasternodeList() to CMasternodeMan::ProcessMessage()
- fix "include"s
- don't check vecMasternodesUsed while not synced
2015-07-17 13:08:15 +03:00
Cory Fields
7e66e9c97b
openssl: avoid config file load/race
Rebased-From: d4b1d5a8ba
Github-Pull: #6438
2015-07-17 09:16:57 +02:00
Evan Duffield
7101c951f8 Budget Improvements
- Client bump
- Improved syncing logic (sholud stop hanging issues)
- New spork for turning on super blocks
- Fixed issue with sending old/invalid finalized budgets
- Fixed issue with syncing clients and lack of confirmations with budget items (for IX)
2015-07-16 20:03:42 -07:00
Evan Duffield
ac488262c2 version bump 2015-07-16 12:13:42 -07:00
Evan Duffield
e5f37b8c98 New Spork : Reconsider X Blocks
- This allows us to fix forks remotely without anyone having to reindex. It remains trustless, because all nodes will simply find the longest chain.
2015-07-16 11:06:45 -07:00
Evan Duffield
017217f423 Added IsTransactionValid for finalized budgets 2015-07-16 10:47:51 -07:00
Evan Duffield
fc54241441 Default txindex to true 2015-07-16 07:34:40 -07:00
Evan Duffield
3c8b335594 Force txindex when a Mastenode 2015-07-16 03:00:16 -07:00
Evan Duffield
e65a1edce3 version / proto bump 2015-07-16 02:43:53 -07:00
Evan Duffield
f139dbbc74 Fixed prepare -- shouldn't check collateral 2015-07-15 15:56:40 -07:00
Evan Duffield
ffed6dc948 Added CBudgetManager::ToString 2015-07-15 14:21:21 -07:00
Evan Duffield
21769085ec Test feeTX in IsValid 2015-07-15 07:18:03 -07:00
Evan Duffield
db080fec22 version bump 2015-07-14 19:49:01 -07:00
Evan Duffield
6e0a468701 Highly improved syncing process 2015-07-14 19:48:02 -07:00
Evan Duffield
9e9e01b5f6 Fixed GetBudget 2015-07-14 16:06:00 -07:00
Evan Duffield
a4e3031db1 Refactored CleanAndRemove Proposals 2015-07-14 15:52:07 -07:00
Evan Duffield
50d1b827eb Fixed proposal fee IX confirmations 2015-07-14 12:52:46 -07:00
Evan Duffield
30ea44322e Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-14 08:04:18 -07:00
Evan Duffield
c2d4b553c5 version bump 2015-07-14 08:04:07 -07:00
evan82
eb7ca6fdef Merge pull request #430 from UdjinM6/v0.12.0.x_mergebtc
V0.12.0.x merge latest fixes from bitcoin 10.0.2
2015-07-14 07:55:38 -07:00
Evan Duffield
d228b4bf47 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-14 07:55:07 -07:00
Evan Duffield
665a93cd4f Merge branch 'v0.12.0.x_lower_mn_reuse' of https://github.com/UdjinM6/dash into UdjinM6-v0.12.0.x_lower_mn_reuse 2015-07-14 07:44:22 -07:00
evan82
a0a4940097 Merge pull request #428 from UdjinM6/v0.12.0.x_fix_IsBudgetCollateralValid_log
V0.12.0.x Fix CBudgetProposalBroadcast::IsBudgetCollateralValid log output / strError
2015-07-14 07:43:08 -07:00
evan82
eb9aa2cb87 Merge pull request #427 from UdjinM6/v0.12.0.x_change_sync_activemn_start
V0.12.0.x Start all DS, mnodeman, IX related checks and activate mn only after sync is over
2015-07-14 07:41:57 -07:00
evan82
d98a6fae23 Merge pull request #426 from UdjinM6/v0.12.0.x_mnb_mnp
V0.12.0.x major (incompatible) masternode broadcast/ping changes
2015-07-14 07:41:09 -07:00
Evan Duffield
e57f2d4003 Check IsValid when preparing fee 2015-07-14 07:05:33 -07:00
Suhas Daftuar
c2ffbe5bdd Ignore getheaders requests when not synced.
Rebased-From: a1ba0778dd
Github-Pull: #6172
2015-07-14 13:19:47 +03:00
Alex Morcos
09a4cb65fc Fix removing of orphan transactions
We don't want to erase orphans that still have missing inputs, they should still be tracked as orphans.  Also, the transaction thats being accepted can't be an orphan otherwise it would have previously been accepted, so doesn't need to be added to the erase queue.

Github-Pull: #5985
Rebased-From: 14d4eef799
2015-07-14 13:19:47 +03:00
Wladimir J. van der Laan
850dcb9334 Add option -alerts to opt out of alert system
Make it possible to opt-out of the centralized alert system by providing
an option `-noalerts` or `-alerts=0`. The default remains unchanged.

This is a gentler form of #6260, in which I went a bit overboard by
removing the alert system completely.

I intend to add this to the GUI options in another pull after this.

Conflicts:
	src/init.cpp
	src/main.cpp

Github-Pull: #6274
Rebased-From: 02a6702a82
2015-07-14 13:19:09 +03:00
Tom Harding
84b483e3c3 Fix getbalance *
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.

Github-Pull: #6276
Rebased-From: 7d6a85ab5b
Rebased-By: @trasher-
2015-07-14 13:19:09 +03:00
Wladimir J. van der Laan
c709b86a5d json: fail read_string if string contains trailing garbage
Change `read_string` to fail when not the entire input has been
consumed. This avoids unexpected, even dangerous behavior (fixes #6223).

The new JSON parser adapted in #6121 also solves this problem so in
master this is a temporary fix, but should be backported to older releases.

Also adds tests for the new behavior.

Github-Pull: #6226
Rebased-From: 4e157fc60d
2015-07-14 13:19:08 +03:00
Luke Dashjr
2fc7256f72 Remove P2SH coinbase flag, no longer interesting
Github-Pull: #6203
Rebased-From: d449772cf6
2015-07-14 13:19:08 +03:00
Wladimir J. van der Laan
d2ccd08ef1 Parameter interaction: disable upnp if -proxy set
To protect privacy, do not use UPNP when a proxy is set. The user may
still specify -listen=1 to listen locally (for a hidden service), so
don't rely on this happening through -listen.

Fixes #2927.

Conflicts:
	src/init.cpp

Rebased-From: 8c35b6f3be
Github-Pull: #6153
2015-07-14 13:19:08 +03:00
Wladimir J. van der Laan
07053c3ada Fix two problems in CSubNet parsing
Fix two CSubNet constructor problems:

- The use of `/x` where 8 does not divide x was broken, due to a
  bit-order issue

- The use of e.g. `1.2.3.4/24` where the netmasked bits in the network
  are not 0 was broken. Fix this by explicitly normalizing the netwok
  according to the bitmask.

Also add tests for these cases.

Fixes #6179. Thanks to @jonasschnelli for reporting and initial fix.

Rebased-From: b45c50ce51
Github-Pull: #6186
2015-07-14 13:19:07 +03:00
Wladimir J. van der Laan
bd3ed5c280 Simplify code for CSubnet
Simplify the code by using CAddress.ip directly, instead of the reversed
GetByte() semantics.

Rebased-From: 19e8d7be42
Github-Pull: #6186
2015-07-14 13:19:07 +03:00
UdjinM6
59271beabd Fix CBudgetProposalBroadcast::IsBudgetCollateralValid log output / strError 2015-07-14 11:32:49 +03:00
UdjinM6
6651abe343 lower mn reuse rate 2015-07-14 10:38:04 +03:00
UdjinM6
f2c5653379 Start all ds, mnodeman, ix related checks and activate mn only after sync is over 2015-07-14 09:16:19 +03:00
UdjinM6
3ef2cec49d proto bump 2015-07-14 08:59:08 +03:00
UdjinM6
26fed43603 Major masternode broadcast/ping changes (incompatible with prev version, proto bump required):
- Do not rely on local lastTimeSeen and requested fRequested anymore. Use last know (signed) ping instead and base all logic on that. Should reduce mn list difference between
 nodes.
- Rework CActiveMasternode accordingly along with states, errorMessages, rpc etc.
- Clean some related code, move parts from public to private
- drop c_str in LogPrintf that were related to this functionality (todo: drop it for LogPrintf everywhere else)
2015-07-14 08:50:30 +03:00
Evan Duffield
bee6941195 Fixed Propagation Of Budgets / Proto Bump 2015-07-13 20:03:08 -07:00
Evan Duffield
6fa0d23714 Commit collateral transaction correctly for finalized budget 2015-07-13 06:34:54 -07:00
Evan Duffield
40a14cb802 version bump / proto bump 2015-07-12 16:39:37 -07:00
Evan Duffield
acf09d1bc1 Collateral is now checked for age 2015-07-12 16:37:55 -07:00
Evan Duffield
8e7c4e7491 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-12 14:04:00 -07:00
Evan Duffield
304ab6c7ab Various improvements to the proposal system
- Proposal scripts are now checked correctly
- Fee transactions are created correctly for IX and non-IX types
2015-07-12 14:02:39 -07:00
crowning-
9b170483b7 Minor Options-Dialog enhancements 2015-07-12 20:23:38 +02:00
crowning-
3f19365d2a Minor Coincontrol-Dialog enhancements 2015-07-12 20:04:52 +02:00
evan82
82bb9617ee Merge pull request #424 from UdjinM6/v0.12.0.x_fix_progress
V0.12.0.x calculate ds progress from 3 parts
2015-07-12 10:48:05 -07:00
evan82
bacd3e456f Merge pull request #423 from crowning-/UI_Enhancements
De-selecting all transactions resets computed sum to 0 now.
2015-07-12 10:47:52 -07:00
Evan Duffield
2885f9e6ca protocol bump / version bump 2015-07-12 10:47:28 -07:00
Evan Duffield
6b7ab34d30 Budget collateral changes
- Use OP_RETURN >> BudgetHash, with an output the size of BUDGET_FEE_TX. This will allow us to burn coins, that will be recreated and avoid hitting the "insane fee" checks
2015-07-12 10:38:32 -07:00
Evan Duffield
0b3ef3c9fe Various fixes
- Proposal submitting now works properly
- Syncing proposals now works properly
- Finalized budgets are now created correctly
2015-07-12 10:34:21 -07:00
UdjinM6
e7b00b8b7e calculate ds progress from 3 parts 2015-07-12 19:18:03 +03:00
crowning-
604914c15e De-selecting all transactions resets computed sum to 0 now. 2015-07-12 18:00:48 +02:00
Evan Duffield
0a02fa00bb removed vote from prepare/submit and fixed some help strings 2015-07-12 08:09:06 -07:00
evan82
635a5fbf97 Merge pull request #422 from crowning-/v0.12.0.x
Fix Darksend completion UI
2015-07-12 07:46:23 -07:00
Evan Duffield
a59c5d9edd fixed issues with rpc commands 2015-07-12 07:45:58 -07:00
crowning-
60358c28e2 Fix Darksend completion UI 2015-07-12 12:57:59 +02:00
UdjinM6
2dbf8290f7 Few fixes for mnbudget rpc
- do not ask for vote on prepare and submit
- fix bug found by @thelazier
- fix command descriptions to avoid confusions
- tiny refactoring for tx/ix
2015-07-12 09:39:22 +03:00
Evan Duffield
640e721487 fixed spork show 2015-07-11 16:17:03 -07:00
Evan Duffield
03d6f3c140 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-11 13:26:22 -07:00
Evan Duffield
c701839a43 Proposal Security Overhaul
Submissions to the network now require a fee to be paid to the network (mining fee) using a special transaction with a OP_RETURN && ProposalHash in one of the outputs. This allows the network to filter spam quickly, while also allowing anyone to submit a proposal to the network.

To implement these changes we've introduced a few new commands:

mnbudget prepare PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN [USE_IX(TRUE|FALSE)]
- To create the special transaction

mnbudget submit PROPOSAL-NAME URL PAYMENT_COUNT BLOCK_START DASH_ADDRESS DASH_AMOUNT YES|NO|ABSTAIN FEE_TX
- After the transaction is accepted by the network and has 3 confirmations, you can submit the transaction to the network here

mnbudget show
- Get the proposal hash from here

mnbudget vote PROPOSAL-HASH YES|NO|ABSTAIN
- You can now simply vote by hash using this command
2015-07-11 13:20:12 -07:00
UdjinM6
1f978f561c Temporary unlock MN coins locked by -mnconflock on masternode start-alias/many and immediately lock them back right after finding all available coins 2015-07-10 19:53:51 +03:00
evan82
4a514b7e7c Merge pull request #420 from UdjinM6/v0.12.0.x_masternode.conf_err_verbose
V0.12.0.x make masternode.conf parsing more verbose on errors / translate strings
2015-07-10 09:18:37 -07:00
UdjinM6
7a09989195 make masternode.conf parsing more verbose on errors / translate strings 2015-07-10 19:08:50 +03:00
UdjinM6
d597653615 fix alternative units in send dialog 2015-07-09 06:54:30 +03:00
Evan Duffield
2d118769f0 version/proto bump 2015-07-08 10:27:26 -07:00
Evan Duffield
8a5ebeaa62 added spork for reseting budget 2015-07-08 10:25:47 -07:00
Evan Duffield
a351456c17 Fixed invalid saved budget.dat issue 2015-07-08 10:17:16 -07:00
Evan Duffield
91a0887a0d Fix active removal of proposals 2015-07-08 08:55:52 -07:00
Evan Duffield
a8f5472037 fixed compile error 2015-07-08 08:19:07 -07:00
evan82
246037abdb Merge pull request #415 from UdjinM6/v0.12.0.x_budgets_var_naming_logging
V0.12.0.x use proper naming for variables in masternode-budget
2015-07-08 07:35:20 -07:00
evan82
872ef7f9a9 Merge pull request #414 from UdjinM6/v0.12.0.x_fix_minmnpaymentsproto
V0.12.0.x fix min mnpayments proto usage
2015-07-08 07:20:31 -07:00
evan82
2a3b96e020 Merge pull request #411 from UdjinM6/v0.12.0.x_various_small_fixes
V0.12.0.x various small fixes
2015-07-08 07:19:41 -07:00
evan82
dea8f15668 Merge pull request #413 from UdjinM6/v0.12.0.x_relayinv
V0.12.0.x introduce RelayInv
2015-07-08 07:17:47 -07:00
evan82
69aced6378 Merge pull request #409 from UdjinM6/v0.12.0.x_fix_GetInputDarksendRounds
V0.12.0.x Fix GetInputDarksendRounds
2015-07-08 07:16:29 -07:00
evan82
87207fbc36 Merge pull request #410 from UdjinM6/v0.12.0.x_fix_progress
V0.12.0.x (Yet) another attempt to get DS progress displayed right
2015-07-08 07:15:39 -07:00
evan82
5914a24f47 Merge pull request #408 from crowning-/v0.12.0.x
satoshi(s) -> duff(s) in locales
2015-07-08 07:15:29 -07:00
evan82
ede21b01fd Merge pull request #407 from UdjinM6/v0.12.0.x_satoshi_duff_dash
V0.12.0.x satoshi(s) -> duff(s)  &  Satoshi:x.x.x -> Dash Core:x.x.x
2015-07-08 07:15:09 -07:00
evan82
1a3975eab0 Merge pull request #406 from UdjinM6/v0.12.0.x_safer_PrepareDarksendDenominate
v0.12.0.x Implement safer version of CWallet::PrepareDarksendDenominate
2015-07-08 07:14:36 -07:00
UdjinM6
2fdb5b01f7 use proper naming for variables in masternode-budget 2015-07-08 05:35:58 +03:00
UdjinM6
635778f0ab use spork dependent logic to get the right minimal proto everywhere MIN_MNPAYMENTS_PROTO_VERSION was used previously 2015-07-08 05:00:09 +03:00
UdjinM6
9cfdaffee5 introduce RelayInv 2015-07-08 04:31:10 +03:00
UdjinM6
d94967d958 small fixes 2015-07-07 15:47:22 +03:00
UdjinM6
a4520af056 (Yet) another attempt to get progress displayed right 2015-07-07 10:21:13 +03:00
UdjinM6
7eee9f15ec Fix GetInputDarksendRounds:
- show user and use in external calculations rounds that are calculated respecting current settings while use "real" rounds in internal calulation to store correct results in cache and easily provide user with updated info on settings change
- fix max real rounds limit (16)
2015-07-07 10:16:22 +03:00
crowning-
9c5bcff4cb satoshi(s) -> duff(s) in locales 2015-07-07 05:13:50 +02:00
UdjinM6
a8d230f80d satoshi(s) -> duff(s) & Satoshi:x.x.x -> Dash Core:x.x.x (both for user visible strings only) 2015-07-07 01:40:38 +03:00
evan82
10ad24226c Merge pull request #405 from UdjinM6/v0.12.0.x_prevent_ban_for_unknown_MN
V0.12.0.x Stop banning nodes for unknown masternodes while processing budget messages
2015-07-06 15:39:42 -07:00
evan82
10d8d3e979 Merge pull request #404 from crowning-/v0.12.0.x
Fixed warning from labelCoinControlChangeLabel
2015-07-06 15:32:30 -07:00
evan82
f6a6d1b4a3 Merge pull request #403 from crowning-/Digits
Configurable decimal digits
2015-07-06 15:32:14 -07:00
UdjinM6
05d93445a2 Implement safer version of CWallet::PrepareDarksendDenominate:
Make outputs by looping through denominations: try to add every needed denomination, repeat up to 5-10 times.
This way we can be pretty sure that it should have at least one of each needed denomination.
We also do not care about full amount as long as we have right denominations, just pass what we found.
2015-07-07 01:20:53 +03:00
Evan Duffield
5b98d9db05 fixed getinfo for 0-vote proposals 2015-07-06 15:06:09 -07:00
UdjinM6
e40de28900 Stop banning nodes for unknown masternodes while processing budget messages.
Also cleanup naming/logging a bit.
2015-07-07 00:00:00 +03:00
crowning-
cc494c6091 Fixed warning QLabel(0xb0049b8, name = "labelCoinControlChangeLabel") does not have a property named "padding" 2015-07-06 22:52:46 +02:00
Evan Duffield
6c6a280df8 Version bump / more fixes 2015-07-06 13:37:43 -07:00
Evan Duffield
05e126f853 Clear expired proposals / added mnbudget check 2015-07-06 13:23:09 -07:00
Evan Duffield
2e8a1dcb94 fixed GetVoteCommand 2015-07-06 12:53:49 -07:00
Evan Duffield
391cc398a4 show voting commands for proposals in mnbudget show 2015-07-06 11:36:13 -07:00
Evan Duffield
1af0fa5098 Only sync masternode assets after new block 2015-07-06 11:12:56 -07:00
Evan Duffield
5f3543efa5 merged 2015-07-06 10:52:09 -07:00
Evan Duffield
4596e7f336 Vastly improved proposal management implementation
-Syncing now happens in stages. Masternodes and Sporks, then Masternode winners, then proposals. Some of these require the masternode signatures, otherwise there are race conditions within the syncing process itself.
-Resigning - When a proposal is sent to the network initially it's signed by a masternode, if that masternode goes inactive the proposal becomes invalid. Resigning allows other masternodes to update proposal keep it valid with the coming and going of masternodes.
-Resigning compatibility - non masternodes will scan and flag proposals as invalid to accept updated owners.
-Invalid votes are now actively removed from the proposals when they go inactive
- Remove budgets with negative votes of more than 10% of network
- Only allow proposals into budget that have more than 10% of network support
- Faster removal of inactive masternodes
2015-07-06 10:46:58 -07:00
UdjinM6
b1d78b5200 Alternative digits implementation 2015-07-06 04:09:10 +03:00
crowning-
ee167ad2f3 Configurable decimal digits 2015-07-05 21:19:46 +02:00
UdjinM6
ce41645713 fix CFinalizedBudget::AutoCheck() crash 2015-07-05 10:37:52 +03:00
crowning-
c990c5a011 Wallet Window Title: minor changes 2015-07-05 03:11:58 +02:00
crowning-
860a895cf5 Merge remote-tracking branch 'upstream/v0.12.0.x' into v0.12.0.x 2015-07-05 03:11:45 +02:00
crowning-
252322997c User configurable Wallet Window Title 2015-07-05 02:27:20 +02:00
crowning-
36f65addc7 Fixed typo 2015-07-05 02:02:14 +02:00
Evan Duffield
edaf479063 Added CleanAndRemove for Proposal votes 2015-07-04 15:49:42 -07:00
Evan Duffield
2b949e08a8 Quicker masternode removal 2015-07-04 10:44:45 -07:00
Evan Duffield
b1360473b4 Budget changes
- Remove budgets with negative votes of more than 10% of network
- Only allow proposals into budget that have more than 10% of network support
2015-07-04 10:42:42 -07:00
Evan Duffield
7481a27fe4 Smarter algorithm for finding the nHeight for the last block 2015-07-04 08:28:55 -07:00
Evan Duffield
6fc05e7fa8 nHeight calculation for BlockValue checking 2015-07-04 07:50:43 -07:00
Evan Duffield
6834476573 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-04 07:28:53 -07:00
Evan Duffield
b04ffb923c Rebuild coinbase cache when needed 2015-07-04 07:27:20 -07:00
crowning-
27a2ceb287 Popup information on first mixing 2015-07-04 15:29:21 +02:00
crowning-
87e72e0331 Persist Date and Type filters in "Transactions" tab 2015-07-04 15:27:37 +02:00
Evan Duffield
b8d5a3ce6b Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-03 22:09:15 -07:00
Evan Duffield
ed799658a9 version bump 2015-07-03 22:09:04 -07:00
evan82
4c25051d98 Merge pull request #398 from UdjinM6/v0.12.0.x_overviewpage_unit
V0.12.0.x overviewpage unit (fix crash)
2015-07-03 22:07:59 -07:00
Evan Duffield
377770c6ec Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-03 22:05:57 -07:00
Evan Duffield
42d9a581a1 Smarter nHeight detection for masternode payments 2015-07-03 22:05:10 -07:00
UdjinM6
a33c569a1d Store current unit as a private member of OverviewPage object and use it instead of calling walletModel->getOptionsModel()->getDisplayUnit(). This should solve an issue when walletModel->getOptionsModel()->getDisplayUnit() fails on shutdown/restart even if (walletModel && walletModel->getOptionsModel()) is true. 2015-07-04 07:58:42 +03:00
Wladimir J. van der Laan
ead842d623 Remove assertion from ~LockedPageManager
This assertion will occur any time that the client quits without
shutting down properly due to an error condition. As the user will
report this error instead of the error that was the root cause, it is
better to remove it.
2015-07-04 05:15:10 +02:00
evan82
2536e85888 Merge pull request #395 from UdjinM6/v0.12.0.x_fix_DS_MN_crashes
V0.12.0.x fix ds mn crashes
2015-07-03 11:10:14 -07:00
evan82
703fbe816a Merge pull request #392 from crowning-/Wallet_Restart
Restart-wallet fix
2015-07-03 11:09:59 -07:00
Evan Duffield
6becaf0462 Added mnbudget projection and changed "show"
- Show now shows every proposal that is known, which seems to be the general expected behavior of the users
- Added "projection" for showing what will end up in the budget if it was finalized currently
2015-07-03 10:54:10 -07:00
Evan Duffield
151cb174f2 Disable autostart in regtest mode 2015-07-03 09:52:27 -07:00
crowning-
8ba0328b71 Only restart wallet 1x, no matter how often a user clicks on a restart-button 2015-07-03 07:55:45 +02:00
crowning-
3195e04d7d Merge remote-tracking branch 'upstream/v0.12.0.x' into Wallet_Restart 2015-07-03 07:55:29 +02:00
Evan Duffield
4420d563cb fixed proposal display functionality 2015-07-02 17:51:31 -07:00
UdjinM6
189e48328d fix 2 crashes 2015-07-03 01:56:43 +03:00
Evan Duffield
5f282c2692 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-07-02 15:34:29 -07:00
Evan Duffield
3bd8cc1e98 fixed bug with proposals 2015-07-02 15:34:11 -07:00
evan82
d39815db32 Merge pull request #394 from UdjinM6/v0.12.0.x_inv
V0.12.0.x inv related fixes
2015-07-02 11:02:04 -07:00
evan82
71e0ede0d4 Merge pull request #393 from UdjinM6/v0.12.0.x_lang80percentplus
V0.12.0.x update languages with 80%+ completition
2015-07-02 11:01:42 -07:00
Evan Duffield
5fdaf0bfc1 added checkpoint 2015-07-02 09:53:55 -07:00
Evan Duffield
13bd6a15eb version/proto bump 2015-07-02 09:45:28 -07:00
Evan Duffield
28052240a5 Improvements for syncing budget votes
- New orphan object and reprocessing logic
- Added some logic for asking peers for missing proposals and finalized budgets
2015-07-02 09:41:33 -07:00
Evan Duffield
d8a6057205 Fixed issues with budget syncing 2015-07-02 08:07:30 -07:00
UdjinM6
b66928043e Few inv related fixes:
- add missing strings and make inv strings a bit more consistent (imo)
- remove "unknown" types that were used to prevent errors thrown at user with old wallet,
  just log such errors in debug mode for "net" category. Should also make behaviour of functions
  relaing on CInv::IsKnownType() more adequate
  (and it doesn't make sense to warn users by throwing errors at them in such situations anyway I guess)
2015-07-02 04:28:45 +03:00
UdjinM6
2ed4c93b6d update languages with 80%+ completition 2015-07-02 03:53:33 +03:00
Evan Duffield
a89b0e705f Fixed syncing code for stuck clients 2015-07-01 16:46:03 -07:00
crowning-
4d758b9924 Restart-wallet fix 2015-07-02 00:12:11 +02:00
evan82
4b6d55b1b9 Merge pull request #391 from UdjinM6/v0.12.0.x_ds_on_overview
V0.12.0.x Various DS related fixes for overview page
2015-06-30 10:31:48 -07:00
UdjinM6
ca94f2f6d7 Various DS related fixes for overview page:
- streamline initialization logic for litemode/masternode/ds
- call updateDarksendProgress on setBalance
- format amountAndRounds for 0 balance same way as for normal balance (see c3febd20a8)
- use style='white-space:pre' to show long strings in tooltips correctly, adapt few strings
- small fixes (cleanup naming, notr, use static where possible and get rid of unneeded class members)
2015-06-30 19:01:51 +03:00
UdjinM6
69f482ec2e Execute "mogrify *.png" to fix "GUI: libpng warning: iCCP: known incorrect sRGB profile" 2015-06-30 05:42:12 +03:00
UdjinM6
e9eb2faeb6 new icon 2015-06-29 02:23:29 +03:00
Evan Duffield
bac2dc81a2 version bump 2015-06-28 14:49:16 -07:00
evan82
faf150d9d3 Merge pull request #388 from UdjinM6/v0.12.0.x_sum_tx
V0.12.0.x sum tx separator and negative value highlight
2015-06-28 14:01:05 -07:00
evan82
7fb910b74f Merge pull request #387 from UdjinM6/v0.12.0.x_compact_amountandrounds
V0.12.0.x compact AmountAndRounds
2015-06-28 14:00:55 -07:00
UdjinM6
c3febd20a8 Do not show decimals for "amounts and rounds" text but show usual way formatted numbers inside its tooltip 2015-06-28 17:27:24 +03:00
UdjinM6
9db667c240 always show separator for sum tx amount and highlight (red) negative amounts 2015-06-28 17:22:14 +03:00
UdjinM6
9bc6042c27 unlock inputs on DS failure 2015-06-28 17:07:44 +03:00
Evan Duffield
2b75faefee Various fixes improvements
- Implemented spork for only paying new nodes after a period of time on mainnet
- protocol bump
- fixed a few issues with sporks. Spork show now shows all sporks, instead of the changed ones. IsSporkActive now supports sporks set to 0 as on.
2015-06-25 12:59:11 -07:00
Evan Duffield
8a4c22ec9a fixed typo 2015-06-25 11:22:11 -07:00
Evan Duffield
5227451604 Merge branch 'v0.12.0.x' of https://github.com/darkcoin/darkcoin into v0.12.0.x 2015-06-25 11:09:19 -07:00
Evan Duffield
55dda32f34 Removed need for amounts in masternode winners protocol 2015-06-25 11:08:50 -07:00
evan82
558ac17318 Merge pull request #385 from UdjinM6/v0.12.0.x_translations
(WIP) V0.12.0.x translations
2015-06-25 08:31:51 -07:00
Evan Duffield
e3963ea71c Spork changes / improvements
- New Command "Spork Active" : Show which sporks report as active
- Cleaned up the spork code and fixed some bugs with defaults
2015-06-25 08:17:53 -07:00
UdjinM6
5e21166456 refresh en source/translations 2015-06-25 17:32:21 +03:00
UdjinM6
9d05c98110 fix strings 2015-06-25 17:32:12 +03:00
Evan Duffield
94493bee63 fixed compile issues 2015-06-24 12:42:01 -07:00
Evan Duffield
38e736ad22 bump version 2015-06-24 11:21:12 -07:00
evan82
e323df71c6 Merge pull request #383 from UdjinM6/v0.12.0.x_small_ds_code_cleanups
V0.12.0.x small ds code cleanups
2015-06-24 11:16:41 -07:00
evan82
479d1cfad4 Merge pull request #382 from UdjinM6/v0.12.0.x_move_ds_pool_status_out_of_overviewpage
V0.12.0.x move ds pool status out of overviewpage
2015-06-24 11:16:26 -07:00
evan82
39c03405fa Merge pull request #381 from UdjinM6/v0.12.0.x_fix_db_shutdown_crash
V0.12.0.x fix db shutdown crash
2015-06-24 11:15:50 -07:00
Evan Duffield
8d8f9fae48 Autostart masternode upon startup 2015-06-24 09:46:49 -07:00
Evan Duffield
fd8afcc91a added masternode status info 2015-06-24 09:41:03 -07:00
UdjinM6
b30f8b5fcb remove unused variable 2015-06-24 19:33:53 +03:00
UdjinM6
a4bb283367 slight optimizations/readability improvements for ds 2015-06-24 19:30:05 +03:00
UdjinM6
451a98732e remove unneeded "darkSendPool." in DS pool class functions 2015-06-24 19:25:43 +03:00
UdjinM6
60622b887d add missing MSG_ENTRIES_ADDED for proper ds status display 2015-06-24 19:23:22 +03:00
UdjinM6
0bfaefde92 move ds pool status out of overview page 2015-06-24 19:08:14 +03:00
UdjinM6
4a9e7dba84 fix db shutdown crash - adopt btc daf956b7b196769f8027026dd047e72412a9a039 2015-06-24 17:49:30 +03:00
Evan Duffield
cf53f2f897 protocol bump 2015-06-24 07:41:52 -07:00
Evan Duffield
71761f6317 Merge branch 'v0.12.0.x' of https://github.com/darkcoin/darkcoin into v0.12.0.x 2015-06-23 16:46:55 -07:00
Evan Duffield
f1b868f098 Removed PoSe due to consensus issues
- With nodes coming and going on the network, the network could come to different opinions about who should get paid next in line due to some nodes being flagged as failing a PoSe check. This will have to be fixed by introducing a blockchain based PoSe system, but that's out of the scope of this release. To fix the issues in the interrim, I'm removing PoSe checks for the time being.
2015-06-23 16:44:31 -07:00
UdjinM6
08a6803165 fixing all kind of typos etc 2015-06-23 23:44:20 +03:00
Evan Duffield
4afaa1d8cf Scan blocks if coinpayee cache is not present 2015-06-23 12:08:11 -07:00
Evan Duffield
3c01ffa444 fixed errors from merge 2015-06-23 10:59:14 -07:00
Evan Duffield
3eeb33e577 version / proto bump 2015-06-23 10:53:22 -07:00
Evan Duffield
43e6976695 merged 2015-06-23 10:53:12 -07:00
Evan Duffield
c72355335c Coinbase Payee Cache Implementation
- Masternode nLastPaid is removed and a new caching system that keeps the last 30 days of coinbase payees replaces it
- To deal with some significant attack vectors, the masternode donation feature was removed. The donation feature was added to support developement anyway, so this will be replaced by the budgeting code.
-  This code should allow the network to come to consensus about who should be paid pretty effectively
2015-06-23 10:48:03 -07:00
evan82
f12664166b Merge pull request #378 from UdjinM6/v0.12.0.x_ds_coincontrol
V0.12.0.x ds coincontrol
2015-06-23 10:12:26 -07:00
evan82
cdaaa297f6 Merge pull request #377 from UdjinM6/v0.12.0.x_dsee_mnb
V0.12.0.x refactor: dsee -> mnb
2015-06-23 10:11:55 -07:00
evan82
6aa49e5a70 Merge pull request #376 from UdjinM6/v0.12.0.x_fees
V0.12.0.x fees fixes
2015-06-23 10:11:20 -07:00
UdjinM6
5037c710de When DS inputs are selected in coincontrol:
- spend exactly these inputs
- allow to spend more than 0.1 as a fee (note: still will respect non-ds fee limits)
2015-06-23 18:47:05 +03:00
UdjinM6
a6a04cb5c1 refactor: dsee -> mnb 2015-06-23 18:40:08 +03:00
UdjinM6
154567bf5d refactor: allowFree -> ignoreFees 2015-06-23 18:24:20 +03:00
UdjinM6
db18ce0480 bump required version for fee_estimates.dat file 2015-06-23 18:22:39 +03:00
UdjinM6
159b3366b1 reject real insane fee instead of hardcoded 2015-06-23 18:19:45 +03:00
UdjinM6
f3e619a2d1 btc/kb -> dash/kb 2015-06-23 18:15:12 +03:00
UdjinM6
d35dab332a bump min fees 10x 2015-06-23 18:02:46 +03:00
UdjinM6
3e95f3b98c accept(verify) DS mixing txes ignoring fees 2015-06-23 07:12:24 +03:00
UdjinM6
9925e0a360 try to lower fee in CreateTransaction 2015-06-22 22:36:35 +03:00
evan82
511b11aa53 Merge pull request #374 from UdjinM6/v0.12.0.x_ds_reservekeys
V0.12.0.x deal with reservekeys in CreateDenominated and MakeCollaterals more accurate (+todo)
2015-06-22 12:25:27 -07:00
evan82
59097ed28d Merge pull request #373 from UdjinM6/v0.12.0.x_fix_PrepareDarksendDenominate
V0.12.0.x fix PrepareDarksendDenominate - loop instead of if
2015-06-22 11:35:29 -07:00
UdjinM6
d766b6b564 fix PrepareDarksendDenominate - loop instead of if 2015-06-22 21:10:46 +03:00
UdjinM6
02230c4263 deal with reservekeys in CreateDenominated and MakeCollaterals more accurate (+todo) 2015-06-22 20:59:27 +03:00
UdjinM6
a049348110 bump ix min proto 2015-06-22 20:51:28 +03:00
Evan Duffield
12863bb423 version bump 2015-06-22 08:47:24 -07:00
Evan Duffield
feaaf1e166 fixed bug with counting votes 2015-06-22 07:20:34 -07:00
Evan Duffield
12e5f8f4d4 added some debugging 2015-06-22 06:50:33 -07:00
Evan Duffield
dddc095856 changed enforcement strategy for mn payments 2015-06-21 10:06:25 -07:00
Evan Duffield
892212d407 version / min version bump 2015-06-21 09:32:32 -07:00
Evan Duffield
b8c842744d clear out old masternodes in CheckAndRemove 2015-06-21 06:54:07 -07:00
Evan Duffield
1cf09fae8e update protocol version 2015-06-20 19:03:06 -07:00
Evan Duffield
ca95ca2d95 fixed nDos for failure of mnp 2015-06-20 13:28:41 -07:00
Evan Duffield
06ac558fee version bump 2015-06-20 13:00:19 -07:00
Evan Duffield
049aae7c49 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-06-20 12:59:38 -07:00
Evan Duffield
947b79c8c5 Changed masternode broadcast/pinging logic
- Fixed a bug causing the broadcasts to be ignored in some situations
- Added some logic to rebroadcast new masternodes, so the rest of the network finds out about unknown nodes quickly
- should help masternode payments to work properly
2015-06-20 12:56:56 -07:00
UdjinM6
97c97f7e40 use v11-like AcceptToMemoryPool call in ProcessMessage(dstx/tx) 2015-06-20 05:33:15 +03:00
Evan Duffield
a0d8442835 added hybrid keys for masternode payment voting 2015-06-19 11:33:02 -07:00
Evan Duffield
b6f760ff90 Check before pulling payee 2015-06-19 09:14:48 -07:00
UdjinM6
58c0f150a4 fix dsc 2015-06-19 04:42:25 +03:00
evan82
3834e459d9 Merge pull request #364 from UdjinM6/v0.12.0.x_fix_mnping
V0.12.0.x fix mnping
2015-06-18 11:52:49 -07:00
UdjinM6
1e393d5b70 fix mnping 2015-06-18 21:41:01 +03:00
evan82
85815dcf29 Merge pull request #362 from snogcel/v0.12.0.x
Available Balance, Pending Label Fix
2015-06-18 10:38:52 -07:00
thelazier
639c67d354 Fix getblocktemplate not show payee from masternode winners.. 2015-06-18 16:40:22 +07:00
snogcel
5fed89fde4 Available Balance, Pending Label Fix 2015-06-17 21:37:30 -06:00
Evan Duffield
cc458007e3 update version 2015-06-17 17:10:42 -07:00
UdjinM6
91c7f66562 remove nLastPaid from CMasternodeBroadcast 2015-06-18 00:18:24 +03:00
UdjinM6
795ee119ec SecondsSincePayment (fix buffer overflow / change logic / move impl to cpp) 2015-06-17 23:03:09 +03:00
Evan Duffield
df77f56e11 Budget stability fixes
- Proposals must start on a budget block now
- Finalized budgets now enforce proposal start and end periods
- Other misc fixes
2015-06-16 10:04:35 -07:00
Evan Duffield
5c4dc3727b fixed issue with reindex and super blocks 2015-06-16 07:04:50 -07:00
Wladimir J. van der Laan
be6420407b
Add option -alerts to opt out of alert system
Make it possible to opt-out of the centralized alert system by providing
an option `-noalerts` or `-alerts=0`. The default remains unchanged.

This is a gentler form of #6260, in which I went a bit overboard by
removing the alert system completely.

I intend to add this to the GUI options in another pull after this.

Conflicts:
	src/init.cpp
	src/main.cpp

Github-Pull: #6274
Rebased-From: 02a6702a82
2015-06-15 10:17:56 +02:00
Tom Harding
0fd8464458
Fix getbalance *
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.

Github-Pull: #6276
Rebased-From: 7d6a85ab5b
Rebased-By: @trasher-
2015-06-15 10:13:13 +02:00
Evan Duffield
c489574e8a Masternode System Bug Fixes
- Fixed a race condition with masternode node selection upon new blocks
- Using nTime for lastpaid instead of the current time for high consensus
2015-06-14 17:05:51 -07:00
UdjinM6
f1debd4688 fix segfault in budgets 2015-06-10 09:49:08 +03:00
Evan Duffield
928f6edcb6 Adjusted max payment per finalized budget to 10% of the monthly block reward 2015-06-09 20:46:24 -06:00
evan82
07fbdfc525 Merge pull request #356 from UdjinM6/v0.12.0.x_mnping_blockhash
V0.12.0.x add recent (tip - 12) blockhash to mnping
2015-06-09 20:04:12 -06:00
evan82
201448cea0 Merge pull request #358 from UdjinM6/v0.12.0.x_fix_budget_gethash
V0.12.0.x fix budget gethash
2015-06-09 20:01:00 -06:00
UdjinM6
5f5ee7a59b fix CFinalizedBudgetVote and CBudgetVote hashing, see https://github.com/dashpay/dash/pull/357 for more info 2015-06-09 19:37:58 +03:00
adios
f9b77c4376 Masternode broadcast's and ping's GetHash method fix 2015-06-09 17:22:31 +04:00
UdjinM6
19d9a65f8a add recent (tip - 12) block hash to mnping 2015-06-09 14:37:36 +03:00
evan82
aa91dde992 Merge pull request #354 from UdjinM6/v0.12.0.x_merge_master
V0.12.0.x merge master
2015-06-07 18:50:37 -06:00
evan82
cddd69ef40 Merge pull request #350 from UdjinM6/v0.12.0.x_budget
V0.12.0.x budget fixes/cleanups
2015-06-06 08:14:44 -06:00
UdjinM6
d53968ea56 fix ix comments 2015-06-04 21:54:33 +03:00
UdjinM6
9e8d54124f Merge branch 'master' into v0.12.0.x_merge_master 2015-06-04 19:14:32 +03:00
evan82
34e808bfbd Merge pull request #348 from UdjinM6/v0.12.0.x_fix_unlock_null_collateral
V0.12.0.x fix unlock/setnull/collateraltx
2015-06-04 07:10:49 -07:00
evan82
1a9e34e18a Merge pull request #347 from UdjinM6/v0.12.0.x_ds_rand_denom
V0.12.0.x ds rand denom
2015-06-04 07:09:59 -07:00
UdjinM6
17d3df5300 fix CBudgetManager::FindProposal 2015-06-03 19:45:15 +03:00
UdjinM6
d335c1ebbe MOVE: group classes` implementation together; REMOVE: GetMasternodeBudgetEscrow (not used) 2015-06-03 19:10:11 +03:00
UdjinM6
6e0a64bc5d simplify few IFs 2015-06-03 18:42:37 +03:00
Wladimir J. van der Laan
181771b712
json: fail read_string if string contains trailing garbage
Change `read_string` to fail when not the entire input has been
consumed. This avoids unexpected, even dangerous behavior (fixes #6223).

The new JSON parser adapted in #6121 also solves this problem so in
master this is a temporary fix, but should be backported to older releases.

Also adds tests for the new behavior.

Github-Pull: #6226
Rebased-From: 4e157fc60d
2015-06-03 15:16:18 +02:00
UdjinM6
b8b3690a5c Merge pull request #349 from crowning-/Statusbar_Icons
Statusbar icons for testnet added
2015-06-03 00:55:36 +03:00
Luke Dashjr
ecc96f5ba9
Remove P2SH coinbase flag, no longer interesting
Github-Pull: #6203
Rebased-From: d449772cf6
2015-06-02 09:14:13 +02:00
Evan Duffield
439679f5bc Finalized Budget Voting and Payment
- Added strBudgetMode with modes of "auto", "output-vin" and "suggest". Auto votes for what the masternode sees as the most popular proposals, output-vin is a delegation mode to another party and "suggest" sends a message to the network, suggesting the most popular proposals
2015-06-01 12:06:03 -07:00
crowning-
859d523a46 Statusbar_Icons: makefile for Gitian fixed 2015-06-01 10:27:46 +02:00
crowning-
8f695a03c1 Statusbar icons for tDASH added 2015-06-01 09:55:07 +02:00
Evan Duffield
a93ceed090 Finalized Budget Changes
- Finalized budgets now pass proposal hash, payee and amount. This keeps them completely separate from the proposal system to aid in consensus.
- Added status messages for badly formed finalized budgets (probably attacks). If users see messages like this they should check the proposals to see if something is wrong with them before voting.
2015-05-30 13:12:12 -07:00
Evan Duffield
c4b1156206 Merge branch 'v0.12.0.x' of https://github.com/dashpay/dash into v0.12.0.x 2015-05-30 10:30:01 -07:00
Evan Duffield
eaf7b940a6 Complete rewrite of consensus code for mn/budget payments
- Added FindProposal and FindFinalBudget to budgeting class
- Added 2 new sporks for Proposals and Budget payment enforcement. This is outside of the decentralized code so we can turn it off if there's a problem.
- Detect budget blocks and pay correct amounts in super blocks
2015-05-30 10:27:51 -07:00
UdjinM6
543256c3e8 - fix issues with locking coins and not unlocking them properly (mostly on failures)
- more SetNull calls on failures
- move collateral tx reset out of SetNull and redo verification/renewal on doAuto in one single place (should prevent fast keypool exhausting on failures)
- move lastNewBlock from SetNull to Reset
2015-05-30 07:44:56 +03:00
crowning-
e01fefa6c4 Dash copyright year fixed 2015-05-30 05:13:09 +02:00
UdjinM6
4292d4d87d - Randomize denoms calculated ot of vecAmounts. Should help to find partners faster/more often and maybe slightly improve anonymity also.
- sessionTotal doesn't makes sense anymore, get rid of it.
- GetDenominationsByAmount cleaned but it is not used anywhere else so maybe it should be removed too (placed a comment there but didn't remove it yet).
2015-05-30 05:59:31 +03:00
UdjinM6
04f9fb043f Merge pull request #342 from crowning-/Wallet_Repair
Wallet Repair Buttons
2015-05-29 11:26:03 +03:00
crowning-
d953b23061 Wallet Repair Buttons: statustip changed 2015-05-29 08:18:33 +02:00
crowning-
4574218349 Wallet Repair Buttons: removed obsolete comment 2015-05-28 23:14:09 +02:00
crowning-
a4dce4340a Wallet Repair Buttons: refactoring and remove old repair args before restart 2015-05-28 23:09:14 +02:00
Evan Duffield
bd4a7f2fad Masternode payment consensus via quorums
- Payees are chosen by their last payment, if no payment it's based on their hash
- Fixed a few issues with counting quorum votes
2015-05-28 10:45:31 -07:00
Evan Duffield
d470eddc01 fixed hashing issues with mnw messages 2015-05-27 15:07:53 -07:00
crowning-
6f49808caa Wallet Repair Buttons: refactoring to remove redundant code 2015-05-27 22:35:46 +02:00
Evan Duffield
fe55b12a1f added improvements for finding next masternode to get paid 2015-05-27 12:47:01 -07:00
Evan Duffield
66dcf6bbc7 cleaned up naming of budget functions 2015-05-27 10:11:00 -07:00
Evan Duffield
41eb74dc82 Stable budget implementation
- All budgeting code seems to be rather stable now. Serialization/caching is working rather well.
- Fixed some ambiguous variable names within the budgeting system that were causing the file caching to not work all of the time
2015-05-27 09:28:55 -07:00
Wladimir J. van der Laan
ebd7d8d78c
Parameter interaction: disable upnp if -proxy set
To protect privacy, do not use UPNP when a proxy is set. The user may
still specify -listen=1 to listen locally (for a hidden service), so
don't rely on this happening through -listen.

Fixes #2927.

Conflicts:
	src/init.cpp

Rebased-From: 8c35b6f3be
Github-Pull: #6153
2015-05-27 09:35:40 +02:00
Wladimir J. van der Laan
ae3d8f371a
Fix two problems in CSubNet parsing
Fix two CSubNet constructor problems:

- The use of `/x` where 8 does not divide x was broken, due to a
  bit-order issue

- The use of e.g. `1.2.3.4/24` where the netmasked bits in the network
  are not 0 was broken. Fix this by explicitly normalizing the netwok
  according to the bitmask.

Also add tests for these cases.

Fixes #6179. Thanks to @jonasschnelli for reporting and initial fix.

Rebased-From: b45c50ce51
Github-Pull: #6186
2015-05-27 09:11:27 +02:00
Wladimir J. van der Laan
e4a7d51537
Simplify code for CSubnet
Simplify the code by using CAddress.ip directly, instead of the reversed
GetByte() semantics.

Rebased-From: 19e8d7be42
Github-Pull: #6186
2015-05-27 09:10:56 +02:00
crowning-
e68350d372 Wallet Repair Buttons (possible segfault on OSX fixed) 2015-05-26 23:09:16 +02:00
Evan Duffield
efe377fa69 tie budget system to masternode payment system 2015-05-26 07:56:51 -07:00
crowning-
3ab747d8ff Wallet Repair Buttons added 2015-05-25 22:59:38 +02:00
crowning-
9a6fe03974 Wallet Repair Buttons: initial commit (+ file permissions restored) 2015-05-25 18:29:11 +02:00
crowning-
8c4175b359 Wallet Repair Buttons: initial commit 2015-05-23 13:28:33 +02:00
evan82
b616fb8ef0 Merge pull request #338 from UdjinM6/lock_masternodes
Lock masternodes from masternode configuration file
2015-05-20 16:06:49 -07:00
evan82
9e5542ac45 Merge pull request #337 from UdjinM6/ds_coin_control
CoinControl should disable DS when non-anonymized inputs are selected
2015-05-20 16:06:38 -07:00
evan82
de562d89f7 Merge pull request #333 from UdjinM6/v0.12.0.x_update_mainnet_lastcheckpoint_data
V0.12.0.x update mainnet lastcheckpoint data
2015-05-20 16:06:08 -07:00
UdjinM6
472d2a21d6 fix tooltip background 2015-05-20 23:09:31 +03:00
UdjinM6
5a8b8538e3 Lock masternodes from masternode configuration file 2015-05-20 20:21:44 +03:00
crowning-
34a205b9a6 Fix tooltip background for OSX 2015-05-20 09:05:46 +02:00
UdjinM6
06032be332 unset DS checkbox if there were non-anonymized inputs selected in coincontrol, give warning 2015-05-20 00:10:52 +03:00
crowning-
eea3317755 Use existing constant instead of hardcoded size value 2015-05-17 21:21:43 +02:00
crowning-
2154f94131 Open peers information page when clicking on connections item 2015-05-17 20:56:00 +02:00
crowning-
32c6068ce9 Merge remote-tracking branch 'upstream/v0.12.0.x' into v0.12.0.x 2015-05-17 16:37:59 +02:00
UdjinM6
5cb819c3f8 Merge pull request #332 from UdjinM6/v0.12.0.x_fix_mnpayment_bugs
V0.12.0.x fix 2 masternode payments bugs
2015-05-17 17:26:12 +03:00
crowning-
dd76a079dd Tooltips for Coincontrol-Dialog added 2015-05-17 14:12:01 +02:00
UdjinM6
a4a72d6fa0 Update last checkpoint data for mainnet - should give more accurate verification progress 2015-05-16 06:04:33 +03:00
UdjinM6
397654ef76 fix masternode payments bugs 2015-05-16 05:53:53 +03:00
UdjinM6
18c60f9ecb Merge branch 'master' into v0.12.0.x_merge_btc010_master (fix spaces) 2015-05-16 02:34:25 +03:00
UdjinM6
e50d9bbc5d Merge branch '0.10' into v0.12.0.x_merge_btc010 2015-05-16 00:05:57 +03:00
crowning-
af08fbf0c9 Merge remote-tracking branch 'upstream/v0.12.0.x' into v0.12.0.x 2015-05-15 20:23:20 +02:00
Evan Duffield
66ac44651e Merge branch 'v0.12.0.x' of https://github.com/darkcoinproject/darkcoin into v0.12.0.x 2015-05-14 18:04:43 -07:00
Evan Duffield
40149c4e41 Budgeting Software / Reference Node Removal
- Added commands for using budgets "mnbudget" and "mnfinalbudget"
- Supports 100% decentralized budget control and view-only site with json meta data object
2015-05-14 18:01:15 -07:00
crowning-
e9a8b99694 Show sum of selected transactions: mouse + key selection added, some general cleanup 2015-05-14 08:31:40 +02:00
Gregory Maxwell
da656068ec
Avoid crash on start in TestBlockValidity with gen=1.
When the internal miner is enabled at the start of a new node, there
 is an near instant assert in TestBlockValidity because its attempting
 to mine a block before the top checkpoint.

Also avoids a data race around vNodes.

Github-Pull: #6123
Rebased-From: bba7c24929
2015-05-12 16:38:04 +02:00
Wladimir J. van der Laan
49e4d14f75
Translations update 2015-05-12 16:33:04 +02:00
Wladimir J. van der Laan
d7e7727658
Preparations for 0.10.2 release 2015-05-12 16:23:53 +02:00
Jonas Schnelli
424ae6629b
don't imbue boost::filesystem::path with locale "C" on windows
fixes https://github.com/bitcoin/bitcoin/issues/6078

Github-Pull: #6093
Rebased-From: b3ffcdf916 3da7849007
2015-05-10 14:26:22 +02:00
crowning-
575ddb3eca Show sum of all selected transactions in 'Transactions' tab. (Own ToDo marker removed) 2015-05-10 01:30:45 +02:00
crowning-
40f742c6be Show sum of all selected transactions in 'Transactions' tab. (typo + file permission fix) 2015-05-10 01:28:03 +02:00
crowning-
3a6466bced Show sum of all selected transactions in 'Transactions' tab. 2015-05-10 01:22:35 +02:00
UdjinM6
4a107035c7 fix boost::get build error 2015-05-09 00:06:07 +03:00
UdjinM6
4c6b9e8969 use tooltip for submited denoms 2015-05-08 17:35:15 +03:00
Cory Fields
824c011d16 wallet: fix boost::get usage with boost 1.58
Backport from master
2015-05-06 16:52:46 -04:00
Evan Duffield
e7557f2baf make masternode votes last 30 days 2015-05-06 13:15:44 -07:00
Wladimir J. van der Laan
ebc0e41ede
qt: translation update for next 0.10 point release 2015-05-04 13:12:30 +02:00
Evan Duffield
c6233880c3 draft 2015-05-04 03:05:08 -07:00
Evan Duffield
160eec6e30 merged 2015-05-04 02:36:23 -07:00
Evan Duffield
f38b8e9572 draft 2015-05-04 02:31:31 -07:00
crowning-
acec2b399f Resync with upstream 2015-05-03 15:29:35 +02:00
crowning-
4fa07131b6 Merge remote-tracking branch 'upstream/v0.12.0.x' into v0.12.0.x 2015-05-03 14:34:40 +02:00
evan82
11f83f3141 Merge pull request #322 from UdjinM6/v0.12.0.x_fix_kgw
V0.12.0.x Fix KGW (handle negative uint256 properly)
2015-05-02 19:43:16 -07:00
evan82
a689f630ed Merge pull request #323 from UdjinM6/v0.12.0.x_fix_ds_mixing
V0.12.0.x DS fixes
2015-05-02 19:43:07 -07:00
evan82
1506d63284 Merge pull request #324 from UdjinM6/v0.12.0.x_mn_payment_initial_download
v0.12.0.x Do not waste CPU calculating MN payments during initial download
2015-05-02 19:41:46 -07:00
UdjinM6
905b28f813 Do not calculate MN payments during initial download 2015-05-02 19:55:31 +03:00
UdjinM6
6e229e16ff DS fixes:
- detect denominated but not yet anonymized balance properly or both (GetAnonymizableBalance)
 - fix progress calculation by using GetAnonymizableBalance
 - do not count MN-like inputs as anonymizable
 - denominate faster: if there is enough new inputs after DS started (their sum is greater then "already denominated but not yet anonymized balance")
 - allow small amounts to be used in CreateDenominated (modified SelectCoinsDark) but only if they are larger then 1 CENT
 - do not use collateral inputs in CreateDenominated (modified SelectCoinsDark)
 - convert some int64_t -> CAmount for money related variables/params
2015-05-02 19:18:20 +03:00
UdjinM6
efca207c13 Fix KGW (handle negative uint256 properly) 2015-05-01 20:17:14 +03:00
Evan Duffield
40adfbf2c9 fixed 2015-04-30 12:54:34 -07:00
Evan Duffield
b02d5260fd fixed most of the budget functions 2015-04-30 10:11:34 -07:00
Evan Duffield
969826c249 Reference Node / Stubbed Out Budget System
- Removed of reference node and replaced with decentralized quorums that pick the masternodes who get paid each block.
- Made a budgeting system, where masternodes can vote on individual budgets and the data is stored perminently on each clients computer
2015-04-30 07:55:37 -07:00
crowning-
6aca47300e Merge remote-tracking branch 'upstream/v0.12.0.x' into v0.12.0.x 2015-04-30 08:31:47 +02:00
crowning-
8f505019e9 Only show most common transaction types by default 2015-04-29 23:46:53 +02:00
UdjinM6
24309f78ce various (gitian) build fixes 2015-04-29 21:27:52 +03:00
crowning-
8223e0d34f Fix for addressbook label problem on Windows 2015-04-26 00:58:50 +02:00
crowning-
cf7e9886f5 Enable dynamic CSS temporarily for debugging 2015-04-25 23:53:58 +02:00
UdjinM6
854a1be027 Merge pull request #316 from UdjinM6/v0.12.0.x_mn_replies
V0.12.0.x Fix translations(mn replies /protobump/ + DS progress)
2015-04-20 17:18:48 +03:00
Gregory Maxwell
139cd8177b
Cap nAttempts penalty at 8 and switch to pow instead of a division loop.
On hosts that had spent some time with a failed internet connection their
 nAttempts penalty was going through the roof (e.g. thousands for all peers)
 and as a result the connect search was pegging the CPU and failing to get
 more than a 4 connections after days of running (because it was taking so
 long per try).

Rebased-From: a784f90c98
Github-Pull: #6029
2015-04-20 13:59:19 +02:00
Suhas Daftuar
bac6fca3c9
Set nSequenceId when a block is fully linked
Also adds a test to CheckBlockIndex

Conflicts:
	src/main.cpp

Rebased-From: c1ecee8f72
Github-Pull: #6010
2015-04-20 13:48:52 +02:00
crowning-
5873a5e5a3 Included new "Peers list" tab into CSS theme 2015-04-19 16:01:45 +02:00
crowning-
4f28254506 Merge remote-tracking branch 'upstream/v0.12.0.x' into v0.12.0.x 2015-04-19 00:38:39 +02:00
dexX7
323de27f4b
Initialization: setup environment before starting QT tests
The environment is prepared by the main thread to guard against invalid locale settings.
2015-04-18 16:06:22 +02:00
dexX7
7494e0915b
Initialization: setup environment before starting tests
The environment is prepared by the main thread to guard against invalid locale settings and to prevent deinitialization issues of Boost path, which can result in app crashes.
2015-04-18 16:06:20 +02:00
dexX7
df45564cf0
Initialization: set fallback locale as environment variable
The scope of `std::locale::global` appears to be smaller than `setenv("LC_ALL", ...)` and insufficient to fix messed up locale settings for the whole application.
2015-04-18 16:06:15 +02:00
Evan Duffield
1e69e57662 Masternode Overhaul
- Added new CMasterBroadcast/CmasternodePing objects, with all of the code required to check each new message. SHould be much easier to tell what's going on now.
2015-04-17 23:44:49 -07:00
UdjinM6
949494d4de Merge pull request #317 from crowning-/auto-wallet-backup
Autobackup: keep n-backups per wallet-name
2015-04-17 02:43:43 +03:00