aaf55d25c6
It turns out that some miners have been staying with old versions of Bitcoin Core because their software behaves poorly with persistent connections and the Bitcoin Core thread and connection limits. What happens is that underlying HTTP libraries leave connections open invisibly to their users and then the user runs into the default four thread limit. This looks like Bitcoin Core is unresponsive to RPC. There are many things that should be improved in Bitcoin Core's behavior here, e.g. supporting more concurrent connections, not tying up threads for idle connections, disconnecting kept-alive connections when limits are reached, etc. All are fairly big, risky changes. Disabling keep-alive is a simple workaround. It's often not easy to turn off the keep-alive support in the client where it may be buried in some platform library. If you are one of the few who really needs persistent connections you probably know that you want them and can find a switch; while if you don't and the misbehavior is hitting you it is hard to discover the source of your problems is keepalive related. Given that it is best to default to off until they're handled better. Github-Merge: #5655 Rebased-From: |
||
|---|---|---|
| .. | ||
| python-bitcoinrpc | ||
| .gitignore | ||
| conflictedbalance.sh | ||
| forknotify.py | ||
| getblocktemplate_longpoll.py | ||
| getblocktemplate_proposals.py | ||
| getchaintips.py | ||
| httpbasics.py | ||
| keypool.py | ||
| listtransactions.py | ||
| mempool_coinbase_spends.py | ||
| mempool_resurrect_test.py | ||
| mempool_spendcoinbase.py | ||
| netutil.py | ||
| README.md | ||
| receivedby.py | ||
| rest.py | ||
| rpcbind_test.py | ||
| send.sh | ||
| smartfees.py | ||
| test_framework.py | ||
| txn_doublespend.py | ||
| util.py | ||
| util.sh | ||
| wallet.py | ||
| walletbackup.py | ||
| zapwallettxes.sh | ||
Regression tests of RPC interface
python-bitcoinrpc
Git subtree of https://github.com/jgarzik/python-bitcoinrpc. Changes to python-bitcoinrpc should be made upstream, and then pulled here using git subtree.
test_framework.py
Base class for new regression tests.
listtransactions.py
Tests for the listtransactions RPC call.
util.py
Generally useful functions.
Bash-based tests, to be ported to Python:
- wallet.sh : Exercise wallet send/receive code.
- walletbackup.sh : Exercise wallet backup / dump / import
- txnmall.sh : Test proper accounting of malleable transactions
- conflictedbalance.sh : More testing of malleable transaction handling
Notes
A 200-block -regtest blockchain and wallets for four nodes is created the first time a regression test is run and is stored in the cache/ directory. Each node has 25 mature blocks (25*50=1250 BTC) in their wallet.
After the first run, the cache/ blockchain and wallets are copied into a temporary directory and used as the initial test state.
If you get into a bad state, you should be able to recover with:
rm -rf cache
killall bitcoind