2021-07-13 18:30:17 +02:00
#!/usr/bin/env python3
2023-08-16 19:27:31 +02:00
# Copyright (c) 2018-2020 The Bitcoin Core developers
2021-07-13 18:30:17 +02:00
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
""" Test the Partially Signed Transaction RPCs.
"""
2021-12-21 07:55:15 +01:00
from decimal import Decimal
2021-07-13 18:30:17 +02:00
from test_framework . test_framework import BitcoinTestFramework
2022-09-24 14:36:35 +02:00
from test_framework . util import (
assert_equal ,
assert_greater_than ,
assert_raises_rpc_error ,
find_output
)
import json
import os
2021-07-13 18:30:17 +02:00
# Create one-input, one-output, no-fee transaction:
class PSBTTest ( BitcoinTestFramework ) :
def set_test_params ( self ) :
self . num_nodes = 3
2019-12-09 19:52:38 +01:00
self . supports_cli = False
2021-07-13 18:30:17 +02:00
2018-09-13 12:33:15 +02:00
def skip_test_if_missing_module ( self ) :
self . skip_if_no_wallet ( )
2021-07-13 18:30:17 +02:00
def run_test ( self ) :
2021-12-13 05:28:46 +01:00
# Create and fund a raw tx for sending 10 DASH
2021-07-13 18:30:17 +02:00
psbtx1 = self . nodes [ 0 ] . walletcreatefundedpsbt ( [ ] , { self . nodes [ 2 ] . getnewaddress ( ) : 10 } ) [ ' psbt ' ]
# Node 1 should not be able to add anything to it but still return the psbtx same as before
psbtx = self . nodes [ 1 ] . walletprocesspsbt ( psbtx1 ) [ ' psbt ' ]
assert_equal ( psbtx1 , psbtx )
# Sign the transaction and send
signed_tx = self . nodes [ 0 ] . walletprocesspsbt ( psbtx ) [ ' psbt ' ]
final_tx = self . nodes [ 0 ] . finalizepsbt ( signed_tx ) [ ' hex ' ]
self . nodes [ 0 ] . sendrawtransaction ( final_tx )
2020-08-31 13:19:50 +02:00
# Manually selected inputs can be locked:
assert_equal ( len ( self . nodes [ 0 ] . listlockunspent ( ) ) , 0 )
utxo1 = self . nodes [ 0 ] . listunspent ( ) [ 0 ]
psbtx1 = self . nodes [ 0 ] . walletcreatefundedpsbt ( [ { " txid " : utxo1 [ ' txid ' ] , " vout " : utxo1 [ ' vout ' ] } ] , { self . nodes [ 2 ] . getnewaddress ( ) : 1 } , 0 , { " lockUnspents " : True } ) [ " psbt " ]
assert_equal ( len ( self . nodes [ 0 ] . listlockunspent ( ) ) , 1 )
# Locks are ignored for manually selected inputs
self . nodes [ 0 ] . walletcreatefundedpsbt ( [ { " txid " : utxo1 [ ' txid ' ] , " vout " : utxo1 [ ' vout ' ] } ] , { self . nodes [ 2 ] . getnewaddress ( ) : 1 } , 0 )
2021-06-04 11:54:38 +02:00
# Create p2sh and p2pkh addresses
2021-07-13 18:30:17 +02:00
pubkey0 = self . nodes [ 0 ] . getaddressinfo ( self . nodes [ 0 ] . getnewaddress ( ) ) [ ' pubkey ' ]
pubkey1 = self . nodes [ 1 ] . getaddressinfo ( self . nodes [ 1 ] . getnewaddress ( ) ) [ ' pubkey ' ]
pubkey2 = self . nodes [ 2 ] . getaddressinfo ( self . nodes [ 2 ] . getnewaddress ( ) ) [ ' pubkey ' ]
2021-06-04 11:54:38 +02:00
p2sh = self . nodes [ 1 ] . addmultisigaddress ( 2 , [ pubkey0 , pubkey1 , pubkey2 ] ) [ ' address ' ]
p2pkh = self . nodes [ 1 ] . getnewaddress ( )
2021-07-13 18:30:17 +02:00
# fund those addresses
2021-06-04 11:54:38 +02:00
rawtx = self . nodes [ 0 ] . createrawtransaction ( [ ] , { p2sh : 10 , p2pkh : 10 } )
rawtx = self . nodes [ 0 ] . fundrawtransaction ( rawtx , { " changePosition " : 2 } )
2021-07-13 18:30:17 +02:00
signed_tx = self . nodes [ 0 ] . signrawtransactionwithwallet ( rawtx [ ' hex ' ] ) [ ' hex ' ]
txid = self . nodes [ 0 ] . sendrawtransaction ( signed_tx )
self . nodes [ 0 ] . generate ( 6 )
self . sync_all ( )
# Find the output pos
p2sh_pos = - 1
p2pkh_pos = - 1
decoded = self . nodes [ 0 ] . decoderawtransaction ( signed_tx )
for out in decoded [ ' vout ' ] :
if out [ ' scriptPubKey ' ] [ ' addresses ' ] [ 0 ] == p2sh :
p2sh_pos = out [ ' n ' ]
elif out [ ' scriptPubKey ' ] [ ' addresses ' ] [ 0 ] == p2pkh :
p2pkh_pos = out [ ' n ' ]
# spend single key from node 1
2020-07-30 09:46:12 +02:00
created_psbt = self . nodes [ 1 ] . walletcreatefundedpsbt ( [ { " txid " : txid , " vout " : p2pkh_pos } ] , { self . nodes [ 1 ] . getnewaddress ( ) : 9.99 } )
walletprocesspsbt_out = self . nodes [ 1 ] . walletprocesspsbt ( created_psbt [ ' psbt ' ] )
2020-07-02 22:53:53 +02:00
# Make sure it has both types of UTXOs
decoded = self . nodes [ 1 ] . decodepsbt ( walletprocesspsbt_out [ ' psbt ' ] )
assert ' non_witness_utxo ' in decoded [ ' inputs ' ] [ 0 ]
2020-07-30 09:46:12 +02:00
# Check decodepsbt fee calculation (input values shall only be counted once per UTXO)
assert_equal ( decoded [ ' fee ' ] , created_psbt [ ' fee ' ] )
2021-07-13 18:30:17 +02:00
assert_equal ( walletprocesspsbt_out [ ' complete ' ] , True )
self . nodes [ 1 ] . sendrawtransaction ( self . nodes [ 1 ] . finalizepsbt ( walletprocesspsbt_out [ ' psbt ' ] ) [ ' hex ' ] )
2021-12-13 05:28:46 +01:00
# feeRate of 0.1 DASH / KB produces a total fee slightly below -maxtxfee (~0.06650000):
2022-12-27 09:48:47 +01:00
res = self . nodes [ 1 ] . walletcreatefundedpsbt ( [ { " txid " : txid , " vout " : p2pkh_pos } , { " txid " : txid , " vout " : p2sh_pos } , { " txid " : txid , " vout " : p2pkh_pos } ] , { self . nodes [ 1 ] . getnewaddress ( ) : 29.99 } , 0 , { " feeRate " : 0.1 } , False )
2021-12-13 05:28:46 +01:00
assert_greater_than ( res [ " fee " ] , 0.06 )
assert_greater_than ( 0.07 , res [ " fee " ] )
2022-12-27 09:48:47 +01:00
decoded_psbt = self . nodes [ 0 ] . decodepsbt ( res [ ' psbt ' ] )
for psbt_in in decoded_psbt [ " inputs " ] :
assert " bip32_derivs " not in psbt_in
2021-12-13 05:28:46 +01:00
# feeRate of 10 DASH / KB produces a total fee well above -maxtxfee
2021-12-28 22:45:54 +01:00
# previously this was silently capped at -maxtxfee
2024-01-25 07:53:18 +01:00
assert_raises_rpc_error ( - 4 , " Fee exceeds maximum configured by user (e.g. -maxtxfee, maxfeerate) " , self . nodes [ 1 ] . walletcreatefundedpsbt , [ { " txid " : txid , " vout " : p2pkh_pos } , { " txid " : txid , " vout " : p2sh_pos } , { " txid " : txid , " vout " : p2pkh_pos } ] , { self . nodes [ 1 ] . getnewaddress ( ) : 29.99 } , 0 , { " feeRate " : 10 } )
2021-12-13 05:28:46 +01:00
2021-07-13 18:30:17 +02:00
# partially sign multisig things with node 1
2021-06-04 11:54:38 +02:00
psbtx = self . nodes [ 1 ] . walletcreatefundedpsbt ( [ { " txid " : txid , " vout " : p2sh_pos } ] , { self . nodes [ 1 ] . getnewaddress ( ) : 9.99 } ) [ ' psbt ' ]
2021-07-13 18:30:17 +02:00
walletprocesspsbt_out = self . nodes [ 1 ] . walletprocesspsbt ( psbtx )
psbtx = walletprocesspsbt_out [ ' psbt ' ]
assert_equal ( walletprocesspsbt_out [ ' complete ' ] , False )
# partially sign with node 2. This should be complete and sendable
walletprocesspsbt_out = self . nodes [ 2 ] . walletprocesspsbt ( psbtx )
assert_equal ( walletprocesspsbt_out [ ' complete ' ] , True )
self . nodes [ 2 ] . sendrawtransaction ( self . nodes [ 2 ] . finalizepsbt ( walletprocesspsbt_out [ ' psbt ' ] ) [ ' hex ' ] )
# check that walletprocesspsbt fails to decode a non-psbt
2021-06-04 11:54:38 +02:00
rawtx = self . nodes [ 1 ] . createrawtransaction ( [ { " txid " : txid , " vout " : p2pkh_pos } ] , { self . nodes [ 1 ] . getnewaddress ( ) : 9.99 } )
2021-07-13 18:30:17 +02:00
assert_raises_rpc_error ( - 22 , " TX decode failed " , self . nodes [ 1 ] . walletprocesspsbt , rawtx )
# Convert a non-psbt to psbt and make sure we can decode it
rawtx = self . nodes [ 0 ] . createrawtransaction ( [ ] , { self . nodes [ 1 ] . getnewaddress ( ) : 10 } )
rawtx = self . nodes [ 0 ] . fundrawtransaction ( rawtx )
new_psbt = self . nodes [ 0 ] . converttopsbt ( rawtx [ ' hex ' ] )
self . nodes [ 0 ] . decodepsbt ( new_psbt )
# Make sure that a psbt with signatures cannot be converted
signedtx = self . nodes [ 0 ] . signrawtransactionwithwallet ( rawtx [ ' hex ' ] )
2019-06-18 14:52:24 +02:00
assert_raises_rpc_error ( - 22 , " Inputs must not have scriptSigs " , self . nodes [ 0 ] . converttopsbt , hexstring = signedtx [ ' hex ' ] )
assert_raises_rpc_error ( - 22 , " Inputs must not have scriptSigs " , self . nodes [ 0 ] . converttopsbt , hexstring = signedtx [ ' hex ' ] , permitsigdata = False )
2018-11-12 19:09:23 +01:00
# Unless we allow it to convert and strip signatures
self . nodes [ 0 ] . converttopsbt ( signedtx [ ' hex ' ] , True )
2021-07-13 18:30:17 +02:00
2018-09-06 00:12:39 +02:00
# Explicitly allow converting non-empty txs
2021-07-13 18:30:17 +02:00
new_psbt = self . nodes [ 0 ] . converttopsbt ( rawtx [ ' hex ' ] )
self . nodes [ 0 ] . decodepsbt ( new_psbt )
# Create outputs to nodes 1 and 2
node1_addr = self . nodes [ 1 ] . getnewaddress ( )
node2_addr = self . nodes [ 2 ] . getnewaddress ( )
txid1 = self . nodes [ 0 ] . sendtoaddress ( node1_addr , 13 )
2019-02-19 16:30:36 +01:00
txid2 = self . nodes [ 0 ] . sendtoaddress ( node2_addr , 13 )
blockhash = self . nodes [ 0 ] . generate ( 6 ) [ 0 ]
2021-07-13 18:30:17 +02:00
self . sync_all ( )
2019-02-19 16:30:36 +01:00
vout1 = find_output ( self . nodes [ 1 ] , txid1 , 13 , blockhash = blockhash )
vout2 = find_output ( self . nodes [ 2 ] , txid2 , 13 , blockhash = blockhash )
2021-07-13 18:30:17 +02:00
# Create a psbt spending outputs from nodes 1 and 2
psbt_orig = self . nodes [ 0 ] . createpsbt ( [ { " txid " : txid1 , " vout " : vout1 } , { " txid " : txid2 , " vout " : vout2 } ] , { self . nodes [ 0 ] . getnewaddress ( ) : 25.999 } )
# Update psbts, should only have data for one input and not the other
2020-02-25 11:49:06 +01:00
psbt1 = self . nodes [ 1 ] . walletprocesspsbt ( psbt_orig , False , " ALL " ) [ ' psbt ' ]
2021-07-13 18:30:17 +02:00
psbt1_decoded = self . nodes [ 0 ] . decodepsbt ( psbt1 )
assert psbt1_decoded [ ' inputs ' ] [ 0 ] and not psbt1_decoded [ ' inputs ' ] [ 1 ]
2020-02-25 11:49:06 +01:00
# Check that BIP32 path was added
assert " bip32_derivs " in psbt1_decoded [ ' inputs ' ] [ 0 ]
psbt2 = self . nodes [ 2 ] . walletprocesspsbt ( psbt_orig , False , " ALL " , False ) [ ' psbt ' ]
2021-07-13 18:30:17 +02:00
psbt2_decoded = self . nodes [ 0 ] . decodepsbt ( psbt2 )
assert not psbt2_decoded [ ' inputs ' ] [ 0 ] and psbt2_decoded [ ' inputs ' ] [ 1 ]
2020-02-25 11:49:06 +01:00
# Check that BIP32 paths were not added
assert " bip32_derivs " not in psbt2_decoded [ ' inputs ' ] [ 1 ]
# Sign PSBTs (workaround issue #18039)
psbt1 = self . nodes [ 1 ] . walletprocesspsbt ( psbt_orig ) [ ' psbt ' ]
psbt2 = self . nodes [ 2 ] . walletprocesspsbt ( psbt_orig ) [ ' psbt ' ]
2021-07-13 18:30:17 +02:00
# Combine, finalize, and send the psbts
combined = self . nodes [ 0 ] . combinepsbt ( [ psbt1 , psbt2 ] )
finalized = self . nodes [ 0 ] . finalizepsbt ( combined ) [ ' hex ' ]
self . nodes [ 0 ] . sendrawtransaction ( finalized )
self . nodes [ 0 ] . generate ( 6 )
self . sync_all ( )
2018-11-30 16:49:42 +01:00
# Make sure change address wallet does not have P2SH innerscript access to results in success
# when attempting BnB coin selection
block_height = self . nodes [ 0 ] . getblockcount ( )
self . nodes [ 0 ] . walletcreatefundedpsbt ( [ ] , [ { self . nodes [ 2 ] . getnewaddress ( ) : self . nodes [ 0 ] . listunspent ( ) [ 0 ] [ " amount " ] + 1 } ] , block_height + 2 , { " changeAddress " : self . nodes [ 1 ] . getnewaddress ( ) } , False )
2018-11-10 04:26:46 +01:00
# Regression test for 14473 (mishandling of already-signed witness transaction):
unspent = self . nodes [ 0 ] . listunspent ( ) [ 0 ]
psbtx_info = self . nodes [ 0 ] . walletcreatefundedpsbt ( [ { " txid " : unspent [ " txid " ] , " vout " : unspent [ " vout " ] } ] , [ { self . nodes [ 2 ] . getnewaddress ( ) : unspent [ " amount " ] + 1 } ] )
complete_psbt = self . nodes [ 0 ] . walletprocesspsbt ( psbtx_info [ " psbt " ] )
double_processed_psbt = self . nodes [ 0 ] . walletprocesspsbt ( complete_psbt [ " psbt " ] )
assert_equal ( complete_psbt , double_processed_psbt )
# We don't care about the decode result, but decoding must succeed.
self . nodes [ 0 ] . decodepsbt ( double_processed_psbt [ " psbt " ] )
2021-07-13 18:30:17 +02:00
# BIP 174 Test Vectors
# Check that unknown values are just passed through
unknown_psbt = " cHNidP8BAD8CAAAAAf//////////////////////////////////////////AAAAAAD/////AQAAAAAAAAAAA2oBAAAAAAAACg8BAgMEBQYHCAkPAQIDBAUGBwgJCgsMDQ4PAAA= "
unknown_out = self . nodes [ 0 ] . walletprocesspsbt ( unknown_psbt ) [ ' psbt ' ]
assert_equal ( unknown_psbt , unknown_out )
# Open the data file
with open ( os . path . join ( os . path . dirname ( os . path . realpath ( __file__ ) ) , ' data/rpc_psbt.json ' ) , encoding = ' utf-8 ' ) as f :
d = json . load ( f )
invalids = d [ ' invalid ' ]
valids = d [ ' valid ' ]
creators = d [ ' creator ' ]
signers = d [ ' signer ' ]
combiners = d [ ' combiner ' ]
finalizers = d [ ' finalizer ' ]
extractors = d [ ' extractor ' ]
# Invalid PSBTs
for invalid in invalids :
assert_raises_rpc_error ( - 22 , " TX decode failed " , self . nodes [ 0 ] . decodepsbt , invalid )
# Valid PSBTs
for valid in valids :
self . nodes [ 0 ] . decodepsbt ( valid )
# Creator Tests
for creator in creators :
created_tx = self . nodes [ 0 ] . createpsbt ( creator [ ' inputs ' ] , creator [ ' outputs ' ] )
assert_equal ( created_tx , creator [ ' result ' ] )
# Signer tests
for i , signer in enumerate ( signers ) :
2018-08-08 23:27:20 +02:00
self . nodes [ 2 ] . createwallet ( " wallet {} " . format ( i ) )
wrpc = self . nodes [ 2 ] . get_wallet_rpc ( " wallet {} " . format ( i ) )
2021-07-13 18:30:17 +02:00
for key in signer [ ' privkeys ' ] :
2018-08-08 23:27:20 +02:00
wrpc . importprivkey ( key )
signed_tx = wrpc . walletprocesspsbt ( signer [ ' psbt ' ] ) [ ' psbt ' ]
2021-07-13 18:30:17 +02:00
assert_equal ( signed_tx , signer [ ' result ' ] )
# Combiner test
for combiner in combiners :
combined = self . nodes [ 2 ] . combinepsbt ( combiner [ ' combine ' ] )
assert_equal ( combined , combiner [ ' result ' ] )
2019-02-11 14:08:10 +01:00
# Empty combiner test
assert_raises_rpc_error ( - 8 , " Parameter ' txs ' cannot be empty " , self . nodes [ 0 ] . combinepsbt , [ ] )
2021-07-13 18:30:17 +02:00
# Finalizer test
for finalizer in finalizers :
finalized = self . nodes [ 2 ] . finalizepsbt ( finalizer [ ' finalize ' ] , False ) [ ' psbt ' ]
assert_equal ( finalized , finalizer [ ' result ' ] )
# Extractor test
for extractor in extractors :
extracted = self . nodes [ 2 ] . finalizepsbt ( extractor [ ' extract ' ] , True ) [ ' hex ' ]
assert_equal ( extracted , extractor [ ' result ' ] )
2018-11-08 16:08:46 +01:00
# Test that psbts with p2pkh outputs are created properly
p2pkh = self . nodes [ 0 ] . getnewaddress ( )
psbt = self . nodes [ 1 ] . walletcreatefundedpsbt ( [ ] , [ { p2pkh : 1 } ] , 0 , { " includeWatching " : True } , True )
2022-12-27 09:48:47 +01:00
decoded_psbt = self . nodes [ 0 ] . decodepsbt ( psbtx )
for psbt_in in decoded_psbt [ " inputs " ] :
assert " bip32_derivs " in psbt_in
2021-07-13 18:30:17 +02:00
2019-01-30 06:32:38 +01:00
# Test decoding error: invalid base64
assert_raises_rpc_error ( - 22 , " TX decode failed invalid base64 " , self . nodes [ 0 ] . decodepsbt , " ;definitely not base64; " )
2021-07-13 18:30:17 +02:00
2021-12-21 07:55:15 +01:00
# Send to all types of addresses
addr1 = self . nodes [ 1 ] . getnewaddress ( )
txid1 = self . nodes [ 0 ] . sendtoaddress ( addr1 , 11 )
vout1 = find_output ( self . nodes [ 0 ] , txid1 , 11 )
addr2 = self . nodes [ 1 ] . getnewaddress ( )
txid2 = self . nodes [ 0 ] . sendtoaddress ( addr2 , 11 )
vout2 = find_output ( self . nodes [ 0 ] , txid2 , 11 )
addr3 = self . nodes [ 1 ] . getnewaddress ( )
txid3 = self . nodes [ 0 ] . sendtoaddress ( addr3 , 11 )
vout3 = find_output ( self . nodes [ 0 ] , txid3 , 11 )
self . sync_all ( )
2022-06-23 01:42:19 +02:00
def test_psbt_input_keys ( psbt_input , keys ) :
""" Check that the psbt input has only the expected keys. """
assert_equal ( set ( keys ) , set ( psbt_input . keys ( ) ) )
# Create a PSBT. None of the inputs are filled initially
2021-12-21 07:55:15 +01:00
psbt = self . nodes [ 1 ] . createpsbt ( [ { " txid " : txid1 , " vout " : vout1 } , { " txid " : txid2 , " vout " : vout2 } , { " txid " : txid3 , " vout " : vout3 } ] , { self . nodes [ 0 ] . getnewaddress ( ) : 32.999 } )
decoded = self . nodes [ 1 ] . decodepsbt ( psbt )
2022-06-23 01:42:19 +02:00
test_psbt_input_keys ( decoded [ ' inputs ' ] [ 0 ] , [ ] )
test_psbt_input_keys ( decoded [ ' inputs ' ] [ 1 ] , [ ] )
test_psbt_input_keys ( decoded [ ' inputs ' ] [ 2 ] , [ ] )
# Update a PSBT with UTXOs from the node
# No inputs should be filled because they are non-witness
2021-12-21 07:55:15 +01:00
updated = self . nodes [ 1 ] . utxoupdatepsbt ( psbt )
decoded = self . nodes [ 1 ] . decodepsbt ( updated )
2022-06-23 01:42:19 +02:00
test_psbt_input_keys ( decoded [ ' inputs ' ] [ 1 ] , [ ] )
test_psbt_input_keys ( decoded [ ' inputs ' ] [ 2 ] , [ ] )
# Try again, now while providing descriptors
descs = [ self . nodes [ 1 ] . getaddressinfo ( addr ) [ ' desc ' ] for addr in [ addr1 , addr2 , addr3 ] ]
2019-07-07 03:36:23 +02:00
updated = self . nodes [ 1 ] . utxoupdatepsbt ( psbt = psbt , descriptors = descs )
2022-06-23 01:42:19 +02:00
decoded = self . nodes [ 1 ] . decodepsbt ( updated )
test_psbt_input_keys ( decoded [ ' inputs ' ] [ 0 ] , [ ] )
test_psbt_input_keys ( decoded [ ' inputs ' ] [ 1 ] , [ ] )
test_psbt_input_keys ( decoded [ ' inputs ' ] [ 2 ] , [ ] )
2021-12-21 07:55:15 +01:00
# Two PSBTs with a common input should not be joinable
psbt1 = self . nodes [ 1 ] . createpsbt ( [ { " txid " : txid1 , " vout " : vout1 } ] , { self . nodes [ 0 ] . getnewaddress ( ) : Decimal ( ' 10.999 ' ) } )
assert_raises_rpc_error ( - 8 , " exists in multiple PSBTs " , self . nodes [ 1 ] . joinpsbts , [ psbt1 , updated ] )
# Join two distinct PSBTs
addr4 = self . nodes [ 1 ] . getnewaddress ( )
txid4 = self . nodes [ 0 ] . sendtoaddress ( addr4 , 5 )
vout4 = find_output ( self . nodes [ 0 ] , txid4 , 5 )
self . nodes [ 0 ] . generate ( 6 )
self . sync_all ( )
psbt2 = self . nodes [ 1 ] . createpsbt ( [ { " txid " : txid4 , " vout " : vout4 } ] , { self . nodes [ 0 ] . getnewaddress ( ) : Decimal ( ' 4.999 ' ) } )
psbt2 = self . nodes [ 1 ] . walletprocesspsbt ( psbt2 ) [ ' psbt ' ]
psbt2_decoded = self . nodes [ 0 ] . decodepsbt ( psbt2 )
assert " final_scriptwitness " not in psbt2_decoded [ ' inputs ' ] [ 0 ] and " final_scriptSig " in psbt2_decoded [ ' inputs ' ] [ 0 ]
joined = self . nodes [ 0 ] . joinpsbts ( [ psbt , psbt2 ] )
joined_decoded = self . nodes [ 0 ] . decodepsbt ( joined )
assert len ( joined_decoded [ ' inputs ' ] ) == 4 and len ( joined_decoded [ ' outputs ' ] ) == 2 and " final_scriptwitness " not in joined_decoded [ ' inputs ' ] [ 3 ] and " final_scriptSig " not in joined_decoded [ ' inputs ' ] [ 3 ]
2022-09-20 10:26:17 +02:00
# Newly created PSBT needs UTXOs and updating
addr = self . nodes [ 1 ] . getnewaddress ( )
txid = self . nodes [ 0 ] . sendtoaddress ( addr , 7 )
self . nodes [ 0 ] . generate ( 6 )
self . sync_all ( )
vout = find_output ( self . nodes [ 0 ] , txid , 7 )
psbt = self . nodes [ 1 ] . createpsbt ( [ { " txid " : txid , " vout " : vout } ] , { self . nodes [ 0 ] . getnewaddress ( ) : Decimal ( ' 6.999 ' ) } )
analyzed = self . nodes [ 0 ] . analyzepsbt ( psbt )
assert not analyzed [ ' inputs ' ] [ 0 ] [ ' has_utxo ' ] and not analyzed [ ' inputs ' ] [ 0 ] [ ' is_final ' ] and analyzed [ ' inputs ' ] [ 0 ] [ ' next ' ] == ' updater ' and analyzed [ ' next ' ] == ' updater '
# After update with wallet, only needs signing
updated = self . nodes [ 1 ] . walletprocesspsbt ( psbt , False , ' ALL ' , True ) [ ' psbt ' ]
analyzed = self . nodes [ 0 ] . analyzepsbt ( updated )
assert analyzed [ ' inputs ' ] [ 0 ] [ ' has_utxo ' ] and not analyzed [ ' inputs ' ] [ 0 ] [ ' is_final ' ] and analyzed [ ' inputs ' ] [ 0 ] [ ' next ' ] == ' signer ' and analyzed [ ' next ' ] == ' signer '
# Check fee and size things
assert analyzed [ ' fee ' ] == Decimal ( ' 0.00100000 ' ) and analyzed [ ' estimated_vsize ' ] == 191 and analyzed [ ' estimated_feerate ' ] == Decimal ( ' 0.00523560 ' )
# After signing and finalizing, needs extracting
signed = self . nodes [ 1 ] . walletprocesspsbt ( updated ) [ ' psbt ' ]
analyzed = self . nodes [ 0 ] . analyzepsbt ( signed )
assert analyzed [ ' inputs ' ] [ 0 ] [ ' has_utxo ' ] and analyzed [ ' inputs ' ] [ 0 ] [ ' is_final ' ] and analyzed [ ' next ' ] == ' extractor '
2021-12-21 07:55:15 +01:00
2019-12-10 18:11:28 +01:00
self . log . info ( " PSBT spending unspendable outputs should have error message and Creator as next " )
analysis = self . nodes [ 0 ] . analyzepsbt ( ' cHNidP8BAHECAAAAAQLlOzD0IqyxBs+IP6PTQ4NpMkMfJwUtvZ2MEr9+u0PtAAAAAAD/////AgD5ApUAAAAAFgAUKNw0x8HRctAgmvoevm4u1SbN7XL87QKVAAAAABYAFPck4gF7iL4NL4wtfRAKgQbghiTUAAAAAAABABUCAAAAAAGghgEAAAAAAAJqAAAAAAABAR8AgIFq49AHABYAFJUDtxf2PHo641HEOBOAIvFMNTr2AAAA ' )
assert_equal ( analysis [ ' next ' ] , ' creator ' )
assert_equal ( analysis [ ' error ' ] , ' PSBT is not valid. Input 0 spends unspendable output ' )
2020-01-29 12:26:17 +01:00
self . log . info ( " PSBT with invalid values should have error message and Creator as next " )
analysis = self . nodes [ 0 ] . analyzepsbt ( ' cHNidP8BAHECAAAAAQXbPuwX0yi0oRvSfIXqeruM5+ibuXvP92RCdIEsJR6jAAAAAAD/////AgD5ApUAAAAAFgAUKNw0x8HRctAgmvoevm4u1SbN7XL87QKVAAAAABYAFPck4gF7iL4NL4wtfRAKgQbghiTUAAAAAAABABMCAAAAAAEBQAda8HUHAAAAAAAAAQcCagABAR8AgIFq49AHABYAFJUDtxf2PHo641HEOBOAIvFMNTr2AAAA ' )
assert_equal ( analysis [ ' next ' ] , ' creator ' )
assert_equal ( analysis [ ' error ' ] , ' PSBT is not valid. Input 0 has invalid value ' )
partial Merge #18224: Make AnalyzePSBT next role calculation simple, correct
1ef28b4f7cfba410fef524def1dac24bbc4086ca Make AnalyzePSBT next role calculation simple, correct (Gregory Sanders)
Pull request description:
Sniped test and alternative to https://github.com/bitcoin/bitcoin/pull/18220
Sjors documenting the issue:
```
A PSBT signed by ColdCard was analyzed as follows (see #17509 (comment))
{
"inputs": [
{
"has_utxo": true,
"is_final": false,
"next": "finalizer"
}
],
"estimated_vsize": 141,
"estimated_feerate": 1e-05,
"fee": 1.41e-06,
"next": "signer"
}
I changed AnalyzePSBT so that it returns "next": "finalizer" instead.
```
It makes it much clearer that the role has been decided before hitting the `calc_fee` block, and groups all state-deciding in one spot instead of 2.
Note that this assumes that PSBT roles are a complete ordering, which for now and in the future seems to be a correct assumption.
ACKs for top commit:
Sjors:
ACK 1ef28b4f7cfba410fef524def1dac24bbc4086ca, much nicer. Don't forget to document the bug fix.
achow101:
ACK 1ef28b4f7cfba410fef524def1dac24bbc4086ca
Empact:
ACK https://github.com/bitcoin/bitcoin/pull/18224/commits/1ef28b4f7cfba410fef524def1dac24bbc4086ca
Tree-SHA512: 22ba4234985c6f9c1445b14565c71268cfaa121c4ef000ee3d5117212b09442dee8d46d9701bceddaf355263fe25dfe40def2ef614d4f2fe66c9ce876cb49934
2020-03-02 10:47:44 +01:00
self . log . info ( " PSBT with signed, but not finalized, inputs should have Finalizer as next " )
analysis = self . nodes [ 0 ] . analyzepsbt ( ' cHNidP8BAHECAAAAAXfx5nfVEBDq0BbpUjqqfvNEWyX2dGCkx7RiW9E6DXPbAAAAAAD9////AlDDAAAAAAAAFgAUy/UxxZuzZswcmFnN/E9DGSiHLUsuGPUFAAAAABYAFLsH5o0R38wXx+X2cCosTMCZnQ4baAAAAAABACwCAAAAAAEA4fUFAAAAABl2qRTgSNoebYX9/i35W9ixgrFUmcLJbYisAAAAACICAv4uHbVQEQkVrUThtBx6BnGlZJcyVHMKOYaJoBpEjQJyRzBEAiBse8ynDCBq+3BBEvQUeCnbf6cz0yt3ylnBsgiV2+zFZwIgCzgYKpTB+BmwtRw4fx5spZjueH8hMuJSnXu/wU/z1scBAQMEAQAAACIGAv4uHbVQEQkVrUThtBx6BnGlZJcyVHMKOYaJoBpEjQJyGA8FaUNUAACAAQAAgAAAAIAAAAAAAAAAAAEBHwDh9QUAAAAAFgAU4EjaHm2F/f4t+VvYsYKxVJnCyW0AACICAv4IiIHn01IKyw4lEaIxhArVyFqGABpomkhcTjULKKv7GA8FaUNUAACAAQAAgAAAAIABAAAAAAAAAAA= ' )
# TODO update tx above.
# currently I can't figure out how to generate transaction, that would be valid and will show correct stage finalizer.
# currently it fails at `verify pubkey` for signer
# assert_equal(analysis['next'], 'finalizer')
2020-01-29 12:26:17 +01:00
analysis = self . nodes [ 0 ] . analyzepsbt ( ' cHNidP8BAHECAAAAAbmNr2X0Nc+2AtaXYjPu3kIFc3Cmj1aYy5WQs5yaUfRvAAAAAAD/////AgCAgWrj0AcAFgAUKNw0x8HRctAgmvoevm4u1SbN7XL87QKVAAAAABYAFPck4gF7iL4NL4wtfRAKgQbghiTUAAAAAAABABQCAAAAAAGghgEAAAAAAAFRAAAAAAEBHwDyBSoBAAAAFgAUlQO3F/Y8ejrjUcQ4E4Ai8Uw1OvYAAAA= ' )
assert_equal ( analysis [ ' next ' ] , ' creator ' )
assert_equal ( analysis [ ' error ' ] , ' PSBT is not valid. Output amount invalid ' )
analysis = self . nodes [ 0 ] . analyzepsbt ( ' cHNidP8BAJoCAAAAAkvEW8NnDtdNtDpsmze+Ht2LH35IJcKv00jKAlUs21RrAwAAAAD/////S8Rbw2cO1020OmybN74e3Ysffkglwq/TSMoCVSzbVGsBAAAAAP7///8CwLYClQAAAAAWABSNJKzjaUb3uOxixsvh1GGE3fW7zQD5ApUAAAAAFgAUKNw0x8HRctAgmvoevm4u1SbN7XIAAAAAAAEAnQIAAAACczMa321tVHuN4GKWKRncycI22aX3uXgwSFUKM2orjRsBAAAAAP7///9zMxrfbW1Ue43gYpYpGdzJwjbZpfe5eDBIVQozaiuNGwAAAAAA/v///wIA+QKVAAAAABl2qRT9zXUVA8Ls5iVqynLHe5/vSe1XyYisQM0ClQAAAAAWABRmWQUcjSjghQ8/uH4Bn/zkakwLtAAAAAAAAQEfQM0ClQAAAAAWABRmWQUcjSjghQ8/uH4Bn/zkakwLtAAAAA== ' )
assert_equal ( analysis [ ' next ' ] , ' creator ' )
assert_equal ( analysis [ ' error ' ] , ' PSBT is not valid. Input 0 specifies invalid prevout ' )
partial Merge #18027: "PSBT Operations" dialog
BACKPORT NOTICE
fixup psbt. all missing changes belongs to src/wallet/scriptpubkeyman.h/cpp ----- they are related to descriptor wallet!
-------------------
931dd4760855e036c176a23ec2de367c460e4243 Make lint-spelling.py happy (Glenn Willen)
11a0ffb29d1b4dcc55c8826873f340ab4196af21 [gui] Load PSBT from clipboard (Glenn Willen)
a6cb0b0c29d327d01aebb98b0504f317eb19c3dc [gui] PSBT Operations Dialog (sign & broadcast) (Glenn Willen)
5dd0c03ffa3aeaa69d8a3a716f902f450d5eaaec FillPSBT: report number of inputs signed (or would sign) (Glenn Willen)
9e7b23b73387600d175aff8bd5e6624dd51f86e7 Improve TransactionErrorString messages. (Glenn Willen)
Pull request description:
Add a "PSBT Operations" dialog, reached from the "Load PSBT..." menu item, giving options to sign or broadcast the loaded PSBT as appropriate, as well as copying the result to the clipboard or saving it to a file.
This is based on Sjors' #17509, and depends on that PR going in first. (It effectively replaces the small "load PSBT" dialog from that PR with a more feature-rich one.)
Some notes:
* The way I display status information is maybe unusual (a status bar, rather than messageboxes.) I think it's helpful to have the information in it be persistent rather than transitory. But if people dislike it, I would probably move the "current state of the transaction" info to the top line of the main label, and the "what action just happened, and did it succeed" info into a messagebox.
* I don't really know much about the translation/localization stuff. I put tr() in all the places it seemed like it ought to go. I did not attempt to translate the result of TransactionErrorString (which is shared by GUI and non-GUI code); I don't know if that's correct, but it matches the "error messages in logs should be googleable in English" heuristic. I don't know whether there are things I should be doing to reduce translator effort (like minimizing the total number of distinct message strings I use, or something.)
* I don't really know how (if?) automated testing is applied to GUI code. I can make a list of PSBTs exercising all the codepaths for manual testing, if that's the right approach. Input appreciated.
ACKs for top commit:
instagibbs:
tested ACK https://github.com/bitcoin/bitcoin/pull/18027/commits/931dd4760855e036c176a23ec2de367c460e4243
Sjors:
re-tACK 931dd4760855e036c176a23ec2de367c460e4243
jb55:
ACK 931dd4760855e036c176a23ec2de367c460e4243
achow101:
ACK 931dd4760855e036c176a23ec2de367c460e4243
Tree-SHA512: ade52471a2242f839a8bd6a1fd231443cc4b43bb9c1de3fb5ace7c5eb59eca99b1f2e9f17dfdb4b08d84d91f5fd65677db1433dd03eef51c7774963ef4e2e74f
2020-06-21 12:56:58 +02:00
assert_raises_rpc_error ( - 25 , ' Inputs missing or spent ' , self . nodes [ 0 ] . walletprocesspsbt , ' cHNidP8BAJoCAAAAAkvEW8NnDtdNtDpsmze+Ht2LH35IJcKv00jKAlUs21RrAwAAAAD/////S8Rbw2cO1020OmybN74e3Ysffkglwq/TSMoCVSzbVGsBAAAAAP7///8CwLYClQAAAAAWABSNJKzjaUb3uOxixsvh1GGE3fW7zQD5ApUAAAAAFgAUKNw0x8HRctAgmvoevm4u1SbN7XIAAAAAAAEAnQIAAAACczMa321tVHuN4GKWKRncycI22aX3uXgwSFUKM2orjRsBAAAAAP7///9zMxrfbW1Ue43gYpYpGdzJwjbZpfe5eDBIVQozaiuNGwAAAAAA/v///wIA+QKVAAAAABl2qRT9zXUVA8Ls5iVqynLHe5/vSe1XyYisQM0ClQAAAAAWABRmWQUcjSjghQ8/uH4Bn/zkakwLtAAAAAAAAQEfQM0ClQAAAAAWABRmWQUcjSjghQ8/uH4Bn/zkakwLtAAAAA== ' )
2020-01-29 12:26:17 +01:00
2021-07-13 18:30:17 +02:00
if __name__ == ' __main__ ' :
PSBTTest ( ) . main ( )