sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-24 19:42:46 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

dashify "Finding reviewers" section to be more relevant

Browse Source 
Signed-off-by: Pasta <Pasta@dash.org>
This commit is contained in:
Pasta 2019-05-15 21:21:54 -05:00
parent e7a21faa2b
commit 2f63322cdc
No known key found for this signature in database
GPG Key ID: 0B8EB7A31A44D9C6
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
CONTRIBUTING.md
View File

@ -227,11 +227,10 @@ a worthwhile change based on the judgement of the maintainers.
### Finding Reviewers ### Finding Reviewers
As most reviewers are themselves developers with their own projects, the review The review process is normally fairly responsive on the Dash Core repository, however
process can be quite lengthy, and some amount of patience is required. If you find this might not always be the case. If you find that you've been waiting
that you've been waiting for a pull request to be given attention for several for a pull request to be given attention for several months, there may be a number
months, there may be a number of reasons for this, some of which you can do something of reasons for this, some of which you can do something about:
about:
- It may be because of a feature freeze due to an upcoming release. During this time, - It may be because of a feature freeze due to an upcoming release. During this time,
only bug fixes are taken into consideration. If your pull request is a new feature, only bug fixes are taken into consideration. If your pull request is a new feature,
@ -243,15 +242,15 @@ about:
that personally, though! Instead, take another critical look at what you are suggesting that personally, though! Instead, take another critical look at what you are suggesting
and see if it: changes too much, is too broad, doesn't adhere to the and see if it: changes too much, is too broad, doesn't adhere to the
[developer notes](doc/developer-notes.md), is dangerous or insecure, is messily written, etc. [developer notes](doc/developer-notes.md), is dangerous or insecure, is messily written, etc.
Identify and address any of the issues you find. Then ask e.g. on IRC if someone could give Identify and address any of the issues you find. Then ask e.g. on the forum or on a community
their opinion on the concept itself. discord if someone could give their opinion on the concept itself.
- It may be because your code is too complex for all but a few people. And those people - It may be because your code is too complex for all but a few people. And those people
may not have realized your pull request even exists. A great way to find people who may not have realized your pull request even exists. A great way to find people who
are qualified and care about the code you are touching is the are qualified and care about the code you are touching is the
[Git Blame feature](https://help.github.com/articles/tracing-changes-in-a-file/). Simply [Git Blame feature](https://help.github.com/articles/tracing-changes-in-a-file/). Simply
find the person touching the code you are touching before you and see if you can find find the person touching the code you are touching before you and see if you can find
them and give them a nudge. Don't be incessant about the nudging though. them and give them a nudge. Don't be incessant about the nudging though.
- Finally, if all else fails, ask on IRC or elsewhere for someone to give your pull request - Finally, if all else fails, ask on discord or elsewhere for someone to give your pull request
a look. If you think you've been waiting an unreasonably long amount of time (month+) for a look. If you think you've been waiting an unreasonably long amount of time (month+) for
no particular reason (few lines changed, etc), this is totally fine. Try to return the favor no particular reason (few lines changed, etc), this is totally fine. Try to return the favor
when someone else is asking for feedback on their code, and universe balances out. when someone else is asking for feedback on their code, and universe balances out.