sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-27 21:12:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

[qa] util: Check return code after closing bitcoind proc

Browse Source 
This has no effect on the outcome of test cases, but
prints shorter and less confusing tracebacks on fails.

I.e. does not print an obvious "ConnectionRefusedError"
when shutting down the nodes due to an invalid return code.
This commit is contained in:
MarcoFalke 2017-06-20 13:54:10 +02:00
parent 643fa0b22d
commit 999923e4bb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/functional/test_framework/util.py
View File

@ -300,8 +300,8 @@ def _stop_node(node, i):
except http.client.CannotSendRequest as e: except http.client.CannotSendRequest as e:
logger.exception("Unable to stop node") logger.exception("Unable to stop node")
return_code = bitcoind_processes[i].wait(timeout=BITCOIND_PROC_WAIT_TIMEOUT) return_code = bitcoind_processes[i].wait(timeout=BITCOIND_PROC_WAIT_TIMEOUT)
assert_equal(return_code, 0)
del bitcoind_processes[i] del bitcoind_processes[i]
assert_equal(return_code, 0)
def _stop_nodes(nodes): def _stop_nodes(nodes):
"""Stop multiple bitcoind test nodes """Stop multiple bitcoind test nodes