sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 03:52:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge #6481: test: actually use masternode with basic bls pubkey in mnauth test

Browse Source 
ec00c372c7 test: fix off-by-one in dynamically_add_masternode (UdjinM6)
6519856344 test: don't add legacy bls mn on start (UdjinM6)
3db20e3ed4 test: actually use masternode with basic bls pubkey in mnauth test (UdjinM6)

Pull request description:

  ## Issue being fixed or feature implemented
  `rpc_manuth` is failing in ~50% cases locally because we still use legacy pubkeys (not in 100% cases because sometimes they look like basic ones). In CI it fails too but we retry failed tests a few times so it's less noticeable. Example of "unlucky" tests: https://gitlab.com/dashpay/dash/-/jobs/8613271300#L1867.

  #6467 follow-up

  ## What was done?
  Add another masternode after v19 activaition to actually use basic bls pubkey

  ## How Has This Been Tested?
  run tests

  ## Breaking Changes
  n/a

  ## Checklist:
  - [ ] I have performed a self-review of my own code
  - [ ] I have commented my code, particularly in hard-to-understand areas
  - [ ] I have added or updated relevant unit/integration/functional/e2e tests
  - [ ] I have made corresponding changes to the documentation
  - [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  knst:
    utACK ec00c372c7
  PastaPastaPasta:
    utACK ec00c372c7

Tree-SHA512: 850a02ea1bd943762cdb0be706f3703742944c294ee9603b1f9ab95a6b10fb827bc9376e03333177d956b2c13df7384cfe0eb2ffef4d05ff3ec239caa8318d24
This commit is contained in:
pasta 2024-12-14 12:10:51 -06:00
commit f656c51979
No known key found for this signature in database
GPG Key ID: 5255B86F912A614A
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
test/functional/rpc_mnauth.py
View File

@ -17,10 +17,11 @@ Tests mnauth RPC command
class FakeMNAUTHTest(DashTestFramework): class FakeMNAUTHTest(DashTestFramework):
def set_test_params(self): def set_test_params(self):
self.set_dash_test_params(2, 1) self.set_dash_test_params(1, 0)
def run_test(self): def run_test(self):
self.activate_v19(expected_activation_height=900) self.activate_v19(expected_activation_height=900)
self.dynamically_add_masternode()
masternode = self.mninfo[0] masternode = self.mninfo[0]
masternode.node.add_p2p_connection(P2PInterface()) masternode.node.add_p2p_connection(P2PInterface())

2
test/functional/test_framework/test_framework.py
View File

@ -1279,7 +1279,7 @@ class DashTestFramework(BitcoinTestFramework):
return return
self.dynamically_initialize_datadir(node_p2p_port, node_rpc_port) self.dynamically_initialize_datadir(node_p2p_port, node_rpc_port)
node_info = self.add_dynamically_node(self.extra_args[1]) node_info = self.add_dynamically_node(self.extra_args[0])
args = ['-masternodeblsprivkey=%s' % created_mn_info.keyOperator] + node_info.extra_args args = ['-masternodeblsprivkey=%s' % created_mn_info.keyOperator] + node_info.extra_args
self.start_node(mn_idx, args) self.start_node(mn_idx, args)