sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 03:52:49 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
19,649 Commits 24 Branches 554 Tags 573 MiB
4f5d4be443
Commit Graph

19649 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
PastaPastaPasta
4f5d4be443
dashification 2021-07-13 13:14:09 -05:00
Wladimir J. van der Laan
9d1bbabbc8
Merge #17302: cli: Add "headers" and "verificationprogress" to -getinfo 
31879345ee9a222b12014c8b2359e1737ff0d8c4 cli: Add "headers" and "verificationprogress" to -getinfo (Wladimir J. van der Laan)

Pull request description:

  These values are useful to know the current progress of initial sync, or of catching up, which is arguably the use of a quick `-getinfo` command.

ACKs for top commit:
  MarcoFalke:
    unsigned ACK 31879345ee9a222b12014c8b2359e1737ff0d8c4
  jonasschnelli:
    utACK 31879345ee9a222b12014c8b2359e1737ff0d8c4
  jonatack:
    Tested ACK 31879345ee9a222b12014c8b2359e1737ff0d8c4 on Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux

Tree-SHA512: 185180ab426b4db5d99eb208ee88d1606f585361875ba3a92b6c28a74fe181d72ed710c8859b969ba49b1ca7d2385695932b79ff621c7a2a7cedd0df717a99ed
 2021-07-13 13:14:09 -05:00
fanquake
9b8250c7c6
Merge #16986: doc: Doxygen-friendly CuckooCache comments 
7aad3b68e7e1680870ca70d945eee88f790d6454 doc: Doxygen-friendly CuckooCache comments (Jon Layton)

Pull request description:

  Similar theme to #16947.

  - `invalid`, `contains` now appear in Doxygen docs
  - `setup` refers to correct argument name `b`
  - Argument references in `code blocks `
  - Lists markdown conformant, uniform line endings

  Tested with `make docs`

ACKs for top commit:
  laanwj:
    ACK 7aad3b68e7e1680870ca70d945eee88f790d6454
  practicalswift:
    ACK 7aad3b68e7e1680870ca70d945eee88f790d6454

Tree-SHA512: 70b38c10e534bad9c6ffcd88cc7a4797644afba5956d47a6c7cc655fcd5857a91f315d6da60e28ce9678d420ed4a51e22267eb8b89e26002b99cad63373dd349
 2021-07-13 13:14:08 -05:00
Wladimir J. van der Laan
6a980d92d9
Merge #17226: gui: Fix payAmount tooltip in SendCoinsEntry 
0fc81a1e8724547a226e5fae5c32fc32d8dfb733 gui: Fix payAmount tooltip in SendCoinsEntry (João Barbosa)

Pull request description:

  Before the tooltip shows in wrong places:

  ![Screenshot 2019-10-23 at 11 33 49](https://user-images.githubusercontent.com/3534524/67384904-f6b6a380-f589-11e9-832c-ec1643014b96.png)
  ![Screenshot 2019-10-23 at 11 33 23](https://user-images.githubusercontent.com/3534524/67384905-f74f3a00-f589-11e9-9944-a52fee097e02.png)

  Now only shows in the amount field:

  ![Screenshot 2019-10-23 at 11 35 30](https://user-images.githubusercontent.com/3534524/67384919-ff0ede80-f589-11e9-8ce4-c122e11fe885.png)

ACKs for top commit:
  laanwj:
    ACK 0fc81a1e8724547a226e5fae5c32fc32d8dfb733

Tree-SHA512: 0857e568c21d380a68c81e9be3212b1745d7d3199a1d5fdef9afc8feed0272f215726fa98bbf8a3fb332389c5454f2316bc1581f1a2ccd76cef46a0e3ac6f99f
 2021-07-13 13:14:08 -05:00
MarcoFalke
432f329f83
Merge #17206: test: Add testcase to simulate bitcoin schema in leveldb 
4896bacc00549c14f3284f5a2b61fb848ac31be0 Add testcase to simulate bitcoin schema in leveldb (MapleLaker)

Pull request description:

  Resurrecting #14125 with updates based on comments of closed PR

ACKs for top commit:
  laanwj:
    ACK 4896bacc00549c14f3284f5a2b61fb848ac31be0
  dongcarl:
    ACK 4896bacc00549c14f3284f5a2b61fb848ac31be0

Tree-SHA512: 3290ea7e1e998901d5ee8921d1d76cec399cae30ac1911a45b86826afed47cee1acf92bd6438f1fa11ed785a3b17abdcb1c169bc0419945eda9fe4c089d0b6eb
 2021-07-13 13:14:08 -05:00
Wladimir J. van der Laan
44e79f0740
Merge #17180: gui: Improved tooltip for send amount field 
088a730fe6f893d43b55ec52e6b5080fd445dd9e static tooltip (JeremyCrookshank)

Pull request description:

  I noticed that on Bitcoin sends the tooltip wasn't very clear for new users and I hope my PR is more concise. If it needs changing more will happily change too 👍
  ![IMG_20191017_192739](https://user-images.githubusercontent.com/46864828/67036925-75d45380-f114-11e9-88bf-bab58161f80a.jpg)

ACKs for top commit:
  laanwj:
    ACK 088a730fe6f893d43b55ec52e6b5080fd445dd9e

Tree-SHA512: 2b1103ac934d8f68d22333af3c0f5d4228b665b1e507378d4ae5b83cc2b6d6aeb46a3d68298cca93feb839db5caa560322c8df5261dc2f7db5abeed9f0dd9c69
 2021-07-13 13:14:07 -05:00
fanquake
5857a5d5b4
Merge #17157: doc: Added instructions for how to add an upsteam to forked repo 
f09ba060cacd42e4cb9a242c1d731deb1f6623c6 doc: Added instructions for how to add an upsteam to forked repo (dannmat)

Pull request description:

  As a first time git developer, I struggled to understand whether to create a new fork for each pull request or not.

  After asking the IRC chat, I have added this to the documentation to further help new developers using git.

ACKs for top commit:
  fanquake:
    ACK f09ba060cacd42e4cb9a242c1d731deb1f6623c6 - For such a simple change, I think we've bike-shed this enough already. The `bitcoin/bitcoin` repo isn't really where anyone should be learning how to use `git` etc, but I think linking out here is ok.

Tree-SHA512: e0e9d655d0725e0128673afedb81dc5ba9387968fcbb681de7e50155a2cfa1a7f39fad040b596f4de9ad6727a1a8a90fd3d36eaa5242bc12186c3b82abd23fb2
 2021-07-13 13:14:07 -05:00
fanquake
062e61dc4a
Merge #17186: gui: Add placeholder text to the sign message field 
7005d6ab8f4393545ec27f528d8c03fc4516ddab gui: Add placeholder text to the sign message field (Danny-Scott)

Pull request description:

  When using the sign message functionality I noticed the "message" field had no label or placeholder text to highlight what it's for.

  I've added the placeholder text to match the tool tip to help it be more user friendly.

ACKs for top commit:
  hebasto:
    Re-ACK 7005d6ab8f4393545ec27f528d8c03fc4516ddab
  fanquake:
    ACK 7005d6ab8f4393545ec27f528d8c03fc4516ddab

Tree-SHA512: 17fe51c134f6373d8d5f9ca98b15bd936da4e61aa5258ceb5d318575d49b43cbfde6f4c3f720eb5928206902e6ba52811ba08737a03c95224e45dabc947d9d11
 2021-07-13 13:14:07 -05:00
fanquake
b485210d68
Merge #17162: chain: Remove CBlockIndex::SetNull helper 
fa0467326ff004a0a20c6af9c8f6adcc74a0c8af chain: Set all CBlockIndex members to null, remove SetNull helper (MarcoFalke)

Pull request description:

  The first commit removes the `SetNull` helper and inlines the member initialization (C++11). See https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#c-data-structures for rationale.

  <strike>The second commit adds the `cs_main` lock annotation to `RaiseValidity`. See also #17161.</strike>

ACKs for top commit:
  promag:
    Code review ACK fa0467326ff004a0a20c6af9c8f6adcc74a0c8af.
  practicalswift:
    ACK fa0467326ff004a0a20c6af9c8f6adcc74a0c8af -- diff still looks correct :)
  laanwj:
    ACK fa0467326ff004a0a20c6af9c8f6adcc74a0c8af, this makes it easy to see that all fields are initialized.

Tree-SHA512: 1b2b9fb0951c03c75b9cce322b89d4ecc9a364ae78b94d91b0b4669437824394dfada820ab6f74dfac3193f602899abfdc244ae2d9351ad293f555488f03470e
 2021-07-13 13:14:06 -05:00
Wladimir J. van der Laan
bd18cd8e07
Merge #17131: rpc: fix -rpcclienttimeout 0 option 
b3b26e149c34fee9c7ae8548c6e547ec6254b441 rpc: fix -rpcclienttimeout 0 option (Fabian Jahr)

Pull request description:

  fixes #17117

  I understood the bug as the help string being wrong, rather than that this feature is missing and should be added. Let me know if it should be the other way around.

  It is notable that if 0 is given as an argument, the fallback that is being used is the libevent default of 50 seconds, rather than `DEFAULT_HTTP_CLIENT_TIMEOUT` (900 seconds). This is not intuitive for the user. I could handle this in this PR but I am unsure which would be the better solution then: Actually adding the feature as described in the help string or falling back to `DEFAULT_HTTP_CLIENT_TIMEOUT`? Happy to hear opinions.

ACKs for top commit:
  MarcoFalke:
    unsigned ACK b3b26e149c34fee9c7ae8548c6e547ec6254b441

Tree-SHA512: 65e526a652c0adcdb4f895e8d78d60c7caa5904c9915b165a3ae95725c87d13af1f916359f80302452a2fcac1a80f4c58cd805ec8c28720fa4b91b3c8baa4155
 2021-07-13 13:14:06 -05:00
fanquake
4c5e542c46
Merge #17125: gui: Add toolTip and placeholderText to sign message fields 
610d9384de7f4de861d94c9b1af4fddc8aa57ad9 gui: Added label & tooltip for Verify Message labels (dannmat)

Pull request description:

  When using the Verify Message functionality, I found the input boxes to be rather confusing as they had no guidance for their purpose.

  I have added tooltips and labels to aid users when verifying messages in future

ACKs for top commit:
  promag:
    Code review ACK 610d9384de7f4de861d94c9b1af4fddc8aa57ad9. Nit, commit and title are a little weird. Suggestion: "gui: Add toolTip and placeholderText to sign message fields"
  MarcoFalke:
    ACK 610d9384de7f4de861d94c9b1af4fddc8aa57ad9 (looks good, didn't compile or tested the changes)
  fanquake:
    ACK - 610d9384de7f4de861d94c9b1af4fddc8aa57ad9

Tree-SHA512: d6a1bc872ad270dce440e96a163ce72cdd4708913d87a0fea749fc8cf2d8163b791cbb96a82030e0cb7d239920ceb0e3f05e0eec113f45a1a8e1309fbd92b4b0
 2021-07-13 13:14:06 -05:00
Wladimir J. van der Laan
a5d5bc5ecf
Merge #17033: Disable _FORTIFY_SOURCE when enable-debug 
44f7a8d7a774f82417106c452d793e6f091bc23e Disable _FORTIFY_SOURCE when enable-debug (Andrew Chow)

Pull request description:

  The `_FORTIFY_SOURCE` macro is enabled by default when hardening is enabled, but it requires optimization in order to be used. Since we disable all optimization with `--enable-debug`, this macro doesn't actually do anything and instead just causes a lot of warnings to be printed. This PR explicitly disables `_FORTIFY_SOURCE` so that these useless warnings aren't printed.

ACKs for top commit:
  laanwj:
    Thanks. ACK 44f7a8d7a774f82417106c452d793e6f091bc23e

Tree-SHA512: e9302aef794dfd9ca9d0d032179ecc51d3212a9a0204454419f410011343b27c32e6be05f385051b5b594c607b91b8e0e588f644584d6684429a649a413077d9
 2021-07-13 13:14:05 -05:00
Wladimir J. van der Laan
e4457ce2ef
Merge #17085: init: Change fallback locale to C.UTF-8 
facb9a1315f97489a20eb0e969fdb14b5128ed2f init: Change fallback locale to C.UTF-8 (Wladimir J. van der Laan)

Pull request description:

  Much of our code assumes file system UTF-8 support, and this is a more realistic guess for modern systems anyway than the default character set (which would be ASCII only). So change the assumed fallback locale (if no locale is defined by the user or OS) to `C.UTF-8`.

  related: https://github.com/bitcoin/bitcoin/issues/14948#issuecomment-488385462

ACKs for top commit:
  MarcoFalke:
    ACK facb9a1315f97489a20eb0e969fdb14b5128ed2f

Tree-SHA512: 5075f9fe6791572d76ec38c58cd56f04ed8086c06a7d7f446d062dffc313c62466ba81f1a7d6b8c7e95791fcff82e4f76871c3534478fbfe5beb456dd8eea340
 2021-07-13 13:14:05 -05:00
fanquake
c79a03ec93
Merge #17087: build: Add variable printing target to Makefiles 
181989f6c9427fc266dbdcc84cb60ac03e67cdb2 build: Add variable printing target to Makefiles (Carl Dong)

Pull request description:

  ```
  I kept finding myself needing these to debug our build system, since
  they are innocuous and are very helpful they probably belong in the
  codebase.

  Source: John Graham-Cumming
  https://www.cmcrossroads.com/article/printing-value-makefile-variable
  ```

ACKs for top commit:
  MarcoFalke:
    ACK 181989f6c9427fc266dbdcc84cb60ac03e67cdb2
  fanquake:
    ACK 181989f6c9427fc266dbdcc84cb60ac03e67cdb2 - concise amount of useful code. Tested on macOS. Did not visit the link.

Tree-SHA512: 2139621e68a499c7347663ca9dc04e166ea6280e05986c27858df0156016ef2f9461262464d70c601419384f43a4ae3bcc67dfc0a05dbeef64f08386ab429cd8
 2021-07-13 13:14:05 -05:00
Wladimir J. van der Laan
22111c88f6
Merge #17066: build: Remove workaround for ancient libtool 
30fc1a3f5470cb347eb4aed281242f120510466f build: Remove workaround for ancient libtool (Hennadii Stepanov)
6ca01b9a104ebadbe7e180cb2b9d390f7c09b4ab build: Ensure a minimal version of libtool (Hennadii Stepanov)

Pull request description:

  Since libtool 1.5.2, on Linux libtool no longer sets RPATH for any directories in the dynamic linker search path, so there is no longer an issue.

  This commit reverts a98356fee8.

  Refs:
  - https://wiki.debian.org/RpathIssue
  - [Debian jessie has libtool 2.4.2](https://packages.debian.org/jessie/libtool)

ACKs for top commit:
  laanwj:
    ACK 30fc1a3f5470cb347eb4aed281242f120510466f

Tree-SHA512: fab56265d4d2c96216a353cc076c6f510e15748d8134f97bae2f67b6d8c0b6a1a9f362d2ab23b19ccc3a8bba8eac3bb1668fc3e42037590f63a7ab4819c9ee15
 2021-07-13 13:14:04 -05:00
Wladimir J. van der Laan
3d8cb7b430
Merge #17030: test: Fix Python Docstring to include all Args. 
8acd58927a614e006641384f61f8e7fca1cc68fc Fix Python Docstring to include all Args. (John Bampton)

Pull request description:

  Found a Python function that had incorrect and missing arguments in its Docstring.

ACKs for top commit:
  laanwj:
    ACK 8acd58927a614e006641384f61f8e7fca1cc68fc

Tree-SHA512: 936f275f29a700d630bb479b5283e47b66f2df76d8b8c053f594e6aedf783cc98a29c924c3a46613f112dfc884acb50f21a0b18f96d939e887b12b921ef2e10f
 2021-07-13 13:14:04 -05:00
fanquake
d96e363a3f
Merge #17031: gui: Prevent processing duplicate payment requests 
3f89e1eb237efcbd6415ca2cd0acddb6596153d7 Prevent processing duplicate payment requests (João Barbosa)

Pull request description:

  Considering the following from Qt [src/plugins/platforms/cocoa/qcocoaapplicationdelegate.mm#L267](13e0a36626/src/plugins/platforms/cocoa/qcocoaapplicationdelegate.mm (L267))

  ```cpp
  - (void)application:(NSApplication *)sender openFiles:(NSArray *)filenames
  {
      Q_UNUSED(filenames);
      Q_UNUSED(sender);

      for (NSString *fileName in filenames) {
          QString qtFileName = QString::fromNSString(fileName);
          if (inLaunch) {
              // We need to be careful because Cocoa will be nice enough to take
              // command line arguments and send them to us as events. Given the history
              // of Qt Applications, this will result in behavior people don't want, as
              // they might be doing the opening themselves with the command line parsing.
              if (qApp->arguments().contains(qtFileName))
                  continue;
          }
          QWindowSystemInterface::handleFileOpenEvent(qtFileName);
      }
  ```

  And that a2714a5c69f0b0506689af04c3e785f71ee0915d was merged, now Qt isn't able to filter out the above notifications, and then a [QFileOpenEvent](https://doc.qt.io/qt-5/qfileopenevent.html) event is delivered to `PaymentServer::eventFilter`, which in turn (re)adds the payment request.

  This change fixes #17025, but makes sense regardless of the issue.

ACKs for top commit:
  laanwj:
    Nah, this seems fine, utACK 3f89e1eb237efcbd6415ca2cd0acddb6596153d7
  Sjors:
    ACK 3f89e1e on macOS 10.14.6
  achow101:
    Code review ACK 3f89e1eb237efcbd6415ca2cd0acddb6596153d7

Tree-SHA512: dd1e0c73fd84953418173ca71f6f5a67ad74a5dc7e3b1d54915ef0545f513df6a24f27242a77bb094e2833a478e2f3bf30ecd50251f3c55b65e780097cb8ab4d
 2021-07-13 13:14:04 -05:00
MarcoFalke
f46f16772d
Merge #16964: gui: Change sendcoins dialogue Yes to Send 
a649cc6a17b8d8d602c6b67037b0c926960f9cdb Change sendcoins dialogue Yes to Send (Gregory Sanders)

Pull request description:

  It's more self-explanatory, matches "cancel" better, and makes future extensions such as https://github.com/bitcoin/bitcoin/pull/16944 more directly understandable to the user.

ACKs for top commit:
  Sjors:
    Trivial code review ACK a649cc6. I also used Send in #16966 (`ui - make send a wizard`)
  laanwj:
    ACK a649cc6a17b8d8d602c6b67037b0c926960f9cdb
  jonatack:
    Code review ACK a649cc6a17b8d8d602c6b67037b0c926960f9cdb

Tree-SHA512: fe4993bc7ac653d28f3d399ade046bcfd405511aec06ff041bb5aef47e0736faf3e3112a6db660cd761af56392dc6b97f2c2341ed3eff4490079c5eb8a0d465a
 2021-07-13 13:14:03 -05:00
Wladimir J. van der Laan
ecf642bb8a
Merge #16952: gui: make sure to update the UI when deleting a transaction 
addaf8af8268d918973883a304025d40af5a33c1 make sure to update the UI when deleting a transaction (Jonas Schnelli)

Pull request description:

  `CWallet::ZapSelectTx` removes transactions from the internal model, but leaves the UI in the dark.
  Adding a `NotifyTransactionChanged()` should avoid having invalid transactions in the GUI.

  Fixes #16950

ACKs for top commit:
  fanquake:
    ACK addaf8af8268d918973883a304025d40af5a33c1 - tested that this fixes #16950
  Sjors:
    tACK addaf8a: tested with an unpruned wallet by calling `removeprunedfunds` on an RBF-replaced transaction. It neatly disappears from the UI.
  kristapsk:
    ACK addaf8af8268d918973883a304025d40af5a33c1 (tested both with and without this change)

Tree-SHA512: 65e8c690847f7499e82c9fef67b60d9aaa63c853732fe7fa7281da33054fcdcd9d24f5b86de71b0827728c25bac8efb7db445863f990304ebfee6fc450620c47
 2021-07-13 13:14:03 -05:00
Wladimir J. van der Laan
732b4bcc63
Merge #16931: test: add unittests for CheckProofOfWork 
0cc7dd74e0af735dddf7e786f4ed136c382a4ad5 test: add unittests for CheckProofOfWork (soroosh-sdi)

Pull request description:

  following situations are covered:
  - negative target
  - overflow target
  - target easier then powLimit
  - invalid hash (hash > target)

  Signed-off-by: soroosh-sdi <soroosh.sardari@gmail.com>

ACKs for top commit:
  promag:
    ACK 0cc7dd74e0af735dddf7e786f4ed136c382a4ad5, just read the code.
  laanwj:
    ACK 0cc7dd74e0af735dddf7e786f4ed136c382a4ad5

Tree-SHA512: 9f9ee952ebb211202939450aa3d61b3c2fae992dcfcab085e877507d78e02ea39a51ccacfc4852a0555f3cba07504ee132abd5cbfed75489553bee45c760bc7e
 2021-07-13 13:14:03 -05:00
Wladimir J. van der Laan
d181c0126e
Merge #16971: qt: Change default size of intro frame 
8cf9898b53d74bd474cc5188e07e671e24a3791f qt: Change default size of intro frame (Emil Engler)

Pull request description:

  Because of the new pruning feature in the intro frame, the size of the intro frame is too small.
  Like you see, some text is not visible completely.

  ### Before
  ![Before](https://i.imgur.com/ppZ3Gf9.png)
  ### After
  ![After](https://i.imgur.com/wcElqLA.png)

  Update: I changed it so it adjusts the size dynamically

ACKs for top commit:
  fanquake:
    ACK 8cf9898b53d74bd474cc5188e07e671e24a3791f - Before and after macOS screens below. Given that most users will only ever see this screen once, I think Qts best effort to dynamically size it is fine.
  jonasschnelli:
    utACK 8cf9898b53d74bd474cc5188e07e671e24a3791f
  Sjors:
    Tested ACK 8cf9898 on macOS. English already fit, so to reproduce the issue, launch in German with `-resetguisettings -lang=de`.
  laanwj:
    ACK 8cf9898b53d74bd474cc5188e07e671e24a3791f

Tree-SHA512: 568b0ae0d5feeda603c0ccf67b5bb3857becea8f22fb98695e1901e662cb1e76377589e39ec743258154d7f6c4a5e544bb003fcc73597400dd427db047392638
 2021-07-13 13:14:02 -05:00
Wladimir J. van der Laan
68810e8e57
Merge #16962: doc: Put PR template in comments 
203a67d21f566634165531a7a75c3f8c9f9c9d6a doc: Put PR template in comments (Wladimir J. van der Laan)

Pull request description:

  This prevents the common annoyance of the text being included into PRs
  accidentally.

ACKs for top commit:
  sdaftuar:
    utACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a
  fanquake:
    ACK 203a67d21f566634165531a7a75c3f8c9f9c9d6a - I make an effort to remove it whenever I see it in a PR.

Tree-SHA512: 3514d285488b7930d7f3d7f8823198d7325d8b7de57a6d8f13e559c0c23b30d58916b15782cbbdc347a375b418e9d0f7a5b99b34d26f3b957d7d5a03a3d83dfd
 2021-07-13 13:14:02 -05:00
Wladimir J. van der Laan
bca013ddd6
Merge #16957: 9% less memory: make SaltedOutpointHasher noexcept 
67d99900b0d770038c9c5708553143137b124a6c make SaltedOutpointHasher noexcept (Martin Ankerl)

Pull request description:

  If the hash is not `noexcept`, `unorderd_map` has to assume that it can throw an exception. Thus when rehashing care needs to be taken. libstdc++ solves this by simply caching the hash value, which increases memory of each node by 8 bytes. Adding `noexcept` prevents this caching. In my experiments with `-reindex-chainstate -stopatheight=594000`, memory usage (maximum resident set size) has decreased by 9.4% while runtime has increased by 1.6% due to additional hashing. Additionally, memusage::DynamicUsage() is now more accurate and does not underestimate.

  |                                       | runtime h:mm:ss | max RSS kbyte |
  |---------------------------------------|-----------------|--------------|
  | master                                |         4:13:59 |      7696728 |
  | 2019-09-SaltedOutpointHasher-noexcept |         4:18:11 |      6971412 |
  | change                                |          +1.65% |       -9,42% |

  Comparison of progress masters vs. 2019-09-SaltedOutpointHasher-noexcept
  ![out](https://user-images.githubusercontent.com/14386/65541887-69424e00-df0e-11e9-8644-b3a068ed8c3f.png)

ACKs for top commit:
  jamesob:
    Tested ACK 67d99900b0

Tree-SHA512: 9c44e3cca993b5a564dd61ebd2926b9c4a238609ea4d283514c018236f977d935e35a384dd4696486fd3d78781dd2ba190bb72596e20a5e931042fa465872a0b
 2021-07-13 13:03:30 -05:00
Wladimir J. van der Laan
a597c1bb8e
Merge #16577: util: CBufferedFile fixes and unit test 
efd2474d17098c754367b844ec646ebececc7c74 util: CBufferedFile fixes (Larry Ruane)

Pull request description:

  The `CBufferedFile` object guarantees its user is able to "rewind" the data stream (that's being read from a file) up to a certain number of bytes, as specified by the user in the constructor. This guarantee is not honored due to a bug in the `SetPos` method.

  Such rewinding is done in `LoadExternalBlockFile()` (currently the only user of this object), which deserializes a series of `CBlock` objects. If that function encounters something unexpected in the data stream, which is coming from a `blocks/blk00???.dat` file, it "rewinds" to an earlier position in the stream to try to get in sync again. The `CBufferedFile` object does not actually rewind its file offset; it simply repositions its internal offset, `nReadPos`, to an earlier position within the object's private buffer; this is why there's a limit to how far the user may rewind.

  If `LoadExternalBlockFile()` needs to rewind (call `blkdat.SetPos()`), the stream may not be positioned as it should be, causing errors in deserialization. This need to rewind is probably rare, which is likely why this bug hasn't been noticed already. But if this object is used elsewhere in the future, this could be a serious problem, especially as, due to the nature of the bug, the `SetPos()` _sometimes_ works.

  This PR adds a unit test for `CBufferedFile` that fails due to this bug. (Until now it has had no unit tests.) The unit test provides good documentation and examples for developers trying to understand `LoadExternalBlockFile()` and for future users of this object.

  This PR also adds code to throw an exception from the constructor if the rewind argument is not less than the buffer size (since that doesn't make any sense).

  Finally, I discovered that the object is too restrictive in one respect: When the deserialization methods call this object's `read` method, a check ensures that the number of bytes being requested is less than the size of the buffer (adjusting for the rewind size), else it throws an exception. This restriction is unnecessary; the object being deserialized can be larger than the buffer because multiple reads from disk can satisfy the request.

ACKs for top commit:
  laanwj:
    ACK ~after squash.~ efd2474d17098c754367b844ec646ebececc7c74
  mzumsande:
    I had intended to follow up earlier on my last comment, ACK efd2474d17098c754367b844ec646ebececc7c74. I reviewed the code, ran tests and did a successful reindex on testnet with this branch.

Tree-SHA512: 695529e0af38bae2af4e0cc2895dda56a71b9059c3de04d32e09c0165a50f6aacee499f2042156ab5eaa6f0349bab6bcca4ef9f6f9ded4e60d4483beab7e4554
 2021-07-13 13:03:30 -05:00
fanquake
d3a9042e01 Merge #16870: build: update boost macros to latest upstream for improved error reporting 
bb99c4e684bbd3053ecf7a789049b11b29260189 build: update boost macros to latest upstream (fanquake)

Pull request description:

  Fixes: #16803

  I opened an [upstream PR](https://github.com/autoconf-archive/autoconf-archive/pull/197) to improve the Boost error reporting, so pull the latest macros.

ACKs for top commit:
  laanwj:
    Code review ACK bb99c4e684bbd3053ecf7a789049b11b29260189
  jonatack:
    Sanity check ACK bb99c4e684bbd3053ecf7a789049b11b29260189, light code read, built and ran tests on Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux. Only tested the happy path.

Tree-SHA512: 34704ed623ac0085215fd874a23fde8f6e39a69fa20d78472b0c4d2306dc101c0571fa26c4c8821600746b94daaaf05faf6d15546899d588081c26357d29ec46
 2021-07-12 20:54:22 -05:00
fanquake
6b46bddf64 Merge #16914: doc: Update homebrew instruction for doxygen 
14c6a2de1a4cf8cc17116d418242709ba2519b9e [doc] update brew instruction for doxygen (Sjors Provoost)

Pull request description:

  I noticed while testing #16912 that `brew install doxygen --with-graphviz` no long works. Instead you need to use `brew install graphviz doxygen`.

ACKs for top commit:
  fanquake:
    ACK 14c6a2de1a4cf8cc17116d418242709ba2519b9e - tested a `make docs` on macOS with and without `graphviz` (`dot`) available.

Tree-SHA512: 2682568e558c16e9e0a657421c449b74cc14a89771844c1c88623fb75b07b89afb63c45a919eb7b9c3dba9bdfaef21489b5f7ea45a08d8d5da18614657c19e47
 2021-07-12 20:54:22 -05:00
Wladimir J. van der Laan
821200cb2d Merge #16809: depends: zlib: Move toolchain options to configure 
f0636d34185d235f51eebaa2ad14c1e6fcaed6c2 depends: zlib: Move toolchain options to configure (Carl Dong)

Pull request description:

  ```
  zlib has its own custom configure script, see comment in zlib.mk for
  more details
  ```

  Performed Guix cross-builds locally and everything worked as expected.

ACKs for top commit:
  laanwj:
    ACK f0636d34185d235f51eebaa2ad14c1e6fcaed6c2

Tree-SHA512: 7ff6114e52a9c49941da31cb0ebd8918b056bf23343790d758e107003d856f3b1f16ebf4ce0ce22e1216a37a610b4c106def3f869d128bfffa61280d45ed6b38
 2021-07-12 20:54:22 -05:00
fanquake
6638fa763c Merge #16879: build: remove redundant sed patching 
93995c27515aa268c2c1aefe82f1a3cee33966ce build: remove unnecessary qt xcb patching (fanquake)
4d45577c4314fd7075094d5b3384b4b86100c125 build: remove unnecessary macOS qt patching (fanquake)

Pull request description:

  While looking at #16838 I found at least two cases of `sed` patching in depends that now seems to be redundant. There's possibly a [third case](https://github.com/bitcoin/bitcoin/pull/16837#discussion_r322842701), but I haven't looked into that enough yet.

  Patching `0` -> `kCGMouseButtonLeft` should not be required, as [`kCGMouseButtonLeft`](https://code.qt.io/cgit/qt/qtbase.git/tree/src/plugins/platforms/cocoa/qcocoacursor.mm?h=5.9#n82) has been used in the `cocoa/qcocoacursor.mm` source for a while.

  The include we were modifying in [`src/plugins/platforms/xcb/qxcbxsettings.cpp`](https://code.qt.io/cgit/qt/qtbase.git/tree/src/plugins/platforms/xcb/qxcbxsettings.cpp?h=5.9#n47) was removed in [this commit](https://code.qt.io/cgit/qt/qtbase.git/commit/src/plugins/platforms/xcb/qxcbxsettings.cpp?h=5.9&id=78731b434e0e99ad108601249108e12d8a49c350).

ACKs for top commit:
  dongcarl:
    ACK 93995c27515aa268c2c1aefe82f1a3cee33966ce

Tree-SHA512: 5e0cbf317b798ce2e142a42b7fabf1d9e8e00d12f59589e98d790195ba27db60858f933b035c6e9cd0deadd8c3406f1ff4a4ed2af4a19e9b5b43aa97d04b9ecb
 2021-07-12 20:54:22 -05:00
Wladimir J. van der Laan
e8f63fc657 Merge #16792: Assert that the HRP is lowercase in Bech32::Encode 
2457aea83c1f9fba708e2335bb197950bf0b6244 Assert that the HRP is lowercase in Bech32::Encode (Samuel Dobson)

Pull request description:

  From BIP-173:
  > The lowercase form is used when determining a character's value for checksum purposes.
  > Encoders MUST always output an all lowercase Bech32 string. If an uppercase version of the encoding result is desired, (e.g.- for presentation purposes, or QR code use), then an uppercasing procedure can be performed external to the encoding process.

  Currently if HRP contains uppercase characters, the checksum will be generated over these uppercase characters resulting in mixed-case output that will always be invalid even if the case is changed manually after encoding. This shouldn't happen because both prefix's `bc` and `tb` are lowercase currently, but we assert this condition anyway.

  This is consistent also with the [C reference implementation](2b0aac650c/ref/c/segwit_addr.c (L59))

ACKs for top commit:
  laanwj:
    ACK 2457aea83c1f9fba708e2335bb197950bf0b6244

Tree-SHA512: 24fcbbc2f315c72c550cc3d82b4332443eea6378fc73d571f98b87492604d023378dd102377c9e05467192cae6049606dee98e4c5688c8d5e4caac50c970284b
 2021-07-12 20:52:56 -05:00
MarcoFalke
d36d5efee5 Merge #16768: test: Make lint-includes.sh work from any directory 
490da639cbd48ce0dc438abbfc89ab796391cb2a Make lint-includes.sh work from any directory (Kristaps Kaupe)

Pull request description:

  Before this change it works from root folder of bitcoin git repo, but if you do `cd test/lint; ./test-includes.sh`, you will have a lot of false positive messages like this:
  ```
  Good job! The circular dependency "chainparamsbase -> util/system -> chainparamsbase" is no longer present.
  Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in ./lint-circular-dependencies.sh
  to make sure this circular dependency is not accidentally reintroduced.

  Good job! The circular dependency "index/txindex -> validation -> index/txindex" is no longer present.
  Please remove it from EXPECTED_CIRCULAR_DEPENDENCIES in ./lint-circular-dependencies.sh
  to make sure this circular dependency is not accidentally reintroduced.

  ```

Top commit has no ACKs.

Tree-SHA512: 07fa69cb2883181dcee922191acac4b242722eeb2916cdffdc7163421302b22f3c9525aaf4c754a9dba1c307032c05285e38191d5c6aabc894321f8a27bbceaa
 2021-07-12 20:52:56 -05:00
fanquake
1d6671fa94 Merge #16760: qt: Change uninstall icon on Windows 
635e9154da223ca760713d7b3b66c0a9321d1277 [qt] Change uninstall icon on Windows (GChuf)

Pull request description:

  Change uninstall icon in Windows by changing a registry value.
  Original uninstall.exe icon remains the same
  Reason: almost no other modern program uses that uninstall icon in Windows.

  before:
  ![before](https://user-images.githubusercontent.com/42591821/63967490-13a09000-ca8d-11e9-8f49-3884d33302ce.png)
  after:
  ![after](https://user-images.githubusercontent.com/42591821/63967491-13a09000-ca8d-11e9-82f0-5adb74246a1e.png)

ACKs for top commit:
  promag:
    ACK 635e9154da223ca760713d7b3b66c0a9321d1277.
  l2a5b1:
    ACK 635e915
  practicalswift:
    ACK 635e9154da223ca760713d7b3b66c0a9321d1277
  jonasschnelli:
    utACK 635e9154da223ca760713d7b3b66c0a9321d1277
  fanquake:
    ACK 635e9154da223ca760713d7b3b66c0a9321d1277 - Tested building and installing using WSL on Windows 10.

Tree-SHA512: a0f435c79e726896cc93db058f1712dcf37daefbcacbf213b340ef2d5f4ff387148b8d659302f3e84be8a9f3df23e72b0ca5937f5d77499b808081bd40bfbbac
 2021-07-12 20:52:56 -05:00
fanquake
04d768d09a Merge #14862: doc: Declare BLOCK_VALID_HEADER reserved 
fa0b910486e9aada077fe47e1201dcb3bd523c87 [doc] chain: Declare BLOCK_VALID_HEADER reserved (MarcoFalke)

Pull request description:

  `BLOCK_VALID_HEADER` was never used and the comment is confusing to me in several ways:

  * It claims "version ok". However, without the previous header, it is not possible to check the validity of the version since the height needs to be known (c.f. BIP 90)
  * It claims "hash satisfies claimed PoW". While it is possible to check against the claimed PoW, it is not possible without the previous header to check that the claimed PoW is itself valid.
  * It claims "1 <= vtx count <= max". However, with the header alone and current consensus rules, the number of transactions is unknown.

ACKs for top commit:
  sipa:
    ACK fa0b910486e9aada077fe47e1201dcb3bd523c87
  ryanofsky:
    ACK fa0b910486e9aada077fe47e1201dcb3bd523c87

Tree-SHA512: 3972995a0a2f83aa55767bf8982af1fcb9493483f62aee6df27e58be9181a48d5968ae718b390cecc8be3ed4f26495683b1cffde8ef272dea0bd610ec169ef8b
 2021-07-12 20:52:56 -05:00
Wladimir J. van der Laan
12b5403aa6 Merge #16695: rpc: Add window final block height to getchaintxstats 
d48c1e837ae1bd08e0f18ad1b57ff72675c3d6ad Add window final block height to getchaintxstats (Jonathan "Duke" Leto)

Pull request description:

  This patch is motivated by the desire to make the output of `getchaintxstats` more useful and optimized for applications to consume and render the data.

  Firstly, this data is already available to the RPC, no additional work is done. Currently additional RPC calls will be needed to look up the height of the final block in the window or the block height that began the window.

  By adding the block height of the final block in the window, the JSON is "self-contained" and applications can calculate the exact block height range of the window with no additional RPC requests.
  For example, a web application which wants to render historical information for `getchaintxstats` RPC on various window sizes might call the RPC with various window lengths, once per day, and store the JSON results somewhere. Because the final block height of each dataset is included, it's no extra work to determine the exact block window range of each JSON response.

ACKs for top commit:
  promag:
    ACK d48c1e837ae1bd08e0f18ad1b57ff72675c3d6ad.

Tree-SHA512: fd4952c125f81a4ad18f7c78498c6b3e265b93cb574832166ac25596321ce84957f971f3f78f37d7e42638dc65f2a5d4d760f289873c9c2f2a82eb00a0f87c3f
 2021-07-12 20:52:56 -05:00
fanquake
33aa4c2840 Merge #16752: doc: Delete stale URL in test README 
41d484d5c88f057e75cfdd8b88587b9a12a61744 doc: Delete stale URL in test README (Michael Folkson)

Pull request description:

  The resource on the Boost unit test framework previously linked to in src/test/README.md was a stale URL.

  Instead of deleting it, I've replaced it with an alternative resource on the framework on [boost.org](https://www.boost.org/doc/libs/1_45_0/libs/test/doc/html/utf/tutorials.html).

ACKs for top commit:
  promag:
    ACK 41d484d5c88f057e75cfdd8b88587b9a12a61744.
  hebasto:
    ACK 41d484d5c88f057e75cfdd8b88587b9a12a61744, the removed link is really obsolete.
  fanquake:
    ACK 41d484d5c88f057e75cfdd8b88587b9a12a61744 - Thanks.

Tree-SHA512: 764f12548441bde615f77b7a2ca7c5188b4ab936972d16b84960fbd8604d4cbd224415bc59ce839e7e63293aa84fd97f31a69e38734e531231cdb0e148d2e1bd
 2021-07-12 20:52:56 -05:00
fanquake
91d5b02582 Merge #16621: doc: add default bitcoin.conf locations 
1373fa7e3d3f04ce6938cdcd2124cba71ff82ca0 doc: add default bitcoin.conf locations (Chuf)

Pull request description:

  Added default bitcoin.conf data directories and paths

ACKs for top commit:
  practicalswift:
    ACK 1373fa7e3d3f04ce6938cdcd2124cba71ff82ca0
  ryanofsky:
    ACK 1373fa7e3d3f04ce6938cdcd2124cba71ff82ca0
  fanquake:
    ACK 1373fa7e3d3f04ce6938cdcd2124cba71ff82ca0 - Already three ACKs and lots of discussion here, so I'm going to merge, and the other comment

Tree-SHA512: 8bb1ed9868c5d171b6791bd6dc9598eddfdf64977d327ff4f333323cef8e3e76b1a67da21e4199f008a12f5610ac6dc6f34f4a13235e8846754eb6d6e5075da4
 2021-07-12 20:52:56 -05:00
fanquake
ee46c9545e Merge #16461: doc: Tidy up shadowing section 
9452802480bd154e23771230bbdfebde1dbaa941 doc: Tidy up shadowing section (João Barbosa)

Pull request description:

  Removes the example because it violates the code format.

ACKs for top commit:
  MarcoFalke:
    unsigned ACK 9452802480bd154e23771230bbdfebde1dbaa941
  ryanofsky:
    ACK 9452802480bd154e23771230bbdfebde1dbaa941
  fanquake:
    ACK 9452802480bd154e23771230bbdfebde1dbaa941 - Thanks for following up.

Tree-SHA512: 1fc31355d368225713298da7803e39e99014fbfcd229f2d3b56c082de95ab2965e51c80b172a5abce4646c53f845fa62a6d94d5df714e7835cac07a8ec7d5da7
 2021-07-12 20:52:56 -05:00
MeshCollider
7fcb8f53ed Merge #16370: depends: cleanup package configure flags 
c295cba5a2f934e51a7c8610ab4c58b8e9d56619 depends: zeromq: disable draft classes and methods (fanquake)
0072237b9e33e0b89f6c9f51dd0b946fa89a6134 depends: xproto: configure flags cleanup (fanquake)
6a8ada3a4f67affcf0ef7452e206083d7b58b2bc depends: qrencode: configure flags cleanup (fanquake)
86beb8cdc4e312bd0bed2cbb273aebb792be2747 depends: fontconfig: configure flags cleanup (fanquake)
e656d95ec74336c2bd93bd387f67aeb6aed4dc40 depends: libxcb: configure flags cleanup (fanquake)
e439388b352b7dfbf2e00c6ba2970fed0a4a5554 depends: libXau: configure flags cleanup (fanquake)

Pull request description:

  Related to #16354.

  This PR adds additional configure flags to packages in depends to explicitly disable features we aren't using; similar to #16183. It also fixes passing `--without-tools` to `qrencode`.

  I've added `--disable-drafts` to `zeromq`:
  ```bash
  Build and install draft classes and methods [default=yes]
  ```

  I'm not entirely sure how far we want to take this. i.e in the `zeromq` package we explicitly pass `--without-libsodium`, even though it's disabled by default.

  Do we also want to explicitly pass all the other `--without` flags? :
  ```bash
    --with-libgssapi_krb5   require libzmq build with libgssapi_krb5
                            [default=no]
    --with-libsodium        use libsodium instead of built-in tweetnacl
                            [default=no]
    --with-pgm              build libzmq with PGM extension. Requires pkg-config
                            [default=no]
    --with-norm             build libzmq with NORM protocol extension,
                            optionally specifying norm path [default=no]
    --with-vmci             build libzmq with VMCI transport [default=no]
  ```

ACKs for top commit:
  dongcarl:
    ACK c295cba5a2f934e51a7c8610ab4c58b8e9d56619

Tree-SHA512: df6d38b863b4008ed2cb06c97eb0e21eaa4b5fde552876065ba7f3c87bf6e372e5b954a51bf3fde2151cfb6d2c022227d34337fc6e50ce0caa1d518abbd2412a
 2021-07-12 20:52:56 -05:00
fanquake
ae01429338 Merge #16694: gui: Ensure transaction send error is always visible 
a4765bd77f9bc5c4d5c866ee6940807522741941 gui: Ensure tx send error highlight is visible (bpay)

Pull request description:

  Rebased and squashed #14956.

  > If sending to multiple recipients and one of the recipient fields is malformed, the highlighted field may not be visible due to being scrolled out of view. This results in a confusing lack of error feedback.

  > Avoid this problem by ensuring the first field containing an error is scrolled into view when Send is clicked.

  You can see the behavior here: https://imgur.com/a/QZG5TQc

  How to test:
  Add a few recipients and give any of them an invalid address or amount. Scroll the invalid recipient out of view and hit Send. With this change, the GUI will scroll to show the invalid recipient, with master it will not, "hiding" the error.

ACKs for top commit:
  jonatack:
    Tested ACK a4765bd77f9bc5c4d5c866ee6940807522741941 on Linux Debian with Qt 5.11.3. Change is that I had added an inadvertent typo in my make bash alias; fixed.
  hebasto:
    ACK a4765bd77f9bc5c4d5c866ee6940807522741941, tested on Debian 9.9 with system Qt 5.7.1.

Tree-SHA512: a5653ca44d6d540214bdb424b0b75a06a5872cff41b0cd8cffd9cef99ebf04a17a3652e561139ac75315b39c3347e5f7ae304fa35e14b48bdae4768a416df9b0
 2021-07-12 20:52:56 -05:00
fanquake
77c46e07dc Merge #16674: refactor: remove obsolete qt algorithm usage 
153d9dd9acffa95bb97a4b1579bd20237fdc9c52 refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound (fanquake)
59373e3e94015316bcaa03a7b9c2e6f442641720 refactor: replace qSort with std::sort (fanquake)
fea33cbbdfb4673033f3414bf1613591ff654aac refactor: replace qStableSort with std::stable_sort (fanquake)

Pull request description:

  `qStablesort`, `qSort`, `qLowerBound` and `qUpperBound` have been marked as obsolete since at least Qt 5.9: [Obsolete Members for QtAlgorithms](https://doc.qt.io/qt-5.9/qtalgorithms-obsolete.html).

  This pull request replaces their usage with the suggested `std::` replacements.

  This also removes some warning spam when compiling against newer Qt (5.13.0 via brew):
  ```bash
    CXX      qt/libbitcoinqt_a-walletcontroller.o
  qt/transactiontablemodel.cpp:96:52: warning: 'qLowerBound<QList<TransactionRecord>::iterator, uint256, TxLessThan>' is deprecated: Use std::lower_bound [-Wdeprecated-declarations]
          QList<TransactionRecord>::iterator lower = qLowerBound(
  qt/transactiontablemodel.cpp:98:52: warning: 'qUpperBound<QList<TransactionRecord>::iterator, uint256, TxLessThan>' is deprecated: Use std::upper_bound [-Wdeprecated-declarations]
          QList<TransactionRecord>::iterator upper = qUpperBound(
  ```

  ```bash
    CXX      qt/libbitcoinqt_a-moc_walletcontroller.o
  qt/bantablemodel.cpp:64:13: warning: 'qStableSort<QList<CCombinedBan>::iterator, BannedNodeLessThan>' is deprecated: Use std::stable_sort [-Wdeprecated-declarations]
              qStableSort(cachedBanlist.begin(), cachedBanlist.end(), BannedNodeLessThan(sortColumn, sortOrder));
  ```

  ```bash
    CXX      qt/libbitcoinqt_a-sendcoinsentry.o
  qt/recentrequeststablemodel.cpp:205:5: warning: 'qSort<QList<RecentRequestEntry>::iterator, RecentRequestEntryLessThan>' is deprecated: Use std::sort [-Wdeprecated-declarations]
      qSort(list.begin(), list.end(), RecentRequestEntryLessThan(column, order));
  ```

ACKs for top commit:
  hebasto:
    ACK 153d9dd9acffa95bb97a4b1579bd20237fdc9c52
  promag:
    ACK 153d9dd9acffa95bb97a4b1579bd20237fdc9c52.
  jonasschnelli:
    utACK 153d9dd9acffa95bb97a4b1579bd20237fdc9c52

Tree-SHA512: 22f7290ed798ce8b0f5f313405377845d4c8e48dc8687be7464e27fff53363b451a40e9e18910a8c3b4b9d4dcc236a366c92e7d171fcb8576c48f149a1886c26
 2021-07-12 20:52:56 -05:00
Wladimir J. van der Laan
00cc0de358 Merge #16611: build: Remove src/obj directory from repository 
b6e9ff899677770741d94f1cf4f61ebb13fc453f build: Remove src/obj directory from repository (Wladimir J. van der Laan)

Pull request description:

  This directory is automatically created by the build process (in the build target directory, see #16588) and doesn't need to be in the repository nor in the tarballs.

  Move associated ignore directive to top-level `.gitignore` file.

ACKs for top commit:
  hebasto:
    Concept ACK b6e9ff899677770741d94f1cf4f61ebb13fc453f

Tree-SHA512: 5f3f5a0e8f19ecf925eb16cab327c3023b8512731bbaad5875828da7a25fdda1b77f6fbd06c002a383913627dc9b552f09ad27c57bcf0cb020ed3b1f506e5fef
 2021-07-12 20:52:56 -05:00
Wladimir J. van der Laan
91cc5488af Merge #16634: doc: Refer in rpcbind doc to the manpage 
fa0119af226255ce1e0e573a575ab37539ff8693 doc: Refer in rpcbind doc to the manpage (MarcoFalke)

Pull request description:

  The help was outdated, so refer to the updated manpage instead.

  * closes #14740
  * closes #9272

ACKs for top commit:
  emilengler:
    Concept ACK fa0119a
  laanwj:
    ACK fa0119af226255ce1e0e573a575ab37539ff8693
  fanquake:
    ACK fa0119af226255ce1e0e573a575ab37539ff8693

Tree-SHA512: 9836e4f31ece7acae334b47e3104b4595d0d1c1977af386a9463faf49aea9de3ab1c1dc3de248d0ee09e3b13693eaf6902dc82d277062e1bb1980b1117236fbb
 2021-07-12 18:42:39 -05:00
Jonas Schnelli
9510931a8a Merge #16435: autoconf: Sane --enable-debug defaults. 
d6ac25bdd96589a71006e3ab3f303b091ffaa9e4 autoconf: Sane --enable-debug defaults. (Carl Dong)

Pull request description:

  ```
  Don't optimize even if variables adhere to as-if rule. This is a
  somewhat sane default for debugging.
  ```

  -----

  Fixes: #14830

  This is more of a "do something dumb and have people correct you" kind of PR. The end goal is to have a configure flag that will allow for debugging without annoying "optimized out" messages, for developer experiences' sake. This is the minimal diff, but people have suggested `--enable-debug-slow` in the past.

ACKs for top commit:
  jonasschnelli:
    Tested ACK d6ac25bdd96589a71006e3ab3f303b091ffaa9e4

Tree-SHA512: 7a5576ad1d33850aff1445ccb71b133f654b455da2d1daed2ed1b82ea773965790a62895aeeab74b23a25513ab96dddb670f9dbc593dd0b8c030694206a99ccf
 2021-07-12 18:42:39 -05:00
MarcoFalke
439b59c379 Merge #16589: build: Remove unused src/obj-test folder 
fa4ee0ddf1b5150a9dcdd3bb711d5a06220ecebb build: Remove unused src/obj-test folder (MarcoFalke)

Pull request description:

  I believe this is no longer used after we switched from a makefile to autotools

ACKs for top commit:
  emilengler:
    Concept ACK fa4ee0ddf1

Tree-SHA512: cbedd3e65afc4de93b16500a0ff2e8778eb94e0224409d9a8d7cfc14cf22087471d260e63ba8d1322afdef5930d6c26fb64060e9e1b23876132cb9cdc35dce2c
 2021-07-12 18:42:39 -05:00
Wladimir J. van der Laan
d062deb53d Merge #16533: build: disable libxcb extensions 
3303124960d3d857d9ce29a88a589e00b1d0f8fa build: disable libxcb extensions (fanquake)

Pull request description:

  Closes #16447.
  Keeping this separate from #16370. So far I've tested the resulting `bitcoin-qt` on Debian Buster.

  I've done a [binary comparison](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/build-for-compare.py) of `bitcoin-qt` between master (e653eeff7651d823407e2e31a89176cc0b240c62) and this PR (fdd48a88e84bec6b728b7b308f1d4b9a234e126d) and could not see any differences:
  ```bash
  root@1417805b82d9:/tmp# shasum compare/*.stripped no_xcb/*.stripped
  2cba7e9985cfe79f0f6ecde39db107b4a998de71  compare/bitcoin-qt.e653eeff7651d823407e2e31a89176cc0b240c62.stripped
  6b0960fcf3e348568c954812ccc5375275500208  compare/bitcoind.e653eeff7651d823407e2e31a89176cc0b240c62.stripped
  2cba7e9985cfe79f0f6ecde39db107b4a998de71  no_xcb/bitcoin-qt.fdd48a88e84bec6b728b7b308f1d4b9a234e126d.stripped
  6b0960fcf3e348568c954812ccc5375275500208  no_xcb/bitcoind.fdd48a88e84bec6b728b7b308f1d4b9a234e126d.stripped
  ```

  libxcb depends `./configure` & `make` log diff (trimmed for breverity)
  The full logs are [here - with extensions](https://gist.github.com/fanquake/f2689a360ea8baafd44c92dd396f66ff) and [here - without extensions](https://gist.github.com/fanquake/9720a195c5031b5c3ca299a72384787c):
  ```diff
  @@ -183,31 +183,31 @@ config.status: executing libtool commands
       XCB buffer size.....: 16384

     X11 extensions
  -    Composite...........: yes
  -    Damage..............: yes
  -    Dpms................: yes
  -    Dri2................: yes
  -    Dri3................: yes
  -    Glx.................: yes
  -    Randr...............: yes
  -    Record..............: yes
  -    Render..............: yes
  -    Resource............: yes
  -    Screensaver.........: yes
  +    Composite...........: no
  +    Damage..............: no
  +    Dpms................: no
  +    Dri2................: no
  +    Dri3................: no
  +    Glx.................: no
  +    Randr...............: no
  +    Record..............: no
  +    Render..............: no
  +    Resource............: no
  +    Screensaver.........: no
       selinux.............: no
  -    Shape...............: yes
  -    Shm.................: yes
  -    Sync................: yes
  -    Xevie...............: yes
  -    Xfixes..............: yes
  -    Xfree86-dri.........: yes
  -    xinerama............: yes
  +    Shape...............: no
  +    Shm.................: no
  +    Sync................: no
  +    Xevie...............: no
  +    Xfixes..............: no
  +    Xfree86-dri.........: no
  +    xinerama............: no
       xinput..............: no
  -    xkb.................: yes
  -    xprint..............: yes
  -    xtest...............: yes
  -    xv..................: yes
  -    xvmc................: yes
  +    xkb.................: no
  +    xprint..............: no
  +    xtest...............: no
  +    xv..................: no
  +    xvmc................: no

     Used CFLAGS:
       CPPFLAGS............: -I/bitcoin/depends/x86_64-pc-linux-gnu/include
  @@ -218,9 +218,9 @@ config.status: executing libtool commands
       Prefix..............: /bitcoin/depends/x86_64-pc-linux-gnu

   Building libxcb...
  -make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f'
  +make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe'
   Making all in src
  -make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src'
  +make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/src'
   /usr/bin/python3 ./c_client.py -p /bitcoin/depends/x86_64-pc-linux-gnu/lib/python3.7/site-packages /bitcoin/depends/x86_64-pc-linux-gnu/share/xcb/xproto.xml
   /usr/bin/python3 ./c_client.py -p /bitcoin/depends/x86_64-pc-linux-gnu/lib/python3.7/site-packages /bitcoin/depends/x86_64-pc-linux-gnu/share/xcb/bigreq.xml
   /usr/bin/python3 ./c_client.py -p /bitcoin/depends/x86_64-pc-linux-gnu/lib/python3.7/site-packages /bitcoin/depends/x86_64-pc-linux-gnu/share/xcb/xc_misc.xml
  @@ -251,332 +251,140 @@ make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/lib
   /usr/bin/python3 ./c_client.py -p /bitcoin/depends/x86_64-pc-linux-gnu/lib/python3.7/site-packages /bitcoin/depends/x86_64-pc-linux-gnu/share/xcb/xv.xml
   /usr/bin/python3 ./c_client.py -p /bitcoin/depends/x86_64-pc-linux-gnu/lib/python3.7/site-packages /bitcoin/depends/x86_64-pc-linux-gnu/share/xcb/xvmc.xml
   make  all-am
  -make[3]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src'
  +make[3]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/src'
     CC       xcb_conn.lo
     CC       xcb_out.lo
     CC       xcb_in.lo
  -  CC       xcb_ext.lo
     CC       xcb_xid.lo
  +  CC       xcb_ext.lo
     CC       xcb_list.lo
     CC       xcb_util.lo
     CC       xcb_auth.lo
     CC       xproto.lo
     CC       bigreq.lo
  -  CC       composite.lo
     CC       xc_misc.lo
  -  CC       damage.lo
  -  CC       dpms.lo
  -  CC       dri2.lo
  -  CC       dri3.lo
  -  CC       present.lo
  -  CC       glx.lo
  -  CC       randr.lo
  -  CC       record.lo
  -  CC       render.lo
  -  CC       res.lo
  -  CC       screensaver.lo
  -  CC       shape.lo
  -  CC       shm.lo
  -  CC       sync.lo
  -  CC       xevie.lo
  -  CC       xf86dri.lo
  -  CC       xfixes.lo
  -  CC       xinerama.lo
  -  CC       xkb.lo
  -  CC       xprint.lo
  -  CC       xtest.lo
  -  CC       xv.lo
  -  CC       xvmc.lo
     CCLD     libxcb.la
  -  CCLD     libxcb-composite.la
  -  CCLD     libxcb-dpms.la
  -  CCLD     libxcb-damage.la
  -  CCLD     libxcb-dri2.la
  -  CCLD     libxcb-dri3.la
  -  CCLD     libxcb-present.la
  -  CCLD     libxcb-glx.la
  -  CCLD     libxcb-randr.la
  -  CCLD     libxcb-record.la
  -  CCLD     libxcb-render.la
  -  CCLD     libxcb-res.la
  -  CCLD     libxcb-screensaver.la
  -  CCLD     libxcb-shape.la
  -  CCLD     libxcb-shm.la
  -  CCLD     libxcb-sync.la
  -  CCLD     libxcb-xevie.la
  -  CCLD     libxcb-xf86dri.la
  -  CCLD     libxcb-xfixes.la
  -  CCLD     libxcb-xinerama.la
  -  CCLD     libxcb-xprint.la
  -  CCLD     libxcb-xtest.la
  -  CCLD     libxcb-xv.la
  -  CCLD     libxcb-xvmc.la
  -  CCLD     libxcb-xkb.la
  -make[3]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src'
  -make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src'
  +make[3]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/src'
  +make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/src'
   Making all in tests
  -make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/tests'
  -make[3]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/tests'
  +make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/tests'
  +make[3]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/tests'
   make[3]: Nothing to be done for 'all-am'.
  -make[3]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/tests'
  -make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/tests'
  +make[3]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/tests'
  +make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/tests'
   Making all in doc
  -make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/doc'
  +make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/doc'
   make[2]: Nothing to be done for 'all'.
  -make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/doc'
  -make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f'
  +make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/doc'
  +make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe'
   make[2]: Nothing to be done for 'all-am'.
  -make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f'
  -make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f'
  +make[2]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe'
  +make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe'
   Staging libxcb...
   make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
  -make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f'
  +make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe'
   Making install in src
  -make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src'
  +make[2]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/src'
   make  install-am
  -make[3]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src'
  -make[4]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src'
  - /bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib'
  - /bin/bash ../libtool   --mode=install /usr/bin/install -c   libxcb.la libxcb-composite.la libxcb-damage.la libxcb-dpms.la libxcb-dri2.la libxcb-dri3.la libxcb-present.la libxcb-glx.la libxcb-randr.la libxcb-record.la libxcb-render.la libxcb-res.la libxcb-screensaver.la libxcb-shape.la libxcb-shm.la libxcb-sync.la libxcb-xevie.la libxcb-xf86dri.la libxcb-xfixes.la libxcb-xinerama.la libxcb-xkb.la libxcb-xprint.la libxcb-xtest.la libxcb-xv.la libxcb-xvmc.la '/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib'
  -libtool: install: /usr/bin/install -c .libs/libxcb.so.1.1.0 /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb.so.1.1.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb.so.1.1.0 libxcb.so.1 || { rm -f libxcb.so.1 && ln -s libxcb.so.1.1.0 libxcb.so.1; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb.so.1.1.0 libxcb.so || { rm -f libxcb.so && ln -s libxcb.so.1.1.0 libxcb.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb.la
  -libtool: install: warning: relinking `libxcb-composite.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-composite.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib composite.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-composite.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-composite.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-composite.so.0.0.0 libxcb-composite.so.0 || { rm -f libxcb-composite.so.0 && ln -s libxcb-composite.so.0.0.0 libxcb-composite.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-composite.so.0.0.0 libxcb-composite.so || { rm -f libxcb-composite.so && ln -s libxcb-composite.so.0.0.0 libxcb-composite.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-composite.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-composite.la
  -libtool: install: warning: relinking `libxcb-damage.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-damage.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib damage.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-damage.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-damage.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-damage.so.0.0.0 libxcb-damage.so.0 || { rm -f libxcb-damage.so.0 && ln -s libxcb-damage.so.0.0.0 libxcb-damage.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-damage.so.0.0.0 libxcb-damage.so || { rm -f libxcb-damage.so && ln -s libxcb-damage.so.0.0.0 libxcb-damage.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-damage.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-damage.la
  -libtool: install: warning: relinking `libxcb-dpms.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-dpms.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib dpms.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-dpms.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-dpms.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-dpms.so.0.0.0 libxcb-dpms.so.0 || { rm -f libxcb-dpms.so.0 && ln -s libxcb-dpms.so.0.0.0 libxcb-dpms.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-dpms.so.0.0.0 libxcb-dpms.so || { rm -f libxcb-dpms.so && ln -s libxcb-dpms.so.0.0.0 libxcb-dpms.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-dpms.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-dpms.la
  -libtool: install: warning: relinking `libxcb-dri2.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-dri2.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib dri2.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-dri2.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-dri2.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-dri2.so.0.0.0 libxcb-dri2.so.0 || { rm -f libxcb-dri2.so.0 && ln -s libxcb-dri2.so.0.0.0 libxcb-dri2.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-dri2.so.0.0.0 libxcb-dri2.so || { rm -f libxcb-dri2.so && ln -s libxcb-dri2.so.0.0.0 libxcb-dri2.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-dri2.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-dri2.la
  -libtool: install: warning: relinking `libxcb-dri3.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-dri3.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib dri3.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-dri3.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-dri3.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-dri3.so.0.0.0 libxcb-dri3.so.0 || { rm -f libxcb-dri3.so.0 && ln -s libxcb-dri3.so.0.0.0 libxcb-dri3.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-dri3.so.0.0.0 libxcb-dri3.so || { rm -f libxcb-dri3.so && ln -s libxcb-dri3.so.0.0.0 libxcb-dri3.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-dri3.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-dri3.la
  -libtool: install: warning: relinking `libxcb-present.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-present.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib present.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-present.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-present.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-present.so.0.0.0 libxcb-present.so.0 || { rm -f libxcb-present.so.0 && ln -s libxcb-present.so.0.0.0 libxcb-present.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-present.so.0.0.0 libxcb-present.so || { rm -f libxcb-present.so && ln -s libxcb-present.so.0.0.0 libxcb-present.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-present.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-present.la
  -libtool: install: warning: relinking `libxcb-glx.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-glx.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib glx.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-glx.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-glx.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-glx.so.0.0.0 libxcb-glx.so.0 || { rm -f libxcb-glx.so.0 && ln -s libxcb-glx.so.0.0.0 libxcb-glx.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-glx.so.0.0.0 libxcb-glx.so || { rm -f libxcb-glx.so && ln -s libxcb-glx.so.0.0.0 libxcb-glx.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-glx.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-glx.la
  -libtool: install: warning: relinking `libxcb-randr.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 1:0:1 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-randr.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib randr.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-randr.so.0.1.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-randr.so.0.1.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-randr.so.0.1.0 libxcb-randr.so.0 || { rm -f libxcb-randr.so.0 && ln -s libxcb-randr.so.0.1.0 libxcb-randr.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-randr.so.0.1.0 libxcb-randr.so || { rm -f libxcb-randr.so && ln -s libxcb-randr.so.0.1.0 libxcb-randr.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-randr.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-randr.la
  -libtool: install: warning: relinking `libxcb-record.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-record.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib record.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-record.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-record.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-record.so.0.0.0 libxcb-record.so.0 || { rm -f libxcb-record.so.0 && ln -s libxcb-record.so.0.0.0 libxcb-record.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-record.so.0.0.0 libxcb-record.so || { rm -f libxcb-record.so && ln -s libxcb-record.so.0.0.0 libxcb-record.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-record.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-record.la
  -libtool: install: warning: relinking `libxcb-render.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-render.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib render.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-render.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-render.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-render.so.0.0.0 libxcb-render.so.0 || { rm -f libxcb-render.so.0 && ln -s libxcb-render.so.0.0.0 libxcb-render.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-render.so.0.0.0 libxcb-render.so || { rm -f libxcb-render.so && ln -s libxcb-render.so.0.0.0 libxcb-render.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-render.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-render.la
  -libtool: install: warning: relinking `libxcb-res.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-res.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib res.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-res.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-res.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-res.so.0.0.0 libxcb-res.so.0 || { rm -f libxcb-res.so.0 && ln -s libxcb-res.so.0.0.0 libxcb-res.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-res.so.0.0.0 libxcb-res.so || { rm -f libxcb-res.so && ln -s libxcb-res.so.0.0.0 libxcb-res.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-res.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-res.la
  -libtool: install: warning: relinking `libxcb-screensaver.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-screensaver.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib screensaver.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-screensaver.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-screensaver.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-screensaver.so.0.0.0 libxcb-screensaver.so.0 || { rm -f libxcb-screensaver.so.0 && ln -s libxcb-screensaver.so.0.0.0 libxcb-screensaver.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-screensaver.so.0.0.0 libxcb-screensaver.so || { rm -f libxcb-screensaver.so && ln -s libxcb-screensaver.so.0.0.0 libxcb-screensaver.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-screensaver.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-screensaver.la
  -libtool: install: warning: relinking `libxcb-shape.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-shape.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib shape.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-shape.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-shape.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-shape.so.0.0.0 libxcb-shape.so.0 || { rm -f libxcb-shape.so.0 && ln -s libxcb-shape.so.0.0.0 libxcb-shape.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-shape.so.0.0.0 libxcb-shape.so || { rm -f libxcb-shape.so && ln -s libxcb-shape.so.0.0.0 libxcb-shape.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-shape.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-shape.la
  -libtool: install: warning: relinking `libxcb-shm.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-shm.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib shm.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-shm.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-shm.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-shm.so.0.0.0 libxcb-shm.so.0 || { rm -f libxcb-shm.so.0 && ln -s libxcb-shm.so.0.0.0 libxcb-shm.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-shm.so.0.0.0 libxcb-shm.so || { rm -f libxcb-shm.so && ln -s libxcb-shm.so.0.0.0 libxcb-shm.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-shm.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-shm.la
  -libtool: install: warning: relinking `libxcb-sync.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 1:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-sync.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib sync.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-sync.so.1.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-sync.so.1.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-sync.so.1.0.0 libxcb-sync.so.1 || { rm -f libxcb-sync.so.1 && ln -s libxcb-sync.so.1.0.0 libxcb-sync.so.1; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-sync.so.1.0.0 libxcb-sync.so || { rm -f libxcb-sync.so && ln -s libxcb-sync.so.1.0.0 libxcb-sync.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-sync.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-sync.la
  -libtool: install: warning: relinking `libxcb-xevie.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xevie.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xevie.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xevie.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xevie.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xevie.so.0.0.0 libxcb-xevie.so.0 || { rm -f libxcb-xevie.so.0 && ln -s libxcb-xevie.so.0.0.0 libxcb-xevie.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xevie.so.0.0.0 libxcb-xevie.so || { rm -f libxcb-xevie.so && ln -s libxcb-xevie.so.0.0.0 libxcb-xevie.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xevie.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xevie.la
  -libtool: install: warning: relinking `libxcb-xf86dri.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xf86dri.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xf86dri.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xf86dri.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xf86dri.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xf86dri.so.0.0.0 libxcb-xf86dri.so.0 || { rm -f libxcb-xf86dri.so.0 && ln -s libxcb-xf86dri.so.0.0.0 libxcb-xf86dri.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xf86dri.so.0.0.0 libxcb-xf86dri.so || { rm -f libxcb-xf86dri.so && ln -s libxcb-xf86dri.so.0.0.0 libxcb-xf86dri.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xf86dri.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xf86dri.la
  -libtool: install: warning: relinking `libxcb-xfixes.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xfixes.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xfixes.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xfixes.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xfixes.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xfixes.so.0.0.0 libxcb-xfixes.so.0 || { rm -f libxcb-xfixes.so.0 && ln -s libxcb-xfixes.so.0.0.0 libxcb-xfixes.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xfixes.so.0.0.0 libxcb-xfixes.so || { rm -f libxcb-xfixes.so && ln -s libxcb-xfixes.so.0.0.0 libxcb-xfixes.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xfixes.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xfixes.la
  -libtool: install: warning: relinking `libxcb-xinerama.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xinerama.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xinerama.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xinerama.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xinerama.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xinerama.so.0.0.0 libxcb-xinerama.so.0 || { rm -f libxcb-xinerama.so.0 && ln -s libxcb-xinerama.so.0.0.0 libxcb-xinerama.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xinerama.so.0.0.0 libxcb-xinerama.so || { rm -f libxcb-xinerama.so && ln -s libxcb-xinerama.so.0.0.0 libxcb-xinerama.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xinerama.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xinerama.la
  -libtool: install: warning: relinking `libxcb-xkb.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 1:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xkb.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xkb.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xkb.so.1.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xkb.so.1.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xkb.so.1.0.0 libxcb-xkb.so.1 || { rm -f libxcb-xkb.so.1 && ln -s libxcb-xkb.so.1.0.0 libxcb-xkb.so.1; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xkb.so.1.0.0 libxcb-xkb.so || { rm -f libxcb-xkb.so && ln -s libxcb-xkb.so.1.0.0 libxcb-xkb.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xkb.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xkb.la
  -libtool: install: warning: relinking `libxcb-xprint.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xprint.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xprint.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xprint.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xprint.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xprint.so.0.0.0 libxcb-xprint.so.0 || { rm -f libxcb-xprint.so.0 && ln -s libxcb-xprint.so.0.0.0 libxcb-xprint.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xprint.so.0.0.0 libxcb-xprint.so || { rm -f libxcb-xprint.so && ln -s libxcb-xprint.so.0.0.0 libxcb-xprint.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xprint.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xprint.la
  -libtool: install: warning: relinking `libxcb-xtest.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xtest.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xtest.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xtest.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xtest.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xtest.so.0.0.0 libxcb-xtest.so.0 || { rm -f libxcb-xtest.so.0 && ln -s libxcb-xtest.so.0.0.0 libxcb-xtest.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xtest.so.0.0.0 libxcb-xtest.so || { rm -f libxcb-xtest.so && ln -s libxcb-xtest.so.0.0.0 libxcb-xtest.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xtest.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xtest.la
  -libtool: install: warning: relinking `libxcb-xv.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xv.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xv.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xv.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xv.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xv.so.0.0.0 libxcb-xv.so.0 || { rm -f libxcb-xv.so.0 && ln -s libxcb-xv.so.0.0.0 libxcb-xv.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xv.so.0.0.0 libxcb-xv.so || { rm -f libxcb-xv.so && ln -s libxcb-xv.so.0.0.0 libxcb-xv.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xv.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xv.la
  -libtool: install: warning: relinking `libxcb-xvmc.la'
  -libtool: install: (cd /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/src; /bin/bash /bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/libtool  --silent --tag CC --mode=relink gcc -m64 -Wall -Wpointer-arith -Wold-style-definition -Wstrict-prototypes -Wmissing-declarations -Wnested-externs -I/bitcoin/depends/x86_64-pc-linux-gnu/include -pipe -O2 -version-info 0:0:0 -no-undefined -L/bitcoin/depends/x86_64-pc-linux-gnu/lib -o libxcb-xvmc.la -rpath /bitcoin/depends/x86_64-pc-linux-gnu/lib xvmc.lo libxcb.la -inst-prefix-dir /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f)
  -libtool: install: /usr/bin/install -c .libs/libxcb-xvmc.so.0.0.0T /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xvmc.so.0.0.0
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xvmc.so.0.0.0 libxcb-xvmc.so.0 || { rm -f libxcb-xvmc.so.0 && ln -s libxcb-xvmc.so.0.0.0 libxcb-xvmc.so.0; }; })
  -libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb-xvmc.so.0.0.0 libxcb-xvmc.so || { rm -f libxcb-xvmc.so && ln -s libxcb-xvmc.so.0.0.0 libxcb-xvmc.so; }; })
  -libtool: install: /usr/bin/install -c .libs/libxcb-xvmc.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-69eae692c4f/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb-xvmc.la
  +make[3]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/src'
  +make[4]: Entering directory '/bitcoin/depends/work/build/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/src'
  + /bin/mkdir -p '/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/bitcoin/depends/x86_64-pc-linux-gnu/lib'
  + /bin/bash ../libtool   --mode=install /usr/bin/install -c   libxcb.la '/bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/bitcoin/depends/x86_64-pc-linux-gnu/lib'
  +libtool: install: /usr/bin/install -c .libs/libxcb.so.1.1.0 /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb.so.1.1.0
  +libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb.so.1.1.0 libxcb.so.1 || { rm -f libxcb.so.1 && ln -s libxcb.so.1.1.0 libxcb.so.1; }; })
  +libtool: install: (cd /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/bitcoin/depends/x86_64-pc-linux-gnu/lib && { ln -s -f libxcb.so.1.1.0 libxcb.so || { rm -f libxcb.so && ln -s libxcb.so.1.1.0 libxcb.so; }; })
  +libtool: install: /usr/bin/install -c .libs/libxcb.lai /bitcoin/depends/work/staging/x86_64-pc-linux-gnu/libxcb/1.10-6757b70fafe/bitcoin/depends/x86_64-pc-linux-gnu/lib/libxcb.la
   libtool: install: warning: remember to run `libtool --finish /bitcoin/depends/x86_64-pc-linux-gnu/lib'
  < snip man and other stuff... >
   Postprocessing libxcb...
   Caching libxcb...
  ```

ACKs for top commit:
  dongcarl:
    tACK 3303124960d3d857d9ce29a88a589e00b1d0f8fa

Tree-SHA512: e5187e2b459d5a7220162df1efeed7cd891ad4429ccfe2823125b2f4d20ab890631b0c042bb8bb8074c69831c7751b47a2789c1f1de42712bd8c4ae7049699d9
 2021-07-12 18:42:39 -05:00
Wladimir J. van der Laan
0f9c331df2 Merge #16573: build: disable building libsecp256k1 benchmarks 
bf72b8a5551868433ae6fa1824915255f104b208 build: disable libsecp256k1 benchmarks (fanquake)

Pull request description:

  These were previously disabled, but upstream changed to having benchmarks enabled by default
  in https://github.com/bitcoin-core/secp256k1/pull/480 and we pulled that change in as part of #15703.

ACKs for top commit:
  laanwj:
    ACK bf72b8a5551868433ae6fa1824915255f104b208
  real-or-random:
    ACK bf72b8a5551868433ae6fa1824915255f104b208 I only looked at the diff
  practicalswift:
    ACK bf72b8a5551868433ae6fa1824915255f104b208 -- diff looks correct

Tree-SHA512: f4c99c774c8bfd37f98fa200667530988ef8da61920fafdff7e929d9dc5dd8304981b625611f6c3fbc525172d269a2a1d33e592297bd8ff418dff11b05b5e204
 2021-07-12 18:42:39 -05:00
fanquake
0b06f27802 Merge #16534: build: add Qt Creator Makefile.am.user to .gitignore 
0a4e4a05ea33171797289a0c4bdfdc43d46e160f [build] .gitignore add Qt Creator Makefile.am.user (Peter Bushnell)

Pull request description:

  Opening Bitcoin with Qt Creator via the Makefile.am generates a Makefile.am.user. Would be handy to have this file ignored. Looking around I can see this file has snuck into a few downstream projects. I do personally find myself editing commits to remove this file when I've not been paying attention. There's got to have been a few PRs with this file accidentally attached.

ACKs for top commit:
  promag:
    ACK 0a4e4a05ea33171797289a0c4bdfdc43d46e160f.
  practicalswift:
    ACK 0a4e4a05ea33171797289a0c4bdfdc43d46e160f -- diff looks correct
  fanquake:
    ACK 0a4e4a05ea33171797289a0c4bdfdc43d46e160f - Something like this might be better in your local .gitignore_global, but we do have a section on Qt Creator in the docs, so I guess this is fine.

Tree-SHA512: 282fd37ec6b313bf86ebe85a42e7f05b14969c683d32f01d2561f4e15d90a2e89f4d0e3c227cb3350684bcae21d178ea343edb32c4c1d33f4849246222c9b8d5
 2021-07-12 18:42:39 -05:00
fanquake
48075b81f6 Merge #16448: doc: add note on precedence of options in bitcoin.conf 
fa2f991fa23fcc2c96d48fc3dd7faa41c959e8ae doc: add note on precedence of options in bitcoin.conf (Torkel Rogstad)

Pull request description:

  This was a good addition to the docs, but the PR was closed. So I've cherry-picked the commit and fixed up Russ's comments as well as the linter issue.

ACKs for top commit:
  laanwj:
    ACK fa2f991fa23fcc2c96d48fc3dd7faa41c959e8ae
  hebasto:
    ACK fa2f991fa23fcc2c96d48fc3dd7faa41c959e8ae, I have reviewed the code and it looks OK, I agree it can be merged.
  jamesob:
    ACK fa2f991fa2
  jonatack:
    ACK fa2f991fa23fcc2c96d48fc3dd7faa41c959e8ae
  ryanofsky:
    ACK fa2f991fa23fcc2c96d48fc3dd7faa41c959e8ae. Only suggested changes since previous review.

Tree-SHA512: d8e7bac19e85ad32205652c3c3036766c611cae52e6e3e8af66a2da054659d914dc153d0cf4ace9c0fa7b41f2a8d74d0edd8d83fe7e984b93d70c01a388cf8ec
 2021-07-12 18:42:39 -05:00
gabriel-bjg
ee6d2f5b0d
Fix data races in bls_worker and use ctpl_stl queue. (#4240) 
Change ctpl implementation to use STL queue & mutex.

Use ctpl synchronized queue instead of boost lockfree queue in bls worker aggregator.

Use smart pointers for memory management of Aggregator and VectorAggregator. With 'delete this;' the objects are prone to data race on the delete operator.

Use smart pointers for memory management of ContributionVerifier.

Pass shared_ptr by value to other threads via worker pool.
 2021-07-11 22:25:27 -05:00
UdjinM6
0f027caba2
Use one global string for "CoinJoin" in gui related stuff (#4117) 2021-07-11 12:28:50 +03:00
UdjinM6
08558d67ee
Merge pull request #4235 from PastaPastaPasta/backport-triv-pr7 
backport: 'trivial' pr7
 2021-07-10 21:46:25 +03:00