Wladimir J. van der Laan
5459116d61
Merge pull request #4293
...
fa126ef
Avoid undefined behavior using CFlatData in CScript serialization (Wladimir J. van der Laan)
2014-06-23 10:44:57 +02:00
Wladimir J. van der Laan
fa126effc2
Avoid undefined behavior using CFlatData in CScript serialization
...
`&vch[vch.size()]` and even `&vch[0]` on vectors can cause assertion
errors with VC in debug mode. This is the problem mentioned in #4239 .
The deeper problem with this is that we rely on undefined behavior.
- Add `begin_ptr` and `end_ptr` functions that get the beginning and end
pointer of vector in a reliable way that copes with empty vectors and
doesn't reference outside the vector
(see https://stackoverflow.com/questions/1339470/how-to-get-the-address-of-the-stdvector-buffer-start-most-elegantly/1339767#1339767 ).
- Add a convenience constructor to CFlatData that wraps a vector.
I added `begin_ptr` and `end_ptr` as separate functions as I imagine
they will be useful in more places.
2014-06-23 10:38:15 +02:00
Wladimir J. van der Laan
52d4abfdef
Merge pull request #4388
...
3dc1464
add missing vhListenSocket.clear(); to CNetCleanup() (Philip Kaufmann)
2831a03
remove unused CNode::Cleanup() (Philip Kaufmann)
2014-06-23 10:21:38 +02:00
Wladimir J. van der Laan
bfb55dd586
Merge pull request #4385
...
040c2d3
Fix formatting (Drak)
2014-06-23 10:21:20 +02:00
Wladimir J. van der Laan
82f2bba1ad
Merge pull request #4391
...
b612bde
remove unneded class CNodeCombinedStats; from rpcconsole.cpp (Philip Kaufmann)
2014-06-23 10:01:07 +02:00
Philip Kaufmann
b612bde521
remove unneded class CNodeCombinedStats; from rpcconsole.cpp
...
- also 2 small style fixes
2014-06-23 08:06:52 +02:00
Pieter Wuille
d4e4e05435
Merge pull request #4309
...
d38da59
Code simplifications after CTransaction::GetHash() caching (Pieter Wuille)
4949004
Add CMutableTransaction and make CTransaction immutable. (Pieter Wuille)
2014-06-22 20:45:30 +02:00
Pieter Wuille
6b40eabbcf
Merge pull request #4381
...
806fd19
Allocate receive buffers in on the fly (Pieter Wuille)
2014-06-22 17:43:40 +02:00
Philip Kaufmann
3dc1464f0a
add missing vhListenSocket.clear(); to CNetCleanup()
2014-06-22 14:52:38 +02:00
Philip Kaufmann
2831a03b79
remove unused CNode::Cleanup()
2014-06-22 14:51:38 +02:00
Pieter Wuille
d38da59bf6
Code simplifications after CTransaction::GetHash() caching
2014-06-22 00:06:17 +02:00
Pieter Wuille
4949004d68
Add CMutableTransaction and make CTransaction immutable.
...
In addition, introduce a cached hash inside CTransaction, to prevent
recalculating it over and over again.
2014-06-21 22:59:03 +02:00
Drak
040c2d3f57
Fix formatting
2014-06-21 21:57:50 +01:00
Pieter Wuille
8f59251b83
Merge pull request #4100
...
a0495bb
Add <Hasher>::OUTPUT_SIZE (Pieter Wuille)
4791b99
crypto: create a separate lib for crypto functions (Cory Fields)
f2647cc
crypto: explicitly check for byte read/write functions (Cory Fields)
5437248
build: move bitcoin-config.h to its own directory (Cory Fields)
3820e01
Extend and move all crypto tests to crypto_tests.cpp (Pieter Wuille)
7ecd973
Move {Read,Write}{LE,BE}{32,64} to common.h and use builtins if possible (Pieter Wuille)
a5bc9c0
Add built-in RIPEMD-160 implementation (Pieter Wuille)
13b5dfe
Move crypto implementations to src/crypto/ (Pieter Wuille)
1cc344c
Add built-in SHA-1 implementation. (Pieter Wuille)
85aab2a
Switch miner.cpp to use sha2 instead of OpenSSL. (Pieter Wuille)
cf0c47b
Remove getwork() RPC call (Pieter Wuille)
7b4737c
Switch script.cpp and hash.cpp to use sha2.cpp instead of OpenSSL. (Pieter Wuille)
977cdad
Add a built-in SHA256/SHA512 implementation. (Pieter Wuille)
2014-06-21 22:52:46 +02:00
Jeff Garzik
b4ccf0a5c7
Merge pull request #4379 from Diapolo/cleanup_compat
...
small cleanup in src/compat .h and .cpp
2014-06-21 16:29:12 -04:00
Pieter Wuille
a0495bb68c
Add <Hasher>::OUTPUT_SIZE
2014-06-21 19:47:43 +02:00
Cory Fields
4791b99e2d
crypto: create a separate lib for crypto functions
...
This lib has no dependencies on other bitcoin functionality. Attempting to
use bitcoin headers will result in a failure to compile.
2014-06-21 19:47:43 +02:00
Cory Fields
f2647cc0e9
crypto: explicitly check for byte read/write functions
...
Don't depend on hard-coded platform lists
2014-06-21 19:47:43 +02:00
Cory Fields
54372482a8
build: move bitcoin-config.h to its own directory
...
This allows us to include its path without making other header includes valid.
2014-06-21 19:47:43 +02:00
Pieter Wuille
3820e01eb9
Extend and move all crypto tests to crypto_tests.cpp
2014-06-21 19:47:43 +02:00
Pieter Wuille
7ecd9739d9
Move {Read,Write}{LE,BE}{32,64} to common.h and use builtins if possible
2014-06-21 19:47:42 +02:00
Pieter Wuille
a5bc9c0917
Add built-in RIPEMD-160 implementation
2014-06-21 19:47:42 +02:00
Pieter Wuille
13b5dfef64
Move crypto implementations to src/crypto/
2014-06-21 19:47:42 +02:00
Pieter Wuille
1cc344ce42
Add built-in SHA-1 implementation.
2014-06-21 19:47:39 +02:00
Pieter Wuille
85aab2a088
Switch miner.cpp to use sha2 instead of OpenSSL.
2014-06-21 19:47:39 +02:00
Pieter Wuille
cf0c47b269
Remove getwork() RPC call
2014-06-21 19:47:39 +02:00
Pieter Wuille
7b4737c878
Switch script.cpp and hash.cpp to use sha2.cpp instead of OpenSSL.
2014-06-21 19:47:39 +02:00
Pieter Wuille
977cdadea8
Add a built-in SHA256/SHA512 implementation.
...
This also moves the HMAC-SHA512 implementation to sha2.cpp.
2014-06-21 19:47:39 +02:00
Wladimir J. van der Laan
540ce6aa10
Merge pull request #4380
...
38405ac
Add comment regarding experimental-use service bits (Peter Todd)
99ddc6c
Add nLocalServices info to RPC getinfo (Peter Todd)
2014-06-21 19:26:18 +02:00
Peter Todd
38405ac141
Add comment regarding experimental-use service bits
...
As per mailing list discussion.
2014-06-21 11:43:23 -04:00
Peter Todd
99ddc6cb70
Add nLocalServices info to RPC getinfo
...
Also show full 64 bits of services. Previously service bits >32 that
were advertised just didn't show up at all.
2014-06-21 11:43:19 -04:00
Pieter Wuille
806fd19ecb
Allocate receive buffers in on the fly
2014-06-21 17:00:38 +02:00
Philip Kaufmann
fc0c07eb64
small cleanup in src/compat .h and .cpp
...
- add license header
- fix include guards
- fix indentation
2014-06-21 14:39:17 +02:00
Wladimir J. van der Laan
aaacfa0898
Merge pull request #4371
...
ea3acaf
AvailableCoins: acquire cs_main mutex (Pavel Vasin)
2014-06-20 16:57:08 +02:00
Pavel Vasin
ea3acaf383
AvailableCoins: acquire cs_main mutex
...
It's required when called from WalletModel
2014-06-20 16:32:57 +04:00
Wladimir J. van der Laan
b8b98d5642
Merge pull request #4310
...
7a9e0b6
Move checkpoint based heuristic checks to AcceptBlockHeader (Pieter Wuille)
2014-06-19 14:38:45 +02:00
Wladimir J. van der Laan
7eb49c79f0
Merge pull request #4358
...
6afa493
rpc: Add acceptors only when listening succeeded (Wladimir J. van der Laan)
33e5b42
rpc: Ignore and log errors during cancel (Wladimir J. van der Laan)
2014-06-19 09:34:42 +02:00
Wladimir J. van der Laan
6afa49329d
rpc: Add acceptors only when listening succeeded
2014-06-19 08:19:52 +02:00
Wladimir J. van der Laan
33e5b42910
rpc: Ignore and log errors during cancel
...
Cancelling the RPC acceptors can sometimes result in an error about
a bad file descriptor.
As this is the shutdown sequence we need to continue nevertheless,
ignore these errors, log a warning and proceed.
Fixes #4352 .
2014-06-19 08:19:46 +02:00
Wladimir J. van der Laan
9fe80a2ec8
Merge pull request #4334
...
6763018
[Qt] rename In:/Out: to Received/Sent in traffic tab (Philip Kaufmann)
2014-06-18 09:59:47 +02:00
Wladimir J. van der Laan
b8e56aa8ef
Merge pull request #4339
...
92a6220
sanity: hook up sanity checks (Cory Fields)
679240d
sanity: add libc/stdlib sanity checks (Cory Fields)
11404af
sanity: autoconf check for sys/select.h (Cory Fields)
2014-06-18 09:52:50 +02:00
Wladimir J. van der Laan
5a514c35bc
Merge pull request #4354
...
7ad720d
Added encryptwallet call to bitrpc.py (dllud)
2014-06-18 09:17:20 +02:00
Wladimir J. van der Laan
5694d10781
Merge pull request #4346
...
1569353
Add `-stopafterblockimport` option (Wladimir J. van der Laan)
2014-06-17 14:51:15 +02:00
Wladimir J. van der Laan
2151419b1b
Merge pull request #4333
...
f6984e8
Add "chain" to getmininginfo, improve help in getblockchaininfo (jtimon)
b82b7ec
Get rid of Params().RPCisTestNet() (jtimon)
2014-06-17 14:11:28 +02:00
jtimon
f6984e8141
Add "chain" to getmininginfo, improve help in getblockchaininfo
2014-06-17 13:11:36 +02:00
jtimon
b82b7ec3dc
Get rid of Params().RPCisTestNet()
2014-06-17 13:08:25 +02:00
Wladimir J. van der Laan
e164828105
Merge pull request #4357
...
1020f59
add comment to HelpMessage() to ensure alphabetical ordering (Philip Kaufmann)
2014-06-17 09:20:40 +02:00
Philip Kaufmann
1020f599f3
add comment to HelpMessage() to ensure alphabetical ordering
...
- also rename hmm to mode, to be consistent between .h and .cpp
2014-06-17 09:17:12 +02:00
dllud
7ad720d890
Added encryptwallet call to bitrpc.py
...
This was the only call requiring password input which was still missing. Much useful to avoid leaving a plain text passphrase in the shell log.
2014-06-17 04:22:47 +01:00
Cory Fields
92a6220711
sanity: hook up sanity checks
2014-06-16 17:21:34 -04:00