Commit Graph

17968 Commits

Author SHA1 Message Date
Oleg Girko
62985c771b
depends: Update Qt download url. (#3756)
Signed-off-by: Oleg Girko <ol@infoserver.lv>

Co-authored-by: Oleg Girko <ol@infoserver.lv>
2020-10-28 22:22:00 +03:00
dustinface
717a41a572
qt: Make sure there is a valid theme set in the options (#3755)
* qt: Add GUIUtil::isValidTheme()

Check if a given string is a valid theme.

* qt: Make sure there is a valid theme set in the options
2020-10-28 22:21:43 +03:00
PastaPastaPasta
01a3435158
update public part of windows code signing certificate (#3749)
* update public part of windows code signing certificate

Signed-off-by: pasta <pasta@dashboost.org>

* Fixing line-breaks

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-10-28 22:21:20 +03:00
PastaPastaPasta
b3c8306867
Make the build an actual release (#3753)
* Make the build an actual release

Signed-off-by: pasta <pasta@dashboost.org>

* bump build version

Signed-off-by: pasta <pasta@dashboost.org>

* bump diff version

Signed-off-by: pasta <pasta@dashboost.org>
2020-09-30 19:58:44 +03:00
thephez
bc9fa667e5
docs: Several more suggestions (#3751) 2020-09-30 19:52:42 +03:00
dustinface
0c960a5efe
doc: Remove trailing whitespaces in release notes (#3747) 2020-09-29 17:02:24 +03:00
UdjinM6
4c669c0449
[v0.16.x] v0.16 release notes (#3582)
* Archive v0.15 release notes

* Drop changes in release notes accidentally introduced by #3426

* Draft v0.16 release notes

* Update doc/release-notes.md

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

* Some additions to 0.16 release notes

* Fix typos

* Format/TODO

* Drop `is`

* Block Reward Reallocation, Dynamic Activation Thresholds, PrivateSend coins and fees, PrivateSend Random Round Mixing, GUI, sporks, cmd, commits, contributors

* Apply suggestions from code review

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

* Apply few more suggestions

* docs: some release note suggestions

* Update PRs/commits list

Replace "Merged branch .."+commits with the regular "<PR name> (<PR number)" thing

* Apply suggestions from code review

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

* Update doc/release-notes.md

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

* Update doc/release-notes.md

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

* Add recent PRs

* Apply suggestions from code review

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

* Format/fix trailing whitespaces

* Fix duplicate whitespaces

* doc: Add details about block reward reallocation

* Update doc/release-notes.md

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

* Apply suggestions from code review - wrap file names in ``

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>

* doc: Some adjustments in the GUI part

Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
Co-authored-by: Alexander Block <ablock84@gmail.com>
Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
Co-authored-by: thephez <thephez@users.noreply.github.com>
Co-authored-by: xdustinface <xdustinfacex@gmail.com>
2020-09-29 07:12:35 +03:00
UdjinM6
58adf53ef3
Merge pull request #3745 from xdustinface/pr-backport-remaining
[v0.16.x] Backport remaining PRs
2020-09-29 04:27:24 +03:00
UdjinM6
37fe9a6e2f Fix mempool sync (#3725)
* masternode: Fix mempool sync

Make sure the mempool sync requests only happen after the blockchain
sync is done.

* Refactor

Loop only if `-syncmempool`=true, make `if` a bit more readable

Co-authored-by: xdustinface <xdustinfacex@gmail.com>
2020-09-29 03:04:19 +02:00
xdustinface
69b77765ba qt: Fix font family updates (#3746)
* qt: Update the application font if the font family gets changed

* qt: Make sure recent transactions have the correct font family

Introduced because QListView is ignored in GUIUtil::updateFonts, so its base font family doesn't change, hence the recent transactions don't adjust because the painter's font doesn't change.

* Store initial font size
2020-09-29 03:04:19 +02:00
xdustinface
cf2da32ffe qt: Fix font size and scaling issues (#3734)
* qt: Make sure font size in MasternodeList gets scaled as expected

* qt: Make sure font size in ShutdownWindow gets scaled as expected

* qt: Drop obsolete application font updates

* qt: Scale QMenu and QMessageBox globally

To make sure non-custom context menus + QMessageBox instances createy by
static calls like QMessageBox::critical are scaled also.

* qt: Avoid redundant scaling for tooltips and menus

* qt: Only update widget's font if required

* qt: Merge GUIUtil::mapFontSizeUpdates into GUIUtil::mapNormalFontUpdates

* qt: Remove obsolete setFixedPitchFont call

* qt: Use setFixedPitchFont in SendCoinsEntry

* qt: Scale font size in increments of 0.25

* qt: Properly scale network traffic stats depending on font metrics

* qt: Update min/max width of OptionsDialog depending on buttons width

* qt: Emit a signal whenever any attribute of AppearanceWidget changed

* qt: Update OptionsDialog width if the appearance changed

* qt: Calculate the initial wide right after the window showed up

Make sure the visibility state of the widgets is correct before width calculations.

* qt: Call parent class showEvent + override it explicit

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

* qt: Let OptionsDialog emit a signal if appearance gets changed

* qt: Resize main toolbar depending on visible buttons / font attributes

* qt: Reset max width after it has been set to still allow window resizing

* qt: Properly update the weight of widgets with default font attributes

* qt: Handle updates to the font attributes

* qt: Use resize() instead of setMaximumWidth()

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

* qt: Call GUIUtil::updateFonts in ModalOverlay constructor

* qt: Make sure default fonts are stored properly for the related widget

* qt: Ignore some low level classes in GUIUtil::updateFont

* rpc: Remove obsolete `.arg()` call

* qt: Drop fixedPitchFont

* qt: Avoid redundant font updates. Let GUIUtil::updateFont handle them

* qt: Scale recent transactions on OverviewPage

They were scaled by font inheritance before

* qt: Ignore QListView in GUIUtil::updateFonts
2020-09-29 02:38:02 +02:00
UdjinM6
586f166499 qt: Fix Recent transactions list height (#3744)
* qt: Bring back setMinimumHeight for recent tx list

This partially reverts a3604f5

Turns out that we still need this at least on Windows (not sure why but tx list looks clipped there atm)

* Reduce number of items in recent tx list by 1 (for PS enabled cases only)

Most users will never see immature funds and the list is going to be too long for them most of the time
2020-09-29 02:36:39 +02:00
UdjinM6
12d0782071 Translations 2020-09 (#3736)
* Update dash_en and dashstrings

* ru

* fi, vi

* 98.94%: ar, de, es, fr, it, ko, nl, pl, th, zh_TW

* >80%: ja, pt, ro, sk, tr, zh_CN

* 100%: pt, tr

* ~98%: zh_CN
2020-09-29 00:53:00 +02:00
UdjinM6
fc8ca6ad50 Bump few things and update man pages for v0.16 (#3737)
* Update nMinimumChainWork and defaultAssumeValid

* Update chainTxData

* Bump BLOCK_CHAIN_SIZE

It's 21Gb on my local machine atm, bumping to 25Gb to give it some space

* `gen-manpages.sh`

* bupm BLOCK_CHAIN_SIZE 25->30
2020-09-29 00:52:51 +02:00
dustinface
8e6706dede qt: Add PrivateSend tab in OptionsDialog, allow to show/hide PS UI (#3717)
* qt: Add PrivateSend tab in OptionsDialog, allow to show/hide PS UI

* qt: Decrease height of OptionsDialog

* Apply suggestions from code review


* qt: Remove obsolete visibility adjustments

Not longer needed since the page is just not reachable if the button is
hidden.

* qt: Make sure PrivateSend related parts are always initialized properly

Not only if its enabled on startup..

* qt: Make updatePrivateSendVisibility a slot to fix the signal connection

* qt: Fix UI updates on OverviewPage if PrivateSend enabled gets toggled

Other way of connecting the slot with true as parameter didn't work..

* qt: Only update and emit the signal for advanced PS UI if required

* qt: Update fPrivateSendEnabled in OptionsModel instead of OptionsDialog

* qt: Recover the PrivateSend enabled state if OptionsDialog gets rejected

* qt: Enable PrivateSend UI by default

* qt: Add some brackets

* qt: Add a comment

* qt: Add a linebreak to the "Enable PrivateSend features" tooltip

* qt: Remove obsolete comment


* qt: Move comment

* qt: Properly reset the previous PS state if OptionsDialog gets rejected

Handle all reject reasons not only the cancle button.
2020-09-28 13:20:20 +02:00
UdjinM6
008c37a250
Merge pull request #3732 from PastaPastaPasta/v16-more-backports
[v0.16.x] V16 more backports
2020-09-26 14:05:08 +03:00
PastaPastaPasta
af457e143d
Fix dbfdf8cb15
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-09-25 17:06:17 +00:00
dustinface
dbfdf8cb15 qt: Finetune OverviewPage (#3715)
* qt: Adjust "Recent Transactions" in Overview tab

Make sure they follow the same format as the transactions in
TransactionsView.

- Removed the transaction type representing arrows
- Apply the same coloring like like in the transaction tab for
the different transaction types (orange = internal, red = outgoing,
green = incoming)

* qt: Cleanup layout of OverviewPage in css

* qt: Add three spacer (left, middle, right) and adjust layout stretch.

This allows to have the elements on the screen aligned symetrically
around the center independent from the window size/resizing.

* qt: Inrease date/amount size for "Recent Transactions" in Overview tab

* qt: Inrease number of "Recent Transactions" displayed in Overview tab

Just to fill the empty space

* qt: Make sure PS elements show as expected and adjust number of recent transactions based on PS

* qt: Adjust transaction entry generation

Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>

* qt: Adjust warning message box

Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>

* Move tx list style to css

* Fix tx list style for the traditional theme

* Drop (no longer needed?) min height offset in SetupTransactionList

Can't reproduce the tx list scrolling issue anymore

* Avoid recreating transaction filter from scratch every time SetupTransactionList is called

We call SetupTransactionList every second now (from privateSendStatus()) and this makes GUI unresponsive for huge wallets (I have ~400k txes in my testnet wallet) because of filter recreation/sorting. There is no need to go through all setup steps really, simply updating the limit works just fine and fixes the issue.

* qt: Fix an `if` statement

* qt: Just some refactoring

* fix code style

* bail out if `filter->rowCount() == nNumItems`

* qt: Make sure number of transactions is always correct

* Drop spacer to let recent tx list occupy max height available

* TransactionFilterProxy::setLimit should emit signals to let coresponding layouts update themselves

https://doc.qt.io/qt-5/qabstractitemmodel.html#layoutAboutToBeChanged
https://doc.qt.io/qt-5/qabstractitemmodel.html#layoutChanged

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-09-25 18:57:46 +02:00
xdustinface
c99d1627a8
qt: Fix compilation 2020-09-24 12:19:40 -04:00
pasta
229ea48a5a
Don't use CPrivateSendClientOptions
Signed-off-by: pasta <pasta@dashboost.org>
2020-09-24 02:18:05 -04:00
pasta
f7c683844c
3710 continued
Signed-off-by: pasta <pasta@dashboost.org>
2020-09-24 02:11:12 -04:00
dustinface
9028712b60
qt: Finetune TransactionsView (#3710)
* qt: Add missing changeEvent call in TransactionView

* qt: Use state related colors in TransactionModel

* qt: Don't colorize the text for abandoned transactions

The red icon should be obvious enough.

* qt: Drop InstantSend column from transaction view/model

* qt: Update verify.png

* qt: Extend the result string of TransactionTableModel::formatTxStatus

* qt: Drop "LLMQ based" in some status strings

* qt: Drop not longer needed ThemedColor entries

* Introduce amountColors(), add a case for `TransactionRecord::PrivateSendDenominate`

Avoid applying orange color to 0-fee mixing txes (PS denominate), use default (grey) color for them

* Tweak IS/CL status string additions a bit more

* Do not apply additional conditions, just use rec statuses

* qt: Adjust amount colors for types Generated and PrivateSendDenominate

Make them green/orange instead.

* Assign all colors explictly, drop default case

Let compiler complain about missing ones if any

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-09-24 01:35:27 -04:00
dustinface
f4e3bf95d0
qt: Finetune CoinControlDialog + bitcoin#14828 (#3701)
* qt: Add min-height for CoinControlTreeWidget#treeWidget::item

The rows resize without it if they get locked and the lock icon appears
besides the checkbox. Looks weird.. and especially if you press the lock
all button its just not nice.

* qt: Set background transparency for CoinControl item::hover

* Merge #14828: qt: Remove hidden columns in coin control dialog

1c28feb7d qt: Remove hidden columns in coin control dialog (João Barbosa)

Pull request description:

  Instead of having hidden columns, store the data in specific roles.

  Overlaps with #14817, fixes #11811.

Tree-SHA512: e86e9ca426b9146ac28997ca1920dbae6cc4e2e494ff94fe131d605cd6c013183fc5de10036c886a4d6dcae497ac4067de3791be0ef9c88f7ce9f57f7bd97422

* qt: Add border-bottom for tree items in CoinControl

* qt: Stretch address column in CoinControlDialog

* Adjust column width for a couple of columns

* qt: Hide PrivateSend rounds column for normal Send tab's CoinControl

* qt: Hide unrelated coins in CoinControl based on active mode. Still allow to show them.

* qt: Hide empty top level items in CoinControlDialog's tree mode

* qt: Hide tree/list radio buttons and default to list for PrivateSend

* qt: Hide address/label column in CoinControl for PrivateSend

* qt: Remove obsolete empty columns

* qt: Rename column "PS Rounds" to "Mixing Rounds"

* qt: Move border-bottom in already existing css selector

* Reveal all PS related coins in coincontrol while in PS mode, not only ones with rounds>=1

Also tweak button text

* qt: Only moving a statement a bit

* qt: Hide the "hideButton" in CoinControlDialog if PrivatSend is disabled

And make it default to show all coins in that case..

Co-authored-by: Jonas Schnelli <dev@jonasschnelli.ch>
Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-09-24 01:23:09 -04:00
thephez
e405f553b9
RPC: Update getprivatesendinfo help (#3727) 2020-09-24 01:20:08 -04:00
UdjinM6
b4a78fb285
Fix testnet icon (#3726)
There is a bug in gdk-pixbuf which prevents ico files from being displayed correctly.
https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/86

Fixed by `convert bitcoin_testnet.ico[4] -define icon:auto-resize=256,128,64,48,32,16 bitcoin_testnet.ico`
2020-09-24 01:19:52 -04:00
dustinface
3650ee6556
qt: Remove unused assets (#3721) 2020-09-24 01:19:40 -04:00
dustinface
cb078422cd
qt: Finetune RPCConsole (#3720)
* qt: Remove icons from debug console

Imo it's clear enough with the colors what commands/output and what user
inout is.

* qt: Draw network stats on the graph + Remove the QGroupBox next to it

The QGroupBox thing just added too much empty space imo.

* qt: Align ThemedStyle colors with css
2020-09-24 01:19:17 -04:00
UdjinM6
a198a74a4f
privatesend: Avoid interacting with keypool in CTransactionBuilder ctor (#3723) 2020-09-24 01:18:43 -04:00
dustinface
f601122cbd
qt: Hide remaining PrivateSend UI if PrivateSend is not enabled (#3716)
* qt: Rename two PrivateSend related labels in OptionsDialog

* qt: Hide main PrivateSend UI elements if its not enabled

- Tab button
- Menu actions

* qt: Hide PrivateSend in OptionsDialog options if its not enabled.

* qt: Hide PrivateSend filter in TransactionView if its not enabled

* Update toolbar shortcuts to match toolbar buttons visibility

* Update src/qt/transactionview.cpp

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-09-24 01:18:26 -04:00
dustinface
c7896eb657
qt: Disable missing macOS focus rects in AddressBookPage (#3711) 2020-09-24 01:17:50 -04:00
UdjinM6
c136522e84
qt: Finetune Options Dialog (#3709)
* Fix proxy port ui elements

* Fix fake net checkboxes

* Fix active options label by enabling text wrapping

* Fix options dialog resizing when font size is changed

* Move "Window" tab options into "Main" tab, drop "Window" tab

* Shrink min sizes a bit

* qt: Drop the surrounding QGroupBox in Options -> Wallet

Co-authored-by: xdustinface <xdustinfacex@gmail.com>
2020-09-24 01:17:22 -04:00
UdjinM6
bb0d5d4808
qt: Make sure send confirmation dialog uses correct font settings (#3714) 2020-09-24 01:17:01 -04:00
dustinface
ab5ffe3c11
qt: Use scaled font size for all QToolTip instances (#3708) 2020-09-24 01:16:40 -04:00
dustinface
42b606ea76
qt: Make sure font size in TransactionDescDialog is adjusted properly (#3707) 2020-09-24 01:16:21 -04:00
UdjinM6
8fa280140a
qt: Tweak few strings (#3706)
* Tweak few strings to make it easier to translate

Use args when it makes sense. Wrap 2 more strings with `tr()`.

* Fix typo
2020-09-24 01:14:12 -04:00
UdjinM6
9ded9501f8
Merge pull request #3702 from PastaPastaPasta/backport-v16-3661
[v0.16.x] Backport #3661
2020-09-14 01:33:19 +03:00
UdjinM6
5c2861538c
Merge pull request #3703 from PastaPastaPasta/backport-v16-realloc
[v0.16.x] Backport v16 realloc
2020-09-14 01:33:02 +03:00
UdjinM6
fa97aa358c
Merge pull request #3704 from PastaPastaPasta/backport-v16-even-more
[v0.16.x] Backport some more
2020-09-14 01:32:30 +03:00
UdjinM6
d892bf5dbb
Merge pull request #3705 from xdustinface/pr-backports-v16
[v0.16.x] More UI + PrivateSend/MN-Sync improvements
2020-09-14 01:32:04 +03:00
dustinface
01a3a6c81a qt: Finetune ModalOverlay (#3699)
* qt: Align warning icon in ModalOverlay properly with the text

* qt: Center form layout in modaloverlay
2020-09-13 10:32:18 +02:00
dustinface
16f9d94404 qt: Make sure the statusbar reflects internal states correct (#3698)
* qt: Increase number of spinner frames

* qt: Add and use BitcoinGUI::startSpinner and BitcoinGUI::stopSpinner

* qt: Handle CMasternodeSync::Reset calls

* qt: Make sure the statusbar always reflects the sync state/progress

* qt: Add BitcoinGUI::updateProgressBarVisibility

* qt: Animate connection icon while connecting

* qt: Refactor check in BitcoinGUI::updateProgressBarVisibility

* qt: Rename some variables

* Update src/qt/bitcoingui.cpp

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>

Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com>
2020-09-13 10:32:10 +02:00
dustinface
19aab3a1d8
qt|wallet: Fix "Use available balance" for PrivateSend (#3700)
* wallet: Allow CoinControl in GetAnonymizedCredit + GetAnonymizedBalance

* qt: Allow CoinControl in WalletModel::getAnonymizedBalance

* qt: Use CoinControl in SendCoinsDialog::useAvailableBalance for PS

* wallet: Fix caching in GetAnonymizedCredit
2020-09-12 21:00:35 -04:00
pasta
08f2437b82
fix indentation
Signed-off-by: pasta <pasta@dashboost.org>
2020-09-12 19:10:49 -04:00
xdustinface
9e425d66c6 Partially merge #3604:
- Add BitcoinGUI::updateWalletStatus()
- Add WalletModel::getWalletModel()
- Make WalletFrame::currentWalletView public
2020-09-12 23:42:00 +02:00
dustinface
2bb94c73eb masternode|net|rpc: Improve masternode sync process (#3690)
* masternode: Replace sync states INITIAL and WAITING with BLOCKCHAIN

* masternode: Peer dependent "assume tip" timeout

I would say its enough to only wait 1 tick if we have more than 3
peers before we move over to governance sync.

* masternode: Notify the UI instantly if switched to governance sync

Without this it takes one iteration more for the UI to receive the
update.

* masternode: Notify the UI about CMasternodeSync::Reset calls

* masternode: Don't instantly reset the sync process

Give it MASTERNODE_SYNC_RESET_SECONDS (600) seconds time after the last
UpdateBlockTip call.

* rpc: Don't switch to next asset in "mnsync reset"

* rpc: Force the reset in "mnsync reset"

* net: Make sure the sync gets a reset if required after network changes

This will reset the sync process if its outdated in the following cases:

- If the connections dropped to zero
- If the connections went from zero to one
- If the network has been enabled or disabled

* Apply suggestions from code review

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

* net: Only open masternode connections if the blockchain is synced

In general it doesn't make sense to connect to masternodes before due to
MNAUTH requires blockchain sync. This could lead to failing quorum
connections/failing masternode
probing.. if a just restarted node/a out of sync node
would hit a dkg block.. Then they would not try to open those
llmq/probing connections for the next 60s (nLLMQConnectionRetryTimeout).
Thats basically what happens in tests right now and they fail without
this commit.

* test: Make sure nodes are synced when they get restored after isolation

Their sync might be out of date otherwise due to bigger mocktime bumps

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-09-12 22:54:56 +02:00
dustinface
aa81a06264 masternode|rpc: Remove unused code (#3689) 2020-09-12 22:54:56 +02:00
dustinface
2e92237865 qt: Improved status bar (#3688)
* qt: Adjust green color

* qt: Don't disable the HD icon

Disabling it leads to incorrect colors due to opacity.

* qt: Move the HD icon to the left

Reason: Its the only one not turning green by default if all is set
properly. So this lets is look better imo.

* qt: Increase statusbar icon size

* qt: Show lock icon in status bar also if wallet is not encrypted

Just as signal to the user!

* qt: Refine connection icon usage

* qt: Use state related colors in statusbar

* qt: Hide the HD icon for non-HD wallets

* qt: Update HD icon
2020-09-12 22:54:56 +02:00
dustinface
54ed089f97 test: Implement unit tests for CTransactionBuilder (#3677)
* makefile.test.include: Let privatesend_tests.cpp depend on ENABLE_WALLET

* test: Implement unit tests for CTransactionBuilder

* Check that we can decrease the amount and GetAmountLeft() is updated accordingly

* Check if resulting tx has a change output when expected

* Avoid pushing nullptr into vecOutputs

* Add few notes about size calculations

* nit: better readability (imo)

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-09-12 22:54:56 +02:00
dustinface
ab0f789be6 wallet: Fix and improve CWallet::CreateTransaction (#3668)
* wallet: Remove unused vecTxDSInTmp in CWallet::CreateTransaction

* wallet: Calculate fees earlier and respect them in change determination

* wallet: Cleanup obsolete code in CreateTransaction

This parts were needed before when the fee was calculated after the
change was assigned. But now with the previous commit the fee is
calculated upfront and respected properly from the begining. So there is
no longer a need of increasing or decreasing the change depending on the
fee as it has the correct value directly after its added.

* wallet: Try to pick other inputs if the selected ones are too small

If nChange is negative in this cases it means that the selected inputs
can't cover the amount to send and the required transaction fee. So we
just add the missing amount to nFeeRet. This leads to the algo
trying to pick larger inputs in the next loop (with nFeeRet more duffs
than in the previous loop). This process gets repeated until the selected
amount is enough to cover all the costs or until the requested amount
can't be selected anymore (not enough utxos to cover it).

* wallet: Break the loop if the transaction is ready

* wallet: Respect additional amount from previous cycles

* wallet: Respect available in coin selection, try all coins in last round

* wallet: Avoid potential infinite loop, just in case..

* wallet: Fix signing in CreateTransaction

Prior it was messed because of 60d96a1a28b55f071c6144f248e136679c44337e. 
Set coins isn't sorted the same way as txNew.vin is so it sometimes may 
pick wrong coins for signing the input.

* wallet: Fix change calculation if "subtract fee from amount" is enabled

* wallet: Return after fee calc if no or not enough amount available

Return the proper fail reason. Prior to this commit it run into
"Exceeded max tried".

Note: Only return if not enough amount is available if we can't subtract
fee from amount.

* wallet: Fix break logic if available amount is not enough

* Revert "wallet: Fix signing in CreateTransaction"

This reverts commit 5fcdc0f00e7b961ebb62c94d17d585537e911309.

* Use a vector of coins instead of a set in CreateTransaction and sort it in a BIP69 compliant way when needed

* wallet: Adjust comment

* Cleaner usage of nChangePosRequest/InOut

* Simplify some fail/try-again conditions (fixed)

* Loop through outputs to update change output position only when outputs are sorted for BIP69

No need to do this for non-bip69 cases (i.e. when a specific change output position was requested and assigned)

* Avoid implicit conversions of int-s into bool-s

* Move `nAmountLeft == nFeeRet` check higher, tweak comments

* wallet: Fix some formatting

* wallet: Improve CTxIn creation in CreateTransaction

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
2020-09-12 22:54:56 +02:00
dustinface
dd55609d6b test: Implement unit tests for CWallet::CreateTransaction (#3667)
* test: Implement unit tests for CWallet::CreateTransaction

* test: Reset minRelayTxFee in CreateTransactionTest

At this point its modified from an other test when running all unit 
tests which lets this test fail unexpectedly.

* test: Lock cs_main/cs_wallet when required in CreateTransactionTest

* test: Add new test in CreateTransactionTest

Test if the wallet creation fails properly with the correct error
messages.

* test: Fixed expected test results for some CreateTransactionTest cases

* test: Fail if CreateTransaction runs into "Exceed max tries" case

* test: Adjust last return in CreateTransaction

* test: Drop dust tests
2020-09-12 22:54:56 +02:00