UdjinM6
9abc393839
Refactor few things here and there ( #3066 )
...
* Refactor `HandleFullyConfirmedBlock()`
* Pass `pindexMined` into `AddNonLockedTx()`
* Unify time import in Dash specific tests
* Refactor UpdateSpork and SetPrivKey
2019-08-28 14:51:59 +03:00
UdjinM6
f2dcac3a4f
Merge #10757 : RPC: Introduce getblockstats to plot things ( #3058 )
...
* Merge #10757 : RPC: Introduce getblockstats to plot things
41d0476f62269027ec2193a5f80d508d789de8aa Tests: Add data file (Anthony Towns)
4cbfb6aad9ba8fa17b5e7ed3e9a36dc8a24f1fcf Tests: Test new getblockstats RPC (Jorge Timón)
35e77a0288bcac5594ff25c10c9679a161cb730b RPC: Introduce getblockstats (Jorge Timón)
cda8e36f019dd181e5c3774961b4f1335e5602cb Refactor: RPC: Separate GetBlockChecked() from getblock() (Jorge Timón)
Pull request description:
It returns per block statistics about several things. It should be easy to add more if people think of other things to add or remove some if I went too far (but once written, why not keep it? EDIT: answer: not to test or maintain them).
The currently available options are: minfee,maxfee,totalfee,minfeerate,maxfeerate,avgfee,avgfeerate,txs,ins,outs (EDIT: see updated list in the rpc call documentation)
For the x axis, one can use height or block.nTime (I guess I could add mediantime if there's interest [EDIT: nobody showed interest but I implemented mediantime nonetheless, in fact there's no distinction between x or y axis anymore, that's for the caller to judge]).
To calculate fees, -txindex is required.
Tree-SHA512: 2b2787a3c7dc4a11df1fce62c8a4c748f5347d7f7104205d5f0962ffec1e0370c825b49fd4d58ce8ce86bf39d8453f698bcd46206eea505f077541ca7d59b18c
* Replace get_mocktime() usage with self.mocktime
2019-08-28 14:50:29 +03:00
UdjinM6
3d5eabcfbb
Update/unify debug and logging rpc descriptions ( #3071 )
...
* Update/unify `debug` and `logging` rpc descriptions
* Add yet another meta - ""
* Apply suggestions from code review
Co-Authored-By: thephez <thephez@users.noreply.github.com>
2019-08-28 10:55:05 +03:00
UdjinM6
0e94e97cc5
Add missing tx type to TxToUniv ( #3069 )
...
* Add missing tx `type` to `TxToUniv`
* Adjust the expected output in unit test testcases accordingly
2019-08-28 10:54:44 +03:00
UdjinM6
becca24fcc
Few fixes in docs/comments ( #3068 )
...
* Few fixes in docs/comments
* Add descriptions
2019-08-28 10:54:19 +03:00
UdjinM6
9d109d6a30
Add missing instantlock/instantlock_internal to getblock's verbosity=2 mode ( #3067 )
2019-08-28 10:53:20 +03:00
UdjinM6
0f088d03af
Change regtest and devnet p2p/rpc ports ( #3064 )
2019-08-28 10:52:00 +03:00
UdjinM6
1905422561
Rework govobject/trigger cleanup a bit ( #3070 )
...
* No friends for `CGovernanceObject`
* Simplify CGovernanceTriggerManager::CleanAndRemove() logic and make sure CSuperblock::IsExpired() does not modify the state
2019-08-23 21:03:05 +03:00
UdjinM6
386de78bcb
Fix SelectCoinsMinConf to allow instant respends ( #3061 )
...
* Modify tests to check for instant respends
This should fail atm...
* Fix SelectCoinsMinConf to allow instant respends
Now tests should pass again.
2019-08-23 21:02:33 +03:00
thephez
cbbeec6897
RPC Getrawtransaction fix ( #3065 )
...
* Remove duplicate hex field from getrawtransaction
* Add missing height to help output
2019-08-22 13:15:08 +03:00
thephez
1e34967996
Added getmemoryinfo parameter string update ( #3062 )
...
- Make consistent with other RPCs
2019-08-22 13:14:22 +03:00
Alexander Block
9d2d8ccede
Add a few malleability tests for DIP2/3 transactions ( #3060 )
...
* Remove unused scriptPubKey
* Add payload malleability check to DIP3 tests
* Also check malleability protection by signatures inside CProUpRegTx
2019-08-22 13:13:34 +03:00
thephez
4983f7abb7
RPC Fix typo in getmerkleblocks help ( #3056 )
2019-08-16 14:54:48 +03:00
UdjinM6
4588f67f84
Merge pull request #3059 from UdjinM6/mergemaster_0.14.0.3
...
Merge master 0.14.0.3 back into develop
2019-08-16 14:53:29 +03:00
PastaPastaPasta
a78dcfdec2
Add the public GPG key for Pasta for Gitian building ( #3057 )
...
* Add the public GPG key for Pasta for Gitain building
* change file ending from gpg to pgp
2019-08-16 14:52:41 +03:00
Alexander Block
6905da5fe4
Merge #11308 : [qa] zapwallettxes: Wait up to 3s for mempool reload ( #3051 )
...
* Merge #11308 : [qa] zapwallettxes: Wait up to 3s for mempool reload
fadd0c16b
2019-08-16 14:51:15 +03:00
UdjinM6
929c892c05
Remove p2p alert leftovers ( #3050 )
...
* Drop ALERT debug category
Was used for p2p alerts only
* Drop `alert` p2p message handling in tests
2019-08-16 14:49:15 +03:00
PastaPastaPasta
0599d3a030
Backport bitcoin#10831: Batch flushing operations to the walletdb during top up and increase keypool size ( #3045 )
...
* backport #10831
Signed-off-by: Pasta <pasta@dashboost.org>
* Apply the same logic for SetHDChain/SetCryptedHDChain
2019-08-16 14:48:46 +03:00
UdjinM6
60cc3c0562
Merge pull request #3049 from PastaPastaPasta/backports-0.15-pr24
...
Backports 0.15 pr24
2019-08-16 14:47:58 +03:00
UdjinM6
c851de9996
Resolve merge issues
2019-08-16 04:15:25 +03:00
UdjinM6
c8b16fa8cd
Merge branch 'master' into mergemaster_0.14.0.3
2019-08-15 21:58:12 +03:00
Alexander Block
7d8eab2641
Add 0.14.0.3 change log to release-notes.md ( #3055 )
2019-08-14 04:51:13 +02:00
UdjinM6
3d6c5ac27a
More mocktime related fixes
2019-08-13 14:50:34 -05:00
UdjinM6
59e57337e4
fix wait_node
2019-08-13 14:50:28 -05:00
UdjinM6
cd30d6b447
simplify stop_node
2019-08-13 14:50:20 -05:00
Pasta
a67f5375fb
remove duplicate import
2019-08-13 14:49:28 -05:00
Pasta
3980caf200
re-add import shutil
2019-08-13 14:48:24 -05:00
Alexander Block
f2443709b3
Update release-notes.md for 0.14.0.3 ( #3054 )
2019-08-13 19:33:52 +02:00
Alexander Block
8aa45cfb0d
Merge pull request #3046 from codablock/pr_v14_backports
...
[v0.14.0.x] Backport pending PRs
2019-08-13 19:33:21 +02:00
PastaPastaPasta
cb480af013
Dashify
...
Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com>
2019-08-13 11:27:56 -05:00
Alexander Block
788d42dbcf
Bump version to 0.14.0.3 and copy release notes ( #3053 )
2019-08-12 20:08:33 +02:00
Pasta
806da3c6e2
adjust number of parameters in sendmany
2019-08-12 09:11:29 -05:00
UdjinM6
c4094c8de1
Few more tiny trivial fixes
2019-08-12 09:07:03 -05:00
UdjinM6
8c2c2a1ad4
s/bitcoind/dashd/ in some places
2019-08-12 09:07:03 -05:00
UdjinM6
76822dd509
fix imports
2019-08-12 09:07:03 -05:00
UdjinM6
4bfef1daad
Add missing dash-specific parts
2019-08-12 09:07:03 -05:00
UdjinM6
9828b624a0
_wait_for_bitcoind_start should be a part of BitcoinTestFramework
2019-08-12 09:07:03 -05:00
UdjinM6
d0288fba58
Refactor/fix mocktime usage in tests
2019-08-12 09:07:03 -05:00
UdjinM6
9c8365ee62
Fix GetMinimumFee changes
2019-08-12 09:07:03 -05:00
UdjinM6
2e235b4b4d
Fix rpcs
2019-08-12 09:07:03 -05:00
UdjinM6
00052aa15b
Drop rbf-related parts
2019-08-12 09:07:03 -05:00
Luke Dashjr
00c4046e55
Wallet: Refactor FundTransaction to accept parameters via CCoinControl
2019-08-12 09:07:03 -05:00
Wladimir J. van der Laan
c9784838a7
Merge #10589 : More economical fee estimates for RBF and RPC options to control
...
f135923f0bf33de0738e3d507c30cfaef69
2019-08-12 09:07:03 -05:00
UdjinM6
c853c012ee
Fix amounts formatting in decoderawtransaction and getsuperblockbudget
2019-08-12 09:07:03 -05:00
MarcoFalke
a82f22e528
Merge #10556 : Move stop/start functions from utils.py into BitcoinTestFramework
...
5ba83c105b8c080d473c5cad967af1fe53637065d2
2019-08-12 09:07:03 -05:00
Pasta
746ebf1651
fix indendation in wallet.cpp
...
Signed-off-by: Pasta <pasta@dashboost.org>
2019-08-12 09:07:03 -05:00
Pasta
3a6b2ce274
backport part of #10481
...
Signed-off-by: Pasta <pasta@dashboost.org>
2019-08-12 09:07:03 -05:00
Wladimir J. van der Laan
ecfdfa64d2
Merge #10792 : Replace MAX_OPCODE for OP_NOP10.
...
c8e29d7
2019-08-12 09:07:03 -05:00
Pasta
1a0d52814e
#10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL
...
-BEGIN VERIFY SCRIPT-
sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/wallet/*/*.cpp src/wallet/*/*.h src/support/allocators/*.h
sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp
sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp
sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp
sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp
sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp
-END VERIFY SCRIPT-
Signed-off-by: Pasta <pasta@dashboost.org>
2019-08-12 09:07:03 -05:00
Wladimir J. van der Laan
ac80c90123
Merge #11012 : Make sure to clean up mapBlockSource if we've already seen the block
...
3f8fa7f
2019-08-12 09:07:03 -05:00
