Alexander Block
c2de362b98
Actually honor fMiningRequiresPeers in getblocktemplate ( #1844 )
...
MiningRequiresPeers() was not used at all. I checked the Bitcoin
code and even there it is set but then ignored. Updated getblocktemplate
to actually honor the value.
The check also removes the need for IsInitialBlockDownload() to be false.
As regtest nodes start with an empty chain they won't be able to use
getblocktemplate for mining otherwise.
2018-01-10 15:22:00 +03:00
Alexander Block
81fb931fb8
Don't delay GETHEADERS when no blocks have arrived yet in devnet ( #1807 )
...
When the first mined block arrives from another node on devnet, we have to
send GETHEADERS immediately as we otherwise will never leave the IBD mode.
2018-01-10 15:20:08 +03:00
Alexander Block
a46bf120bc
Don't directly call "wine test_dash.exe" and let "make check" handle it ( #1841 )
...
Turned out "make check" will use wine if needed and for some reason does
not suffer from the same performance issues when called manually.
2018-01-10 12:18:52 +03:00
Alexander Block
e805f790e3
Automatically build and push docker image to docker.io/dashpay/dashd-develop ( #1809 )
...
* Automatically build and push docker image to dashpay/dashd-develop
* Remove DOCKER_REPO env var from .travis.yml and add new-line to .gitignore
This should not have been there and results in errournous pushes to
"dashpay/dashd/dashpay/dashd-develop".
Also add missing new-line in .gitignore
* Fix Travis build failures happening due to large writes to stdout
Travis issue: https://github.com/travis-ci/travis-ci/issues/4704
Build failure happened since the introduction of secrets in .travis.yml
* Fix BUILD_DIR
Due to changes in develop the build dir has changed to be just "build".
* Remove bogus upload example from .travis.yml
* Switch to pushing on "develop" branch
Used "pr_docker" before for testing purposes.
* Only push docker image when TRAVIS_PULL_REQUEST = false
2018-01-10 12:17:43 +03:00
Kamil Woźniak
1cffb8a7ec
Include p2pk into addressindex ( #1839 )
...
* Add simple test for p2pk script
refs #1767
* Add p2pk transaction addresses indexing
Addresses from p2pk transaction are now indexed by transations pubkeys
hashes. Even if it isn't strict behavior and the p2pk are rare
and obsolete, it is transaction that should be able to be looked up.
fixes #1767
* Add p2pk script checking tests
refs #1767
2018-01-09 14:23:46 +03:00
UdjinM6
eecec4535c
Merge pull request #1824 from codablock/pr_backport_bitcoin_0.14-1
...
Backport missing PRs from Bitcoin 0.14 - Part 1
2018-01-09 14:22:25 +03:00
UdjinM6
9965d51bb6
Avoid reference leakage in CKeyHolderStorage::AddKey ( #1840 )
2018-01-09 14:11:43 +03:00
UdjinM6
c532be1c06
Protect CKeyHolderStorage via mutex ( #1834 )
2018-01-09 12:18:10 +03:00
UdjinM6
d69ad9d619
Skip existing masternode conections on mixing ( #1833 )
2018-01-09 12:17:54 +03:00
Alexander Block
e2a795fd84
Return EXIT_SUCCESS instead of 0 in main()
2018-01-08 18:41:25 +01:00
Alexander Block
e3da73ebf8
Update Dash related code to use new SyncTransaction notifications interface
2018-01-08 18:41:06 +01:00
Alexander Block
ebc466dbd5
Revert test_bitcoin.info to test_dash.info in Makefile.am
2018-01-08 18:40:04 +01:00
Alexander Block
f8ffc55af2
Partially cherry-pick tests refactorings found in Bitcoin SegWit PRs
...
These were mixed into SegWit related PRs and are still needed in Dash.
2018-01-08 18:04:55 +01:00
Alexander Block
8460a9b975
Dashify translation_process.md
2018-01-08 18:04:55 +01:00
MarcoFalke
5b62ad34a3
Merge #8551 : [qa] Remove unused code
...
faaec13
[qa] Remove unused code (MarcoFalke)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
b47cc13317
Merge #8548 : [wallet] Use __func__ to get function name for output printing
...
fa785d1
Use __func__ to get function name for output printing (MarcoFalke)
2018-01-08 18:04:55 +01:00
Alexander Block
ae90d0f09e
Align HD wallet status icon code with Bitcoin code
...
Rename labelEncryptionIcon to labelWalletEncryptionIcon
Reorder icons in Makefile.qt.include
Add missing entries in debian/copyright
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
5bf3dadcb6
Merge #8461 : document return value of networkhashps for getmininginfo RPC endpoint
...
65f4532
document return value of networkhashps for getmininginfo RPC endpoint (Jameson Lopp)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
80573f2bf4
Merge #8540 : qt: Fix random segfault when closing "Choose data directory" dialog
...
b4a9aa5
qt: Fix random segfault when closing "Choose data directory" dialog (Wladimir J. van der Laan)
2018-01-08 18:04:55 +01:00
Pieter Wuille
55ccc56a80
Merge #8453 : Bring secp256k1 subtree up to date with master
...
b213535
Squashed 'src/secp256k1/' changes from 6c527ec..7a49cac (Wladimir J. van der Laan)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
7231c66901
Revert "[qa] Adjust timeouts for micro-optimization of run time"
...
This reverts commit fa2d68f79c
.
Temporary revert - see discussion in #8532 .
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
6ac01da712
Merge #8531 : [qa] abandonconflict: Use assert_equal
...
fa64306
[qa] abandonconflict: Use assert_equal (MarcoFalke)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
e6dca369e6
Merge #8504 : test: Remove java comparison tool
...
eb0c52e
travis: Remove hostname hack (Wladimir J. van der Laan)
3c5251d
test: Remove java comparison tool (Wladimir J. van der Laan)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
10aaf04b73
Merge #8505 : Trivial: Fix typos in various files
...
1aacfc2
various typos (leijurv)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
6b8160ba20
Merge #8513 : Fix a type error that would not compile on OSX.
...
8194a6e
Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) (Jeremy Rubin)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
7bba7375d0
Merge #8482 : [qa] Use single cache dir for chains
...
fad8cf6
[qa] Use single cache dir for chains (MarcoFalke)
fa2d68f
[qa] Adjust timeouts for micro-optimization of run time (MarcoFalke)
fae596f
[qa] Sort scripts by time for pull_tester and don't overwrite setup_chain (MarcoFalke)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
5c928f0052
Merge #8512 : Trivial: Corrected JSON typo on setban of net.cpp
...
6ffd996
Corrected JSON typo on setban of net.cpp (Sev)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
bdddabb3cf
Merge #8521 : qa: Remove duplicate hash160
implementation
...
c1582d5
qa: Remove duplicate `hash160` implementation (Wladimir J. van der Laan)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
9ecef83138
Merge #8520 : build: Remove check for openssl/ec.h
...
936c144
build: Remove check for `openssl/ec.h` (Wladimir J. van der Laan)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
599df51726
Merge #8516 : [trivial] remove no-longer-used InitError logic
...
edb6cf1
remove no-longer-used InitError logic (instagibbs)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
a953997b28
Merge #8058 : [Doc] Add issue template
...
3897668
Adds issue template. [skip ci] (CryptoVote)
2018-01-08 18:04:55 +01:00
MarcoFalke
bc659c3e6e
Merge #8270 : Tests: Use portable #! in python scripts (/usr/bin/env)
...
7b01ce2
Favour python over python2 as per PR #7723 (Matthew King)
873e81f
Use portable #! in python scripts (/usr/bin/env) (Matthew King)
2018-01-08 18:04:55 +01:00
Jonas Schnelli
a377499c10
Merge #8192 : [trivial] Remove URLs from About dialog translations
...
208d37f
[trivial] Remove URLs from About dialog translations (fanquake)
2018-01-08 18:04:55 +01:00
Alexander Block
f4af44676a
Add SYNC_TRANSACTION_NOT_IN_BLOCK constant and fix callers of SyncTransaction
...
Needed due to out-of-order backporting.
2018-01-08 18:04:55 +01:00
Pieter Wuille
256b9b77a2
Merge #7946 : Reduce cs_main locks during ConnectTip/SyncWithWallets
...
b3b3c2a
Reduce cs_main locks during ConnectTip/SyncWithWallets (Jonas Schnelli)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
6ba688b1c6
Merge #8353 : Trivial: tiny c++11 refactors
...
c784086
use std::map::emplace() instead of std::map::insert() (whythat)
5e187e7
use c++11 std::unique_ptr instead of boost::shared_ptr (whythat)
947913f
use std::map::erase(const_iterator, const_iterator) to get non-constant iterator (whythat)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
cca05694c5
Merge #8293 : Bugfix: Allow building libbitcoinconsensus without any univalue
...
8a270b2
Bugfix: Allow building libbitcoinconsensus without any univalue (Luke Dashjr)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
7dafb5303e
Merge #8492 : configure: Allow building bench_bitcoin by itself
...
216d796
configure: Allow building bench_bitcoin by itself (Luke Dashjr)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
82336d8184
Merge #8503 : [doc] typos, text errors
...
e11f9a2
[doc] typos, READMEs, comments (Justin Camarena)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
d5b5aeefe3
Merge #8481 : Qt: Fix minimize and close bugs
...
05242e9
Fix minimize and close bugs (adlawren)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
549894bac7
Merge #8444 : Fix p2p-feefilter.py for changed tx relay behavior
...
2c517b3
Fix p2p-feefilter.py for changed tx relay behavior (Suhas Daftuar)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
5e54cf907d
Merge #8392 : Fix several node initialization issues
...
9d4eb9a
Do diskspace check before import thread is started (Pieter Wuille)
aa59f2e
Add extra message to avoid a long 'Loading banlist' (Pieter Wuille)
0fd2a33
Use a signal to continue init after genesis activation (Pieter Wuille)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
35202920f8
Merge #8439 : [doc] Increase recommended memory in gitian build guide
...
7fdbce9
[doc] Increase recommended memory in gitian build guide (fanquake)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
2c3a218b34
Merge #8189 : rename mapAddrCount to mapNetGroupNodes
...
657fc19
rename mapAddrCount to mapNetGroupNodes (instagibbs)
2018-01-08 18:04:55 +01:00
Wladimir J. van der Laan
7c62457e6f
Merge #8428 : Update README.md inside of src/test/
...
b8db185
Update README.md (Chris Stewart)
2018-01-08 18:04:55 +01:00
Pieter Wuille
e34e2bbcca
Merge #8432 : Make CWallet::fFileBacked private.
...
29c2d99
Make CWallet::fFileBacked private. (Patrick Strateman)
2018-01-08 18:04:55 +01:00
Pieter Wuille
9589e24485
Merge #8152 : [Wallet] Remove CWalletDB* parameter from CWallet::AddToWallet
...
5723bb4
Remove unused pwalletdb from CWallet::AddToWallet (Patrick Strateman)
867f842
Remove CWalletDB* parameter from CWallet::AddToWallet (Patrick Strateman)
00f09c9
Split CWallet::AddToWallet into AddToWallet and LoadToWallet. (Patrick Strateman)
2018-01-08 18:04:55 +01:00
Pieter Wuille
aa6c37919b
Merge #8413 : Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock
...
c8664ee
Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock (Jorge Timón)
2018-01-08 18:04:55 +01:00
Pieter Wuille
60668fb93d
Merge #8346 : Mempool: Use Consensus::CheckTxInputs direclty over main::CheckInputs
...
a6cc299
Mempool: Use Consensus::CheckTxInputs direclty over main::CheckInputs (Jorge Timón)
2018-01-08 18:04:55 +01:00
MarcoFalke
8c76eb7394
Merge #8400 : [qa]: enable rpcbind_test
...
9bbb414
[qa]: enable rpcbind_test (whythat)
0ff4375
[qa]: add parsing for '<host>:<port>' argument form to rpc_url() (whythat)
2018-01-08 18:04:55 +01:00