Mark Friedenbach
dea8d21fc6
Enable policy enforcing GetMedianTimePast as the end point of lock-time constraints
...
Transactions are not allowed in the memory pool or selected for inclusion in a block until their lock times exceed chainActive.Tip()->GetMedianTimePast(). However blocks including transactions which are only mature under the old rules are still accepted; this is *not* the soft-fork required to actually rely on the new constraint in production.
2015-10-23 09:02:24 -07:00
Mark Friedenbach
9d55050773
Add rules--presently disabled--for using GetMedianTimePast as endpoint for lock-time calculations
...
The lock-time code currently uses CBlock::nTime as the cutoff point for time based locked transactions. This has the unfortunate outcome of creating a perverse incentive for miners to lie about the time of a block in order to collect more fees by including transactions that by wall clock determination have not yet matured. By using CBlockIndex::GetMedianTimePast from the prior block instead, the self-interested miner no longer gains from generating blocks with fraudulent timestamps. Users can compensate for this change by simply adding an hour (3600 seconds) to their time-based lock times.
If enforced, this would be a soft-fork change. This commit only adds the functionality on an unexecuted code path, without changing the behaviour of Bitcoin Core.
2015-10-23 09:02:24 -07:00
Jeff Garzik
46f74379b8
Merge pull request #6873
2015-10-23 09:01:22 -04:00
Wladimir J. van der Laan
c719cefc41
Merge pull request #6856
...
d3b09f6
Do not allow blockfile pruning during reindex. (Alex Morcos)
2015-10-23 14:41:30 +02:00
Wladimir J. van der Laan
2a1090d4f5
Merge pull request #6351
...
65ef372
Add BIP65 to getblockchaininfo softforks list (Peter Todd)
cde7ab2
Add RPC tests for the CHECKLOCKTIMEVERIFY (BIP65) soft-fork (Peter Todd)
287f54f
Add CHECKLOCKTIMEVERIFY (BIP65) soft-fork logic (Peter Todd)
2015-10-23 13:33:13 +02:00
Wladimir J. van der Laan
bf7c1958d1
Merge pull request #5936
...
212bcca
Add optional locktime to createrawtransaction (Tom Harding)
2015-10-23 12:47:19 +02:00
Wladimir J. van der Laan
923c5e93a9
Merge pull request #6818
...
b48da5c
script: Remove magic numbers (David Hill)
2015-10-23 11:50:10 +02:00
Wladimir J. van der Laan
fa1d252e82
Merge pull request #6790
...
8c15f33
[trivial] Update contrib/devtools/README.md (MarcoFalke)
338f62f
[devtools] add clang-format.py (MarcoFalke)
2015-10-23 10:45:50 +02:00
Wladimir J. van der Laan
b2b173acab
Merge pull request #6867
...
a4e28b3
Set TCP_NODELAY on P2P sockets. (Gregory Maxwell)
2015-10-23 09:29:49 +02:00
Jeff Garzik
3795e8152b
leveldbwrapper file rename to dbwrapper.*
2015-10-22 21:33:06 -04:00
Jeff Garzik
8587b23038
leveldbwrapper symbol rename: Remove "Level" from class, etc. names
2015-10-22 21:02:20 -04:00
Jeff Garzik
6ec4b7eb20
leveldbwrapper: Remove unused .Prev(), .SeekToLast() methods
...
Also, trim trailing whitespace.
2015-10-22 20:49:02 -04:00
Gregory Maxwell
a4e28b3d1e
Set TCP_NODELAY on P2P sockets.
...
Nagle appears to be a significant contributor to latency now that the static
sleeps are gone. Most of our messages are relatively large compared to
IP + TCP so I do not expect this to create enormous overhead.
This may also reduce traffic burstyness somewhat.
2015-10-22 17:57:48 +00:00
Wladimir J. van der Laan
f2c869aef2
Merge pull request #6848
...
c6824f8
Add DERSIG transaction test cases (J Ross Nicoll)
2015-10-22 18:02:17 +02:00
Wladimir J. van der Laan
2cd020d054
Merge pull request #6846
...
3cb56f3
*: alias -h for --help (Daniel Cousens)
2015-10-22 17:53:07 +02:00
Wladimir J. van der Laan
a09297010e
Merge pull request #6854
...
579b863
devtools: Add security-check.py (Wladimir J. van der Laan)
2015-10-22 10:23:42 +02:00
Wladimir J. van der Laan
579b863cd7
devtools: Add security-check.py
...
Perform the following ELF security checks:
- PIE: Check for position independent executable (PIE), allowing for address space randomization
- NX: Check that no sections are writable and executable (including the stack)
- RELRO: Check for read-only relocations, binding at startup
- Canary: Check for use of stack canary
Also add a check to symbol-check.py that checks that only the subset of
allowed libraries is imported (to avoid incompatibilities).
2015-10-22 03:35:38 +02:00
Daniel Cousens
3cb56f3778
*: alias -h for --help
2015-10-22 00:07:30 +11:00
Wladimir J. van der Laan
0fbfc5106c
Merge pull request #6859
...
41db8c4
http: Restrict maximum size of request line + headers (Wladimir J. van der Laan)
2015-10-21 11:19:25 +02:00
Wladimir J. van der Laan
3b20e239c6
Merge pull request #6722
...
58254aa
Fix stale comment in CTxMemPool::TrimToSize. (Matt Corallo)
2bc5018
Fix comment formatting tabs (Matt Corallo)
8abe0f5
Undo GetMinFee-requires-extra-call-to-hit-0 (Matt Corallo)
9e93640
Drop minRelayTxFee to 1000 (Matt Corallo)
074cb15
Add reasonable test case for mempool trimming (Matt Corallo)
d355cf4
Only call TrimToSize once per reorg/blocks disconnect (Matt Corallo)
794a8ce
Implement on-the-fly mempool size limitation. (Matt Corallo)
e6c7b36
Print mempool size in KB when adding txn (Matt Corallo)
241d607
Add CFeeRate += operator (Matt Corallo)
e8bcdce
Track (and define) ::minRelayTxFee in CTxMemPool (Matt Corallo)
9c9b66f
Fix calling mempool directly, instead of pool, in ATMP (Matt Corallo)
49b6fd5
Add Mempool Expire function to remove old transactions (Pieter Wuille)
78b82f4
Reverse the sort on the mempool's feerate index (Suhas Daftuar)
2015-10-21 08:50:16 +02:00
Wladimir J. van der Laan
c6de5cc886
Merge pull request #6796
...
c7b36cc
Change URLs to https in debian/control (Matt Corallo)
e253e83
Update debian/changelog and slight tweak to debian/control (Matt Corallo)
2015-10-20 17:09:22 +02:00
Wladimir J. van der Laan
e26a3f6713
Merge pull request #6235
...
55a8975
Chainparams: Translations: DRY: options and error strings (Jorge Timón)
f3525e2
Chainparams: Replace CBaseChainParams::Network enum with string constants (suggested by Wladimir) (Jorge Timón)
2015-10-20 17:06:28 +02:00
Wladimir J. van der Laan
41db8c4733
http: Restrict maximum size of request line + headers
...
Prevent memory exhaustion by sending lots of data.
Also add a test to `httpbasics.py`.
Closes #6425
2015-10-20 14:31:40 +02:00
Jorge Timón
55a89751fa
Chainparams: Translations: DRY: options and error strings
...
Also remove SelectBaseParamsFromCommandLine and SelectParamsFromCommandLine
2015-10-20 14:28:43 +02:00
Jorge Timón
f3525e24e3
Chainparams: Replace CBaseChainParams::Network enum with string constants (suggested by Wladimir)
2015-10-20 14:22:44 +02:00
Wladimir J. van der Laan
020c4073a0
Merge pull request #6841
...
b6d5e32
Make fee aware of min relay in pruning.py RPC test (Alex Morcos)
2015-10-20 12:53:45 +02:00
Wladimir J. van der Laan
ae69a75c55
Merge pull request #6801
...
e76d9e4
[depends] Latest config.guess and config.sub (fanquake)
2015-10-20 12:35:54 +02:00
Wladimir J. van der Laan
87e5539e9c
Merge pull request #6827
...
bd4c22e
[rpc-tests] Check return code (MarcoFalke)
0d8b175
[rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase (MarcoFalke)
2015-10-20 12:21:25 +02:00
Wladimir J. van der Laan
c834f56869
Merge pull request #6853
...
7801f43
Added fPowNoRetargeting field to Consensus::Params that disables nBits recalculation. (Eric Lombrozo)
2015-10-20 12:07:44 +02:00
Wladimir J. van der Laan
488f8517a1
Merge pull request #6829
...
53b86d0
doc: add comment explaining initial header request (Daniel Kraft)
2015-10-20 12:06:44 +02:00
MarcoFalke
bd4c22ed56
[rpc-tests] Check return code
2015-10-20 10:28:42 +02:00
MarcoFalke
0d8b1759d2
[rpc-tests] fundrawtransaction: Update fee after minRelayTxFee increase
2015-10-20 10:25:45 +02:00
Alex Morcos
d3b09f6bac
Do not allow blockfile pruning during reindex.
...
Also clarify startup message.
2015-10-19 14:43:04 -04:00
Eric Lombrozo
7801f4387d
Added fPowNoRetargeting field to Consensus::Params that disables nBits recalculation.
2015-10-19 14:25:21 -04:00
Wladimir J. van der Laan
da7d57fb95
Merge pull request #6852
...
bfcdc21
build: make sure OpenSSL heeds noexecstack (Wladimir J. van der Laan)
2015-10-19 15:02:57 +02:00
Wladimir J. van der Laan
5f5ee0f3ce
Merge pull request #6837
...
0658d0b
temporarily comment out rpcbind.py (Alex Morcos)
2015-10-19 12:15:26 +02:00
Wladimir J. van der Laan
bfcdc21a5d
build: make sure OpenSSL heeds noexecstack
...
This passes `-Wa,--noexecstack` to the assembler when building
platform-specific assembly files, to signal that a non-executable stack
can be used. This is the same approach as used by Debian
(see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=430583 )
2015-10-19 12:03:29 +02:00
Wladimir J. van der Laan
fc41278e96
Merge pull request #6843
...
99963b9
Correct spelling mistakes in doc folder (Mitchell Cash)
2015-10-19 12:01:07 +02:00
Matt Corallo
58254aa3bc
Fix stale comment in CTxMemPool::TrimToSize.
2015-10-19 02:41:52 -07:00
Wladimir J. van der Laan
5888046323
Merge pull request #6849
...
d2e3fbc
Mention PHP bindings to libbitcoinconsensus (Thomas Kerin)
2015-10-19 11:29:25 +02:00
Thomas Kerin
d2e3fbc620
Mention PHP bindings to libbitcoinconsensus
2015-10-18 19:04:14 +01:00
J Ross Nicoll
c6824f8a90
Add DERSIG transaction test cases
...
Add test cases for DERSIG flag enforcement against transactions.
2015-10-18 17:27:41 +01:00
Mitchell Cash
99963b938f
Correct spelling mistakes in doc folder
...
- OSX —> OS X
- XCode —> Xcode
- github —> GitHub
- homebrew —> Homebrew
- gitian —> Gitian
- Other miscellaneous obvious spelling fixes and whitespace removal
2015-10-18 06:25:43 +10:00
Alex Morcos
b6d5e32e0e
Make fee aware of min relay in pruning.py RPC test
2015-10-17 15:52:40 -04:00
Alex Morcos
0658d0ba82
temporarily comment out rpcbind.py
...
until libevent is fixed. also remove duplicate commented-out forknotify.py.
2015-10-16 10:27:03 -04:00
MarcoFalke
8c15f33d15
[trivial] Update contrib/devtools/README.md
2015-10-15 20:28:29 +02:00
MarcoFalke
338f62f701
[devtools] add clang-format.py
2015-10-15 19:43:16 +02:00
David Hill
b48da5c189
script: Remove magic numbers
...
This adds two new constants, MAX_OPS_PER_SCRIPT and
MAX_PUBKEYS_PER_MULTISIG.
2015-10-15 09:48:15 -04:00
Wladimir J. van der Laan
d78a880900
Merge pull request #6820
...
60af755
build: univalue subdir build fixups (Cory Fields)
2015-10-15 12:55:25 +02:00
Wladimir J. van der Laan
8ce9920635
Merge pull request #6817
...
a0d5e0d
[doc] Cleanup release-process documentation (Michael)
2015-10-15 12:54:13 +02:00