Commit Graph

14961 Commits

Author SHA1 Message Date
UdjinM6
b98643c27d
Split sentinel expiration in CMasternode::Check() in two parts (timeout and version) (#2121)
The initial ping is sent with defaults which switch MNs to SENTINEL_PING_EXPIRED state
while they should really be in PRE_ENABLED state. The fix is to split this verification
in two parts - this way sentinel version is only checked after at least one ping is received
from the masternode itself and not from the cold wallet.
2018-06-18 19:07:34 +03:00
UdjinM6
5669fc880e
Fix typos and rpc help text (#2120)
* Fix typo in PS info dialog

Also adjust translations accordingly.

* Fix typo in PS low key warning

* Fix typo in sendrawtransaction help

* Fix sendtoaddress/sendmany help text

* Fix listreceivedby* help text

* Fix typo in listunspent help

* Fix spelling "recieves"->"receives"

Shame on me

* transactions->transaction

* receives->"incoming payments grouped"
2018-06-18 19:07:09 +03:00
UdjinM6
d076ad4cea
Update release notes and staging tree in README (#2116)
* Update release notes

* add 2118

* bump staging tree in README.md
2018-06-12 22:10:36 +03:00
UdjinM6
806d7f0496
Fix rpc tests broken by 2110 (#2118) 2018-06-12 21:37:31 +03:00
UdjinM6
836e104710
Bump proto to 70210 (#2109) 2018-06-12 14:33:41 +03:00
UdjinM6
8d8fdb4339
sendrawtransaction no longer bypasses transaction policy limits by default (#2110)
* [rpc] sendrawtransaction no longer bypasses minRelayTxFee

The prioritisetransaction API can always be used if a transaction needs to be submitted that bypasses minRelayTxFee.

* Allow to bypass transaction policy limits in sendrawtransaction

Add new rpc param to sendrawtransaction to have an ability to tweak its behaviour.
Default is `false` i.e. "do not bypass".

* fix
2018-06-12 14:33:23 +03:00
UdjinM6
8e129877a6
Partially revert 1922 (#2108)
Turned out we actually need mixing collaterals charged as fees in our mempool for them to be relayed.
2018-06-11 13:14:41 +03:00
UdjinM6
8c2d16f5f3
Limit IS quorums by updated MNs only (#2107) 2018-06-11 13:14:24 +03:00
Semen Martynov
0a71c693e7 Remove explicit wallet lock in MasternodeList::StartAll() (#2106)
Possible fix #2104
2018-06-11 13:14:00 +03:00
UdjinM6
0de79d70b5
Do not create oversized transactions (bad-txns-oversize) (#2103) 2018-06-11 13:13:20 +03:00
UdjinM6
fcac40ab4e
RPC: fix wallet lock check in privatesend start (#2102) 2018-06-11 13:13:03 +03:00
UdjinM6
23ba94b370
Bump remaining min protocols (#2097)
* bump MIN_GOVERNANCE_PEER_PROTO_VERSION

* bump MIN_MASTERNODE_PAYMENT_PROTO_VERSION_2
2018-06-06 19:06:52 +03:00
UdjinM6
6c79c348ee
Drop "MAY, 2018" clause for proposal validation on mainnet (#2101) 2018-06-06 19:06:23 +03:00
UdjinM6
6079b860e3
Drop trigger objects when triggers are deleted or failed to be created (#2098)
* Mark an object for deletion when the corresponding trigger is deleted

* Mark objects for deletion if creation of corresponding triggers failed

* NULL -> nullptr

* Make sure pObj is not null
2018-06-06 18:56:33 +03:00
UdjinM6
9299a84b1f
Bump few consts (#2096)
* bump BLOCK_CHAIN_SIZE

* bump nMinBlocksToStore default
2018-06-06 10:59:25 +03:00
UdjinM6
dbbedc031c
Fix JoinExistingQueue bug (#2100)
10s denoms were ignored due to the value overflow
2018-06-06 10:59:09 +03:00
Alexander Block
7b43720f05
Fix copying of final binaries into dashcore-binaries (#2090)
* Fix copying of final binaries into dashcore-binaries

* Fix binary names in gitian-osx-signer.yml and gitian-win-signer.yml
2018-05-31 17:31:00 +02:00
UdjinM6
ca2eae6e6e
12.3 release notes draft (#2045)
* 12.3 release notes draft

* update

* mn info dialog

* typo

* Minor additions and fixes

* A few additions

* Addressed reviews, rephrased, updated

* add recent commits

* more typos

* add recent commits

* Add recent commits

* add Chris Adam to credits for image work
2018-05-30 16:47:06 +03:00
Alexander Block
faeb4480a1 Update manpages with ./contrib/devtools/gen-manpages.sh (#2088) 2018-05-30 15:29:01 +03:00
Alexander Block
cc593615e1 Bump copyright year to 2018 (#2087) 2018-05-30 15:28:44 +03:00
Alexander Block
2129ee4d8c Add docker support when doing Gitian builds (#2084)
* gitian-build.sh: fix signProg being recognized as two parameters

* Support docker based Gitian builds

Requires a gitian-builder version with
https://github.com/devrandom/gitian-builder/pull/181

This will also switch to use Docker by default.

* Switch back to using lxc as default until upstream gitian-builder is ready
2018-05-30 13:48:30 +03:00
Alexander Block
6a1456ef4c Update gitian key for codablock (#2085)
https://keybase.io/codablock

Old key was using default gpg settings with 2048 bits.
2018-05-29 18:13:47 +03:00
Nathan Marley
82805a6c69 swap out old logo for T&C logo in Qt GUI (#2081)
* Qt: rename light theme to light-retro

* add new light theme with new logo images

* revert changes to light.css

* Qt: rename light-hires theme to light-hires-retro

* copy, not move

* restore light-hires.css

* all links updated from light to light-retro

* revert rm trailing spaces in src/qt/guiutil.cpp

* all links updated from light-hires to light-hires-retro
2018-05-29 18:13:08 +03:00
Alexander Block
ab96a6af63 Update gitian keys, script and doc (#2082)
* Remove Bitcoin Gitian keys

* Update gitian-build.sh and gitian-building.md

gitian-building.md referenced "br0" but "lxcbr0" was used in the script.
gitian-build.sh used 10.0.2.2 as IP for the bridge but this conflicts with
VirtualBox networking.

* Add gitian key for codablock

https://keybase.io/codablock

* Add gitian key for schinzelh

https://keybase.io/schinzelh

* Add gitian key for gladcow

https://keybase.io/gladcow

* Add gitian key for nmarley

https://keybase.io/nmarley

* Add gitian key for udjinm6

https://keybase.io/UdjinM6

* Add EOL chars
2018-05-26 21:04:07 +03:00
UdjinM6
c60079b594
ThreadOpenMasternodeConnections should process only one mn at a time (#2080) 2018-05-26 21:03:49 +03:00
UdjinM6
7ac4b972ab
Require all participants to submit equal number of inputs (#2075)
Activates via SPORK_6_NEW_SIGS to avoid nInputCount malleability
2018-05-26 21:03:23 +03:00
UdjinM6
0260821f87
fix SelectCoinsByDenominations (#2074)
Should return all denoms, excluding some for privacy reason is the job for PrepareDenominate
2018-05-26 21:03:08 +03:00
UdjinM6
5d057cf664
Add string_cast benchmark (#2073)
* Add string_cast benchmark

* add NumberToString
2018-05-26 21:02:49 +03:00
UdjinM6
cf71f5767d
Fix potential DoS vector for masternode payments (#2071)
* Skip only already verified mn payments vote duplicates

* Update mn payment vote stats only if mn payment vote sig is ok
2018-05-26 21:02:23 +03:00
thephez
ef85d5144d Comment updates - InstantSend (#2062)
* [Comment] - Minor Instantx comment updates and additions

* [Comment] - Update to doxygen recognised format
 - Capitalisation changes

* [Comment] - Add some minor InstantSend comments
2018-05-13 23:58:01 +03:00
UdjinM6
febdc2116c
Fix nl locale alias (#2061) 2018-05-13 23:57:43 +03:00
UdjinM6
1264a55779
Fix spork signature check for new nodes after SPORK_6_NEW_SIGS is switched to ON (#2060)
Unlike for other messages we have to check for new format even with SPORK_6_NEW_SIGS inactive because SPORK_6_NEW_SIGS default is OFF it is not the first spork to sync (and even if it would, spork order can't be guaranteed anyway).
2018-05-13 23:57:32 +03:00
Nathan Marley
41680f4d94 small cleanup in a few places (#2058)
* move nStart closer to used and initialize it

* Quells warning displayed with `-Wmaybe-uninitialized` flag

* remove unused mnEntries vectors

* add devnet magic bytes to mininode.py

* remove unused governance-misc.h file

* remove old TODO comments

* replace map count/insert w/emplace in instantx.cpp

This feels like an optimization, something about:

```
if map.count(key)
     return false
else
     insert(pair)
     return true
```

... just feels icky. Plus, `vote.GetMasternodeOutpoint()` is only called
once. The previous version might be slightly more readable, however.

* Revert "replace map count/insert w/emplace in instantx.cpp"

This reverts commit d7f876e863.
2018-05-13 23:57:12 +03:00
UdjinM6
ff93dd6131
Check devnet genesis block (#2057)
* Fix off-by-one in BIPXX activation heights for devnet

* Fail on invalid devnet genesis block
2018-05-13 23:56:51 +03:00
Alexander Block
1dbf5a0f63 Fix transaction/block versions for devnet genesis blocks (#2056)
* Fix transaction/block versions for devnet genesis blocks

56ff71fcec mistakenly increased the coinbase transaction version instead
of the block version. This fixes it.

* Use v1 for coinbase transaction
2018-05-13 23:56:21 +03:00
UdjinM6
741b94875b
Translations201804 (#2012)
* fix doc

* fix string in masternode list

* make translate

* fix askpassphrasedialog.cpp

* ru

* add fr and sk

* 	add fi

* update fi

* update ru

* it, pl, zh_TW

Note: zh_TW has one issue: `Mismatch between 'Too many %f denominations, removing.' and '太多輸入金額,正在移除。'`

* add/update bg, de, fi, it, vi, zh_CN, zh_TW

* add nl

* update es

* add pt_BR (97.5%)
2018-04-30 01:10:20 +03:00
UdjinM6
6ab1fd7636
RPC: Add description for InstantSend-related fields of mempool entry (#2050) 2018-04-30 01:09:47 +03:00
Nathan Marley
8e24b087b4 replace boost iterators in dash-specific code (#2048) 2018-04-23 13:25:04 +03:00
UdjinM6
2583e1963c
Test: Add few valid/invalid proposals (internationalization) (#2044)
Co-authored-by: Alex Werner <Alex-Werner@users.noreply.github.com>
2018-04-23 13:24:15 +03:00
Nathan Marley
25eb6d7b33 clean up governance vote code (#2042)
* clean up governance vote code

* remove old comment on votemanager design

* use map::find for signal string lookup

* make mapStrVoteSignals const and static

* this should be read-only for lookups (const)
* this should be allocated only once (static)
2018-04-23 13:23:58 +03:00
Alexander Block
7719b7ec25 Update BIP147 deployment times, nMinimumChainWork and defaultAssumeValid (#2030)
* Update BIP147 deployment times

* Update nMinimumChainWork and defaultAssumeValid of mainnet
2018-04-20 13:54:49 +03:00
UdjinM6
b07503f013
Some cleanup (mostly trivial) (#2038)
* Drop CInstantSend::IsEnoughOrphanVotesForTxAndOutPoint

* small cleanup in rpc tests

* move some pieces from .h to .cpp

* fix few log outputs

* fix some comments

* some trivial fixes + readability
2018-04-20 13:53:23 +03:00
UdjinM6
a648d6efff
Drop delayed headers logic and fix duplicate initial headers sync by handling block inv correctly (#2032)
* Drop custom logic for delaying GETHEADERS

Reverts "Fix duplicate headers download in initial sync (#1589)" and all following fixes

This reverts commit 169afafd50.

* Fix duplicate initial headers sync
2018-04-20 13:53:05 +03:00
Nathan Marley
99085c5b68 swap devnet magic bytes around (#2028)
Prevents testnet and devnet messages from being confused and helps
differentiate which network messages should refer to.
2018-04-20 13:52:31 +03:00
UdjinM6
138441eb82
Add forkpoint to getchaintips (#2039) 2018-04-18 14:50:52 +03:00
Nathan Marley
f8e5c5d56e Simplify spork defaults by using a map (#2037) 2018-04-18 14:50:26 +03:00
Spencer Lievens
6dd8304a5c Remove duplication of "class CBlockIndex;" (#2036) 2018-04-18 14:50:08 +03:00
UdjinM6
4ea7903777
Dashify lib names (#2035) 2018-04-18 14:49:57 +03:00
UdjinM6
4148b82009
Release notes cleanup (#2034)
* Merge "Prepare 0.12.2.3 release notes (#1846)" from master

* drop bitcoin release notes
2018-04-18 14:49:40 +03:00
UdjinM6
a37dbd6d2b
Fix netfulfilledman usage (#2033)
* drop CMasternodeSync::ClearFulfilledRequests()

* Cleanup netfulfilledman periodically

* Do not expose RemoveFulfilledRequest()
2018-04-18 14:49:25 +03:00