Wladimir J. van der Laan
44fef99e66
net: Fix sent reject messages for blocks and transactions
...
Ever since we #5913 have been sending invalid reject messages
for transactions and blocks.
test: Add basic test for `reject` code
Extend P2P test framework to make it possible to expect reject
codes for transactions and blocks.
Github-Pull: #7179
Rebased-From: 9fc6ed6003
20411903d7
2015-12-10 11:59:34 +01:00
Wladimir J. van der Laan
b2d7ada372
test: remove necessity to call create_callback_map
...
Remove necessity to call create_callback_map (as well as the function
itself) from the Python P2P test framework. Invoke the appropriate
methods directly.
- Easy to forget to call it and wonder why it doesn't work
- Simplifies the code
- This makes it easier to handle new messages in subclasses
Github-Pull: #7171
Rebased-From: 2f601d215d
2015-12-07 12:45:14 +01:00
Gregory Maxwell
f31955d9da
Replace setInventoryKnown with a rolling bloom filter.
...
Github-Pull: #7133
Rebased-From: ec73ef37ec
e20672479e
6b849350ab
b6a0da45db
d41e44c9ac
aa4b0c26b0
2015-12-04 15:01:09 +01:00
Peter Todd
092e9ad7d9
Remove old replace-by-fee tests
...
Made redundant by tests in qa/rpc-tests/replace-by-fee.py
2015-12-02 18:26:53 +08:00
Wladimir J. van der Laan
16f4a6e0fe
Merge pull request #7137
...
cfdc662
Explicitly set chain limits in replace-by-fee test (Suhas Daftuar)
2015-12-01 13:32:21 +01:00
Wladimir J. van der Laan
2ef5ffa59a
Merge pull request #6915
...
2d8860e
Fix removeForReorg to use MedianTimePast (Suhas Daftuar)
b7fa4aa
Don't call removeForReorg if DisconnectTip fails (Suhas Daftuar)
7e49f5f
Track coinbase spends in CTxMemPoolEntry (Suhas Daftuar)
bb8ea1f
removeForReorg calls once-per-disconnect-> once-per-reorg (Matt Corallo)
474b84a
Make indentation in ActivateBestChainStep readable (Matt Corallo)
b0a064c
Fix comment in removeForReorg (Matt Corallo)
9b060e5
Fix removal of time-locked transactions during reorg (Matt Corallo)
0c9959a
Add failing test checking timelocked-txn removal during reorg (Matt Corallo)
2015-12-01 13:17:34 +01:00
Wladimir J. van der Laan
9afbd96919
Merge pull request #7022
...
50947ef
Change default block priority size to 0 (Alex Morcos)
2015-12-01 12:39:34 +01:00
Suhas Daftuar
2b31ab90c4
Add rpc test for prioritisetransaction
2015-12-01 11:03:57 +01:00
Suhas Daftuar
6e8b07f5f3
Add rounding helper function to util.py
2015-12-01 11:03:37 +01:00
Wladimir J. van der Laan
eb3d1b3487
Merge pull request #7135
...
fa3a38a
[qa] pull-tester: Cleanup (run keypool, tidy stdout) (MarcoFalke)
2015-12-01 09:56:09 +01:00
Wladimir J. van der Laan
30c2d8c635
Merge pull request #7105
...
9ac63d6
Keep track of explicit wallet conflicts instead of using mempool (Pieter Wuille)
2015-12-01 09:22:08 +01:00
Alex Morcos
50947ef23f
Change default block priority size to 0
...
Make RPC tests have a default block priority size of 50000 (the old default) so we can still use free transactions in RPC tests. When priority is eliminated, we will have to make a different change if we want to continue allowing free txs.
2015-11-30 16:16:24 -05:00
Gregory Maxwell
438ee59839
Merge pull request #7044
...
d52fbf0
Added additional config option for multiple RPC users. (Gregory Sanders)
2015-11-30 12:25:28 -08:00
Matt Corallo
0c9959a308
Add failing test checking timelocked-txn removal during reorg
2015-11-30 13:02:04 -05:00
Suhas Daftuar
cfdc66280f
Explicitly set chain limits in replace-by-fee test
2015-11-30 12:35:24 -05:00
MarcoFalke
fa3a38a7f2
[qa] pull-tester: Cleanup (run keypool, tidy stdout)
...
* Run keypool (takes 6 seconds)
* Print duration of each rpc test
* Structure output (bold, new lines)
2015-11-30 16:01:57 +01:00
Wladimir J. van der Laan
a7751824ce
Merge pull request #7103
...
fa506c0
[wallet] Add rpc tests to verify fee calculations (MarcoFalke)
4b89f01
Default fPayAtLeastCustomFee to false (Ryan Havar)
2015-11-30 12:18:20 +01:00
Wladimir J. van der Laan
6fc287f2df
Merge pull request #7027
...
4ea1790
[qa] keypool: DRY: Use test framework (MarcoFalke)
c6973ca
[qa] keypool: Fix white space to prepare transition to test framework (MarcoFalke)
2015-11-30 12:15:21 +01:00
Gregory Sanders
d52fbf00e3
Added additional config option for multiple RPC users.
2015-11-29 08:34:20 -05:00
Pieter Wuille
9ac63d6d30
Keep track of explicit wallet conflicts instead of using mempool
2015-11-29 13:24:02 +01:00
Suhas Daftuar
50262d8953
Allow block announcements with headers
...
This replaces using inv messages to announce new blocks, when a peer requests
(via the new "sendheaders" message) that blocks be announced with headers
instead of inv's.
Since headers-first was introduced, peers send getheaders messages in response
to an inv, which requires generating a block locator that is large compared to
the size of the header being requested, and requires an extra round-trip before
a reorg can be relayed. Save time by tracking headers that a peer is likely to
know about, and send a headers chain that would connect to a peer's known
headers, unless the chain would be too big, in which case we revert to sending
an inv instead.
Based off of @sipa's commit to announce all blocks in a reorg via inv,
which has been squashed into this commit.
Rebased-by: Pieter Wuille
2015-11-29 11:59:23 +01:00
MarcoFalke
fa506c0c9b
[wallet] Add rpc tests to verify fee calculations
2015-11-28 22:52:13 +01:00
Wladimir J. van der Laan
0e935865b9
Merge pull request #6871
...
63b5840
Fix usage of local python-bitcoinlib (Peter Todd)
16a2f93
Fix incorrect locking of mempool during RBF replacement (Peter Todd)
97203f5
Port test to rpc-test framework (Suhas Daftuar)
20367d8
Add test for max replacement limit (Suhas Daftuar)
73d9040
Improve RBF replacement criteria (Suhas Daftuar)
b272ecf
Reject replacements that add new unconfirmed inputs (Peter Todd)
fc8c19a
Prevent low feerate txs from (directly) replacing high feerate txs (Peter Todd)
0137e6f
Add tests for transaction replacement (Peter Todd)
5891f87
Add opt-in full-RBF to mempool (Peter Todd)
2015-11-27 13:20:39 +01:00
Wladimir J. van der Laan
e92377fa7f
Merge pull request #6134
...
e304432
Pass reference to estimateSmartFee and cleanup whitespace (Suhas Daftuar)
56106a3
Expose RPC calls for estimatesmart functions (Alex Morcos)
e93a236
add estimateSmartFee to the unit test (Alex Morcos)
6303051
EstimateSmart functions consider mempool min fee (Alex Morcos)
f22ac4a
Increase success threshold for fee estimation to 95% (Alex Morcos)
4fe2823
Change wallet and GUI code to use new smart fee estimation calls. (Alex Morcos)
22eca7d
Add smart fee estimation functions (Alex Morcos)
2015-11-27 12:59:37 +01:00
Wladimir J. van der Laan
ed34e0577e
Merge pull request #7052
...
a0953cd
[qa] python-bitcoinrpc is no longer a subtree (MarcoFalke)
2015-11-24 09:29:46 +01:00
Gregory Maxwell
0b0fc179ab
Merge pull request #7028
...
e16ee1c
[qa] Extend README.md (MarcoFalke)
cc97574
[qa] Split README.md to /qa and /qa/rpc-tests (MarcoFalke)
2015-11-22 14:51:30 -08:00
Gregory Maxwell
9cdd407ca5
Merge pull request #7029
...
c800c95
Remove unmaintained example test script_test.py (Suhas Daftuar)
2015-11-22 14:47:40 -08:00
Peter Todd
63b5840257
Fix usage of local python-bitcoinlib
...
Previously was using the system-wide python-bitcoinlib, if it existed,
rather than the local copy that you check out in the README.
2015-11-20 16:23:01 -05:00
Wladimir J. van der Laan
07b770caf3
Merge pull request #7019
...
33b7f83
[qa] travis: cover *receivedby* rpcs (MarcoFalke)
2015-11-20 09:01:07 +01:00
MarcoFalke
a0953cdf07
[qa] python-bitcoinrpc is no longer a subtree
...
* Only authproxy.py is taken from the python-bitcoinrpc
2015-11-19 12:39:49 +01:00
MarcoFalke
e16ee1cd1e
[qa] Extend README.md
2015-11-18 11:59:12 +01:00
MarcoFalke
cc975745d5
[qa] Split README.md to /qa and /qa/rpc-tests
...
+ Update with new -help message
2015-11-17 13:03:59 +01:00
Alex Morcos
56106a3300
Expose RPC calls for estimatesmart functions
...
Also add testing for estimatesmartfee in smartfees.py
2015-11-16 15:42:31 -05:00
Suhas Daftuar
c800c95997
Remove unmaintained example test script_test.py
2015-11-16 09:50:50 -05:00
MarcoFalke
4ea1790553
[qa] keypool: DRY: Use test framework
2015-11-16 12:01:32 +01:00
MarcoFalke
c6973ca03b
[qa] keypool: Fix white space to prepare transition to test framework
2015-11-16 12:01:32 +01:00
MarcoFalke
33b7f83c59
[qa] travis: cover *receivedby* rpcs
2015-11-14 22:33:13 +01:00
Jonas Schnelli
d61fcff071
don't enforce maxuploadtargets disconnect for whitelisted peers
2015-11-13 21:04:12 +01:00
Wladimir J. van der Laan
d2e987aa19
Merge pull request #6958
...
9c3ee3b
[doc] Add -maxuploadtarget release notes (MarcoFalke)
b27e81f
[net] Cleanup maxuploadtarget (MarcoFalke)
2015-11-13 13:27:33 +01:00
Jeff Garzik
38ed190eef
Merge #6771 from branch 'lowerLimits' of git://github.com/morcos/bitcoin
2015-11-12 15:38:59 -05:00
MarcoFalke
b27e81f115
[net] Cleanup maxuploadtarget
...
* log: nMaxOutboundLimit is in bytes
* log: Hide misleading -maxuploadtarget=0 warning
* qa : Minor cleanup to maxuploadtarget rpc tests
* net: Use DEFAULT_MAX_UPLOAD_TARGET = 0
2015-11-12 20:45:57 +01:00
Wladimir J. van der Laan
5fcc14ee05
Merge pull request #6804
...
b5cbd39
Add basic coverage reporting for RPC tests (James O'Beirne)
2015-11-12 08:22:36 +01:00
James O'Beirne
b5cbd396ca
Add basic coverage reporting for RPC tests
...
Thanks to @MarcoFalke @dexX7 @laanwj for review.
2015-11-11 10:33:43 -08:00
Suhas Daftuar
97203f5606
Port test to rpc-test framework
2015-11-10 14:14:46 -05:00
Suhas Daftuar
20367d831f
Add test for max replacement limit
2015-11-10 14:14:07 -05:00
Peter Todd
b272ecfdb3
Reject replacements that add new unconfirmed inputs
2015-11-10 14:14:07 -05:00
Peter Todd
fc8c19a07c
Prevent low feerate txs from (directly) replacing high feerate txs
...
Previously all conflicting transactions were evaluated as a whole to
determine if the feerate was being increased. This meant that low
feerate children pulled the feerate down, potentially allowing a high
transaction with a high feerate to be replaced by one with a lower
feerate.
2015-11-10 14:14:07 -05:00
Peter Todd
0137e6fafd
Add tests for transaction replacement
2015-11-10 14:14:07 -05:00
Wladimir J. van der Laan
2980a18572
Fix crash in validateaddress with -disablewallet
...
Fix a null pointer dereference in validateaddress with -disablewallet. Also add a regression testcase.
2015-11-09 08:44:19 +01:00
Wladimir J. van der Laan
26752767df
Merge pull request #6894
...
3e187f2
Fix BIP65 p2p test (Suhas Daftuar)
2015-10-29 13:12:47 +01:00