## Issue being fixed or feature implemented Client version string is inconsistent. Building `v20.0.0-beta.8` tag locally produces binaries that report `v20.0.0-beta.8` version but binaries built in guix would report `v20.0.0rc1-g3e732a952226a20505f907e4fd9b3fdbb14ea5ee` instead. Building any commit after `v20.0.0-beta.8` locally would result in versions like `v20.0.0rc1-8c94153d2497` which is close but it's still yet another format. And both versions with `rc1` in their names are confusing cause you'd expect them to mention `beta.8` instead maybe (or is it just me? :D ). ## What was done? Change it so that the version string would look like this: on tag: ~`v20.0.0-beta.8-dev` or `v20.0.0-beta.8-gitarc`~ `v20.0.0-beta.8` post-tag: ~`v20.0.0-beta.8-1-gb837e08164-gitarc`~ `v20.0.0-beta.8-1-gb837e08164` post-tag format is `recent tag`-`commits since that tag`-`g+12 chars of commit hash`-`dirty (optional)` ~-`dev or gitarc`~ ~`dev`/`gitarc` suffixes should help avoiding confusion with the release versions and they also indicate the way non-release binaries were built.~ Note that release binaries do not use any of this, they still use `PACKAGE_VERSION` from `configure` like before. Also, `CLIENT_VERSION_RC` is no longer used in this setup so it was removed. Few things aren't clear to me yet: 1. Version bump in `configure.ac` no longer affects the reported version (unless it's an actual release). Are there any downsides I might be missing? 2. Which tag should we use on `develop` once we bump version in configure? `v21.0.0-init`? `v21.0.0-alpha1`? 3. How is it going to behave once `merge master back into develop` kind of PR is merged? E.g. say `develop` branch is on `v21.0.0-alpha1` tag and we merge v20.1.0 from `master` back into it. Will this bring `v20.1.0` release tag into `develop`? Will it become the one that will be used from that moment? If so we will probably need another tag on `develop` every time such PR is merged e.g. `v21.0.0-alpha2` (or whatever the next number is). Don't think these are blockers but would like to hear thoughts from others. ## How Has This Been Tested? Built binaries locally, built them using guix at a specific tag and at some commit on top of it. ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
12 KiB
Release Process
- Update translations, see translation_process.md.
- Update manpages, see gen-manpages.sh.
Before every minor and major release:
- Update bips.md to account for changes since the last release.
- Update DIPs with any changes introduced by this release (see this pull request for an example)
- Update version in
configure.ac
(don't forget to setCLIENT_VERSION_IS_RELEASE
totrue
) - Write release notes (see below)
- Update
src/chainparams.cpp
nMinimumChainWork
with information from thegetblockchaininfo
rpc. - Update
src/chainparams.cpp
defaultAssumeValid
with information from thegetblockhash
rpc.- The selected value must not be orphaned so it may be useful to set the value two blocks back from the tip.
- Testnet should be set some tens of thousands back from the tip due to reorgs there.
- This update should be reviewed with a
reindex-chainstate
withassumevalid=0
to catch any defect that causes rejection of blocks in the past history.
- Ensure all TODOs are evaluated and resolved if needed
- Verify Insight works
- Verify p2pool works (unmaintained; no responsible party)
- Tag version and push (see below)
- Validate that CI passes
Before every major release:
- Update hardcoded seeds, see this pull request for an example.
- Update
src/chainparams.cpp
m_assumed_blockchain_size
andm_assumed_chain_state_size
with the current size plus some overhead (see this for information on how to calculate them). - Update
src/chainparams.cpp
chainTxData
with statistics about the transaction count and rate. Use the output of the RPCgetchaintxstats
, see this pull request for an example. Reviewers can verify the results by runninggetchaintxstats <window_block_count> <window_last_block_hash>
with thewindow_block_count
andwindow_last_block_hash
from your output.
First time / New builders
Install Guix using one of the installation methods detailed in contrib/guix/INSTALL.md.
Check out the source code in the following directory hierarchy.
cd /path/to/your/toplevel/build
git clone https://github.com/dashpay/guix.sigs.git
git clone https://github.com/dashpay/dash-detached-sigs.git
git clone https://github.com/dashpay/dash.git
Dash Core maintainers/release engineers, suggestion for writing release notes
Write release notes. git shortlog helps a lot, for example:
git shortlog --no-merges v(current version, e.g. 19.3.0)..v(new version, e.g. 20.0.0)
Generate list of authors:
git log --format='- %aN' v(current version, e.g. 19.3.0)..v(new version, e.g. 20.0.0) | sort -fiu
Tag version (or release candidate) in git
git tag -s v(new version, e.g. 20.0.0)
Setup and perform Guix builds
Checkout the Dash Core version you'd like to build:
pushd ./dash
export SIGNER='(your builder key, ie udjinm6, pasta, etc)'
export VERSION='(new version, e.g. 20.0.0)'
git fetch "v${VERSION}"
git checkout "v${VERSION}"
popd
Ensure your guix.sigs are up-to-date if you wish to guix-verify
your builds
against other guix-attest
signatures.
git -C ./guix.sigs pull
Create the macOS SDK tarball: (first time, or when SDK version changes)
Note: this step can be skipped if our CI still uses bitcoin's SDK package (see SDK_URL)
Create the macOS SDK tarball, see the macOS build instructions for details.
Build and attest to build outputs:
Follow the relevant Guix README.md sections:
Verify other builders' signatures to your own. (Optional)
Add other builders keys to your gpg keyring, and/or refresh keys: See ../dash/contrib/builder-keys/README.md
.
Follow the relevant Guix README.md sections:
Next steps:
Commit your signature to guix.sigs
:
pushd guix.sigs
git add "${VERSION}/${SIGNER}/noncodesigned.SHA256SUMS{,.asc}"
git commit -a
git push # Assuming you can push to the guix.sigs tree
popd
Codesigner only: Create Windows/macOS detached signatures:
- Only one person handles codesigning. Everyone else should skip to the next step.
- Only once the Windows/macOS builds each have 3 matching signatures may they be signed with their respective release keys.
Codesigner only: Sign the macOS binary:
-
Transfer
dashcore-osx-unsigned.tar.gz
to macOS for signing -
Extract and sign:
tar xf dashcore-osx-unsigned.tar.gz ./detached-sig-create.sh -s "Key ID" -o runtime
-
Enter the keychain password and authorize the signature
-
Move
signature-osx.tar.gz
back to the guix-build host
Codesigner only: Sign the windows binaries:
-
Extract and sign:
tar xf dashcore-win-unsigned.tar.gz ./detached-sig-create.sh -key /path/to/codesign.key
-
Enter the passphrase for the key when prompted
-
signature-win.tar.gz
will be created
Codesigner only: Commit the detached codesign payloads:
pushd ~/dashcore-detached-sigs
# checkout the appropriate branch for this release series
git checkout "v${VERSION}"
rm -rf *
tar xf signature-osx.tar.gz
tar xf signature-win.tar.gz
git add -A
git commit -m "add detached sigs for win/osx for ${VERSION}"
git push
popd
Non-codesigners: wait for Windows/macOS detached signatures:
- Once the Windows/macOS builds each have 3 matching signatures, they will be signed with their respective release keys.
- Detached signatures will then be committed to the dash-detached-sigs repository, which can be combined with the unsigned apps to create signed binaries.
Create (and optionally verify) the codesigned outputs:
Commit your signature for the signed macOS/Windows binaries:
pushd ./guix.sigs
git add "${VERSION}/${SIGNER}"/all.SHA256SUMS{,.asc}
git commit -m "Add ${SIGNER} ${VERSION} signed binaries signatures"
git push # Assuming you can push to the guix.sigs tree
popd
After 3 or more people have guix-built and their results match:
- Combine the
all.SHA256SUMS.asc
file from all signers intoSHA256SUMS.asc
:cat "$VERSION"/*/all.SHA256SUMS.asc > SHA256SUMS.asc
- GPG sign each download / binary
- Upload zips and installers, as well as
SHA256SUMS.asc
from last step, to GitHub as GitHub draft release.-
The contents of each
./dash/guix-build-${VERSION}/output/${HOST}/
directory, except for*-debug*
files.Guix will output all of the results into host subdirectories, but the
SHA256SUMS
file does not include these subdirectories. In order for downloads via torrent to verify without directory structure modification, all of the uploaded files need to be in the same directory as theSHA256SUMS
file.The
*-debug*
files generated by the guix build contain debug symbols for troubleshooting by developers. It is assumed that anyone that is interested in debugging can run guix to generate the files for themselves. To avoid end-user confusion about which file to pick, as well as save storage space do not upload these to the dash.org server.find guix-build-${VERSION}/output/ -maxdepth 2 -type f -not -name "SHA256SUMS.part" -and -not -name "*debug*" -exec scp {} user@dash.org:/var/www/bin/dash-core-${VERSION} \;
-
The
SHA256SUMS
file -
The
SHA256SUMS.asc
combined signature file you just created
-
- Validate
SHA256SUMS.asc
and all binaries attached to GitHub draft release are correct - Notarize macOS binaries
- Publish release on GitHub
- Fast-forward
master
branch on GitHub - Update the dash.org download links
- Ensure that docker hub images are up to date
Announce the release:
- Release on Dash forum: https://www.dash.org/forum/topic/official-announcements.54/ (necessary so we have a permalink to use on twitter, reddit, etc.)
- Prepare product brief (major versions only)
- Prepare a release announcement tweet
- Follow-up tweets with any important block heights for consensus changes
- Post on Reddit
- Celebrate
After the release:
- Submit patches to BTCPay to ensure they use latest / compatible version see https://github.com/dashpay/dash/issues/4211#issuecomment-966608207
- Update Core and User docs (docs.dash.org)
- Test Docker build runs without error in Dashmate
- Add new Release Process items to repo Release Process document
- Merge
master
branch back intodevelop
so thatmaster
could be fast-forwarded on next release again
MacOS Notarization
Prerequisites
Make sure you have the latest Xcode installed on your macOS device. You can download it from the Apple Developer website.
You should have a valid Apple Developer ID under the team you are using which is necessary for the notarization process.
To avoid including your password as cleartext in a notarization script, you can provide a reference to a keychain item. You can add a new keychain item named AC_PASSWORD
from the command line using the notarytool
utility:
xcrun notarytool store-credentials "AC_PASSWORD" --apple-id "AC_USERNAME" --team-id <WWDRTeamID> --password <secret_2FA_password>
Notarization
Open Terminal, and navigate to the location of the .dmg file.
Then, run the following command to notarize the .dmg file:
xcrun notarytool submit dashcore-{version}-{x86_64, arm64}-apple-darwin.dmg --keychain-profile "AC_PASSWORD" --wait
Replace {version}
with the version you are notarizing. This command uploads the .dmg file to Apple's notary service.
The --wait
option makes the command wait to return until the notarization process is complete.
If the notarization process is successful, the notary service generates a log file URL. Please save this URL, as it contains valuable information regarding the notarization process.
Notarization Validation
After successfully notarizing the .dmg file, extract Dash-Qt.app
from the .dmg.
To verify that the notarization process was successful, run the following command:
spctl -a -vv -t install Dash-Qt.app
Replace Dash-Qt.app
with the path to your .app file. This command checks whether your .app file passes Gatekeeper’s
checks. If the app is successfully notarized, the command line will include a line stating source=<Notarized Developer ID>
.
Additional information
How to calculate m_assumed_blockchain_size
and m_assumed_chain_state_size
Both variables are used as a guideline for how much space the user needs on their drive in total, not just strictly for the blockchain. Note that all values should be taken from a fully synced node and have an overhead of 5-10% added on top of its base value.
To calculate m_assumed_blockchain_size
:
- For
mainnet
-> Take the size of the Dash Core data directory, excluding/regtest
and/testnet3
directories. - For
testnet
-> Take the size of the/testnet3
directory.
To calculate m_assumed_chain_state_size
:
- For
mainnet
-> Take the size of the/chainstate
directory. - For
testnet
-> Take the size of the/testnet3/chainstate
directory.
Notes:
- When taking the size for
m_assumed_blockchain_size
, there's no need to exclude the/chainstate
directory since it's a guideline value and an overhead will be added anyway. - The expected overhead for growth may change over time, so it may not be the same value as last release; pay attention to that when changing the variables.