mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
07fd889be9
## Issue being fixed or feature implemented
Many usages of `CBLS{Signature,PrivateKey,PublicKey}` assume using
global variable, even if can be specified explicitly.
Some of these usages have been deglobalized in this PR.
Some prior improvements and fixes are here:
[#5403](https://github.com/dashpay/dash/pull/5403)
## What was done?
- Refactored the uses of global variable of `bls_legacy_scheme` from
`SetHex`, `SetByteVector`, some rpc calls.
- Removed flag `checkMalleable` to simplify code because it's always
`true`.
- Removed dependency from `txmempool.h` on `bls.h` to speed up
compilation.
## How Has This Been Tested?
Run unit/functional tests.
## Breaking Changes
No breaking changes assumed. But in theory behaviour of some RPC can be
more explicit and predictable.
## Checklist:
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone
|
||
|---|---|---|
| .. | ||
| classes.cpp | ||
| classes.h | ||
| exceptions.h | ||
| governance.cpp | ||
| governance.h | ||
| object.cpp | ||
| object.h | ||
| validators.cpp | ||
| validators.h | ||
| vote.cpp | ||
| vote.h | ||
| votedb.cpp | ||
| votedb.h | ||