dash/src
fanquake 1ec0e30afb
Merge #19980: refactor: Some wallet cleanups
9b74461fa293453a9eb0b1717b30b3f7fa778d91 refactor: Assert before dereference in CWallet::GetDatabase (João Barbosa)
021feb3187b207d511561c1f0ffd7f9e5e0c9c1d refactor: Drop redudant CWallet::GetDBHandle (João Barbosa)

Pull request description:

ACKs for top commit:
  achow101:
    Code Review ACK 9b74461fa293453a9eb0b1717b30b3f7fa778d91
  meshcollider:
    utACK 9b74461fa293453a9eb0b1717b30b3f7fa778d91
  ryanofsky:
    Code review ACK 9b74461fa293453a9eb0b1717b30b3f7fa778d91. Changes since last review: rebasing due to conflict, dropping wallet path commit c6a5cd7a64c78b162f545a3467d0fea7dcaadfcc as suggested in discussion, making GetDatabase() const in the earlier commit. Giving more descriptive title like

Tree-SHA512: 68cf3b5e9fe0acb3a5cd081086629989f213f1904cc344e5775767b56759a7d905b1e1c303afbe40f172ff81bf07f3719b59d8f6ec2de3fdd53cd0e2d220fb25
2023-07-26 09:37:53 +05:30
..
bench Merge #20575: Do not run functions with necessary side-effects in assert() 2023-07-26 09:37:51 +05:30
bls feat: mnlistdiff v20 CL sig quorums (#5377) 2023-07-10 11:23:09 -05:00
coinjoin Merge #19980: refactor: Some wallet cleanups 2023-07-26 09:37:53 +05:30
compat partial bitcoin#20963: Build binaries for 64-bit POWER 2023-05-31 11:06:40 -05:00
config
consensus fix!: making MnEhfTx to comply DIP-0023 (#5505) 2023-07-25 21:46:55 +03:00
crc32c
crypto
dashbls build: stop tracking cmake dependency relic_conf.h.in 2023-06-28 23:44:03 +03:00
evo fix!: making MnEhfTx to comply DIP-0023 (#5505) 2023-07-25 21:46:55 +03:00
governance refactor: deglobalization of bls_legacy_scheme 2/N (#5443) 2023-06-30 19:27:39 -05:00
immer
index
interfaces Merge #18278: interfaces: Describe and follow some code conventions 2023-05-31 12:01:04 -05:00
leveldb
llmq feat: bury v19 activation (#5496) 2023-07-23 15:19:38 -05:00
logging
masternode merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
node Merge #18660: test: Verify findCommonAncestor always initializes outputs 2023-07-24 11:42:34 -05:00
policy Merge #20497: [Refactor] Add MAX_STANDARD_SCRIPTSIG_SIZE to policy 2023-07-26 09:37:53 +05:30
primitives feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
qt Merge #18601: wallet: Refactor WalletRescanReserver to use wallet reference 2023-07-21 16:03:00 -05:00
rpc Merge #20964: rpc: Add specific error code for "wallet already loaded" 2023-07-26 09:37:52 +05:30
script merge bitcoin#21584: Fix assumeutxo crash due to invalid base_blockhash 2023-06-06 22:38:56 +05:30
secp256k1
support
test Merge #20425: fuzz: Make CAddrMan fuzzing harness deterministic 2023-07-26 09:37:53 +05:30
univalue
util feat: Check if settings file is empty (#5504) 2023-07-24 20:58:43 +03:00
wallet Merge #19980: refactor: Some wallet cleanups 2023-07-26 09:37:53 +05:30
zmq Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
.clang-format
addrdb.cpp
addrdb.h
addressindex.h
addrman.cpp merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
addrman.h merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp
banman.h Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
base58.cpp Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
base58.h Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
batchedlogger.cpp
batchedlogger.h
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
bip39.h fix(wallet): truncate mnemonic passphrase instead of crashing 2023-06-12 10:56:10 +03:00
bitcoin-cli.cpp Merge #16680: Preparations for more testchains 2023-04-25 23:41:20 -05:00
bitcoin-tx.cpp Merge #16680: Preparations for more testchains 2023-04-25 23:41:20 -05:00
bitcoin-wallet.cpp Merge #20271: doc: Document that wallet salvage is experimental 2023-07-21 16:03:00 -05:00
bitcoind.cpp Merge #16680: Preparations for more testchains 2023-04-25 23:41:20 -05:00
blockencodings.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
blockencodings.h
blockfilter.cpp Merge bitcoin/bitcoin#23760: util: move MapIntoRange() for reuse in fuzz tests 2023-04-17 11:17:34 -05:00
blockfilter.h
bloom.cpp feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
bloom.h Merge #17164: p2p: Avoid allocating memory for addrKnown where we don't need it 2023-04-17 19:34:02 +03:00
cachemap.h
cachemultimap.h
chain.cpp
chain.h merge bitcoin#19806: UTXO snapshot activation 2023-06-06 22:38:56 +05:30
chainparams.cpp feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
chainparams.h merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
chainparamsbase.cpp Merge #16680: Preparations for more testchains 2023-04-25 23:41:20 -05:00
chainparamsbase.h
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp merge bitcoin#19806: UTXO snapshot activation 2023-06-06 22:38:56 +05:30
coins.h merge bitcoin#21584: Fix assumeutxo crash due to invalid base_blockhash 2023-06-06 22:38:56 +05:30
compat.h merge bitcoin#20685: Add I2P support using I2P SAM 2023-07-24 20:45:49 +03:00
compressor.cpp
compressor.h
context.h
core_io.h
core_memusage.h
core_read.cpp Merge #19851: refactor: Extract ParseOpCode from ParseScript 2023-07-25 10:45:09 -05:00
core_write.cpp feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
ctpl_stl.h
cuckoocache.h
cxxtimer.hpp
dash-cli-res.rc
dash-tx-res.rc
dash-wallet-res.rc
dashd-res.rc
dbwrapper.cpp Merge bitcoin/bitcoin#23214: Replace stoul with ToIntegral in dbwrapper 2023-04-17 11:17:34 -05:00
dbwrapper.h fix: CDBTransaction::GetMemoryUsage() logging 2023-07-17 01:00:48 +03:00
dsnotificationinterface.cpp refactor: using reference instead reference to unique_ptr with object (#5381) 2023-06-04 15:26:23 -05:00
dsnotificationinterface.h refactor: using reference instead reference to unique_ptr with object (#5381) 2023-06-04 15:26:23 -05:00
dummywallet.cpp Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
flat-database.h
flatfile.cpp
flatfile.h Merge #18087: Get rid of VARINT default argument 2023-05-24 12:43:57 -05:00
fs.cpp
fs.h
hash.cpp
hash.h
hdchain.cpp feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
hdchain.h feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
httprpc.cpp
httprpc.h
httpserver.cpp Merge bitcoin/bitcoin#22914: util: remove libevent <= 2.0.18 back-compat code 2023-04-17 11:17:34 -05:00
httpserver.h
i2p.cpp merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
i2p.h merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
indirectmap.h
init.cpp merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
init.h
key_io.cpp
key_io.h
key.cpp
key.h partial Merge #17212: refactor: Remove unused CExt{Pub,}Key (de)serialization methods 2023-04-17 10:42:25 -05:00
limitedmap.h chore: Drop unused unordered_limitedmap::insert_or_update() 2023-07-17 01:00:48 +03:00
logging.cpp merge bitcoin#20685: Add I2P support using I2P SAM 2023-07-24 20:45:49 +03:00
logging.h merge bitcoin#20685: Add I2P support using I2P SAM 2023-07-24 20:45:49 +03:00
Makefile.am merge bitcoin#20685: Add I2P support using I2P SAM 2023-07-24 20:45:49 +03:00
Makefile.bench.include Merge #18397: build: Fix libevent linking for bench_bitcoin binary 2023-05-31 12:01:04 -05:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include
Makefile.qttest.include
Makefile.test_fuzz.include merge bitcoin#20995: Avoid initializing version to less than MIN_PEER_PROTO_VERSION 2023-07-24 20:45:49 +03:00
Makefile.test_util.include Merge #17593: test: move more utility functions into test utility library 2023-04-25 23:14:25 +03:00
Makefile.test.include fix!: making MnEhfTx to comply DIP-0023 (#5505) 2023-07-25 21:46:55 +03:00
Makefile.univalue.include
mapport.cpp
mapport.h
memusage.h
merkleblock.cpp feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
merkleblock.h
messagesigner.cpp
messagesigner.h
miner.cpp feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
miner.h feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
net_permissions.cpp merge bitcoin#18991: Cache responses to GETADDR to prevent topology leaks 2023-06-05 10:11:03 -05:00
net_permissions.h merge bitcoin#18991: Cache responses to GETADDR to prevent topology leaks 2023-06-05 10:11:03 -05:00
net_processing.cpp Merge #21713: Refactor ProcessNewBlock to reduce code duplication 2023-07-26 09:37:51 +05:30
net_processing.h refactor: using reference instead reference to unique_ptr with object (#5381) 2023-06-04 15:26:23 -05:00
net_types.h
net.cpp Merge #20432: net: Treat raw message bytes as uint8_t 2023-07-25 10:45:09 -05:00
net.h Merge #20432: net: Treat raw message bytes as uint8_t 2023-07-25 10:45:09 -05:00
netaddress.cpp merge bitcoin#20685: Add I2P support using I2P SAM 2023-07-24 20:45:49 +03:00
netaddress.h merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
netbase.cpp merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
netbase.h merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
netfulfilledman.cpp
netfulfilledman.h Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp
outputtype.h Merge #18034: Get the OutputType for a descriptor 2023-05-24 12:43:57 -05:00
pow.cpp fix: respect fPowNoRetargeting for post-btc algos 2023-06-12 10:56:10 +03:00
pow.h
prevector.h
protocol.cpp chore: Drop MSG_LEGACY_TXLOCK_REQUEST/LEGACYTXLOCKREQUEST (#5483) 2023-07-17 01:02:15 +03:00
protocol.h chore: Drop MSG_LEGACY_TXLOCK_REQUEST/LEGACYTXLOCKREQUEST (#5483) 2023-07-17 01:02:15 +03:00
psbt.cpp partial Merge #18224: Make AnalyzePSBT next role calculation simple, correct 2023-05-31 18:14:23 -05:00
psbt.h
pubkey.cpp
pubkey.h
random.cpp
random.h
randomenv.cpp
randomenv.h
rest.cpp
reverse_iterator.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp Merge bitcoin/bitcoin#21948: test: Fix off-by-one in mockscheduler test RPC 2023-07-25 10:45:09 -05:00
scheduler.h Merge bitcoin/bitcoin#24069: refactor: replace RecursiveMutex m_cs_callbacks_pending with Mutex (and rename) 2023-05-31 10:52:02 -05:00
serialize.h Merge #18087: Get rid of VARINT default argument 2023-05-24 12:43:57 -05:00
shutdown.cpp
shutdown.h
span.h
spentindex.h
spork.cpp merge bitcoin#19791: Move Misbehaving() to PeerManager 2023-05-11 09:19:47 -05:00
spork.h merge bitcoin#19791: Move Misbehaving() to PeerManager 2023-05-11 09:19:47 -05:00
stacktraces.cpp ci: build TSan with clang 15 and add -Werror=thread-safety, fix-up stacktraces (#5375) 2023-05-26 13:49:29 -05:00
stacktraces.h
statsd_client.cpp
statsd_client.h
streams.h
sync.cpp Merge #21010: refactor: remove straggling boost::mutex usage 2023-07-25 10:45:09 -05:00
sync.h Merge #19337: sync: detect double lock from the same thread 2023-07-25 10:45:09 -05:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp Merge #20141: Avoid the use of abs64 in timedata 2023-05-31 10:52:02 -05:00
timedata.h
tinyformat.h
torcontrol.cpp merge bitcoin#20685: Add I2P support using I2P SAM 2023-07-24 20:45:49 +03:00
torcontrol.h
txdb.cpp fix: implement missing logic for additional indexes, fix bugs and logging (#5477) 2023-07-24 20:54:24 +03:00
txdb.h fix: implement missing logic for additional indexes, fix bugs and logging (#5477) 2023-07-24 20:54:24 +03:00
txmempool.cpp fix!: making MnEhfTx to comply DIP-0023 (#5505) 2023-07-25 21:46:55 +03:00
txmempool.h feat!: add an implementation of DIP 0027 Credit Asset Locks (#5026) 2023-07-24 11:39:38 -05:00
ui_interface.cpp Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
ui_interface.h Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
uint256.cpp
uint256.h
undo.h
unordered_lru_cache.h fix: off-by-1 in unordered_lru_cache 2023-06-12 10:56:10 +03:00
validation.cpp fix: implement missing logic for additional indexes, fix bugs and logging (#5477) 2023-07-24 20:54:24 +03:00
validation.h Merge #20575: Do not run functions with necessary side-effects in assert() 2023-07-26 09:37:51 +05:30
validationinterface.cpp Merge #17399: validation: Templatize ValidationState instead of subclassing 2023-05-24 12:43:57 -05:00
validationinterface.h Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
version.h feat: mnlistdiff v20 CL sig quorums (#5377) 2023-07-10 11:23:09 -05:00
versionbits.cpp
versionbits.h
versionbitsinfo.cpp feat: bury v19 activation (#5496) 2023-07-23 15:19:38 -05:00
versionbitsinfo.h refactor: cleanup CChainParams unused data and functions (#5474) 2023-07-04 12:25:36 -05:00
walletinitinterface.h
warnings.cpp
warnings.h