mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
9c54cb16de
581b343d5bf517510ab0236583ca96628751177d Add in/out connections to cli -getinfo (Jon Atack)
d9cc13e88d096c1a171159c01cbb96444f7f8d7f UNIX_EPOCH_TIME fixup in rpc getnettotals (Jon Atack)
1ab49b81cf32b6ef9e312a0a8ac45c68a3262f0d Add in/out connections to rpc getnetworkinfo (Jon Atack)
Pull request description:
This is basic info that is present in the GUI that I've been wishing to have exposed via the RPC and CLI without needing a bash workaround or script. For human users it would also be useful to have it in `-getinfo`.
`bitcoin-cli getnetworkinfo`
```
"connections": 15,
"connections_in": 6,
"connections_out": 9,
```
`bitcoin-cli -getinfo`
```
"connections": {
"in": 6,
"out": 9,
"total": 15
},
```
Update the tests, RPC help, and release notes for the changes. Also fixup the `getnettotals` timemillis help while touching `rpc/net.cpp`.
-----
Reviewers can manually test this PR by [building from source](https://jonatack.github.io/articles/how-to-compile-bitcoin-core-and-run-the-tests), launching bitcoind, and then running `bitcoin-cli -getinfo`, `bitcoin-cli getnetworkinfo`, `bitcoin-cli help getnetworkinfo`, and `bitcoin-cli help getnettotals` (for the UNIX epoch time change).
ACKs for top commit:
eriknylund:
> tACK [581b343](581b343d5b) on master at [a0a422c](a0a422c34c), ran unit & functional tests and and confirmed changes on an existing datadir ✌️
benthecarman:
tACK `581b343`
willcl-ark:
tACK for 581b343d5bf517510ab0236583ca96628751177d, this time rebased onto master at 862fde88be706adb20a211178253636442c3ae00.
shesek:
tACK `581b343`. This provides what I needed, thanks!
n-thumann:
tACK 581b343 on master at a0a422c, ran unit & functional tests and and confirmed changes on an existing datadir ✌️
Tree-SHA512: 08dd3ac8fefae401bd8253ff3ac027603c528eeccba53cedcb127771316173a7052fce44af8fa33ac98ebc4cf2a2b11cdefd949995d55e9b9a5942b876d00dc5
17 lines
830 B
Markdown
17 lines
830 B
Markdown
## Updated RPCs
|
|
|
|
- `getnetworkinfo` now returns fields `connections_in`, `connections_out`,
|
|
`connections_mn_in`, `connections_mn_out`, `connections_mn`
|
|
that provide the number of inbound and outbound peer
|
|
connections. These new fields are in addition to the existing `connections`
|
|
field, which returns the total number of peer connections. Old fields
|
|
`inboundconnections`, `outboundconnections`, `inboundmnconnections`,
|
|
`outboundmnconnections` and `mnconnections` are removed (dash#5823)
|
|
|
|
## CLI
|
|
|
|
- The `connections` field of `dash-cli -getinfo` is expanded to return a JSON
|
|
object with `in`, `out` and `total` numbers of peer connections and `mn_in`,
|
|
`mn_out` and `mn_total` numbers of verified mn connections. It previously
|
|
returned a single integer value for the total number of peer connections. (dash#5823)
|